Better Support for Picture-in-Picture Custom Layouts (Based on #6127) (#6247)

src/citra/config.cpp

@@ -177,6 +177,8 @@ void Config::ReadValues() {
         static_cast<u16>(sdl2_config->GetInteger("Layout", "custom_bottom_right", 360));
     Settings::values.custom_bottom_bottom =
         static_cast<u16>(sdl2_config->GetInteger("Layout", "custom_bottom_bottom", 480));
+    Settings::values.custom_second_layer_opacity =
+        static_cast<u16>(sdl2_config->GetInteger("Layout", "custom_second_layer_opacity", 100));
 
     // Utility
     Settings::values.dump_textures = sdl2_config->GetBoolean("Utility", "dump_textures", false);

src/citra/default_ini.h

@@ -204,6 +204,9 @@ custom_bottom_top =
 custom_bottom_right =
 custom_bottom_bottom =
 
+# Opacity of second layer when using custom layout option (bottom screen unless swapped)
+custom_second_layer_opacity =
+
 # Swaps the prominent screen with the other screen.
 # For example, if Single Screen is chosen, setting this to 1 will display the bottom screen instead of the top screen.
 # 0 (default): Top Screen is prominent, 1: Bottom Screen is prominent

src/citra_qt/configuration/config.cpp

@@ -9,6 +9,7 @@
 #include <QSettings>
 #include "citra_qt/configuration/config.h"
 #include "common/file_util.h"
+#include "common/settings.h"
 #include "core/frontend/mic.h"
 #include "core/hle/service/service.h"
 #include "input_common/main.h"
@@ -496,6 +497,7 @@ void Config::ReadLayoutValues() {
         ReadBasicSetting(Settings::values.custom_bottom_top);
         ReadBasicSetting(Settings::values.custom_bottom_right);
         ReadBasicSetting(Settings::values.custom_bottom_bottom);
+        ReadBasicSetting(Settings::values.custom_second_layer_opacity);
     }
 
     qt_config->endGroup();
@@ -1006,6 +1008,7 @@ void Config::SaveLayoutValues() {
         WriteBasicSetting(Settings::values.custom_bottom_top);
         WriteBasicSetting(Settings::values.custom_bottom_right);
         WriteBasicSetting(Settings::values.custom_bottom_bottom);
+        WriteBasicSetting(Settings::values.custom_second_layer_opacity);
     }
 
     qt_config->endGroup();

src/common/settings.h

@@ -464,6 +464,7 @@ struct Values {
     Setting<u16> custom_bottom_top{240, "custom_bottom_top"};
     Setting<u16> custom_bottom_right{360, "custom_bottom_right"};
     Setting<u16> custom_bottom_bottom{480, "custom_bottom_bottom"};
+    Setting<u16> custom_second_layer_opacity{100, "custom_second_layer_opacity"};
 
     SwitchableSetting<double> bg_red{0.f, "bg_red"};
     SwitchableSetting<double> bg_green{0.f, "bg_green"};

src/core/frontend/emu_window.cpp

@@ -178,7 +178,7 @@ void EmuWindow::UpdateCurrentFramebufferLayout(unsigned width, unsigned height,
         layout_option.GetValue(), Settings::values.upright_screen.GetValue());
 
     if (Settings::values.custom_layout.GetValue() == true) {
-        layout = Layout::CustomFrameLayout(width, height);
+        layout = Layout::CustomFrameLayout(width, height, Settings::values.swap_screen.GetValue());
     } else {
         width = std::max(width, min_size.first);
         height = std::max(height, min_size.second);

src/core/frontend/framebuffer_layout.cpp

@@ -349,7 +349,7 @@ FramebufferLayout SeparateWindowsLayout(u32 width, u32 height, bool is_secondary
     return SingleFrameLayout(width, height, is_secondary, upright);
 }
 
-FramebufferLayout CustomFrameLayout(u32 width, u32 height) {
+FramebufferLayout CustomFrameLayout(u32 width, u32 height, bool is_swapped) {
     ASSERT(width > 0);
     ASSERT(height > 0);
 
@@ -364,8 +364,13 @@ FramebufferLayout CustomFrameLayout(u32 width, u32 height) {
                                       Settings::values.custom_bottom_right.GetValue(),
                                       Settings::values.custom_bottom_bottom.GetValue()};
 
+    if (is_swapped) {
+        res.top_screen = bot_screen;
+        res.bottom_screen = top_screen;
+    } else {
         res.top_screen = top_screen;
         res.bottom_screen = bot_screen;
+    }
     return res;
 }
 
@@ -375,7 +380,8 @@ FramebufferLayout FrameLayoutFromResolutionScale(u32 res_scale, bool is_secondar
         layout = CustomFrameLayout(std::max(Settings::values.custom_top_right.GetValue(),
                                             Settings::values.custom_bottom_right.GetValue()),
                                    std::max(Settings::values.custom_top_bottom.GetValue(),
-                                            Settings::values.custom_bottom_bottom.GetValue()));
+                                            Settings::values.custom_bottom_bottom.GetValue()),
+                                   Settings::values.swap_screen.GetValue());
     } else {
         int width, height;
         switch (Settings::values.layout_option.GetValue()) {

src/core/frontend/framebuffer_layout.h

@@ -114,7 +114,7 @@ FramebufferLayout SeparateWindowsLayout(u32 width, u32 height, bool is_secondary
  * @param height Window framebuffer height in pixels
  * @return Newly created FramebufferLayout object with default screen regions initialized
  */
-FramebufferLayout CustomFrameLayout(u32 width, u32 height);
+FramebufferLayout CustomFrameLayout(u32 width, u32 height, bool is_swapped);
 
 /**
  * Convenience method to get frame layout by resolution scale

src/video_core/renderer_opengl/renderer_opengl.cpp

@@ -1002,13 +1002,43 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
     }
 
     glUniform1i(uniform_layer, 0);
-    if (layout.top_screen_enabled) {
+    if (!Settings::values.swap_screen) {
+        DrawTopScreen(layout, top_screen, stereo_single_screen);
+        glUniform1i(uniform_layer, 0);
+        ApplySecondLayerOpacity();
+        DrawBottomScreen(layout, bottom_screen, stereo_single_screen);
+    } else {
+        DrawBottomScreen(layout, bottom_screen, stereo_single_screen);
+        glUniform1i(uniform_layer, 0);
+        ApplySecondLayerOpacity();
+        DrawTopScreen(layout, top_screen, stereo_single_screen);
+    }
+    state.blend.enabled = false;
+}
+
+void RendererOpenGL::ApplySecondLayerOpacity() {
+    if (Settings::values.custom_layout &&
+        Settings::values.custom_second_layer_opacity.GetValue() < 100) {
+        state.blend.enabled = true;
+        state.blend.src_rgb_func = GL_CONSTANT_ALPHA;
+        state.blend.src_a_func = GL_CONSTANT_ALPHA;
+        state.blend.dst_a_func = GL_ONE_MINUS_CONSTANT_ALPHA;
+        state.blend.dst_rgb_func = GL_ONE_MINUS_CONSTANT_ALPHA;
+        state.blend.color.alpha = Settings::values.custom_second_layer_opacity.GetValue() / 100.0f;
+    }
+}
+
+void RendererOpenGL::DrawTopScreen(const Layout::FramebufferLayout& layout,
+                                   const Common::Rectangle<u32>& top_screen,
+                                   const bool stereo_single_screen) {
+    if (!layout.top_screen_enabled) {
+        return;
+    }
+
     if (layout.is_rotated) {
         if (Settings::values.render_3d.GetValue() == Settings::StereoRenderOption::Off) {
-                int eye = static_cast<int>(Settings::values.mono_render_option.GetValue());
+            DrawSingleScreenRotated(screen_infos[0], (float)top_screen.left, (float)top_screen.top,
-                DrawSingleScreenRotated(screen_infos[eye], (float)top_screen.left,
+                                    (float)top_screen.GetWidth(), (float)top_screen.GetHeight());
-                                        (float)top_screen.top, (float)top_screen.GetWidth(),
-                                        (float)top_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::SideBySide) {
             DrawSingleScreenRotated(screen_infos[0], (float)top_screen.left / 2,
@@ -1021,24 +1051,20 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
                                     (float)top_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::CardboardVR) {
-                DrawSingleScreenRotated(screen_infos[0], layout.top_screen.left,
+            DrawSingleScreenRotated(screen_infos[0], layout.top_screen.left, layout.top_screen.top,
-                                        layout.top_screen.top, layout.top_screen.GetWidth(),
+                                    layout.top_screen.GetWidth(), layout.top_screen.GetHeight());
-                                        layout.top_screen.GetHeight());
             glUniform1i(uniform_layer, 1);
-                DrawSingleScreenRotated(screen_infos[1],
+            DrawSingleScreenRotated(
-                                        layout.cardboard.top_screen_right_eye +
+                screen_infos[1], layout.cardboard.top_screen_right_eye + ((float)layout.width / 2),
-                                            ((float)layout.width / 2),
+                layout.top_screen.top, layout.top_screen.GetWidth(), layout.top_screen.GetHeight());
-                                        layout.top_screen.top, layout.top_screen.GetWidth(),
-                                        layout.top_screen.GetHeight());
         } else if (stereo_single_screen) {
-                DrawSingleScreenStereoRotated(
+            DrawSingleScreenStereoRotated(screen_infos[0], screen_infos[1], (float)top_screen.left,
-                    screen_infos[0], screen_infos[1], (float)top_screen.left, (float)top_screen.top,
+                                          (float)top_screen.top, (float)top_screen.GetWidth(),
-                    (float)top_screen.GetWidth(), (float)top_screen.GetHeight());
+                                          (float)top_screen.GetHeight());
         }
     } else {
         if (Settings::values.render_3d.GetValue() == Settings::StereoRenderOption::Off) {
-                int eye = static_cast<int>(Settings::values.mono_render_option.GetValue());
+            DrawSingleScreen(screen_infos[0], (float)top_screen.left, (float)top_screen.top,
-                DrawSingleScreen(screen_infos[eye], (float)top_screen.left, (float)top_screen.top,
                              (float)top_screen.GetWidth(), (float)top_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::SideBySide) {
@@ -1054,19 +1080,24 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
             DrawSingleScreen(screen_infos[0], layout.top_screen.left, layout.top_screen.top,
                              layout.top_screen.GetWidth(), layout.top_screen.GetHeight());
             glUniform1i(uniform_layer, 1);
-                DrawSingleScreen(screen_infos[1],
+            DrawSingleScreen(
-                                 layout.cardboard.top_screen_right_eye + ((float)layout.width / 2),
+                screen_infos[1], layout.cardboard.top_screen_right_eye + ((float)layout.width / 2),
-                                 layout.top_screen.top, layout.top_screen.GetWidth(),
+                layout.top_screen.top, layout.top_screen.GetWidth(), layout.top_screen.GetHeight());
-                                 layout.top_screen.GetHeight());
         } else if (stereo_single_screen) {
             DrawSingleScreenStereo(screen_infos[0], screen_infos[1], (float)top_screen.left,
                                    (float)top_screen.top, (float)top_screen.GetWidth(),
                                    (float)top_screen.GetHeight());
         }
     }
+}
+
+void RendererOpenGL::DrawBottomScreen(const Layout::FramebufferLayout& layout,
+                                      const Common::Rectangle<u32>& bottom_screen,
+                                      const bool stereo_single_screen) {
+    if (!layout.bottom_screen_enabled) {
+        return;
     }
-    glUniform1i(uniform_layer, 0);
+
-    if (layout.bottom_screen_enabled) {
     if (layout.is_rotated) {
         if (Settings::values.render_3d.GetValue() == Settings::StereoRenderOption::Off) {
             DrawSingleScreenRotated(screen_infos[2], (float)bottom_screen.left,
@@ -1074,12 +1105,12 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
                                     (float)bottom_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::SideBySide) {
-                DrawSingleScreenRotated(
+            DrawSingleScreenRotated(screen_infos[2], (float)bottom_screen.left / 2,
-                    screen_infos[2], (float)bottom_screen.left / 2, (float)bottom_screen.top,
+                                    (float)bottom_screen.top, (float)bottom_screen.GetWidth() / 2,
-                    (float)bottom_screen.GetWidth() / 2, (float)bottom_screen.GetHeight());
+                                    (float)bottom_screen.GetHeight());
             glUniform1i(uniform_layer, 1);
-                DrawSingleScreenRotated(
+            DrawSingleScreenRotated(screen_infos[2],
-                    screen_infos[2], ((float)bottom_screen.left / 2) + ((float)layout.width / 2),
+                                    ((float)bottom_screen.left / 2) + ((float)layout.width / 2),
                                     (float)bottom_screen.top, (float)bottom_screen.GetWidth() / 2,
                                     (float)bottom_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
@@ -1101,9 +1132,8 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
         }
     } else {
         if (Settings::values.render_3d.GetValue() == Settings::StereoRenderOption::Off) {
-                DrawSingleScreen(screen_infos[2], (float)bottom_screen.left,
+            DrawSingleScreen(screen_infos[2], (float)bottom_screen.left, (float)bottom_screen.top,
-                                 (float)bottom_screen.top, (float)bottom_screen.GetWidth(),
+                             (float)bottom_screen.GetWidth(), (float)bottom_screen.GetHeight());
-                                 (float)bottom_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::SideBySide) {
             DrawSingleScreen(screen_infos[2], (float)bottom_screen.left / 2,
@@ -1116,13 +1146,11 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
                              (float)bottom_screen.GetHeight());
         } else if (Settings::values.render_3d.GetValue() ==
                    Settings::StereoRenderOption::CardboardVR) {
-                DrawSingleScreen(screen_infos[2], layout.bottom_screen.left,
+            DrawSingleScreen(screen_infos[2], layout.bottom_screen.left, layout.bottom_screen.top,
-                                 layout.bottom_screen.top, layout.bottom_screen.GetWidth(),
+                             layout.bottom_screen.GetWidth(), layout.bottom_screen.GetHeight());
-                                 layout.bottom_screen.GetHeight());
             glUniform1i(uniform_layer, 1);
             DrawSingleScreen(screen_infos[2],
-                                 layout.cardboard.bottom_screen_right_eye +
+                             layout.cardboard.bottom_screen_right_eye + ((float)layout.width / 2),
-                                     ((float)layout.width / 2),
                              layout.bottom_screen.top, layout.bottom_screen.GetWidth(),
                              layout.bottom_screen.GetHeight());
         } else if (stereo_single_screen) {
@@ -1131,7 +1159,6 @@ void RendererOpenGL::DrawScreens(const Layout::FramebufferLayout& layout, bool f
                                    (float)bottom_screen.GetHeight());
         }
     }
-    }
 }
 
 void RendererOpenGL::TryPresent(int timeout_ms, bool is_secondary) {

src/video_core/renderer_opengl/renderer_opengl.h

@@ -89,6 +89,12 @@ private:
     void ConfigureFramebufferTexture(TextureInfo& texture,
                                      const GPU::Regs::FramebufferConfig& framebuffer);
     void DrawScreens(const Layout::FramebufferLayout& layout, bool flipped);
+    void ApplySecondLayerOpacity();
+    void DrawBottomScreen(const Layout::FramebufferLayout& layout,
+                          const Common::Rectangle<u32>& bottom_screen,
+                          const bool stereo_single_screen);
+    void DrawTopScreen(const Layout::FramebufferLayout& layout,
+                       const Common::Rectangle<u32>& top_screen, const bool stereo_single_screen);
     void DrawSingleScreenRotated(const ScreenInfo& screen_info, float x, float y, float w, float h);
     void DrawSingleScreen(const ScreenInfo& screen_info, float x, float y, float w, float h);
     void DrawSingleScreenStereoRotated(const ScreenInfo& screen_info_l,