JosJuice
22aa88109f
Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined
...
This lets us reduce the number of USE_RETRO_ACHIEVEMENTS ifdefs in the
code base, reducing visual clutter. In particular, needing an ifdef for
each call to IsHardcodeModeActive was annoying to me. This also reduces
the risk that someone writes code that accidentally fails to compile
with USE_RETRO_ACHIEVEMENTS disabled.
We could cut down on ifdefs even further by making HardcodeWarningWidget
always exist, but that would result in non-trivial code ending up in the
binary even with USE_RETRO_ACHIEVEMENTS disabled, so I'm leaving it out
of this PR. It's not a lot of code though, so I might end up revisiting
it at some point.
2024-06-06 08:26:20 +02:00
Admiral H. Curtiss
2b386cdcdc
Merge pull request #12812 from LillyJadeKatrin/retroachievements-close-fixes
...
Properly reset Discord presence after game close
2024-05-31 20:18:22 +02:00
Admiral H. Curtiss
0e6db07203
Merge pull request #12794 from TryTwo/PR_Windows_Initialize_Fix
...
MainWindow, Bugfix: Initialize geometries before calling GetWindowSystemInfo
2024-05-31 20:00:37 +02:00
Dentomologist
de9326bd53
InterfacePane: Add BalloonTip to user style combobox
2024-05-31 19:10:30 +02:00
Dentomologist
33b64d6c91
InterfacePane: Add BalloonTip to cursor visible radio buttons
2024-05-31 19:09:00 +02:00
Dentomologist
a581fa2bfa
InterfacePane: Add BalloonTip to lock mouse checkbox
2024-05-31 19:07:33 +02:00
Dentomologist
9ed1688d09
InterfacePane: Add BalloonTip to pause on focus lost checkbox
2024-05-31 19:06:50 +02:00
Dentomologist
14f01bb12c
InterfacePane: Add BalloonTip to show active title checkbox
2024-05-31 19:06:11 +02:00
Dentomologist
c5532b19e6
InterfacePane: Add BalloonTip to enable on-screen display checkbox
2024-05-31 19:05:35 +02:00
Dentomologist
16cdd0a961
InterfacePane: Add BalloonTip to use panic handlers checkbox
2024-05-31 19:04:57 +02:00
Dentomologist
dc15a555c9
InterfacePane: Add BalloonTip to confirm on stop checkbox
2024-05-31 19:04:18 +02:00
Dentomologist
d1ac66824e
InterfacePane: Add BalloonTip to disable screensaver checkbox
2024-05-31 19:03:19 +02:00
Dentomologist
26758716ae
InterfacePane: Add BalloonTip to use covers checkbox
2024-05-31 19:01:43 +02:00
Dentomologist
78ab53a6e4
InterfacePane: Add BalloonTip to focused hotkeys checkbox
2024-05-31 19:01:03 +02:00
Dentomologist
afe5bfd512
InterfacePane: Add BalloonTip to debugging enabled checkbox
2024-05-31 18:59:24 +02:00
Dentomologist
7d704ca9ca
InterfacePane: Add BalloonTip to language combobox
2024-05-31 18:57:28 +02:00
Dentomologist
266bbeefc8
InterfacePane: Add BalloonTip to top window checkbox
2024-05-31 18:52:22 +02:00
Dentomologist
55aaa323ec
InterfacePane: Add BalloonTip to theme combobox
2024-05-31 18:52:13 +02:00
Dentomologist
ae0914174f
InterfacePane: Add BalloonTip to title database checkbox
2024-05-31 18:25:47 +02:00
Admiral H. Curtiss
072b6cdb1d
Merge pull request #12797 from mitaclaw/branch-watch-tool-fixes-1
...
Branch Watch Tool: Fixes
2024-05-31 18:11:36 +02:00
OatmealDome
c3e0aeb184
Merge pull request #12728 from OatmealDome/mac-version-numbers-2
...
ScmRevGen: Generate Info.plist files containing the current version
2024-05-30 01:13:32 -04:00
Tillmann Karras
5255fe5f74
DolphinTool: support WAD verification
2024-05-28 19:00:00 +01:00
LillyJadeKatrin
8e33a5778e
Properly reset Discord presence after game close
...
Also fixed an Achievement log that was reporting even when achievements were disabled.
2024-05-27 17:52:13 -04:00
Tilka
8582644058
Merge pull request #12796 from JosJuice/interpreter-cr0-so-gt
...
Interpreter: Fix GT when setting SO of CR
2024-05-26 17:57:06 +01:00
JosJuice
921d711113
Jit: Clarify FixGTBeforeSettingCRFieldBit comment
2024-05-26 08:32:25 +02:00
Tillmann Karras
4619db2ae9
DiscIO: drop unused Volume::CheckContentIntegrity() overload
...
The offset-based overload hasn't been in use since
f754a1a548
2024-05-26 00:10:26 +01:00
Tilka
f35e8e62e6
Merge pull request #12795 from JosJuice/remove-isbranchtarget
...
PPCAnalyst: Remove unused member isBranchTarget
2024-05-25 23:10:17 +01:00
Tilka
52f51d0d87
Merge pull request #12802 from JosJuice/ppcanalyst-bi-shift
...
PPCAnalyst: Fix handling of FL_READ_CR_BI
2024-05-25 23:01:45 +01:00
JosJuice
30eff8e37c
PPCAnalyst: Fix handling of FL_READ_CR_BI
...
BI contains both the field and the flag (5 bits total), so we need to
shift away the 2 flag bits to get the 3 field bits. (Same as the
CRBA/CRBB handling in the code just below the BI code.)
2024-05-25 18:13:38 +02:00
mitaclaw
3b214a4978
BranchWatchDialog: Resolve Linux FIXME
...
This stopped being an issue for me with a recent package update, so I guess Qt6 was fixed upstream?
2024-05-25 06:22:45 -07:00
mitaclaw
4a2ec86a9a
Branch Watch Tool: Add Rule Of 5 And Remove Unnecessary Include
2024-05-25 06:22:44 -07:00
mitaclaw
ecce8e81c8
BranchWatchDialog: Case-Insensitive Sorting
2024-05-24 15:42:04 -07:00
JosJuice
46dc406325
Interpreter: Fix GT when setting SO of CR
...
This is the same fixup as in Jit64::FixGTBeforeSettingCRFieldBit.
2024-05-24 21:21:46 +02:00
JosJuice
f6aca69ea0
PPCAnalyst: Remove unused member isBranchTarget
...
Branch targets always start a new block, so this variable isn't useful.
2024-05-24 20:51:39 +02:00
Admiral H. Curtiss
222a393080
Merge pull request #12782 from brad0/openbsd_arm64
...
Add OpenBSD/arm64 support.
2024-05-23 21:38:57 +02:00
LillyJadeKatrin
1e9e0cd2d7
Remove names from badge objects
...
The names attached to the BadgeStatus object are obsolete and unneeded and are removed from everything that uses them. All BadgeStatus references are updated to just Badge.
2024-05-23 21:29:23 +02:00
LillyJadeKatrin
3b61b6d816
Add Default Achievement Badges
...
The defaults get loaded in by Dolphin at emulator start, and are used if the badge that would normally be displayed has not for whatever reason been downloaded yet. Badges attached to this PR are placeholders (MayIMilae is designing permanent badges) and reside in Sys\Load\RetroAchievements.
2024-05-23 21:29:15 +02:00
LillyJadeKatrin
dc8f3f6eae
Refactored Achievement Badges into Texture Layers
...
Achievement badges/icons are refactored into the type CustomTextureData::ArraySlice::Level as that is the data type images loaded from the filesystem will be. This includes everything that uses the badges in the Qt UI and OnScreenDisplay, and similarly removes the OSD::Icon type because Level already contains that information.
2024-05-23 10:41:45 -04:00
LillyJadeKatrin
75465f00cc
Remove Badges Enabled option from Achievements
...
Was informed by the RetroAchievements team that this isn't an option in most emulators, and as the next commits will be to enable default icons, there will always be something to display.
2024-05-23 10:40:08 -04:00
TryTwo
564d4c3c25
MainWindow: Initialize geometries before calling GetWindowSystemInfo.
...
On Windows:
wsi.render_window being set will set/save the initial geometry, which will cause sizing bugs until it's set again by the user resizing/repositioning.
2024-05-22 21:27:50 -07:00
Admiral H. Curtiss
578a3ce543
Merge pull request #12722 from JosJuice/jitarm64-mtfsfix-minor
...
JitArm64: Minor mtfsfix optimization
2024-05-22 23:54:29 +02:00
Brad Smith
57963c87d8
Add OpenBSD/arm64 support.
...
Fix building on OpenBSD/arm64 and add CPU feature detection.
2024-05-22 14:32:37 -04:00
Admiral H. Curtiss
35ee08ba9f
Merge pull request #12736 from mitaclaw/minizip-ng-update
...
Externals: Update minizip-ng to 4.0.5 and convert to submodule
2024-05-21 22:21:56 +02:00
Admiral H. Curtiss
5c2f73986a
Merge pull request #12537 from TellowKrinkle/MTLSubgroup
...
VideoCommon: More specific subgroup op bugs
2024-05-21 22:17:22 +02:00
Admiral H. Curtiss
321dc9b76d
Merge pull request #12711 from jordan-woyak/modifier-range-ini-default
...
InputCommon: Fix unnecessary "Modifier/Range" ini file entries.
2024-05-21 22:11:42 +02:00
Admiral H. Curtiss
abc8aa2237
Merge pull request #12764 from Sintendo/jitarm64-temp-regs
...
JitArm64: Skip temp regs where possible
2024-05-21 22:06:21 +02:00
Admiral H. Curtiss
a64b796df0
Merge pull request #12787 from iwubcode/imgui_mouse_clicks_queue
...
VideoCommon: use imgui input queue for mouse clicks
2024-05-21 22:01:45 +02:00
Admiral H. Curtiss
b9a2c18cb3
Merge pull request #12788 from iwubcode/hotkey_frame_advance_host_thread
...
DolphinQt: trigger frame advance from hotkeys on the host thread
2024-05-21 21:52:05 +02:00
Admiral H. Curtiss
cb71d84908
Merge pull request #12786 from AdmiralCurtiss/config-window-fix
...
DolphinQt/Settings/GeneralPane: Don't emit a ConfigChanged signal while saving config
2024-05-20 13:52:48 +02:00
JosJuice
3e046c2b32
DolphinQt: Fix double argument in Infinity error message
...
This was a mistake I made in 83b280d903
2024-05-19 21:52:49 +02:00
