35557 Commits

Author	SHA1	Message	Date
mitaclaw	c377c1e21e	CheatsManager/CheatSearchWidget: Avoid Global System Accessor ... OnResetClicked and GenerateARCode appear to have been using the CPUThreadGuard in error.	2024-03-11 20:51:15 -07:00
Admiral H. Curtiss	551dcec0b1	Merge pull request #12602 from mitaclaw/qt-memory-global-system ... Memory(View)Widget: Avoid Global System Accessor	2024-03-12 04:12:52 +01:00
Admiral H. Curtiss	6ccf35ad4d	Merge pull request #12600 from lioncash/dspreg ... DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs()	2024-03-12 04:02:09 +01:00
Jordan Woyak	62caa24d40	DolphinQt: Add IRPassthrough indicator.	2024-03-11 21:40:53 -05:00
Admiral H. Curtiss	d35a88564f	Merge pull request #12608 from mitaclaw/bootmanager-global-system ... BootManager: Avoid Global System Accessor	2024-03-12 03:39:48 +01:00
Admiral H. Curtiss	72bcdadc16	Merge pull request #12492 from AdmiralCurtiss/wiimote-ir-passthrough ... Implement IR passthrough for emulated Wiimotes	2024-03-12 03:27:07 +01:00
Admiral H. Curtiss	cda008bd10	Merge pull request #12533 from sepalani/bba-psh-ack ... BBA/HLE: Add missing PSH flag	2024-03-12 03:09:11 +01:00
Jordan Woyak	f86e9e9cbd	Merge pull request #12610 from mitaclaw/branch-watch-dialog-gcc ... BranchWatchDialog: Fix GCC Warnings	2024-03-11 17:36:21 -05:00
Admiral H. Curtiss	f6f435e624	WiimoteEmu: Set sensible defaults for IR Object expressions.	2024-03-11 22:51:57 +01:00
Admiral H. Curtiss	617fcc3cf8	WiimoteEmu: Add user-accessible controls that report the desired state of the IR camera objects.	2024-03-11 22:49:19 +01:00
Admiral H. Curtiss	c3903fcc7e	InputCommon/WiimoteController: Add inputs that report the raw IR objects seen by the Wiimote.	2024-03-11 22:46:05 +01:00
Admiral H. Curtiss	9c68b156d1	Core/HW/WiimoteCommon: Add a method to DataReport to query the format of the stored IR data.	2024-03-11 22:27:16 +01:00
Admiral H. Curtiss	eced34f3f3	Core/HW/WiimoteEmu: Allow storing and reporting up to 4 camera objects, like a real Wiimote.	2024-03-11 22:27:16 +01:00
Jordan Woyak	5c656a2b6f	Merge pull request #12623 from eltociear/patch-1 ... WiimoteReal: fix typo in WiimoteReal.cpp	2024-03-11 12:19:46 -05:00
Jordan Woyak	b23dbad098	InputCommon: Remove some IOKit leftovers.	2024-03-11 01:11:13 -05:00
Sam Belliveau	153d0201a8	Add HDR to Metal	2024-03-10 03:25:33 -04:00
Admiral H. Curtiss	b89a88afbc	Merge pull request #12615 from mitaclaw/ppc-symbol-db-member ... PPCSymbolDB: Eliminate Redundant Member	2024-03-10 06:18:23 +01:00
Admiral H. Curtiss	adac827a04	Merge pull request #12625 from mitaclaw/Wshadow-uncaptured-local ... CMakeLists: Add Clang's Specific WShadow Diagnostics	2024-03-10 00:59:20 +01:00
mitaclaw	f71f2c6ba1	CMakeLists: Add Clang's Specific WShadow Diagnostics ... For parity with GCC.	2024-03-09 15:34:39 -08:00
Admiral H. Curtiss	ef75a6ff23	Merge pull request #12622 from mitaclaw/branch-watch-dialog-errata ... BranchWatchDialog: Fix Misc. Errata	2024-03-10 00:06:21 +01:00
LillyJadeKatrin	5418e89523	Adjusted achievement progress updates to duration short	2024-03-08 23:26:56 -05:00
mitaclaw	fe61efcd7a	DVDInterface: Modernize With CPUThreadGuard	2024-03-08 15:17:41 -08:00
mitaclaw	0645b4d579	BranchWatchDialog: Fix Misc. Errata ... Window icon was missing from QDialog lacking a parent. Giving the QDialog a parent revealed I had failed to make it properly non-modal, necessitating further changes. Settings save less often, now only upon destruction. Construction of BranchWatchDialog is now deferred.	2024-03-07 15:59:03 -08:00
mitaclaw	0f36654d2b	PPCSymbolDB: Eliminate Redundant Member ... This can be accessed through the CPUThreadGuard.	2024-03-06 21:44:53 -08:00
Ikko Eltociear Ashimine	7b0d4f0578	WiimoteReal: fix typo in WiimoteReal.cpp ... continous -> continuous	2024-03-07 01:27:39 +09:00
mitaclaw	4568446398	JitInterface::ClearCache: Modernize With CPUThreadGuard ... It is recommended to view this diff with whitespace changes hidden.	2024-03-04 19:45:34 -08:00
LillyJadeKatrin	085c17aed4	Remove the update callback on all events ... Not only was the extra call to the update callback in the AchievementEventHandler method unnecessary, it was getting called on events that don't even need to be tracked here, causing a lot of lag when it turned out one achievement was repeatedly spamming Achievement Reset Events as a shortcut.	2024-03-04 20:04:08 -05:00
OatmealDome	6372bf51eb	Merge pull request #12597 from nlebeck/settingshandler-unittests-thirdtry ... Add some simple unit tests for SettingsHandler	2024-03-03 18:13:45 -05:00
OatmealDome	aba9b110e8	Merge pull request #12612 from LillyJadeKatrin/retroachievements-logout-bug ... Don't Publish Unofficial Achievements	2024-03-03 14:51:04 -05:00
JMC47	93c95ee1a3	Merge pull request #12592 from LillyJadeKatrin/retroachievements-enable-hardcore ... Properly enable RetroAchievements hardcore mode	2024-03-03 13:20:23 -05:00
LillyJadeKatrin	f556f646a2	Don't Publish Unofficial Achievements ... Check an achievement's category and only request RetroAchievements to award if it is CORE and not UNOFFICIAL.	2024-03-03 12:58:20 -05:00
mitaclaw	8d5e39751e	BranchWatchDialog: Fix GCC Warnings ... GCC can't lambda right.	2024-03-02 07:53:23 -08:00
Admiral H. Curtiss	58616a6e4c	Merge pull request #12438 from Filoppi/custom_relative_aspect_ratio ... Add Custom Relative and Raw (Squared Pixels) aspect ratios	2024-03-02 14:14:19 +01:00
Admiral H. Curtiss	f2e04e0603	Merge pull request #12359 from mitaclaw/code-diff-dialog-refresh ... BranchWatchDialog: A Total Replacement for CodeDiffDialog	2024-03-02 14:13:54 +01:00
Admiral H. Curtiss	8840f7f8bc	Merge pull request #12599 from lioncash/vertman ... VertexManagerBase: Initialize m_ticks_elapsed on construction	2024-03-02 14:11:23 +01:00
mitaclaw	16c609dcd4	BootManager: Avoid Global System Accessor	2024-03-01 23:39:04 -08:00
Niel Lebeck	0344ec6d79	Add simple unit tests for SettingsHandler	2024-03-01 20:52:45 -08:00
Naim2000	f208b320a3	AesDevice: fix key & iv arrays	2024-03-01 15:00:28 -05:00
mitaclaw	0d4cb5ddc7	State: Avoid Global System Accessor	2024-03-01 10:52:50 -08:00
mitaclaw	26141eece8	Memory(View)Widget: Avoid Global System Accessor	2024-03-01 07:09:20 -08:00
Filoppi	41b19e262f	Add custom relative and raw (squared pixels) aspect ratio modes	2024-02-29 21:11:19 +02:00
Lioncash	e52109a356	DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs() ... A DynamicReg instance is 80 bytes in size, so this just gets rid of some unnecessary copy churn.	2024-02-28 10:27:35 -05:00
Lioncash	7bf77a56f4	VertexManagerBase: Initialize m_ticks_elapsed on construction ... Ensures that this always has a deterministic value on construction like everything else in the class.	2024-02-28 10:21:08 -05:00
Mai	5a81916ee9	Merge pull request #12598 from mitaclaw/case-insensitive ... CodeWidget: Simplify Case-Insensitive Contains	2024-02-28 08:48:10 -05:00
mitaclaw	8eeb93d51a	CodeWidget: Simplify Case-Insensitive Contains	2024-02-27 12:03:38 -08:00
mitaclaw	8134c8a572	BranchWatchDialog: A Total Replacement for CodeDiffDialog ... With a purpose-built Branch Watch feature built into the emulated system: BranchWatchDialog, replacing CodeDiffDialog, is now better than ever!	2024-02-27 11:40:58 -08:00
mitaclaw	fd8f2c7822	JitArm64: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	7cccedca1e	Jit64: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	2aa250a68a	Interpreter: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	67f60bec7e	PowerPC: Implement BranchWatch ... This new component can track code paths by watching branch hits.	2024-02-26 19:38:27 -08:00
LillyJadeKatrin	56b82e764c	Clear active challenges when game closes ... Failing to do this was causing challenge icons to carry over into the next game if a game was closed while the icons were active, even if the next game to run was a completely different game entirely with completely different badges.	2024-02-26 22:21:05 -05:00
Admiral H. Curtiss	5090a028e6	Merge pull request #12435 from Filoppi/fix-aspect-ratio-stuck ... Fix aspect ratio heuristics getting stuck to a state	2024-02-20 21:36:43 +01:00
Filoppi	48fbbdba7c	Video: update widescreen heuristic code to never get stuck to specific old values when changing settings	2024-02-20 22:26:19 +02:00
LillyJadeKatrin	d66b96b1c0	Properly enable RetroAchievements hardcore mode ... RetroAchievements plans to use the user_agent in unlock requests to determine which software version was used to play the game, and can filter older software versions out. As such, I have been given the go-ahead to remove the hardcoded line that forces hardcore to always be false.	2024-02-20 12:59:01 -05:00
Filoppi	3f102ea8c2	Video: Make the game resolution (within the window) snap to the XFB size if they are within a ~1 pixel treshold on one axis only. ... This takes care of making the image clearer in some edge cases where the game was already running at near perfect 4:3 with no stretching, and the VI aspect ratio didn't match the XFB by one pixel, making the image stretched and blurry. -Video: Fix `FindClosestIntegerResolution() using the window aspect ratio and not the draw aspect ratio, causing it to prefer stretching over black bars in cases when it wasn't desirable.	2024-02-20 03:09:11 +02:00
Filoppi	95ee0ac781	Video: Fix aspect ratio heuristics getting stuck to widescreen (or to non widescreen) (m_is_game_widescreen variable) if the user first forced the aspect ratio to 16:9/4:3 and then set it back to Auto.	2024-02-20 02:42:52 +02:00
Admiral H. Curtiss	ccf2435047	Merge pull request #12586 from LillyJadeKatrin/retroachievements-pointspread-fix ... Fixes to Achievement points count/mastery	2024-02-19 02:41:14 +01:00
LillyJadeKatrin	e5b73fec08	Fixes to Achievement points count/mastery ... Two minor updates to improve the Achievement Manager's handling of a player's completion rate. One, UnlockStatus and the unlock map now track achievement category, such that TallyScore does not count unofficial achievements in counts/points. Two, the determinations for mastery/completion are now improved to check (1) that the achievement triggering this is CORE (not UNOFFICIAL) and (2) that it has not already been unlocked at this level on the site, which should be sufficient to determine that the unlocking of this particular achievement completes/masters the game.	2024-02-18 19:27:18 -05:00
Mai	22d96ef5b5	Merge pull request #12590 from iwubcode/graphics_mod_action_factory_name ... VideoCommon: move factory names to be a static inside each action class	2024-02-18 17:13:03 -05:00
Mai	27415b0ba1	Merge pull request #12587 from AdmiralCurtiss/localtime ... Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out	2024-02-18 17:12:29 -05:00
iwubcode	a1147dae6e	VideoCommon: move factory names to be a static inside each action class, so that they can be reused in the future for serialization	2024-02-18 15:45:10 -06:00
Admiral H. Curtiss	638808c944	IOS/FS: Display the invalid path in the ASSERT in BuildFilename().	2024-02-18 20:06:32 +01:00
Admiral H. Curtiss	0157166940	Merge pull request #12585 from iwubcode/json_util_vec3 ... Common: add json utility functions for Vec3 serialization	2024-02-18 19:02:59 +01:00
iwubcode	edbf8f1772	Common: add json utility functions for Vec3 serialization	2024-02-17 22:06:06 -06:00
Admiral H. Curtiss	d3140e72c3	Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out.	2024-02-18 04:45:37 +01:00
Admiral H. Curtiss	52410813f2	Common: Add utility function that wraps localtime_s() or localtime_t().	2024-02-18 04:40:25 +01:00
Admiral H. Curtiss	982ad93355	Merge pull request #12582 from LillyJadeKatrin/retroachievements-bugfix-2 ... Improved achievements disabled messaging	2024-02-18 03:49:44 +01:00
Admiral H. Curtiss	9b5fd5d34e	Merge pull request #12281 from TellowKrinkle/AsahiGL33 ... VideoCommon: Don't use indexed output for fbfetch	2024-02-18 02:33:50 +01:00
Dentomologist	56ff19c513	BalloonTip: Rework BalloonTip drawing ... * Fix irregularly shaped corners * Remove extra space for BalloonTips with no message or no title * When the target tip location is not on a screen, put the tooltip on the mouse's screen instead of the primary screen * Fix description getting cut off when the title was too long * Expose border width as a parameter * Fix spacing and sizing issues with larger border widths	2024-02-17 12:36:19 -08:00
Mai	21300bb21b	Merge pull request #12457 from iwubcode/asset_memory_limit ... VideoCommon: handle asset memory going over reserved limit correctly	2024-02-16 15:46:52 -05:00
LillyJadeKatrin	394af40db5	Improved achievements disabled messaging ... Most obviously, there is no longer a warning message to the player in the achievement window that achievements are disabled if a game is not currently running.	2024-02-15 16:33:18 -05:00
Dentomologist	a1d6a54eaa	DolphinTool: Fix parsing of command line bzip2 flag ... Use "bzip2" instead of "bzip" in optparse's compression choices for the convert command. This is both more accurate and matches what the ParseCompressionTypeString function expects. The mismatch between the two parsing functions prevented compression using bzip2 because either ParseCompressionTypeString or optparse would generate an error when using "bzip" or "bzip2" respectively. Fixes https://bugs.dolphin-emu.org/issues/13427	2024-02-13 12:44:03 -08:00
Mai	a583526a1c	Merge pull request #12575 from n8pjl/werror-nonnull ... IOFile: avoid clearing errors on null file struct	2024-02-13 07:43:19 -05:00
Mai	9e6d701fbc	Merge pull request #12577 from iwubcode/mesh_for_asset_loader ... VideoCommon: make mesh asset data loadable by asset loader	2024-02-13 07:42:57 -05:00
iwubcode	2ab877586d	VideoCommon: make mesh asset data loadable by asset loader	2024-02-12 21:45:32 -06:00
Admiral H. Curtiss	f0d363eea7	Core/DSPHLE: Construct accelerator in AX and AXWii constructors. ... This fixes an issue introduced by 3b0444be6b where the m_accelerator would not be initialized when loading a savestate if the current UCode mismatched the UCode in the savestate, leading to a crash.	2024-02-12 04:18:18 +01:00
Peter Lafreniere	3da2e15e6b	IOFile: avoid clearing errors on null file struct ... When performing a default compilation with recent GCC & glibc, the use of -Werror=nonnull causes a build error. The error is given as IOFile::ClearError() can call std::clearerr() with a null file, which can trigger a null-pointer dereference in libc. Change the std::clearerr() call to be conditional on a file being open.	2024-02-11 20:55:31 -05:00
Mai	aa66842172	Merge pull request #12574 from sepalani/exi-exit ... EXI: Don't kill Dolphin when receiving BBA_IOB	2024-02-11 20:32:33 -05:00
iwubcode	60772ed9d2	VideoCommon: add functionality to prepare for a mesh asset that is loaded from a GLTF file	2024-02-11 13:28:00 -06:00
iwubcode	ecfcae8718	Externals: add tinygltf, a library used to load or save GLTF mesh files	2024-02-11 13:26:39 -06:00
Sepalani	7c276c1993	EXI: Don't kill Dolphin when receiving BBA_IOB ... According to @Kirbymimi it doesn't crash on real hardware. Testing was done by sending many UDP packets to an unbound port.	2024-02-11 23:15:23 +04:00
Mai	80d77ac0b4	Merge pull request #12568 from noahpistilli/kd-register-default-id ... IOS/KD: Correctly handle registration of the default user ID	2024-02-11 13:52:40 -05:00
Mai	dd15c012f3	Merge pull request #12573 from JosJuice/android-wii-menu-download-size ... Android: Mention download size in the Wii Menu not installed message	2024-02-11 13:52:01 -05:00
Mai	9b3fdfb37b	Merge pull request #12572 from JosJuice/android-menu-init-guard ... Android: Don't check Wii Menu version before directory initialization	2024-02-11 13:51:30 -05:00
JosJuice	b404da78c4	Android: Mention download size in the Wii Menu not installed message ... Google Play's policies require us to tell the user the size of any large download. The size seems to vary by just a megabyte or two across regions in my testing, so I'm listing a rough size for all the regions. I'm also taking the opportunity to shorten the message to make it easier to read.	2024-02-11 11:34:51 +01:00
JosJuice	06964a921d	Android: Don't check Wii Menu version before directory initialization ... Fixes a crash.	2024-02-11 11:15:18 +01:00
JosJuice	48ae529762	Android: Update Load Wii System Menu string in onPrepareOptionsMenu ... Because the wording of the Load Wii System Menu string can change depending on the contents of the NAND, we should update that menu item in a method that's guaranteed to get called every time the user opens the menu rather than one that's only guaranteed to be called once.	2024-02-11 10:58:42 +01:00
Admiral H. Curtiss	e6ee217a7c	Core: Move Emulation IOS instance to System.	2024-02-07 22:07:30 +01:00
Mai	ca81d8b8a6	Merge pull request #12565 from LillyJadeKatrin/retroachievements-bugfix ... Retain Save State Folder	2024-02-07 14:03:12 -05:00
Sketch	33dd3b078c	Correctly log register errors	2024-02-07 09:36:36 -05:00
TellowKrinkle	5949911a5a	VideoCommon: Don't use indexed output for fbfetch ... A nonzero index makes no sense, and Mesa doesn't like it when you supply an index	2024-02-07 03:52:31 +01:00
JosJuice	b5c5371848	Arm64Emitter: Don't optimize ADD to MOV for SP ... Unlike ADD (immediate), MOV (register) treats SP as ZR. Therefore the ADDI2R optimization that was added in 67791d227c can't optimize ADD to MOV when exactly one of the registers is SP. There currently isn't any code in Dolphin that calls ADDI2R with parameters that would trigger this case.	2024-02-06 21:58:07 +01:00
LillyJadeKatrin	1ed7b35710	Retain Save State Folder ... Adds a setting field under the hood to retain which folder the player last saved/loaded a state to/from, so that the dialog box to select a state to save/load reopens at that folder.	2024-02-05 19:44:09 -05:00
Mai	9240f579ea	Merge pull request #12561 from JosJuice/profile-consistency ... InputCommon: Fix profile path inconsistencies	2024-02-05 09:47:08 -05:00
JosJuice	1315b54ffa	InputCommon: Use distinct values for profile key ... Because the last commit made us use separate folders for GCPad and GCKey profiles, we should also use separate game INI keys for them. Otherwise setting e.g. PadProfile1 in a game INI will make both GCPad and GCKey try to load it, typically with one of them succeeding and the other one showing a panic alert due to the profile not existing in its folder. Better do this breaking change for GCKeys in the same PR as the other breaking change rather than later.	2024-02-04 17:55:08 +01:00
JosJuice	6cf55ab1ee	InputCommon: Unify GetProfileName and GetProfileDirectoryName ... After reading the previous commit, you might think "hold on, what's the difference between GetProfileName and GetProfileDirectoryName"? These two are being used for the exact same thing - figuring out where profiles are stored - yet they return different values for certain controllers like GC keyboards! As far as I can tell, the existing code has been broken for GC keyboards since they were introduced a decade ago. The GUI (and more recently, also InputCycler) would write and read profiles in one location, and our code for loading profiles specified in a game INI file would read profiles in another location. This commit gets rid of the set of values used by the game INI code in favor of the other set. This does breaking existing setups where a GCKey profile has been configured in a game INI, but I think the number of working such setups is vanishingly small. The alternative would make existing GCKey profiles go missing from the profile dropdown in the GUI, which I think would be more disruptive. The alternative would also force new GCKey profiles into the same directory as GCPad profiles. This commit also fixes a regression from d6c0f8e749. The Android GUI was using GetProfileName to figure out what key to use in the game INI, which made it use incorrect game INI entries for GameCube controller profiles but not Wii Remote profiles. Now the Android GUI uses GetProfileKey for this, fixing the problem.	2024-02-04 17:55:08 +01:00
JosJuice	2bcf70af3f	InputCommon: Refactor away InputConfig::LoadConfig's switch case ... By having getters for this information, other code that needs access to the same information can call the getters instead of duplicating the information.	2024-02-04 16:46:10 +01:00
Sepalani	1831a8cec5	BBA/HLE: Add missing PSH flag	2024-02-03 10:12:07 +04:00
Admiral H. Curtiss	abbc4bd0bd	Merge pull request #12551 from lioncash/cheev ... AchievementManager: Minor cleanup	2024-02-03 03:01:56 +01:00
Admiral H. Curtiss	4e3886e7e8	Merge pull request #12557 from mitaclaw/cpu-thread-guarantees-1 ... CheatSearch: Remove redundant lambdas	2024-02-03 02:45:06 +01:00
Admiral H. Curtiss	df5baab873	Merge pull request #12550 from lioncash/dead ... VertexLoaderManager: Remove unused entry struct	2024-02-03 02:38:02 +01:00
Lioncash	4f40bdf501	VertexLoaderManager: Use fill() in Init() ... Same behavior, less code.	2024-02-01 23:04:40 -05:00
Lioncash	ea95c82a01	VertexLoaderManager: Remove unused entry struct ... This isn't used anywhere, so it can be removed.	2024-02-01 23:04:39 -05:00
Lioncash	db80abbadd	AchievementManager: Tidy up GetRichPresence() ... This can be a direct return.	2024-02-01 23:03:24 -05:00
Lioncash	c14414a151	AchievementManager: clear name in CloseGame()/LogOut() ... A little more idiomatic.	2024-02-01 23:03:24 -05:00
Lioncash	2d8af7b7f8	AchievementManager: Replace memsets where applicable ... We can just use brace initialization to zero these out. Smaller to write and a little quicker to read.	2024-02-01 23:03:24 -05:00
Lioncash	184fe932ed	AchievementManager: std::move leaderboard info in FetchBoardInfo() ... Avoids churning some allocations.	2024-02-01 23:03:24 -05:00
Lioncash	76c381e6f7	AchievementManager: Ensure update callback is always valid ... This way we don't need to do any validity checking aside from the initial setting of the callback. Also cuts down on line noise.	2024-02-01 23:03:23 -05:00
Lioncash	2b83cc739a	AchievementManager: Convert .compare() into equality operators ... These perform a default comparison, which is the same as using the equality operators.	2024-02-01 23:03:23 -05:00
Lioncash	394418b415	AchievementManager: Remove unnecessary .get() ... Same behavior, less code.	2024-02-01 23:03:23 -05:00
Lioncash	161efff6c9	AchievementManager: Remove long qualifier ... We can remove the long qualifying on some ResponseType instances to lessen the amount of reading.	2024-02-01 23:03:23 -05:00
Lioncash	7096f99f79	CustomPipeline: Mark arrays as constexpr ... Ensures that these go into the ro section.	2024-02-01 23:02:45 -05:00
Lioncash	59211589b9	CustomPipeline: Make use of emplace_back() in GlobalConflicts() ... We can use the string_view arguments to directly construct strings inside of the global_result vector.	2024-02-01 23:02:45 -05:00
Lioncash	353ceedb50	CustomPipeline: Resolve unused variable warning ... We can just use holds_alternative here instead.	2024-02-01 23:02:45 -05:00
mitaclaw	085c4d154e	CheatSearch: Remove redundant lambdas ... Core::RunAsCPUThread is obsoleted by CPUThreadGuard reference already passed into the function. The nonsense lambda in CheatSearchWidget is from changes in fdb7328c73.	2024-02-01 19:54:47 -08:00
Admiral H. Curtiss	951be30891	Core: Fix booting titles from NAND.	2024-02-01 19:50:20 +01:00
Admiral H. Curtiss	14121c5504	Core/ConfigManager: Remove dead bAutomaticStart flag.	2024-01-31 22:53:43 +01:00
Admiral H. Curtiss	da6b5dd38a	Merge pull request #12546 from lioncash/event ... VideoCommon/Statistics: Remove global system accessor from s_after_frame_event	2024-01-31 21:16:21 +01:00
Admiral H. Curtiss	18abf7c768	Merge pull request #12544 from lioncash/getmod ... GraphicsModGroup: Allow heterogenous lookup for GetMod()	2024-01-31 20:17:26 +01:00
Admiral H. Curtiss	202c10d757	Merge pull request #12547 from lioncash/movie ... Core/Movie: Remove lingering global system instance accessors	2024-01-31 20:12:07 +01:00
Lioncash	5ade2e39ef	Core/Movie: Remove lingering global system instance accessors ... The movie manager is already passed in a reference to the relevant system, so we can use that instead.	2024-01-31 13:30:24 -05:00
Lioncash	16d8b6e6b3	Common/HookableEvent: std::move callback instance in Register() ... Potentially avoids reallocations if the capture buffer of the callback is quite large.	2024-01-31 13:16:50 -05:00
Lioncash	cac66317aa	VideoCommon/Statistics: Remove global system accessor from s_after_frame_event ... Instead, we make the event take a reference to the system and then pass it in when the event is triggered. This does introduce two other accessors, but these are much easier to refactor out over time, and without modification to the existing event interface.	2024-01-31 13:12:09 -05:00
Lioncash	0dfefacdf4	VertexLoaderBase: Collapse std namespace for hash and mark noexcept ... Makes the hash specialization a little less noisy. Also we mark it noexcept, since hashes shouldn't be throwing exceptions (and this can be optimized on).	2024-01-31 12:43:00 -05:00
Lioncash	8e4b2565cd	TextureConfig: Collapse std namespace for hash ... Lets us collapse the namespacing and make the specialization a little less noisy.	2024-01-31 12:41:33 -05:00
Lioncash	b63dcd504d	RenderState: Collapse std namespace for hash ... We can specify the namespace on the hash to make the specialization a little less noisy.	2024-01-31 12:40:10 -05:00
Lioncash	5bfaa3a966	NativeVertexFormat: Collapse std namespace and mark hash noexcept ... We can just tag the std:: onto the end of the specialization to make it less noisy. Also mark it as noexcept, since hashes shouldn't throw exceptions.	2024-01-31 12:37:44 -05:00
Lioncash	40b050fe37	GraphicsModGroup: std::move graphics_mod in Load() ... The config object is quite heavyweight, so we should move this instead of copying.	2024-01-31 12:27:43 -05:00
Lioncash	ccacda5e2c	GraphicsModGroup: Simplify try_add_mod() ... We can use contains() here, and also move the mod config if it's valid instead of copying it, since it contains quite a bit of allocated data.	2024-01-31 12:23:21 -05:00
Lioncash	81aca79145	GraphicsModListWidget: Pass optional by const reference ... All we do is read from it, so we don't need to copy the string if we happen to have one.	2024-01-31 12:09:35 -05:00
Lioncash	a1879ea099	GraphicsModGroup: Allow heterogenous lookup for GetMod() ... Allows using keys that aren't directly std::string as the key. This lets us use std::string_view for the incoming path name, making it more flexible with other string types.	2024-01-31 12:05:17 -05:00
Mai	30fdf25f8f	Merge pull request #12542 from AdmiralCurtiss/system-sconfig ... Migrate m_is_mios and bWii from SConfig to System.	2024-01-31 09:57:17 -05:00
Admiral H. Curtiss	9a3e770c23	Migrate SConfig::bWii to System.	2024-01-31 12:54:07 +01:00
Mai	e0828815e7	Merge pull request #12540 from mitaclaw/encode-reg-to-64 ... Add Missing EncodeRegTo64 in JitArm64::dcbx	2024-01-30 13:08:03 -05:00
mitaclaw	45481620b8	Add Missing EncodeRegTo64 in JitArm64::dcbx ... ARM64FloatEmitter::ABI_PushRegisters expects an XReg temporary, not a WReg.	2024-01-30 03:06:32 -08:00
Admiral H. Curtiss	8d515d407c	Migrate SConfig::m_is_mios to System.	2024-01-30 03:45:17 +01:00
luc-git	d124fcbb0d	DolphinQt/RenderWidget: Add comments for SetCursorLocked() on Linux. ... Co-authored-by: Admiral H. Curtiss <pikachu025@gmail.com>	2024-01-30 01:06:30 +01:00
LillyJadeKatrin	fd99a5db9a	Reverse endianness of achievement memory peeks ... rcheevos expects these multi-byte peeks to have the opposite endianness so they need to be swapped before rcheevos gets them.	2024-01-29 11:55:49 -05:00
Admiral H. Curtiss	8482a50154	Merge pull request #12530 from iwubcode/custom_shaders_compilation_fixes ... VideoCommon: fix some issues when compiling custom shaders	2024-01-28 14:30:37 +01:00
Admiral H. Curtiss	4843705061	Merge pull request #12534 from iwubcode/custom-pipeline-refactor ... VideoCommon: refactor the custom pipeline logic to be reusable	2024-01-28 14:28:23 +01:00
Admiral H. Curtiss	c9715e7e7d	Merge pull request #12535 from iwubcode/vertexmanager_draw_refactor ... VideoCommon: refactor drawing into its own function	2024-01-28 14:27:41 +01:00
Admiral H. Curtiss	0405b4dcc2	Merge pull request #12536 from LillyJadeKatrin/retroachievements-bugfix ... Removed post data from Achievement request logs	2024-01-28 14:26:09 +01:00
LillyJadeKatrin	f25bdda728	Removed post data from Achievement request logs ... post_data included passwords and API keys in plaintext so continuing to include it in logs is a security liability.	2024-01-27 18:50:27 -05:00
JosJuice	990303a028	Merge pull request #12519 from lioncash/leak ... PostProcessing: Don't potentially leak memory in BlitFromTexture()	2024-01-27 22:29:45 +01:00
iwubcode	c34b3ae390	VideoCommon: refactor drawing into its own function	2024-01-27 14:45:34 -06:00
iwubcode	3e3967ff94	VideoCommon: refactor the custom pipeline logic in the graphics mod action into a separate class, so it is reusable	2024-01-27 00:12:49 -06:00
Admiral H. Curtiss	e740e32562	Merge pull request #12522 from lioncash/ppcanalyst ... PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore()	2024-01-26 20:29:16 +01:00
Admiral H. Curtiss	b0491c2ce8	Merge pull request #12529 from iwubcode/math_determinant ... Common: add determinant functions to Matrix33 and Matrix44	2024-01-26 19:13:38 +01:00
Admiral H. Curtiss	b09b59c125	Merge pull request #12521 from lioncash/reent ... Core: Make use of reentrant time utilities where applicable	2024-01-26 18:55:26 +01:00
Admiral H. Curtiss	460ab609d0	Merge pull request #12524 from lioncash/memb ... Jit64AsmCommon: Remove redundant m_jit member from CommonAsmRoutines	2024-01-26 18:53:44 +01:00