195 Commits

Author	SHA1	Message	Date
Lioncash	ab0892e5a5	UICommon/GameFile: Deduplicate string paths where applicable ... Rather than construct strings twice, we can just construct it once and reuse it. While we're at it, we can move variables closer to where they're actually used within DownloadDefaultCover()	2019-05-28 07:27:35 -04:00
Lioncash	27ecb93b32	UICommon/GameFile: Remove unnecessary initializers ... All of the standardized types have constructors that will automatically initialize them, so the explicit initializers are redundant.	2019-05-28 07:00:15 -04:00
Lioncash	56faf750be	UICommon/GameFile: std::move std::string argument in constructor ... Allows for calling code to move the argument into the constructor, avoiding a copy.	2019-05-28 06:57:48 -04:00
Lioncash	8e65869484	UICommon/GameFile: Default no-arg constructor and destructor within the cpp file ... A GameFile instance contains quite a lot of non-trivial types, so default construction and destruction in the same translation unit.	2019-05-28 05:53:40 -04:00
Lioncash	49ca31467d	UICommon/GameFile: Use in-class initializers where applicable ... Allows deduplicating code within the constructor initializer list.	2019-05-28 05:51:51 -04:00
Lioncash	f07cf9ebab	UICommon/ResourcePack: Allow ReadCurrentFileUnlimited() to read into any contiguous container ... This allows the same code to be used to read into a std::string, which allows for eliminating the vector->string transfer when reading the manifest file. A ContiguousContainer is a concept that includes std::array, std::string, and std::vector.	2019-05-27 13:29:40 -04:00
Lioncash	5c4d3f55da	UICommon/Manager: Remove unused std::string variable in Remove()	2019-05-27 13:09:21 -04:00
Lioncash	41cda6fe6d	UICommon/ResourcePack: Use ScopeGuards to manage closing files ... Makes it way harder to introduce resource leaks, and plugs the existing resource leaks in the constructor and Install() where the file wouldn't be closed in some error cases.	2019-05-27 13:02:04 -04:00
Lioncash	157a305507	UICommon/ResourcePack: Deduplicate string construction ... A few cases duplicate the string patch creation, which is kind of wasteful. We can just construct the string once.	2019-05-27 12:45:23 -04:00
Lioncash	a22cc615a9	UICommon/ResourcePack: Remove unnecessary resizes ... We can simply construct the containers with the desired size in these cases.	2019-05-27 12:37:46 -04:00
Lioncash	57701cd988	UICommon/ResourcePack: Make TEXTURE_PATH a regular array ... Same behavior, only it doesn't unnecessarily store a pointer in the executable. While we're at it, make it constexpr and move it into the namespace.	2019-05-27 12:33:50 -04:00
spycrab	5625baa32c	UICommon/VideoUtils.cpp: Add missing include	2019-05-08 21:00:23 +02:00
Techjar	ff972e3673	Reformat repo to clang-format 7.0 rules	2019-05-06 18:48:04 +00:00
Léo Lam	99a4ca8de7	Merge pull request #7839 from ShFil119/impr/redundant ... Remove redundant initialization	2019-05-04 22:50:51 +02:00
Mikaela Szekely	8fe7e271f3	UICommon: Properly set user dir if ./user is a file (not a directory)	2019-05-03 23:30:50 -06:00
Léo Lam	bec85a0962	Merge pull request #8013 from JosJuice/titledatabase-japanese-gc ... Show Japanese GC games in Japanese when using TitleDatabase	2019-05-01 17:37:31 +02:00
Léo Lam	ef88dd73b3	Merge pull request #8014 from JosJuice/getuniqueidentifier-language-independent ... Make GameFile::GetUniqueIdentifier independent of language setting	2019-05-01 17:34:01 +02:00
Filip Gawin	c110ffcdaa	Remove redundant initialization	2019-04-30 01:22:24 +02:00
JosJuice	3bef561e5d	Make GameFile::GetUniqueIdentifier independent of language setting ... My bad. We need this in the situation where two users are using different languages and the game has a different name in each language.	2019-04-27 14:00:58 +02:00
JMC47	6ea43235d5	Merge pull request #7841 from iwubcode/config-mgr-onion ... Config: Move the 'Display' settings from ConfigManager to the layered config system	2019-04-21 00:01:47 -04:00
JosJuice	e98f5fe665	Show Japanese GC games in Japanese when using TitleDatabase ... Because the GC language setting cannot be set to Japanese, we need a special condition for Japanese GC games. I accidentally removed it in PR 7816, but here it is again in a new form. We could do the same thing with Korean GC games if we want to (which we couldn't do before PR 7816), but due to how spotty GameTDB is with having Korean names for Korean GC releases, things will be more consistent if we just use English for them.	2019-04-20 12:12:35 +02:00
spycrab	336edbef1e	UICommon/NetPlayIndex: Handle non 200 HTTP return codes	2019-04-13 12:58:23 +02:00
spycrab	2a1dee4dce	Merge pull request #7976 from spycrab/netplay_index_feedback ... Qt/NetPlay: Show feedback for index adding	2019-04-12 14:21:42 +02:00
spycrab	8b6bb39e82	Qt/NetPlay: Show feedback for index adding	2019-04-11 21:26:00 +02:00
Techjar	f1e06b89da	UICommon/NetPlayIndex: Fix possible crash when Add is called again	2019-04-10 22:39:16 -04:00
spycrab	746849f891	Merge pull request #7964 from Techjar/fix-netplayindex-segfault ... UICommon/NetPlayIndex: Fix random segfaults after quitting NetPlay	2019-04-09 12:45:58 +02:00
spycrab	75f1a5d0cc	Qt/NetPlayBrowser: Various small fixes	2019-04-08 00:01:23 +02:00
Techjar	dc552f2cbb	UICommon/NetPlayIndex: Fix random segfaults after quitting NetPlay ... We can't join a detached thread, so NetPlayIndex gets deleted before the notification thread exits, creating a race condition. We switch to using Common::Event because just sleeping leaves the UI hung on the thread join for a few seconds.	2019-04-06 17:23:37 -04:00
spycrab	094bf0d2ff	Qt/NetPlay: Integrate NetPlayIndex	2019-04-06 12:27:30 +02:00
iwubcode	840afc2ad4	Config: Move the 'Display' settings from ConfigManager to the layered config system	2019-03-30 18:43:02 -05:00
spycrab	827e40d78a	UICommon: Add NetPlayIndex helper	2019-03-30 17:13:57 +01:00
Lioncash	6045b44203	UICommon/ResourcePack: Provide inequality operator to complement equality operator ... Provides symmetrical behavior with the equality operator.	2019-03-13 15:55:20 -04:00
Lioncash	9d096a5e16	UICommon/ResourcePack: Mark ResourcePack's operator== as const	2019-03-13 15:53:30 -04:00
Tilka	19f4772e47	Merge pull request #7816 from JosJuice/titledatabase-edge-cases ... Fix edge cases in TitleDatabase, cover downloading, Gecko code downloading	2019-02-26 04:25:45 +00:00
Tillmann Karras	8b330e1ca3	Discord: fix typo	2019-02-25 19:31:49 +00:00
JosJuice	9df763b4ac	TitleDatabase: Don't merge multiple languages into same map ... Instead of selecting languages based on the user config at the time of TitleDatabase creation and merging the different languages into one map for GC and one map for Wii, have one map for each language, and have the caller supply the language they want. This makes us not need the IsGCTitle function, which is inaccurate for IDs that start with D.	2019-02-25 19:55:46 +01:00
JosJuice	8842a0f402	Keep track of GameTDB ID separately from game ID ... The difference between Dolphin's game IDs and GameTDB's game IDs is that GameTDB uses four characters for non-disc titles, whereas Dolphin uses six characters for all titles. This fixes: - TitleDatabase considering Datel discs to be NHL Hitz 2002 - Gecko code downloading not working for discs with IDs starting with P - Cover downloading mixing up discs with channels (e.g. Mario Kart Wii and Mario Kart Channel) and making extra HTTP requests. (Android was actually doing a better job at this than DolphinQt!)	2019-02-25 19:54:25 +01:00
JosJuice	5ace78bf20	Don't show asterisk next to DOL/ELF size in game list	2019-02-23 16:17:39 +01:00
Tilka	8d59d1bb11	Merge pull request #7798 from ShFil119/impr/empty ... Use empty instead of size	2019-02-13 01:59:43 +00:00
Filip Gawin	49fe9f5db1	Use empty instead of size	2019-02-13 00:03:49 +01:00
spycrab	f86b34ceb9	ResourcePacks: Fix various bugs	2019-02-11 11:05:35 +01:00
spycrab	63cdebba88	UICommon/AutoUpdate: Add macOS support	2019-02-06 20:50:09 +01:00
spycrab	b6863ff0a2	ResourcePacks: Support compression	2019-02-02 15:54:06 +01:00
JMC47	1d3e3de44b	Merge pull request #7629 from JosJuice/auto-disc-change ... Automatic disc change for 2-disc games	2019-01-15 13:01:36 -05:00
JosJuice	bd665aad5d	Automatic disc change for 2-disc games	2019-01-04 09:24:38 +01:00
spycrab	c2c23677ed	UICommon/ResourcePack: Fix resource packs without manifests being able to crash dolphin	2019-01-02 22:47:18 +01:00
spycrab	71d53c922f	Implement resource packs	2018-12-19 11:03:09 +01:00
Pierre Bourdon	98b0efb6de	Merge pull request #7499 from JosJuice/purge-game-list-cache ... DolphinQt: Implement "Purge Game List Cache"	2018-10-28 17:00:04 +01:00
JosJuice	8bbec31295	DolphinQt: Implement "Purge Game List Cache" ... This is a missing feature from DolphinWX.	2018-10-25 08:29:54 +02:00
Stenzek	c95802afeb	CMake: Make X11 and EGL optional	2018-10-20 21:11:34 +10:00