35578 Commits

Author	SHA1	Message	Date
JMC47	93c95ee1a3	Merge pull request #12592 from LillyJadeKatrin/retroachievements-enable-hardcore ... Properly enable RetroAchievements hardcore mode	2024-03-03 13:20:23 -05:00
LillyJadeKatrin	f556f646a2	Don't Publish Unofficial Achievements ... Check an achievement's category and only request RetroAchievements to award if it is CORE and not UNOFFICIAL.	2024-03-03 12:58:20 -05:00
mitaclaw	8d5e39751e	BranchWatchDialog: Fix GCC Warnings ... GCC can't lambda right.	2024-03-02 07:53:23 -08:00
Admiral H. Curtiss	58616a6e4c	Merge pull request #12438 from Filoppi/custom_relative_aspect_ratio ... Add Custom Relative and Raw (Squared Pixels) aspect ratios	2024-03-02 14:14:19 +01:00
Admiral H. Curtiss	f2e04e0603	Merge pull request #12359 from mitaclaw/code-diff-dialog-refresh ... BranchWatchDialog: A Total Replacement for CodeDiffDialog	2024-03-02 14:13:54 +01:00
Admiral H. Curtiss	8840f7f8bc	Merge pull request #12599 from lioncash/vertman ... VertexManagerBase: Initialize m_ticks_elapsed on construction	2024-03-02 14:11:23 +01:00
mitaclaw	16c609dcd4	BootManager: Avoid Global System Accessor	2024-03-01 23:39:04 -08:00
Niel Lebeck	0344ec6d79	Add simple unit tests for SettingsHandler	2024-03-01 20:52:45 -08:00
Naim2000	f208b320a3	AesDevice: fix key & iv arrays	2024-03-01 15:00:28 -05:00
mitaclaw	0d4cb5ddc7	State: Avoid Global System Accessor	2024-03-01 10:52:50 -08:00
mitaclaw	26141eece8	Memory(View)Widget: Avoid Global System Accessor	2024-03-01 07:09:20 -08:00
Filoppi	41b19e262f	Add custom relative and raw (squared pixels) aspect ratio modes	2024-02-29 21:11:19 +02:00
Lioncash	e52109a356	DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs() ... A DynamicReg instance is 80 bytes in size, so this just gets rid of some unnecessary copy churn.	2024-02-28 10:27:35 -05:00
Lioncash	7bf77a56f4	VertexManagerBase: Initialize m_ticks_elapsed on construction ... Ensures that this always has a deterministic value on construction like everything else in the class.	2024-02-28 10:21:08 -05:00
Mai	5a81916ee9	Merge pull request #12598 from mitaclaw/case-insensitive ... CodeWidget: Simplify Case-Insensitive Contains	2024-02-28 08:48:10 -05:00
mitaclaw	8eeb93d51a	CodeWidget: Simplify Case-Insensitive Contains	2024-02-27 12:03:38 -08:00
mitaclaw	8134c8a572	BranchWatchDialog: A Total Replacement for CodeDiffDialog ... With a purpose-built Branch Watch feature built into the emulated system: BranchWatchDialog, replacing CodeDiffDialog, is now better than ever!	2024-02-27 11:40:58 -08:00
mitaclaw	fd8f2c7822	JitArm64: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	7cccedca1e	Jit64: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	2aa250a68a	Interpreter: Install BranchWatch	2024-02-26 19:38:27 -08:00
mitaclaw	67f60bec7e	PowerPC: Implement BranchWatch ... This new component can track code paths by watching branch hits.	2024-02-26 19:38:27 -08:00
LillyJadeKatrin	56b82e764c	Clear active challenges when game closes ... Failing to do this was causing challenge icons to carry over into the next game if a game was closed while the icons were active, even if the next game to run was a completely different game entirely with completely different badges.	2024-02-26 22:21:05 -05:00
Admiral H. Curtiss	5090a028e6	Merge pull request #12435 from Filoppi/fix-aspect-ratio-stuck ... Fix aspect ratio heuristics getting stuck to a state	2024-02-20 21:36:43 +01:00
Filoppi	48fbbdba7c	Video: update widescreen heuristic code to never get stuck to specific old values when changing settings	2024-02-20 22:26:19 +02:00
LillyJadeKatrin	d66b96b1c0	Properly enable RetroAchievements hardcore mode ... RetroAchievements plans to use the user_agent in unlock requests to determine which software version was used to play the game, and can filter older software versions out. As such, I have been given the go-ahead to remove the hardcoded line that forces hardcore to always be false.	2024-02-20 12:59:01 -05:00
Filoppi	3f102ea8c2	Video: Make the game resolution (within the window) snap to the XFB size if they are within a ~1 pixel treshold on one axis only. ... This takes care of making the image clearer in some edge cases where the game was already running at near perfect 4:3 with no stretching, and the VI aspect ratio didn't match the XFB by one pixel, making the image stretched and blurry. -Video: Fix `FindClosestIntegerResolution() using the window aspect ratio and not the draw aspect ratio, causing it to prefer stretching over black bars in cases when it wasn't desirable.	2024-02-20 03:09:11 +02:00
Filoppi	95ee0ac781	Video: Fix aspect ratio heuristics getting stuck to widescreen (or to non widescreen) (m_is_game_widescreen variable) if the user first forced the aspect ratio to 16:9/4:3 and then set it back to Auto.	2024-02-20 02:42:52 +02:00
Admiral H. Curtiss	ccf2435047	Merge pull request #12586 from LillyJadeKatrin/retroachievements-pointspread-fix ... Fixes to Achievement points count/mastery	2024-02-19 02:41:14 +01:00
LillyJadeKatrin	e5b73fec08	Fixes to Achievement points count/mastery ... Two minor updates to improve the Achievement Manager's handling of a player's completion rate. One, UnlockStatus and the unlock map now track achievement category, such that TallyScore does not count unofficial achievements in counts/points. Two, the determinations for mastery/completion are now improved to check (1) that the achievement triggering this is CORE (not UNOFFICIAL) and (2) that it has not already been unlocked at this level on the site, which should be sufficient to determine that the unlocking of this particular achievement completes/masters the game.	2024-02-18 19:27:18 -05:00
Mai	22d96ef5b5	Merge pull request #12590 from iwubcode/graphics_mod_action_factory_name ... VideoCommon: move factory names to be a static inside each action class	2024-02-18 17:13:03 -05:00
Mai	27415b0ba1	Merge pull request #12587 from AdmiralCurtiss/localtime ... Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out	2024-02-18 17:12:29 -05:00
iwubcode	a1147dae6e	VideoCommon: move factory names to be a static inside each action class, so that they can be reused in the future for serialization	2024-02-18 15:45:10 -06:00
Admiral H. Curtiss	638808c944	IOS/FS: Display the invalid path in the ASSERT in BuildFilename().	2024-02-18 20:06:32 +01:00
Admiral H. Curtiss	0157166940	Merge pull request #12585 from iwubcode/json_util_vec3 ... Common: add json utility functions for Vec3 serialization	2024-02-18 19:02:59 +01:00
iwubcode	edbf8f1772	Common: add json utility functions for Vec3 serialization	2024-02-17 22:06:06 -06:00
Admiral H. Curtiss	d3140e72c3	Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out.	2024-02-18 04:45:37 +01:00
Admiral H. Curtiss	52410813f2	Common: Add utility function that wraps localtime_s() or localtime_t().	2024-02-18 04:40:25 +01:00
Admiral H. Curtiss	982ad93355	Merge pull request #12582 from LillyJadeKatrin/retroachievements-bugfix-2 ... Improved achievements disabled messaging	2024-02-18 03:49:44 +01:00
Admiral H. Curtiss	9b5fd5d34e	Merge pull request #12281 from TellowKrinkle/AsahiGL33 ... VideoCommon: Don't use indexed output for fbfetch	2024-02-18 02:33:50 +01:00
Dentomologist	56ff19c513	BalloonTip: Rework BalloonTip drawing ... * Fix irregularly shaped corners * Remove extra space for BalloonTips with no message or no title * When the target tip location is not on a screen, put the tooltip on the mouse's screen instead of the primary screen * Fix description getting cut off when the title was too long * Expose border width as a parameter * Fix spacing and sizing issues with larger border widths	2024-02-17 12:36:19 -08:00
Mai	21300bb21b	Merge pull request #12457 from iwubcode/asset_memory_limit ... VideoCommon: handle asset memory going over reserved limit correctly	2024-02-16 15:46:52 -05:00
LillyJadeKatrin	394af40db5	Improved achievements disabled messaging ... Most obviously, there is no longer a warning message to the player in the achievement window that achievements are disabled if a game is not currently running.	2024-02-15 16:33:18 -05:00
Dentomologist	a1d6a54eaa	DolphinTool: Fix parsing of command line bzip2 flag ... Use "bzip2" instead of "bzip" in optparse's compression choices for the convert command. This is both more accurate and matches what the ParseCompressionTypeString function expects. The mismatch between the two parsing functions prevented compression using bzip2 because either ParseCompressionTypeString or optparse would generate an error when using "bzip" or "bzip2" respectively. Fixes https://bugs.dolphin-emu.org/issues/13427	2024-02-13 12:44:03 -08:00
Mai	a583526a1c	Merge pull request #12575 from n8pjl/werror-nonnull ... IOFile: avoid clearing errors on null file struct	2024-02-13 07:43:19 -05:00
Mai	9e6d701fbc	Merge pull request #12577 from iwubcode/mesh_for_asset_loader ... VideoCommon: make mesh asset data loadable by asset loader	2024-02-13 07:42:57 -05:00
iwubcode	2ab877586d	VideoCommon: make mesh asset data loadable by asset loader	2024-02-12 21:45:32 -06:00
Admiral H. Curtiss	f0d363eea7	Core/DSPHLE: Construct accelerator in AX and AXWii constructors. ... This fixes an issue introduced by 3b0444be6b where the m_accelerator would not be initialized when loading a savestate if the current UCode mismatched the UCode in the savestate, leading to a crash.	2024-02-12 04:18:18 +01:00
Peter Lafreniere	3da2e15e6b	IOFile: avoid clearing errors on null file struct ... When performing a default compilation with recent GCC & glibc, the use of -Werror=nonnull causes a build error. The error is given as IOFile::ClearError() can call std::clearerr() with a null file, which can trigger a null-pointer dereference in libc. Change the std::clearerr() call to be conditional on a file being open.	2024-02-11 20:55:31 -05:00
Mai	aa66842172	Merge pull request #12574 from sepalani/exi-exit ... EXI: Don't kill Dolphin when receiving BBA_IOB	2024-02-11 20:32:33 -05:00
iwubcode	60772ed9d2	VideoCommon: add functionality to prepare for a mesh asset that is loaded from a GLTF file	2024-02-11 13:28:00 -06:00
iwubcode	ecfcae8718	Externals: add tinygltf, a library used to load or save GLTF mesh files	2024-02-11 13:26:39 -06:00
Sepalani	7c276c1993	EXI: Don't kill Dolphin when receiving BBA_IOB ... According to @Kirbymimi it doesn't crash on real hardware. Testing was done by sending many UDP packets to an unbound port.	2024-02-11 23:15:23 +04:00
Mai	80d77ac0b4	Merge pull request #12568 from noahpistilli/kd-register-default-id ... IOS/KD: Correctly handle registration of the default user ID	2024-02-11 13:52:40 -05:00
Mai	dd15c012f3	Merge pull request #12573 from JosJuice/android-wii-menu-download-size ... Android: Mention download size in the Wii Menu not installed message	2024-02-11 13:52:01 -05:00
Mai	9b3fdfb37b	Merge pull request #12572 from JosJuice/android-menu-init-guard ... Android: Don't check Wii Menu version before directory initialization	2024-02-11 13:51:30 -05:00
JosJuice	b404da78c4	Android: Mention download size in the Wii Menu not installed message ... Google Play's policies require us to tell the user the size of any large download. The size seems to vary by just a megabyte or two across regions in my testing, so I'm listing a rough size for all the regions. I'm also taking the opportunity to shorten the message to make it easier to read.	2024-02-11 11:34:51 +01:00
JosJuice	06964a921d	Android: Don't check Wii Menu version before directory initialization ... Fixes a crash.	2024-02-11 11:15:18 +01:00
JosJuice	48ae529762	Android: Update Load Wii System Menu string in onPrepareOptionsMenu ... Because the wording of the Load Wii System Menu string can change depending on the contents of the NAND, we should update that menu item in a method that's guaranteed to get called every time the user opens the menu rather than one that's only guaranteed to be called once.	2024-02-11 10:58:42 +01:00
Admiral H. Curtiss	e6ee217a7c	Core: Move Emulation IOS instance to System.	2024-02-07 22:07:30 +01:00
Mai	ca81d8b8a6	Merge pull request #12565 from LillyJadeKatrin/retroachievements-bugfix ... Retain Save State Folder	2024-02-07 14:03:12 -05:00
Sketch	33dd3b078c	Correctly log register errors	2024-02-07 09:36:36 -05:00
TellowKrinkle	5949911a5a	VideoCommon: Don't use indexed output for fbfetch ... A nonzero index makes no sense, and Mesa doesn't like it when you supply an index	2024-02-07 03:52:31 +01:00
JosJuice	b5c5371848	Arm64Emitter: Don't optimize ADD to MOV for SP ... Unlike ADD (immediate), MOV (register) treats SP as ZR. Therefore the ADDI2R optimization that was added in 67791d227c can't optimize ADD to MOV when exactly one of the registers is SP. There currently isn't any code in Dolphin that calls ADDI2R with parameters that would trigger this case.	2024-02-06 21:58:07 +01:00
LillyJadeKatrin	1ed7b35710	Retain Save State Folder ... Adds a setting field under the hood to retain which folder the player last saved/loaded a state to/from, so that the dialog box to select a state to save/load reopens at that folder.	2024-02-05 19:44:09 -05:00
Mai	9240f579ea	Merge pull request #12561 from JosJuice/profile-consistency ... InputCommon: Fix profile path inconsistencies	2024-02-05 09:47:08 -05:00
JosJuice	1315b54ffa	InputCommon: Use distinct values for profile key ... Because the last commit made us use separate folders for GCPad and GCKey profiles, we should also use separate game INI keys for them. Otherwise setting e.g. PadProfile1 in a game INI will make both GCPad and GCKey try to load it, typically with one of them succeeding and the other one showing a panic alert due to the profile not existing in its folder. Better do this breaking change for GCKeys in the same PR as the other breaking change rather than later.	2024-02-04 17:55:08 +01:00
JosJuice	6cf55ab1ee	InputCommon: Unify GetProfileName and GetProfileDirectoryName ... After reading the previous commit, you might think "hold on, what's the difference between GetProfileName and GetProfileDirectoryName"? These two are being used for the exact same thing - figuring out where profiles are stored - yet they return different values for certain controllers like GC keyboards! As far as I can tell, the existing code has been broken for GC keyboards since they were introduced a decade ago. The GUI (and more recently, also InputCycler) would write and read profiles in one location, and our code for loading profiles specified in a game INI file would read profiles in another location. This commit gets rid of the set of values used by the game INI code in favor of the other set. This does breaking existing setups where a GCKey profile has been configured in a game INI, but I think the number of working such setups is vanishingly small. The alternative would make existing GCKey profiles go missing from the profile dropdown in the GUI, which I think would be more disruptive. The alternative would also force new GCKey profiles into the same directory as GCPad profiles. This commit also fixes a regression from d6c0f8e749. The Android GUI was using GetProfileName to figure out what key to use in the game INI, which made it use incorrect game INI entries for GameCube controller profiles but not Wii Remote profiles. Now the Android GUI uses GetProfileKey for this, fixing the problem.	2024-02-04 17:55:08 +01:00
JosJuice	2bcf70af3f	InputCommon: Refactor away InputConfig::LoadConfig's switch case ... By having getters for this information, other code that needs access to the same information can call the getters instead of duplicating the information.	2024-02-04 16:46:10 +01:00
Sepalani	1831a8cec5	BBA/HLE: Add missing PSH flag	2024-02-03 10:12:07 +04:00
Admiral H. Curtiss	abbc4bd0bd	Merge pull request #12551 from lioncash/cheev ... AchievementManager: Minor cleanup	2024-02-03 03:01:56 +01:00
Admiral H. Curtiss	4e3886e7e8	Merge pull request #12557 from mitaclaw/cpu-thread-guarantees-1 ... CheatSearch: Remove redundant lambdas	2024-02-03 02:45:06 +01:00
Admiral H. Curtiss	df5baab873	Merge pull request #12550 from lioncash/dead ... VertexLoaderManager: Remove unused entry struct	2024-02-03 02:38:02 +01:00
Lioncash	4f40bdf501	VertexLoaderManager: Use fill() in Init() ... Same behavior, less code.	2024-02-01 23:04:40 -05:00
Lioncash	ea95c82a01	VertexLoaderManager: Remove unused entry struct ... This isn't used anywhere, so it can be removed.	2024-02-01 23:04:39 -05:00
Lioncash	db80abbadd	AchievementManager: Tidy up GetRichPresence() ... This can be a direct return.	2024-02-01 23:03:24 -05:00
Lioncash	c14414a151	AchievementManager: clear name in CloseGame()/LogOut() ... A little more idiomatic.	2024-02-01 23:03:24 -05:00
Lioncash	2d8af7b7f8	AchievementManager: Replace memsets where applicable ... We can just use brace initialization to zero these out. Smaller to write and a little quicker to read.	2024-02-01 23:03:24 -05:00
Lioncash	184fe932ed	AchievementManager: std::move leaderboard info in FetchBoardInfo() ... Avoids churning some allocations.	2024-02-01 23:03:24 -05:00
Lioncash	76c381e6f7	AchievementManager: Ensure update callback is always valid ... This way we don't need to do any validity checking aside from the initial setting of the callback. Also cuts down on line noise.	2024-02-01 23:03:23 -05:00
Lioncash	2b83cc739a	AchievementManager: Convert .compare() into equality operators ... These perform a default comparison, which is the same as using the equality operators.	2024-02-01 23:03:23 -05:00
Lioncash	394418b415	AchievementManager: Remove unnecessary .get() ... Same behavior, less code.	2024-02-01 23:03:23 -05:00
Lioncash	161efff6c9	AchievementManager: Remove long qualifier ... We can remove the long qualifying on some ResponseType instances to lessen the amount of reading.	2024-02-01 23:03:23 -05:00
Lioncash	7096f99f79	CustomPipeline: Mark arrays as constexpr ... Ensures that these go into the ro section.	2024-02-01 23:02:45 -05:00
Lioncash	59211589b9	CustomPipeline: Make use of emplace_back() in GlobalConflicts() ... We can use the string_view arguments to directly construct strings inside of the global_result vector.	2024-02-01 23:02:45 -05:00
Lioncash	353ceedb50	CustomPipeline: Resolve unused variable warning ... We can just use holds_alternative here instead.	2024-02-01 23:02:45 -05:00
mitaclaw	085c4d154e	CheatSearch: Remove redundant lambdas ... Core::RunAsCPUThread is obsoleted by CPUThreadGuard reference already passed into the function. The nonsense lambda in CheatSearchWidget is from changes in fdb7328c73.	2024-02-01 19:54:47 -08:00
Admiral H. Curtiss	951be30891	Core: Fix booting titles from NAND.	2024-02-01 19:50:20 +01:00
Admiral H. Curtiss	14121c5504	Core/ConfigManager: Remove dead bAutomaticStart flag.	2024-01-31 22:53:43 +01:00
Admiral H. Curtiss	da6b5dd38a	Merge pull request #12546 from lioncash/event ... VideoCommon/Statistics: Remove global system accessor from s_after_frame_event	2024-01-31 21:16:21 +01:00
Admiral H. Curtiss	18abf7c768	Merge pull request #12544 from lioncash/getmod ... GraphicsModGroup: Allow heterogenous lookup for GetMod()	2024-01-31 20:17:26 +01:00
Admiral H. Curtiss	202c10d757	Merge pull request #12547 from lioncash/movie ... Core/Movie: Remove lingering global system instance accessors	2024-01-31 20:12:07 +01:00
Lioncash	5ade2e39ef	Core/Movie: Remove lingering global system instance accessors ... The movie manager is already passed in a reference to the relevant system, so we can use that instead.	2024-01-31 13:30:24 -05:00
Lioncash	16d8b6e6b3	Common/HookableEvent: std::move callback instance in Register() ... Potentially avoids reallocations if the capture buffer of the callback is quite large.	2024-01-31 13:16:50 -05:00
Lioncash	cac66317aa	VideoCommon/Statistics: Remove global system accessor from s_after_frame_event ... Instead, we make the event take a reference to the system and then pass it in when the event is triggered. This does introduce two other accessors, but these are much easier to refactor out over time, and without modification to the existing event interface.	2024-01-31 13:12:09 -05:00
Lioncash	0dfefacdf4	VertexLoaderBase: Collapse std namespace for hash and mark noexcept ... Makes the hash specialization a little less noisy. Also we mark it noexcept, since hashes shouldn't be throwing exceptions (and this can be optimized on).	2024-01-31 12:43:00 -05:00
Lioncash	8e4b2565cd	TextureConfig: Collapse std namespace for hash ... Lets us collapse the namespacing and make the specialization a little less noisy.	2024-01-31 12:41:33 -05:00
Lioncash	b63dcd504d	RenderState: Collapse std namespace for hash ... We can specify the namespace on the hash to make the specialization a little less noisy.	2024-01-31 12:40:10 -05:00
Lioncash	5bfaa3a966	NativeVertexFormat: Collapse std namespace and mark hash noexcept ... We can just tag the std:: onto the end of the specialization to make it less noisy. Also mark it as noexcept, since hashes shouldn't throw exceptions.	2024-01-31 12:37:44 -05:00
Lioncash	40b050fe37	GraphicsModGroup: std::move graphics_mod in Load() ... The config object is quite heavyweight, so we should move this instead of copying.	2024-01-31 12:27:43 -05:00
Lioncash	ccacda5e2c	GraphicsModGroup: Simplify try_add_mod() ... We can use contains() here, and also move the mod config if it's valid instead of copying it, since it contains quite a bit of allocated data.	2024-01-31 12:23:21 -05:00
Lioncash	81aca79145	GraphicsModListWidget: Pass optional by const reference ... All we do is read from it, so we don't need to copy the string if we happen to have one.	2024-01-31 12:09:35 -05:00
Lioncash	a1879ea099	GraphicsModGroup: Allow heterogenous lookup for GetMod() ... Allows using keys that aren't directly std::string as the key. This lets us use std::string_view for the incoming path name, making it more flexible with other string types.	2024-01-31 12:05:17 -05:00
Mai	30fdf25f8f	Merge pull request #12542 from AdmiralCurtiss/system-sconfig ... Migrate m_is_mios and bWii from SConfig to System.	2024-01-31 09:57:17 -05:00
Admiral H. Curtiss	9a3e770c23	Migrate SConfig::bWii to System.	2024-01-31 12:54:07 +01:00
Mai	e0828815e7	Merge pull request #12540 from mitaclaw/encode-reg-to-64 ... Add Missing EncodeRegTo64 in JitArm64::dcbx	2024-01-30 13:08:03 -05:00
mitaclaw	45481620b8	Add Missing EncodeRegTo64 in JitArm64::dcbx ... ARM64FloatEmitter::ABI_PushRegisters expects an XReg temporary, not a WReg.	2024-01-30 03:06:32 -08:00
Admiral H. Curtiss	8d515d407c	Migrate SConfig::m_is_mios to System.	2024-01-30 03:45:17 +01:00
luc-git	d124fcbb0d	DolphinQt/RenderWidget: Add comments for SetCursorLocked() on Linux. ... Co-authored-by: Admiral H. Curtiss <pikachu025@gmail.com>	2024-01-30 01:06:30 +01:00
LillyJadeKatrin	fd99a5db9a	Reverse endianness of achievement memory peeks ... rcheevos expects these multi-byte peeks to have the opposite endianness so they need to be swapped before rcheevos gets them.	2024-01-29 11:55:49 -05:00
Admiral H. Curtiss	8482a50154	Merge pull request #12530 from iwubcode/custom_shaders_compilation_fixes ... VideoCommon: fix some issues when compiling custom shaders	2024-01-28 14:30:37 +01:00
Admiral H. Curtiss	4843705061	Merge pull request #12534 from iwubcode/custom-pipeline-refactor ... VideoCommon: refactor the custom pipeline logic to be reusable	2024-01-28 14:28:23 +01:00
Admiral H. Curtiss	c9715e7e7d	Merge pull request #12535 from iwubcode/vertexmanager_draw_refactor ... VideoCommon: refactor drawing into its own function	2024-01-28 14:27:41 +01:00
Admiral H. Curtiss	0405b4dcc2	Merge pull request #12536 from LillyJadeKatrin/retroachievements-bugfix ... Removed post data from Achievement request logs	2024-01-28 14:26:09 +01:00
LillyJadeKatrin	f25bdda728	Removed post data from Achievement request logs ... post_data included passwords and API keys in plaintext so continuing to include it in logs is a security liability.	2024-01-27 18:50:27 -05:00
JosJuice	990303a028	Merge pull request #12519 from lioncash/leak ... PostProcessing: Don't potentially leak memory in BlitFromTexture()	2024-01-27 22:29:45 +01:00
iwubcode	c34b3ae390	VideoCommon: refactor drawing into its own function	2024-01-27 14:45:34 -06:00
iwubcode	3e3967ff94	VideoCommon: refactor the custom pipeline logic in the graphics mod action into a separate class, so it is reusable	2024-01-27 00:12:49 -06:00
Admiral H. Curtiss	e740e32562	Merge pull request #12522 from lioncash/ppcanalyst ... PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore()	2024-01-26 20:29:16 +01:00
Admiral H. Curtiss	b0491c2ce8	Merge pull request #12529 from iwubcode/math_determinant ... Common: add determinant functions to Matrix33 and Matrix44	2024-01-26 19:13:38 +01:00
Admiral H. Curtiss	b09b59c125	Merge pull request #12521 from lioncash/reent ... Core: Make use of reentrant time utilities where applicable	2024-01-26 18:55:26 +01:00
Admiral H. Curtiss	460ab609d0	Merge pull request #12524 from lioncash/memb ... Jit64AsmCommon: Remove redundant m_jit member from CommonAsmRoutines	2024-01-26 18:53:44 +01:00
Admiral H. Curtiss	c3652a7129	Merge pull request #12532 from lioncash/json ... GraphicsMod/ShaderAsset: Lessen object churn a little bit	2024-01-26 18:52:52 +01:00
Mai	a553308775	Merge pull request #12443 from iwubcode/custom_pipeline_action_material_cubemap ... VideoCommon: update custom pipeline action to support a variety of texture samplers, support for materials, and more!	2024-01-26 12:39:37 -05:00
iwubcode	b37f096f4b	Common: add determinant functions to Matrix33 and Matrix44	2024-01-24 23:02:57 -06:00
Lioncash	7a59ecc39d	GraphicsTarget: Reduce object churn a little	2024-01-24 23:00:01 -05:00
Lioncash	1b7da37114	GraphicsTargetGroup: Reduce object churn a little	2024-01-24 22:52:58 -05:00
Lioncash	24f952c12b	GraphicsModFeature: Reduce object churn a little	2024-01-24 22:48:53 -05:00
Lioncash	0385b40bd8	GraphicsModAsset: Reduce object churn a little	2024-01-24 22:47:22 -05:00
Lioncash	2253d9a95d	GraphicsModGroup: Mark move constructor and assignment as noexcept ... Allows containers to optimize off of std::move_if_noexcept	2024-01-24 22:41:30 -05:00
Lioncash	0327b11e0b	GraphicsModGroup: Reduce object churn ... We can emplace and move to avoid doing object copies.	2024-01-24 22:40:05 -05:00
Lioncash	e3e20df185	GraphicsMod: Avoid some object churn ... We have quite a bit of allocation churn going on here, so we can emplace and move where appropriate to alleviate that a little.	2024-01-24 22:34:50 -05:00
Lioncash	7b6463ef1f	ShaderAsset: Emplace value instances when possible in ToJson() ... Constructs elements directly inside the container and also makes it shorter to read in certain instances.	2024-01-24 18:47:44 -05:00
Mai	97160ddc83	Merge pull request #12531 from LillyJadeKatrin/retroachievements-bugfix ... Add host URL setting to achievements config	2024-01-24 16:17:17 -05:00
Admiral H. Curtiss	58bff55c71	Merge pull request #12528 from lioncash/assembler ... DolphinQt/MenuBar: Hide assembler option if debug UI is disabled	2024-01-24 18:48:32 +01:00
Admiral H. Curtiss	2826099808	Merge pull request #12523 from lioncash/fallthrough ... Core: Get rid of some unannotated fallthrough cases	2024-01-24 18:40:32 +01:00
Admiral H. Curtiss	5692e15285	Merge pull request #12525 from lioncash/defined ... Core: Convert some preprocessor checking to use #ifdef/#if defined() over #if	2024-01-24 18:39:49 +01:00
JosJuice	74d4cb0274	Merge pull request #12526 from lioncash/trace ... CodeTrace: Use std::set::lower_bound() over std::lower_bound()	2024-01-24 17:56:39 +01:00
JosJuice	dab03e4c08	Merge pull request #12527 from lioncash/highlight ... GekkoSyntaxHighlight: Fix FPR terminal highlighting being treated as GPRs	2024-01-24 17:55:44 +01:00
LillyJadeKatrin	03e3f65653	Add host URL setting to achievements config ... The Host URL setting in the RetroAchievements config will, if set, be used as the host URL for all server requests for achievements. This allows for an easy switch to the RetroAchievements staging server for testing.	2024-01-24 07:08:54 -05:00
iwubcode	cf081e839d	VideoCommon: fix compilation error in pixel shaders when per-pixel lighting isn't set for custom shaders	2024-01-23 21:50:42 -06:00
iwubcode	a8d45b8e55	VideoCommon: fix compilation error in uber pixel shaders when pixel shader lighting isn't set for custom shaders	2024-01-23 21:50:42 -06:00
iwubcode	7118fc5b7b	VideoCommon: fix pixel shader compilation error that happens when uint output is defined	2024-01-23 21:50:42 -06:00
iwubcode	a37fd83218	VideoCommon: fix uber shader pixel compilation error that happens when uint output is defined	2024-01-23 21:50:41 -06:00
Lioncash	a65aaccd59	DolphinQt/MenuBar: Hide assembler option if debug UI is disabled ... Fixes a little visual inconsistency in the UI, where the assembler would always be shown, but all other debug-related utilities would be hidden.	2024-01-23 18:57:23 -05:00
Lioncash	100242a380	GekkoSyntaxHighlight: Collapse cases for builtin color formats ... Same behavior, but without as much duplication.	2024-01-23 18:39:59 -05:00
Lioncash	e4fa5614d1	GekkoSyntaxHighlight: Fix FPR terminal highlighting being treated as GPRs ... Copy-paste error. Ultimately GPR and FPRs use the same highlighting style anyway, so this is mostly just a correctness change.	2024-01-23 18:38:06 -05:00
Lioncash	6cb3389696	CodeTrace: Use std::set::lower_bound() over std::lower_bound() ... std::set's lower_bound() is optimized better than the generic implementation of std::lower_bound() std::lower_bound() works best on random access iterators, where the number of comparisons can be logarithmic. However, since std::set's iterators are bidirectional iterators, the comparisons will actually be linear in practice when using std::lower_bound(). So, we can use std::set's version which is guaranteed to be logarithmic.	2024-01-23 17:21:22 -05:00
Lioncash	258161bab7	DolphinAnalytics: Use #ifdef instead of #if for platform testing	2024-01-23 16:51:31 -05:00
Lioncash	4ccc5178a6	PowerPC: Use #ifdef instead of #if for platform testing ... This way we don't assume these symbols are always defined.	2024-01-23 16:47:43 -05:00
Lioncash	f695ae5730	JitInterface: Use #ifdef instead of #if for platform testing ... \#if assumes the symbols will always be defined, but they aren't depending on the platform.	2024-01-23 16:42:36 -05:00
Lioncash	a9f89a7d3b	WiimoteEmu: check for __APPLE__ with defined() ... This is only defined on certain platforms and isn't always defined.	2024-01-23 16:40:21 -05:00
Lioncash	3c64d030c5	FreeLookManager: check for __APPLE__ with defined() ... Previously this was treating the identifier as if it were always defined by default	2024-01-23 16:40:10 -05:00
Lioncash	b06e1880b6	Jit64AsmCommon: Remove redundant m_jit member from CommonAsmRoutines ... We pass a JIT instance all the way down to EmuCodeBlock, which is accessible under protected as well, so this isn't really necessary.	2024-01-23 16:27:02 -05:00
Lioncash	adb79d4e32	WiimoteReal: Explicitly break instead of fallthrough in IsBalanceBoard() ... Same behavior, no compiler warnings.	2024-01-23 16:22:10 -05:00
Lioncash	28e93827db	EXI_DeviceAGP: Annotate fallthrough with [[fallthrough]] ... Same behavior, but eleminates compiler warnings.	2024-01-23 16:19:23 -05:00
Lioncash	7ef0262f8a	PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore() ... The type checking is duplicated here, which makes this seem a little weird, so we can get rid of it.	2024-01-23 16:08:24 -05:00
Lioncash	6a86b35e88	State: Make use of re-entrant variant of localtime ... Makes this member function thread-safe. We can also unify the string handling to make it easier to maintain.	2024-01-23 15:28:30 -05:00
Lioncash	1b3f61041a	Movie: Remove global system accessor from GetRTCDisplay() ... We can just use m_system instance reference instead.	2024-01-23 15:15:13 -05:00
Lioncash	763562357b	Movie: Mark getters as const ... These don't modify internal member state.	2024-01-23 15:15:13 -05:00
Lioncash	c0b0023b64	Movie: Use re-entrant variant of gmtime in GetRTCDisplay() ... Makes this member function thread-safe.	2024-01-23 15:15:10 -05:00
Lioncash	f03da37693	NetKDTime: Use re-entrant variants of gmtime ... Makes these implementations more thread-safe by design. These likely won't be run on any other thread, but we may as well just use the re-entrant variant if it's available.	2024-01-23 14:30:44 -05:00
iwubcode	3a688aa35e	VideoCommon: add function to serialize MaterialAsset to json	2024-01-23 13:01:33 -06:00
Lioncash	5aeadb1ef8	PostProcessing: Don't potentially leak memory in BlitFromTexture() ... All release() does is relinquish the pointer, rather than free the memory associated with it.	2024-01-23 13:34:40 -05:00
Lioncash	a3f9f2c7aa	PostProcessing: Remove unnecessary get() calls in BlitFromTexture() ... We can just use operator-> instead.	2024-01-23 13:34:16 -05:00
JosJuice	f2292467ad	Merge pull request #12518 from lioncash/pragma ... AchievementSettings: Move pragma once out of ifdef	2024-01-23 19:24:38 +01:00
JosJuice	96fda3d126	Merge pull request #12517 from lioncash/alloc ... Jit64/JitRegCache: Simplify GetAllocationOrder()	2024-01-23 19:23:42 +01:00
iwubcode	a40a952177	VideoCommon: add a method to calculate a default value for ShaderAsset and another to list its types	2024-01-23 11:58:32 -06:00
iwubcode	b5a6225e1a	VideoCommon: add function to serialize ShaderAsset to json	2024-01-23 11:58:32 -06:00
Lioncash	49eadbb824	AchievementSettings: Move pragma once out of ifdef ... Makes the header a little more consistent with others (and also we should still have a header guard be present at all times).	2024-01-23 11:56:50 -05:00
Lioncash	9f82efa3e2	Jit64/JitRegCache: Simplify GetAllocationOrder() ... Given we have fixed allocation orders, we can just directly return a span instead of a pointer and a size via an out parameter. Makes it a little more convenient, since we get both pieces of info at once, and also have the ability to iterate directly off the span out of the box.	2024-01-23 11:03:59 -05:00
Mai	713572e874	Merge pull request #12510 from JosJuice/android-revert-attach-early ... Revert "Android: Attach CPU thread to JVM early"	2024-01-21 10:23:15 -05:00
Mai	d64705d691	Merge pull request #12512 from JosJuice/assembler-dirty-flag ... DolphinQt: Rework dirty flag handling in AssemblerWidget::TabTextForEditor	2024-01-21 10:22:46 -05:00
JosJuice	4b7c953415	Merge pull request #12509 from AdmiralCurtiss/bbox-init-only-if-supported ... VideoCommon: Only initialize Bounding Box if supported by GPU/driver.	2024-01-20 21:59:15 +01:00
JosJuice	6276232574	DolphinQt: Rework dirty flag handling in AssemblerWidget::TabTextForEditor ... Putting the handling of the dirty flag in only one string makes it clearer for translators what's going on.	2024-01-20 20:00:52 +01:00
JosJuice	6cd67e3937	Partially revert "DolphinQt/Assembler: improve translatability" ... This reverts the parts of commit c8c9928eb1 that made translatability worse rather than better. Changing "Error in column %2" to "%1 in column %2" not only means that the translators have to check the i18n comments to know what word hides behind %1, but there's also the problem that the translator might need to translate "Error" in this context differently from the standalone string "Error". Having to copy-paste some HTML tags may be annoying for translators, but it's a far less serious problem.	2024-01-20 14:46:41 +01:00
JosJuice	c8327ad514	Revert "Android: Attach CPU thread to JVM early" ... This reverts commit e86d713600. A proper fix was added in 86c1f6e1e7, so the workaround is no longer necessary.	2024-01-20 14:26:50 +01:00
Admiral H. Curtiss	ac670d99e2	VideoCommon: Only initialize Bounding Box if supported by GPU/driver.	2024-01-20 12:34:24 +01:00
Admiral H. Curtiss	83d4b692b8	InputCommon/WGInput: Handle add/remove events on separate thread to prevent deadlocks. ... In particular this is triggered when running Dolphin with the Steam overlay.	2024-01-18 00:30:45 +01:00
Admiral H. Curtiss	12318f921f	Merge pull request #12503 from AdmiralCurtiss/sdl-fixes ... InputCommon/SDL: Fix potential issues in controller initialization.	2024-01-18 00:29:25 +01:00
Mai	6aacbc4c35	Merge pull request #12488 from JosJuice/jitarm64-psq-stxx-w0 ... JitArm64: Remove unnecessary locking of W0 in psq_stXX	2024-01-15 15:14:59 -05:00
Mai	5534f510e0	Merge pull request #12498 from AdmiralCurtiss/globals-socket ... Core/IOS/Network/Socket: Avoid global system accessor.	2024-01-15 15:13:41 -05:00
Admiral H. Curtiss	c7d7ae4912	InputCommon/SDL: Code style fixes.	2024-01-15 15:19:41 +01:00
Admiral H. Curtiss	5e6e61c723	InputCommon/SDL: Avoid potential infinite loops from integer truncation.	2024-01-15 15:19:24 +01:00
Admiral H. Curtiss	d657ad5932	InputCommon/SDL: Check for errors from SDL_JoystickNumButtons(), SDL_JoystickNumAxes(), SDL_JoystickNumHats().	2024-01-15 15:18:38 +01:00
Admiral H. Curtiss	959c39133b	InputCommon/SDL: Fix incorrect use of std::vector::assign() and check bounds.	2024-01-15 15:17:32 +01:00
Admiral H. Curtiss	95cba6be2b	Core/Movie: Refactor to class, move to System. ... A bit of global state remains (the `header` in `BeginRecordingInput()`) due to unclear lifetime requirements.	2024-01-15 08:05:30 +01:00
Mai	c76dee7807	Merge pull request #12285 from iwubcode/serialize_graphics_mods ... VideoCommon: add ability to serialize graphics mod to json object	2024-01-13 14:15:14 -05:00
Admiral H. Curtiss	1cca3b24c6	Merge pull request #12085 from SuperSamus/sdl-gamecontroller ... SDL: Add GameController API, cleanup	2024-01-13 16:37:43 +01:00
Martino Fontana	51e05f468a	SDL: Add GameController API, cleanup	2024-01-13 16:10:25 +01:00
Admiral H. Curtiss	4a362ddd33	Core/IOS/Network/Socket: Avoid global system accessor.	2024-01-13 13:18:20 +01:00
Mai	8760aca8ec	Merge pull request #12500 from AdmiralCurtiss/globals-fiforecorder ... FifoRecorder: Move instance to System.	2024-01-13 06:38:39 -05:00
Mai	d36baf633c	Merge pull request #12499 from AdmiralCurtiss/globals-mmiorw ... Core/HW/MMIO: Pass System through Read() and Write().	2024-01-13 06:37:49 -05:00
Admiral H. Curtiss	443b4ae745	Core/FifoPlayer: Avoid global System accessor.	2024-01-12 21:54:35 +01:00
Admiral H. Curtiss	637fd49909	FifoRecorder: Move instance to System.	2024-01-12 15:06:06 +01:00
Admiral H. Curtiss	42d61cfc4c	Core/HW/MMIO: Pass System through Read() and Write().	2024-01-12 08:28:01 +01:00
Mai	6725c25600	Merge pull request #12494 from AdmiralCurtiss/globals-wiiipc ... Core/IOS/WiiIPC: Refactor to class, move to System.	2024-01-12 02:08:00 -05:00
Mai	ab3655fbea	Merge pull request #12496 from AdmiralCurtiss/globals-gba ... Core/HW/GBACore: Avoid global System accessor.	2024-01-12 02:05:57 -05:00
Admiral H. Curtiss	bca5b10faf	Merge pull request #12489 from JosJuice/optimizable-access-size ... PowerPC: Add access size parameter to MMU::IsOptimizableRAMAddress	2024-01-12 07:44:59 +01:00
Admiral H. Curtiss	f7a9ea9d7e	Core/HW/GBACore: Avoid global System accessor.	2024-01-12 07:30:20 +01:00
Admiral H. Curtiss	5a633f0bcf	Core/IOS/WiiIPC: Add missing variables to savestate.	2024-01-12 06:37:11 +01:00