emu-mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-03 22:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity
72cf2bdb87
dolphin/Source/Core/DolphinQt/Config
History
JosJuice 72cf2bdb87 Audit uses of IsRunning and GetState 
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
2024-06-21 20:52:55 +02:00
..
ConfigControls InterfacePane: Add BalloonTip to cursor visible radio buttons 2024-05-31 19:09:00 +02:00
ControllerInterface DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
Graphics Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
Mapping DolphinQt/Mapping: Disable relative input when "Mouse Controlled Pointing" button is pressed. 2024-04-15 14:52:26 -05:00
ToolTipControls DolphinQt: Fix BalloonTip positioning on secondary monitors. 2024-03-20 03:13:11 -05:00
ARCodeWidget.cpp CheatsManager: Allow making the window smaller 2024-03-31 13:17:56 -07:00
ARCodeWidget.h Disable cheats in hardcore mode 2023-12-02 16:41:17 -05:00
CheatCodeEditor.cpp Split out code for serializing/deserializing cheat lines 2021-08-28 19:31:27 +02:00
CheatCodeEditor.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
CheatWarningWidget.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
CheatWarningWidget.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
CommonControllersWidget.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
CommonControllersWidget.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
ControllersWindow.cpp Qt/WiimoteControllersWidget: Add bluetooth unavailable message 2023-02-24 14:30:43 -08:00
ControllersWindow.h Qt/WiimoteControllersWidget: Add bluetooth unavailable message 2023-02-24 14:30:43 -08:00
FilesystemWidget.cpp DolphinQt: Properly Delete (Some) Widgets 2024-04-30 11:17:28 -07:00
FilesystemWidget.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
FreeLookWidget.cpp AchievementManager: Make GetInstance() return a reference 2023-12-11 13:36:39 -05:00
FreeLookWidget.h Qt: Rename GraphicsChoice to ConfigChoice 2023-04-25 11:39:24 -07:00
FreeLookWindow.cpp Disable Freelook in hardcore mode 2023-12-02 16:41:16 -05:00
FreeLookWindow.h Disable Freelook in hardcore mode 2023-12-02 16:41:16 -05:00
GameConfigEdit.cpp Rename Fast Disc Speed to Emulate Disc Speed and invert option 2023-02-12 16:20:38 -05:00
GameConfigEdit.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
GameConfigHighlighter.cpp DolphinQt: Adjust panel-specific colors and syntax highlighting for dark theme. 2023-08-12 19:43:12 +02:00
GameConfigHighlighter.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
GameConfigWidget.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
GameConfigWidget.h Qt/GameConfigWidget: Add Manual Texture Sampling 2023-07-25 00:45:13 +02:00
GamecubeControllersWidget.cpp Core::IsRunning: Avoid Global System Accessor 2024-05-01 08:54:17 -07:00
GamecubeControllersWidget.h Qt/GamecubeControllersWidget: Disable dropdowns during netplay. 2022-10-02 23:10:43 +02:00
GeckoCodeWidget.cpp CheatsManager: Allow making the window smaller 2024-03-31 13:17:56 -07:00
GeckoCodeWidget.h Disable cheats in hardcore mode 2023-12-02 16:41:17 -05:00
GraphicsModListWidget.cpp Core::GetState: Avoid Global System Accessor 2024-04-08 16:23:23 -07:00
GraphicsModListWidget.h GraphicsModListWidget: Pass optional by const reference 2024-01-31 12:09:35 -05:00
GraphicsModWarningWidget.cpp DolphinQt: add warning if graphics mods are not enabled 2022-06-27 18:28:28 -05:00
GraphicsModWarningWidget.h DolphinQt: add warning if graphics mods are not enabled 2022-06-27 18:28:28 -05:00
HardcoreWarningWidget.cpp Disabled Hardcore Mode when Achievements disabled 2024-05-02 04:44:52 -04:00
HardcoreWarningWidget.h Added Hardcore Warning Widget 2023-12-02 16:41:15 -05:00
InfoWidget.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
InfoWidget.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
LogConfigWidget.cpp DolphinQt: Fix leak in LogConfigWidget 2023-04-04 16:05:23 -04:00
LogConfigWidget.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
LogWidget.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
LogWidget.h Common: Move FixedSizeQueue into Common namespace 2023-03-22 01:23:15 -04:00
NewPatchDialog.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
NewPatchDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
PatchesWidget.cpp Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
PatchesWidget.h Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
PropertiesDialog.cpp Disable cheats in hardcore mode 2023-12-02 16:41:17 -05:00
PropertiesDialog.h Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
SettingsWindow.cpp Treewide: Adjust order of includes 2021-12-10 14:49:57 -08:00
SettingsWindow.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
VerifyWidget.cpp VerifyWidget: Listen for Core::State OnEmulationStateChanged 2024-04-09 12:13:02 -07:00
VerifyWidget.h VerifyWidget: Listen for Core::State OnEmulationStateChanged 2024-04-09 12:13:02 -07:00
WiimoteControllersWidget.cpp Core::GetState: Avoid Global System Accessor 2024-04-08 16:23:23 -07:00
WiimoteControllersWidget.h Qt/WiimoteControllersWidget: Add bluetooth unavailable message 2023-02-24 14:30:43 -08:00