mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-01-01 01:30:53 +01:00
7c2a39706e
There were three distinct mechanisms for signaling breakpoint changes in DolphinQt, and the wiring had room for improvement. The behavior of these signals has been consolidated into the new `Host::PPCBreakpointsChanged` signal, which can be emitted from anywhere in DolphinQt to properly update breakpoints everywhere in DolphinQt. This improves a few things: - For the `CodeViewWidget` and `MemoryViewWidget`, signals no longer need to propagate through the `CodeWidget` and `MemoryWidget` (respectively) to reach their destination (incoming or outgoing). - For the `BreakpointWidget`, by self-triggering from its own signal, it no longer must manually call `Update()` after all of the emission sites. - For the `BranchWatchDialog`, it now has one less thing it must go through the `CodeWidget` for, which is a plus.
95 lines
2.0 KiB
C++
95 lines
2.0 KiB
C++
// Copyright 2018 Dolphin Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#pragma once
|
|
|
|
#include <QDockWidget>
|
|
#include <QString>
|
|
|
|
#include "Common/CommonTypes.h"
|
|
#include "DolphinQt/Debugger/CodeViewWidget.h"
|
|
|
|
class BranchWatchDialog;
|
|
class QCloseEvent;
|
|
class QLineEdit;
|
|
class QShowEvent;
|
|
class QSplitter;
|
|
class QListWidget;
|
|
class QPushButton;
|
|
class QTableWidget;
|
|
|
|
namespace Common
|
|
{
|
|
struct Symbol;
|
|
}
|
|
namespace Core
|
|
{
|
|
class System;
|
|
}
|
|
class PPCSymbolDB;
|
|
|
|
class CodeWidget : public QDockWidget
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
explicit CodeWidget(QWidget* parent = nullptr);
|
|
~CodeWidget();
|
|
|
|
void Step();
|
|
void StepOver();
|
|
void StepOut();
|
|
void Skip();
|
|
void ShowPC();
|
|
void SetPC();
|
|
|
|
void OnBranchWatchDialog();
|
|
void ToggleBreakpoint();
|
|
void AddBreakpoint();
|
|
void SetAddress(u32 address, CodeViewWidget::SetAddressUpdate update);
|
|
|
|
void Update();
|
|
void UpdateSymbols();
|
|
signals:
|
|
void RequestPPCComparison(u32 addr);
|
|
void ShowMemory(u32 address);
|
|
|
|
private:
|
|
void CreateWidgets();
|
|
void ConnectWidgets();
|
|
void UpdateCallstack();
|
|
void UpdateFunctionCalls(const Common::Symbol* symbol);
|
|
void UpdateFunctionCallers(const Common::Symbol* symbol);
|
|
|
|
void OnPPCSymbolsChanged();
|
|
void OnSearchAddress();
|
|
void OnSearchSymbols();
|
|
void OnSelectSymbol();
|
|
void OnSelectCallstack();
|
|
void OnSelectFunctionCallers();
|
|
void OnSelectFunctionCalls();
|
|
|
|
void closeEvent(QCloseEvent*) override;
|
|
void showEvent(QShowEvent* event) override;
|
|
|
|
Core::System& m_system;
|
|
PPCSymbolDB& m_ppc_symbol_db;
|
|
|
|
BranchWatchDialog* m_branch_watch_dialog = nullptr;
|
|
QLineEdit* m_search_address;
|
|
QPushButton* m_branch_watch;
|
|
|
|
QLineEdit* m_search_callstack;
|
|
QListWidget* m_callstack_list;
|
|
QLineEdit* m_search_symbols;
|
|
QListWidget* m_symbols_list;
|
|
QLineEdit* m_search_calls;
|
|
QListWidget* m_function_calls_list;
|
|
QLineEdit* m_search_callers;
|
|
QListWidget* m_function_callers_list;
|
|
CodeViewWidget* m_code_view;
|
|
QSplitter* m_box_splitter;
|
|
QSplitter* m_code_splitter;
|
|
|
|
QString m_symbol_filter;
|
|
};
|