dolphin/Source
Pokechu22 a81b44f697 Fix menu bar becoming desynced when Pause at End of Movie is disabled
Previously, when Pause at End of Movie was disabled, the game would continue running as it should, but the menu bar would think the game was paused, showing the play button instead of the pause button.  To make things worse, clicking the play button would then restart the game, instead of pausing or doing nothing.  F10 paused/unpaused as normal, though.

The old behavior was essentially to enable stepping/pause mode (via `CPU::Break()`) and then if Pause at End of Movie was disabled, to un-pause on the host thread (via `CPU::EnableStepping(false)`).  For reasons which aren't entirely clear to me, the first one notified the menu bar (through the `Host::UpdateDisasmDialog` callback, not the `Settings::EmulationStateChanged` one), and the second did not.  In any case, this approach does not particularly make sense; I don't see any reason to pause and unpause if Pause at End of Movie is disabled; instead, we should only pause when Pause at End of Movie is enabled.

This behavior was probably introduced in c1944f623b, though I haven't tested it.
2022-02-16 11:07:12 -08:00
..
Android Android: Fix the logic for getting the Riivolution path 2022-02-09 21:43:52 +01:00
Core Fix menu bar becoming desynced when Pause at End of Movie is disabled 2022-02-16 11:07:12 -08:00
DSPSpy DSPSpy: Replace less_test with cond_test 2021-08-22 17:07:41 -07:00
DSPTool Core: Add GBA host interface 2021-07-13 16:42:49 +02:00
PCH msvc: update to vs2022 and windows sdk 10.0.22000 2021-11-11 08:01:26 -08:00
UnitTests Merge pull request #10367 from Pokechu22/fmt-8.1.1 2022-01-20 21:14:41 +01:00
VSProps msbuild: remove workaround for older winsdk 2021-11-15 16:23:33 -08:00
.clang-format
CMakeLists.txt CMakeLists: Replace tab characters with spaces 2022-01-16 15:20:40 -08:00
dolphin-emu.sln DolphinTool: CLI utility interface and disc image tools 2021-12-03 15:40:19 -06:00