emu-mirror/yuzu
1
0
Fork 0
mirror of https://github.com/yuzu-mirror/yuzu.git synced 2024-11-18 18:17:34 +01:00
Code Issues Packages Projects Releases Wiki Activity
20,293 Commits 2 Branches 1 Tag 107 MiB
a2fb5a13b2
Commit Graph

17969 Commits

Author SHA1 Message Date
lat9nq
1c93476a80 video_core,yuzu: Move UpdateRescalingInfo call to video_core 
This only needs to happen once per game boot, so we can just call it
during CreateGPU and be done with it, avoiding the need to call it in
the frontends.
 2021-11-16 22:11:30 +01:00
ameerj
3233fa5dc8 gl_texture_cache: Disable scissor test when scaling textures 
Fixes a bug on BOTW where some objects were no longer being rendered after blitting
 2021-11-16 22:11:30 +01:00
ameerj
89a7e566c7 vk_texture_cache: Fix unsupported blit format error checking 2021-11-16 22:11:30 +01:00
ameerj
f8339cd703 vk_texture_cache: Fix early returns on unsupported scales 2021-11-16 22:11:30 +01:00
ameerj
31478c6c1b video_core: Misc resolution scaling related refactoring 2021-11-16 22:11:30 +01:00
ameerj
88ef04dbaf texture_cache: Refactor scaled image size calculation 2021-11-16 22:11:30 +01:00
Fernando Sahmkow
237a43004f Texture Cache: Fix calculations when scaling. 2021-11-16 22:11:30 +01:00
ameerj
e0a3830855 gl_texture_cache: Fix BGR pbo size for scaled textures 2021-11-16 22:11:30 +01:00
ameerj
581ea90062 rescaling_pass: Fix IR errors when unscalable texture types are encountered 2021-11-16 22:11:30 +01:00
Fernando Sahmkow
ea82bd4b7e Texture Cache: Fix Rescaling on Multisample 2021-11-16 22:11:30 +01:00
Fernando Sahmkow
19ca0c9ab5 TextureCache: Base fixes on rescaling. 2021-11-16 22:11:30 +01:00
ameerj
99eec162da rescaling_pass: Logic simplification and minor style cleanup 2021-11-16 22:11:30 +01:00
ameerj
276565973f rescaling_pass: Scale ImageFetch offset if it exists 
Plus some code deduplication
 2021-11-16 22:11:30 +01:00
ameerj
dd66384451 rescaling_pass: Enable PatchImageQueryDimensions on fragment stages 2021-11-16 22:11:30 +01:00
ameerj
36f261edef vk_texture_cache: Simplify scaled image management 2021-11-16 22:11:30 +01:00
ameerj
8183142cd4 gl_texture_cache: Fix scaling backup logic 2021-11-16 22:11:30 +01:00
ameerj
122ddeb7ff vk_rasterizer: Fix scaling on Y_NEGATE 2021-11-16 22:11:30 +01:00
ameerj
16017ac450 vk_texture_cache: Use nearest neighbor scaling when available 2021-11-16 22:11:30 +01:00
ameerj
27af298e78 gl_texture_cache: Fix depth and integer format scaling blits 2021-11-16 22:11:30 +01:00
ameerj
b027fac794 gl_texture_cache/rescaling_pass: minor cleanup 2021-11-16 22:11:30 +01:00
ameerj
c8a971be91 vk_texture_cache: Minor cleanup 2021-11-16 22:11:30 +01:00
ameerj
edb5844240 rescaling_pass: Fix and simplify shuffle/fragcoord pass 2021-11-16 22:11:30 +01:00
Fernando Sahmkow
b3a9c8f108 Shader: Don't rescale FragCoord if used by Shuffle 2021-11-16 22:11:30 +01:00
ameerj
6000fe69a4 image_info: Mark MSAA textures as non-rescalable 
Blitting or resolving multisampled images requires the dimensions of the src and dst to be equal for valid usage, making them difficult for resolution scaling using the current implementation.
 2021-11-16 22:11:30 +01:00
ameerj
80f8d4989e bootmanager: Fix screenshot resolution factor usage 
Fixes screenshots at non integer scaling
 2021-11-16 22:11:30 +01:00
ameerj
fcf2b2c78a gl_texture_cache: Simplify scaling 
We don't need to reconstruct new textures every time we ScaleUp/ScaleDown. We can scale up once, and revert to the original texture whenever scaling down.
Fixes memory leaks due to glDeleteTextures being deferred for later handling on some drivers
 2021-11-16 22:11:29 +01:00
ameerj
ae8d19d17e Renderers: Unify post processing filter shaders 2021-11-16 22:11:29 +01:00
ameerj
29710f3250 gl_texture_cache: fix scaling on upload 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
a6b88e85bf Renderer: Implement Bicubic and ScaleForce filters. 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
c5bbbf3902 Texture Cache: fix scaling on upload and stop scaling on base resolution. 2021-11-16 22:11:29 +01:00
ameerj
68e038404c shader, video_core: Fix GCC build errors 2021-11-16 22:11:29 +01:00
ameerj
65781f88f8 emit_spirv: Fix RescalingLayout alignment 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
d7c9792169 TextureCache: Fix Buffer Views Scaling. 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
dfa8291526 RescalingPass: Agregate pixels on texelFetch while on Fragment Shader 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
4b1393a691 Texture Cache: Correctly fix Blits Rescaling. 2021-11-16 22:11:29 +01:00
Fernando Sahmkow
8f78444de3 shader: Fix TextureSize check on rescaling. 2021-11-16 22:11:29 +01:00
ameerj
ed675cfd8c texture_cache: Disable dst_image scaling in BlitImage 
Fixes scaling in Super Mario Party
 2021-11-16 22:11:29 +01:00
ameerj
dc28284437 emit_spirv: Fix RescalingLayout alignment 2021-11-16 22:11:29 +01:00
ReinUsesLisp
e66d5b88a6 shader: Properly scale image reads and add GL SPIR-V support 
Thanks for everything!
 2021-11-16 22:11:29 +01:00
ReinUsesLisp
fc9bb3c3fe shader: Properly blacklist and scale image loads 2021-11-16 22:11:29 +01:00
ReinUsesLisp
c7a1cbad44 texture_cache: Add getter to query if image view is rescaled 2021-11-16 22:11:29 +01:00
ReinUsesLisp
526e47f148 vk_rasterizer: Minor style change 2021-11-16 22:11:29 +01:00
ReinUsesLisp
c9238555f7 gl_texture_cache: Fix scaling blits 2021-11-16 22:11:29 +01:00
ReinUsesLisp
cfeb161c7e glsl/glasm: Pass and use scaling parameters in shaders 2021-11-16 22:11:29 +01:00
ReinUsesLisp
4a512d6827 gl_rasterizer: Properly scale viewports and scissors 2021-11-16 22:11:29 +01:00
ameerj
05d98d9bbf gl_texture_cache: Fix multi layered texture Scale 2021-11-16 22:11:29 +01:00
ameerj
b6060873ce gl_compute_pipeline: Add downscale factor to shader uniforms 2021-11-16 22:11:29 +01:00
ameerj
9bc7b04ca5 gl_rasterizer: Fix rescale dirty state checking 2021-11-16 22:11:29 +01:00
ameerj
f086c82e1f gl_graphics_pipeline: Add downscale factor to shader uniforms 2021-11-16 22:11:28 +01:00
ReinUsesLisp
2182d25750 texture_cache: Fix blacklists on compute 2021-11-16 22:11:28 +01:00
ReinUsesLisp
56ccda1d99 texture_cache: Simplify image view queries and blacklisting 2021-11-16 22:11:28 +01:00
Fernando Sahmkow
48d81506a3 Vulkan: Fix downscaling Blit. 2021-11-16 22:11:28 +01:00
Fernando Sahmkow
07c564f38b Texture Cache: Implement Rating System. 2021-11-16 22:11:28 +01:00
Fernando Sahmkow
cee7eba64e OpenGL: set linear mag filter when blitting a downscaled image. 2021-11-16 22:11:28 +01:00
Fernando Sahmkow
117f8ee7a4 Vulkan: Fix AA when rescaling. 2021-11-16 22:11:28 +01:00
Fernando Sahmkow
0e8cf38f39 Texture Cache: Implement Blacklisting. 2021-11-16 22:11:28 +01:00
Morph
138d9d7eff main: Add resolution scale label in the status bar 
Shows the resolution scale as "Scale: {}x" in the status bar, where {} is a floating point value representing the current resolution scaling factor.
 2021-11-16 22:11:28 +01:00
ReinUsesLisp
d2388dd0d0 vulkan: Implement rescaling shader patching 2021-11-16 22:11:28 +01:00
ReinUsesLisp
dc72d4d4f5 vk_texture_cache: Properly scale blit source images 2021-11-16 22:11:28 +01:00
ReinUsesLisp
baf0993d5c vk_graphics_pipeline: Use Shader::NumDescriptors when possible 2021-11-16 22:11:28 +01:00
ReinUsesLisp
6f3a41abe2 opengl: Use Shader::NumDescriptors when possible 2021-11-16 22:11:28 +01:00
ReinUsesLisp
656adee630 spirv: Implement rescaling patching 2021-11-16 22:11:28 +01:00
ReinUsesLisp
01379c5e3c shader/rescaling_pass: Patch more instructions 2021-11-16 22:11:28 +01:00
ReinUsesLisp
c15332c44f shader: Add IsTextureScaled opcode 2021-11-16 22:11:28 +01:00
ReinUsesLisp
74efa57c1b texture_cache: Add image getters 2021-11-16 22:11:28 +01:00
ReinUsesLisp
c892359d1b shader: Add copy constructor to instructions 2021-11-16 22:11:28 +01:00
ReinUsesLisp
95761cc6a7 shader: Add integer division opcodes 2021-11-16 22:11:28 +01:00
ReinUsesLisp
43aa695a04 common/settings: Remove unused scaling options 2021-11-16 22:11:28 +01:00
ReinUsesLisp
e580299467 shader: Fix rescaling pass 2021-11-16 22:11:28 +01:00
ameerj
fad2c92a39 gl_texture_cache: Simplify rescaling 2021-11-16 22:11:28 +01:00
ameerj
d5143c83a9 texture_cache: Fix typo in aliased image rescaling 2021-11-16 22:11:28 +01:00
ReinUsesLisp
0fb4b84383 vk_texture_cache: Simplify and optimize scaling blits 2021-11-16 22:11:28 +01:00
ReinUsesLisp
520c4a44f6 vk_texture_cache: Fix scaling blit validation errors 2021-11-16 22:11:28 +01:00
ReinUsesLisp
1672e9ba09 shader: Fix resolution scaling pass 2021-11-16 22:11:27 +01:00
ReinUsesLisp
fb924ea85c shader: Add resolution down factor opcode 2021-11-16 22:11:27 +01:00
ameerj
fddf372c68 gl_texture_cache: Implement ScaleDown 2021-11-16 22:11:27 +01:00
ameerj
0a6c895af7 gl_texture_cache: Rescale fixes for multi-layered textures 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
dfc65cd0a3 Texture Cache: Implement Rescaling on Aliases and Blits. 2021-11-16 22:11:27 +01:00
ReinUsesLisp
d464b122d5 Fix blits with mips 2021-11-16 22:11:27 +01:00
ReinUsesLisp
973f8f1d08 Fix blits 2021-11-16 22:11:27 +01:00
ameerj
de66a69ed4 renderer_gl: Resolution scaling fixes 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
8704c93913 TextureCache: Fix rescaling of ImageCopies 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
778700ff9d TextureCache: Modify Viewports/Scissors according to Rescale. 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
71ca84d829 Settings: eliminate rescaling_factor. 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
84f2aea896 Texture Cache: More rescaling fixes. 2021-11-16 22:11:27 +01:00
ameerj
10e5065a5c gl_texture_cache: WIP texture rescale 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
ba18047e8d Texture Cache: Implement Vulkan UpScaling & DownScaling 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
360e897ccd ShaderDecompiler: Add initial support for rescaling. 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
37ef9c9130 Settings: Add resolution scaling to settings. 2021-11-16 22:11:27 +01:00
Fernando Sahmkow
22f4b290b6 VideoCore: Initial Setup for the Resolution Scaler. 2021-11-16 22:11:27 +01:00
Matías Locatti
ffb79afd29
Replace keys error pop up 
Fight me.
 2021-11-16 03:53:28 -03:00
Fernando S
720970c4c1
Merge pull request #7326 from ameerj/vp8 
codecs: Implement VP8 video decoding support
 2021-11-14 23:03:56 +01:00
Romain Failliot
2e5866147e Replace "Light" theme by "Default" 
This reflects the current behavior: Light = System default. If your
system is set to dark theme, then Light = Dark, which is a bit confusing
for the end user.

In this PR, I propose to change "Light" with "Default". This way, the
user has "Default" and "Default Colorful", which will apply the system
theme. Now that the Flatpak respects the system theme, I think this
makes much more sense.

I also simplified the theme update. Before the code was branching
between the default theme and the others, but I think we can have
something simpler by forcing the default theme if no theme is defined in
the settings, or if the selected theme doesn't exist. And if there's an
error, tell the theme name in the error message.
 2021-11-14 08:52:55 -05:00
bunnei
30442d8a89
Merge pull request #7260 from vonchenplus/spirv_support_legacy_attribute_v2 
shader: Spirv support legacy attribute v2
 2021-11-14 02:07:45 -08:00
bunnei
0eacc362dd
Merge pull request #7272 from behunin/the-courteous-logger 
Logging: Impl refactor
 2021-11-13 00:03:54 -08:00
ameerj
c50f170597 codes: Rename ComposeFrameHeader to ComposeFrame 
These functions were composing the entire frame, not just the headers. Rename to more accurately describe them.
 2021-11-12 23:52:19 -05:00
ameerj
d35391b9f4 vp8: Implement header composition 
Enables frame decoding with FFmpeg
 2021-11-12 23:52:18 -05:00
ameerj
b39b33b1fe codecs: Add VP8 codec class 2021-11-12 19:49:45 -05:00
OatmealDome
50acc0da20 program_metadata: Add default ThreadInfo kernel capability 2021-11-10 22:01:05 -05:00
Morph
3af2117c88 applets/swkbd: Fix text check message encoding 
The text check message can be encoded in UTF-8.
 2021-11-08 14:57:53 -05:00
Morph
1af499c15b applets/swkbd: Skip text checking if the text has been confirmed 
Confirm means that the text has already been checked by the application to be correct, but is asking the user for confirmation.
The confirmation text itself seems to be corrupted though, this needs to be investigated.

Fixes the software keyboard in Famicom Detective Club: The Missing Heir
 2021-11-08 13:05:50 -05:00
Narr the Reg
ced1302975
service/pctl: Stub EndFreeCommunication 
- Used by Just Dance 2022
 2021-11-05 12:16:19 -04:00
Feng Chen
70d51f72ec
vulkan_device: Add missing vulkan image format R5G6B5 in GetFormatProperties 
- Used by Dragon Quest Builders
 2021-11-05 10:31:40 -04:00
Morph
3a71ff44f8
Merge pull request #7279 from Morph1984/system-get-program-id 
general: Get the current process program id directly from the system
 2021-11-04 20:34:20 -04:00
Morph
2ceb514a39
Merge pull request #7289 from ameerj/perf-stat-shutdown 
core: Reorder perf_stats destruction order on Shutdown
 2021-11-04 20:34:09 -04:00
ameerj
0cf78a34ba core: Reorder perf_stats destruction order on Shutdown 
Avoids the gpu_core using perf_stats after it's been freed.
 2021-11-04 20:19:58 -04:00
Fernando S
3ceefc64f1
Merge pull request #7287 from Morph1984/stub-aoc 
service: aoc: Stub more 13.x functions used by Animal Crossing
 2021-11-05 00:26:10 +01:00
Morph
a6e6a5ac38 general: Get the current process program id directly from the system 
This allows us to avoid including KProcess' header file in files that only need to get the current process' program id.
 2021-11-04 16:59:39 -04:00
Morph
64275dfbf4 general: Rename GetTitleID to GetProgramID 2021-11-04 16:57:16 -04:00
bunnei
f178a8ef0c
Merge pull request #7282 from ameerj/core-includes 
core: Reduce unused header includes
 2021-11-04 13:56:10 -07:00
Morph
21c1316503 service: aoc: Stub NotifyUnmountAddOnContent 
Used by Animal Crossing: New Horizons v2.0.0 DLC
 2021-11-04 16:50:08 -04:00
Morph
ef427e4cb0 service: aoc: Stub NotifyMountAddOnContent and NotifyMountAddOnContent 
Used by Animal Crossing: New Horizons v2.0.0 DLC
 2021-11-04 16:48:47 -04:00
german77
bee6b71553 service/acc: Rename Unknown160 to InitializeApplicationInfoV2 2021-11-04 10:10:58 -06:00
Morph
f2988ecabc service: acc: Stub acc:u0 '160' 
- Used by Animal Crossing: New Horizons v2.0.0

Since the name is currently unknown, '160' is used as a placeholder.
 2021-11-04 02:57:13 -04:00
ameerj
b275f2e475 core: Fix transitive include build errors 2021-11-03 21:42:58 -04:00
ameerj
7c4b6aab2e core: Remove unused includes 2021-11-03 21:42:57 -04:00
Feng Chen
f2a4204245 Simply legacy attribute implement 2021-11-04 09:26:16 +08:00
Morph
b871388a31 svc: Correct WaitSynchronization num_handles param type 
num_handles is a s32
 2021-11-02 22:31:04 -04:00
bunnei
7ce29ea74e
Merge pull request #7262 from FernandoS27/Buffalo-buffalo-Buffalo-buffalo-buffalo 
ShaderCache: Order Phi Arguments from farthest away to nearest.
 2021-11-02 16:34:03 -07:00
Mai M
43ba9db890
Merge pull request #7265 from Morph1984/gl-rasterizer-unused-include 
gl_rasterizer: Remove unused includes
 2021-11-02 18:43:31 -04:00
Morph
cb09ea0f01 general: Remove MakeResult helpers 
This is made obsolete by the presence of implicit constructors.
 2021-11-02 17:23:19 -04:00
Morph
98b351758c hle/result: Amend ResultVal documentation 
This amends the documentation slightly to reflect the updated interface.
 2021-11-02 15:20:36 -04:00
Morph
52e52924bb hle/result: Reimplement ResultVal using Common::Expected 
Common::Expected effectively provides the same functions as ResultVal, so we can implement it with this.
This can be replaced with std::expected with minimal effort should it be standardized in the C++ Standard Template Library.
 2021-11-02 15:20:35 -04:00
Morph
a41e9e93dd common: Implement a subset of P0323 (std::expected) 
This implementation is based on and is a subset of the proposed implementation of std::expected
https://github.com/TartanLlama/expected/blob/master/include/tl/expected.hpp
 2021-11-02 15:20:35 -04:00
bunnei
b118fa8698
Merge pull request #7227 from vonchenplus/fix_memory_leak_v2 
Fix memory leak v2
 2021-11-01 20:11:30 -07:00
Levi Behunin
d6b5f64484 Refactor Logging Impl 
Loop on stop_token and remove final_entry in Entry.
Move Backend thread out of Impl Constructor to its own function.
Add Start function for backend thread.
Use stop token in PopWait and check if entry filename is nullptr before logging.
 2021-11-01 18:36:27 -06:00
Fernando Sahmkow
2d4bbd83e6 Shader Cahe: Fix Phi Nodes on GLASM. 2021-11-02 00:59:25 +01:00
Fernando Sahmkow
194579bc4f ShaderCache: Fix Phi Nodes Type on OGL. 2021-11-01 22:26:17 +01:00
Morph
d607ceacf4 gl_rasterizer: Remove unused includes 
This removes unused includes, especially the core includes which were causing this file to be recompiled every time files included by those headers are modified.
 2021-10-31 23:57:51 -04:00
Fernando Sahmkow
c50ad56bf5 ShaderCache: Order Phi Arguments from farthest away to nearest. 2021-10-31 19:34:15 +01:00
vonchenplus
49f9a44235 Support gl_FogFragCoord attribute 2021-10-31 23:34:17 +08:00
bunnei
99ba26460d
Merge pull request #7246 from german77/userimage 
profile_manager: Resize any image bigger than 256p
 2021-10-31 04:07:34 -07:00
Fernando S
7aa0d97eed
Merge pull request #7201 from ameerj/spirv-depth-sampling 
emit_spirv_image: Fix depth image implicit lod sample in non-fragment stages
 2021-10-30 16:45:58 +02:00
bunnei
a3a353edf2
Merge pull request #6702 from lat9nq/disable-screensaver 
yuzu_cmd, yuzu qt: Use SDL to disable the screen saver
 2021-10-30 00:29:05 -07:00
bunnei
7c2c72a6d6
Merge pull request #7244 from Morph1984/application-lang-pt-br 
file_sys/ns: Add Brazilian Portuguese to the list of ApplicationLanguage
 2021-10-29 22:32:38 -07:00
lat9nq
604b6d1210 yuzu qt: Disable the screensaver with SDL2 
Disables the screen saver when a game boots using SDL2 so that it works
on any supported platform.
 2021-10-30 01:23:52 -04:00
bunnei
92159b210e
Merge pull request #7240 from Morph1984/resultval-remove-cv 
hle/result: Remove cv-qualifiers from Arg in MakeResult
 2021-10-29 21:35:32 -07:00
german77
f503dbf071 profile_manager: Resize any image bigger than 256p 2021-10-29 17:56:51 -05:00
bunnei
c1b199bd21
Merge pull request #7241 from Morph1984/resultval-move-assignment 
hle/result: Add move assignment operator in ResultVal
 2021-10-29 09:14:32 -07:00
bunnei
60e79d50f8
Merge pull request #7243 from lat9nq/nvdrv-warn 
gl_device: Force GLASM on NVIDIA drivers 495-496
 2021-10-28 17:57:53 -07:00
Morph
3f8d74dec1 CMakeLists: Document the /GT compile option 2021-10-28 20:43:46 -04:00
Morph
cd49907248
Merge pull request #7007 from FernandoS27/intel-options 
Build System: Build with JCC Erratum Mitigation
 2021-10-28 20:40:13 -04:00
Morph
baf599c1d3 file_sys: control_metadata: Add BrazilianPortuguese 2021-10-28 20:05:26 -04:00
Morph
e4052a1dab ns: language: Add BrazilianPortuguese to ApplicationLanguage 
It seems that Nintendo finally filled that last empty spot in ApplicationLanguage for a total of 16 supported languages.
 2021-10-28 20:05:05 -04:00
Ameer J
fac2e073a1
Merge pull request #7223 from Moonlacer/geometry_property_removal 
per_game_ui: Geometry Property Removal and Minor Rewording to the Per Game UI
 2021-10-28 19:39:00 -04:00
lat9nq
61121d1b22 gl_device: Force GLASM on NVIDIA drivers 495-496 
GLSL shaders currently do not render correctly on the recent NVIDIA
drivers. This adds a check that forces assembly shaders for these
drivers since they seem unaffected and adds a warning informing of the
decision.

Developers can disable the check by enabling graphics debugging.
 2021-10-28 19:38:49 -04:00
Morph
1b5c37fa29 hle/result: Declare copy/move constructor/assignment as noexcept 
While we're at it, we can also declare these copy/move constructor/assignment as noexcept.
 2021-10-28 04:00:21 -04:00
Morph
189927c237 hle/result: Add move assignment operator in ResultVal 
ResultVal was missing a move assignment operator, add it.
 2021-10-28 03:52:21 -04:00
Morph
1ff9ad4e7c hle/result: Remove cv-qualifiers from Arg in MakeResult 
This removes the const qualification for types when MakeResult(arg) is used in a const member function, allowing for automatic deduction and removing the need to manually specify the non-const type as the template argument.
 2021-10-28 03:07:18 -04:00
Ameer J
40c8a8c627
Merge pull request #7186 from MightyCreak/fix-crash-configure-window 
ui: fix crash when closing configure window
 2021-10-26 22:15:45 -04:00
Feng Chen
dd29285e35 Fix dangling kernel objects when exiting 2021-10-27 09:06:30 +08:00
Feng Chen
052017e189 Revert PR7009 2021-10-27 09:06:30 +08:00
Feng Chen
a8b0104923 Fix memory leak 2021-10-27 09:06:22 +08:00
vonchenplus
36c21ff6cb Support gl_BackSecondaryColor attribute 2021-10-26 23:14:40 +08:00
vonchenplus
92bebecf46 Support gl_FrontSecondaryColor attribute 2021-10-26 23:09:44 +08:00
vonchenplus
b04c7b6343 Support gl_BackColor attribute 2021-10-26 23:01:57 +08:00
Moonlacer
1665e2d2a6 Geometry property removal and rewording 2021-10-25 17:39:36 -05:00
Morph
63ed7d9af7
Merge pull request #7193 from FernandoS27/idle 
SVC: Implement svcInfo:IdleTickCount
 2021-10-25 09:17:49 -04:00
Ameer J
3c8c17be4d
Merge pull request #7218 from bylaws/aswdqdsam 
Fixup channel submit IOCTL syncpoint parameters
 2021-10-24 19:35:00 -04:00
Ameer J
aed5878dd3
Merge pull request #7222 from FernandoS27/fix-indixed-textures-again 
TexturePass: Fix clamping  of images as this allowed negative indices.
 2021-10-24 15:16:31 -04:00
Fernando Sahmkow
e5291e2031 TexturePass: Fix clamping of images as this allowed negative indices. 2021-10-24 20:46:36 +02:00
Andrew Strelsky
31b9797296
Fixed ARM_Dynamic_64 Step 2021-10-24 11:16:32 -04:00
Fernando S
5299554bb0
Merge pull request #7206 from vonchenplus/fix_vulkan_viewport_issue 
Vulkan Rasterizer: Fix viewport issue
 2021-10-24 01:53:04 +02:00
Billy Laws
2dbef58eeb Fixup channel submit IOCTL syncpoint parameters 
The current arguments worked by happenstance as games only ever submit
one syncpoint and request one fence back, if a game were to do something
other than this then the arguments would've been parsed entirely wrong.
 2021-10-24 00:01:35 +01:00
Ameer J
494e34af6a
Merge pull request #7070 from FernandoS27/want-you-bad 
Vulkan Rasterizer: Correct DepthBias/PolygonOffset on Vulkan.
 2021-10-23 18:02:23 -04:00
Fernando Sahmkow
ad8afaf1ef Vulran Rasterizer: address feedback. 2021-10-23 23:46:29 +02:00
Fernando S
33e92c15eb
Revert "input_common: Fix data race on GC implementation" 2021-10-23 23:32:16 +02:00
Fernando S
7461196839
Merge pull request #6515 from german77/gc_thread_safe 
input_common: Fix data race on GC implementation
 2021-10-23 23:28:22 +02:00
Feng Chen
b769bea61b Fix vulkan viewport issue 2021-10-22 22:56:31 +08:00
ameerj
1841f63a40 common/alignment: Fix VS2022 compilation 
VS2022 seems to introduce an optimization when moving vectors to check for equality of the element values. AlignmentAllocator needed to overload the equality operator to fix compilation of its usage in vector moving.
 2021-10-20 01:22:00 -04:00
ameerj
b01aa721ff input_common: Fix VS2022 compilation errors 2021-10-20 01:21:59 -04:00
bunnei
c82318c9cb
Merge pull request #7197 from Moonlacer/tas_help_link 
tas_ui: Add a Help Link to the TAS Page on the yuzu Website, Along with Minor Grammar Changes
 2021-10-19 15:49:30 -07:00
bunnei
c871320760
Merge pull request #7198 from ameerj/settings-chrono 
settings: Remove std::chrono usage
 2021-10-19 09:55:50 -07:00
ameerj
06894b0711 emit_spirv_image: Fix depth image implicit lod sample in compute 
Ensures all drivers behave the same way in this case.
 2021-10-17 17:09:11 -04:00
bunnei
4e81b799f1
Merge pull request #7173 from Morph1984/invalidate-unmap 
KPageTable: Perform ranged invalidation when unmapping code memory
 2021-10-17 03:25:26 -07:00
ameerj
ef811c6425 settings: Remove std::chrono usage 
Alleviates the dependency on chrono for all files that include settings.h
 2021-10-17 00:37:49 -04:00
Moonlacer
abe6d39b1a add_link 
remove_accident

fix_whoopsie
 2021-10-16 21:48:49 -05:00
Ameer J
3791c7ca82
Merge pull request #7077 from FernandoS27/face-down 
A series of fixes to queries and indexed samplers.
 2021-10-16 21:41:54 -04:00
Fernando Sahmkow
3f4444b552 Shader Compiler: avoid overflowed indices on indixed samplers. 2021-10-17 03:38:09 +02:00
Ameer J
5b735a4c9d
Merge pull request #7127 from FernandoS27/i-saw-a-wabbit 
A few fixes on Vulkan and Rasterizer Caching
 2021-10-16 21:37:43 -04:00
Mai M
28d343d288
Merge pull request #7195 from MightyCreak/fix-warning-typo 
main: fix typo in warning message
 2021-10-16 19:50:41 -04:00
Fernando Sahmkow
da6673e79a SVC: Implement svcInfo:IdleTickCount 
Used by the Witcher 3
 2021-10-16 20:33:44 +02:00
Romain Failliot
992f325662 main: fix typo in warning message 2021-10-16 12:53:06 -04:00
Morph
d4c79a0404 main: Add missing make_unique for ui 2021-10-15 19:36:52 -04:00
bunnei
aef3ae1cb9
Merge pull request #7187 from FernandoS27/boy-i-say-boy 
NVHost_Ctrl: Force wait if the gpu falls behind too long.
 2021-10-15 16:14:32 -07:00
Morph
41b4047536
Merge pull request #7188 from Morph1984/web-applet-include 
qt_web_browser: Add missing QApplication include
 2021-10-15 18:52:22 -04:00
Feng Chen
de81571289
service/vi: Stub IHOSBinderDriver::TransactParcel GetBufferHistory (#7184) 2021-10-15 18:50:45 -04:00
Morph
2b622411fd qt_web_browser: Add missing QApplication include 2021-10-15 18:48:50 -04:00
Fernando Sahmkow
53cf91d151 NvHost/Core: Address Feedback. 2021-10-16 00:23:27 +02:00
FernandoS27
198c6ad0d7 Suspend temporally 2021-10-16 00:23:23 +02:00
FernandoS27
7dca0bc11d NVHost_Ctrl: Force wait if the gpu falls behind too long. 2021-10-16 00:22:01 +02:00
Romain Failliot
427ce8dcef ui: fix crash when closing configure window 
This crash happens 100% of the time (on Linux at least), you just need
to open the configure window and click OK.

It seems to happen when the tabs are destroyed and once all the tabs are
destroyed, a final signal is sent with `index == -1`. So `debug_tab_tab`
doesn't exist anymore when this happens, so the crash.
 2021-10-15 17:43:30 -04:00
Morph
5c6ca597c5 bootmanager: Forward declare System and SystemResultStatus 2021-10-15 17:35:34 -04:00
Morph
f0dc07dbac yuzu: Construct system in GMainWindow 2021-10-15 17:35:33 -04:00
Morph
17763a44d5 core: Move ResultStatus outside of System 
Allows it to be a forward declaration in other header files.
 2021-10-15 17:34:49 -04:00
Morph
218ebc1fe8 yuzu_cmd: Remove remaining static system instances 2021-10-15 17:34:48 -04:00
Morph
b6719094e6 core: Remove static system instance 2021-10-15 17:34:48 -04:00
Mai M
764369f4c7
Merge pull request #7172 from Morph1984/out-of-bounds 
string_util: Prevent out of bounds access in u16string_view buffer
 2021-10-15 17:04:44 -04:00
Mai M
d5c4af2d5b
Merge pull request #7174 from MightyCreak/hide-cursor-by-default 
Check "Hide mouse on inactivity" by default
 2021-10-15 17:03:10 -04:00
Mai M
5b7b7276d5
Merge pull request #7185 from Morph1984/make_unique_ui 
yuzu: Use make_unique instead of operator new for constructing ui
 2021-10-15 16:58:45 -04:00
Romain Failliot
ecef109162 Hide mouse cursor by default 2021-10-15 16:01:20 -04:00
Creak
bad122b195
main: Slightly refactor NCA entry installation in InstallNCA (#7181) 
* main: Slightly refactor NCA entry installation in InstallNCA

Co-authored-by: Ameer J <52414509+ameerj@users.noreply.github.com>
 2021-10-15 15:57:25 -04:00
Morph
86908d569e main: Use std::unique_ptr for ui 2021-10-15 15:35:59 -04:00
Morph
ab441fb009 configuration: Use std::make_unique instead of operator new for ui 2021-10-15 15:26:32 -04:00
lat9nq
851fe91b69
config: Read network_interface 
Let's yuzu_cmd use a network interface. Also adds it to the default ini.
 2021-10-15 12:14:09 -04:00
Moonlacer
c68ce25a14
settings_ui: Better NVDEC Description For Each Video Rendering Option (#7165) 
* better_description

* Revert "better_description"

This reverts commit 3a152a6ba6f2d6e02530b69a8194e4db302c8acd.

* better_nvdec_wording

* best_performance

* update_word_stuff

* another_update
 2021-10-14 18:01:12 -07:00
Morph
b02d662980
Merge pull request #6774 from lat9nq/remove-global-yuzu 
yuzu qt: Remove global system instances
 2021-10-14 14:12:22 -04:00
Morph
0d6057b2fa string_util: Make use of std::string_view and add bounds checking 
Makes use of std::string_view in StringFromFixedZeroTerminatedBuffer and add bounds checking
 2021-10-14 14:09:34 -04:00
Morph
3ffff78a27 string_util: Prevent out of bounds access in u16string_view buffer 2021-10-14 14:09:34 -04:00
Morph
894b483a0d
Merge pull request #7157 from ameerj/vic-surface-size 
vic: Use the minimum of surface/frame dimensions when writing the final frame to the GPU
 2021-10-13 20:41:17 -04:00
bunnei
2643752f93
Merge pull request #7142 from german77/sdl_range 
input_common/sdl: Fix joystick range
 2021-10-13 15:15:18 -07:00
bunnei
9f0f827db4
Merge pull request #7158 from ameerj/window-900p 
main: Add option to reset window size to 900p
 2021-10-13 12:29:45 -07:00
Morph
50384e2619 KPageTable: Perform ranged invalidation when unmapping code memory 
Co-Authored-By: Fernando S. <1731197+FernandoS27@users.noreply.github.com>
 2021-10-13 14:27:11 -04:00
Ameer J
a39760b947
Merge pull request #7147 from behunin/patch-1 
Update configure_tas.ui
 2021-10-12 15:52:21 -04:00
Ameer J
018cf3853e
Merge pull request #7109 from vonchenplus/fix_h264_max__reference_num_error 
h264: Use max allowed max_num_ref_frames when using CPU decoding
 2021-10-12 14:08:37 -04:00
Creak
0b8a7ca213
common/fs/path_util: Slightly refactor PathManagerImpl's constructor 
This moves all GenerateYuzuPath calls outside of the platofrm-specific #ifdefs, replacing them with assignments to paths.
 2021-10-11 21:56:25 -04:00
Romain Failliot
39b3c9022d Create local variables for mouse and wheel positions 2021-10-11 19:21:24 -04:00
Romain Failliot
818651909f Fix a few warnings 
- configure_input_player_widget.cpp: always better to use `const auto &`
  whenever possible
- profiler.cpp: `ev->pos()` is deprecated, replace with
  `ev->position()`, which returns floats, thus the addition of
  `.toPoint()` (same as what's happening in `pos()`)
- game_list.cpp: `QString::SplitBehavior` is deprecate, use `Qt::`
  namespace instead
 2021-10-11 19:21:17 -04:00
Morph
97452b9558
Merge pull request #7110 from vonchenplus/fix_extract_offline_romefs_error 
applets/web: Fallback to loader to get the manual romfs if none is found
 2021-10-11 02:09:42 -04:00
german77
8212a864ca input_common/sdl: Fix joystick range 2021-10-11 01:03:01 -05:00
ameerj
5c829c7e4e main: Add option to reset window size to 900p 2021-10-11 01:29:02 -04:00
Feng Chen
0ee2185c59 applets/web: Fallback to loader to get the manual romfs if none is found 2021-10-11 13:12:51 +08:00
ameerj
f346b04d12 vic: Use the minimum of surface/frame dimensions when writing the final frame to the GPU 
Addresses possible buffer overflow behavior.
 2021-10-10 18:44:16 -04:00
Feng Chen
ba8be75037 h264: Use max allowed max_num_ref_frames when using CPU decoding 2021-10-10 20:07:19 +08:00
Valeri
0394e4bb8e
vic: Allow surface to be higher than frame 
Touhou Genso Wanderer Lotus Labyrinth R decodes 1920x1080 videos into 1920x1088 surface.
Only allow mismatch for height, since larger width would result in increasingly offset rows and somewhat defeat entire purpose of this check.
 2021-10-09 20:22:09 +03:00
Mai M
39cd6306e6
Merge pull request #7138 from ameerj/vic-fmt 
vic: Implement RGBX8 video frame format
 2021-10-08 19:19:20 -04:00
Levi Behunin
54ae8d1649
Update configure_tas.ui 
Remove the geometry property again(7045) after 7090 re-added.
 2021-10-08 15:52:17 -06:00
ameerj
403fc86c11 vic: Avoid memory corruption when multiple streams with different dimensions are decoded 
This is a work around to avoid buffer overflow errors until multi channel/multi stream decoding is supported.
 2021-10-08 01:22:38 -04:00
ameerj
5aae61775f vic: Refactor frame writing methods 2021-10-07 14:56:44 -04:00
lat9nq
b6894bfc5b discord_impl: Remove global system instances 2021-10-07 13:50:13 -04:00
lat9nq
4ce53ffe6a game_list: Remove global instances of Core::System 2021-10-07 13:50:13 -04:00
lat9nq
493905665c configuration: Add const qualifier where able 2021-10-07 13:50:13 -04:00
lat9nq
fb66a455c4 yuzu qt: Remove global system instances from config, WaitTree, main 2021-10-07 13:50:13 -04:00
Morph
bea7824bd1 kernel: hle_ipc: Foward declare KAutoObject 2021-10-07 13:32:36 -04:00
Morph
7bb2dd75cd service: Reduce header include overhead 2021-10-07 13:32:21 -04:00
ameerj
899fdb9c44 vic: Implement RGBX frame format 2021-10-07 11:06:57 -04:00
Fernando S
f84328934f
Merge pull request #7118 from ameerj/vc-gpu-impl 
gpu: Migrate implementation to the cpp file
 2021-10-06 20:02:31 +02:00
bunnei
8fad7dc248
Merge pull request #7090 from Moonlacer/tas_spacing_addition 
(Minor Change) Hint (?) Button Removal and Spacing Change to the TAS Window
 2021-10-05 21:18:04 -07:00
bunnei
5b2fa8dd41
Merge pull request #7115 from ameerj/log-compile 
common/logging: Reduce dependent header include overhead
 2021-10-05 10:05:46 -07:00
bunnei
b869439969
Merge pull request #7103 from Morph1984/service-ctx-event 
service: Replace all service event creation with ServiceContext::CreateEvent
 2021-10-04 17:20:46 -07:00
bunnei
158a693111
Merge pull request #7101 from ameerj/vk-tess-topology 
vk_graphics_pipeline: Force patch list topology when tessellation is used
 2021-10-04 15:37:32 -07:00
Fernando Sahmkow
0498669b4b Vulkan: Fix failing barrier on refresh. 2021-10-04 20:56:15 +02:00
FernandoS27
bb8bf740e9 RasterizerInterface: Correct size of CPU addresses to cache. 2021-10-04 20:47:31 +02:00
FernandoS27
7f4de3466a Vulkan: Fix the master Semaphore 2021-10-04 20:46:58 +02:00
bunnei
1d829150ee
Merge pull request #7107 from astrelsky/iob_fix 
prevent access violation from iob in Memory::IsValidVirtualAddress
 2021-10-04 11:08:35 -07:00
Ameer J
01f79d638f
Merge pull request #7091 from vonchenplus/fix_memroy_leak 
core: Fix memory leak
 2021-10-04 00:09:08 -04:00
bunnei
e209fff374
Merge pull request #7111 from lat9nq/no-title-bar-version 
main: Don't add an extra separator when the title version is absent
 2021-10-03 00:27:08 -07:00
bunnei
4a77ceb151
Merge pull request #7113 from Morph1984/no-log-ip-addr 
network: Do not log IP address
 2021-10-02 23:19:34 -07:00
ameerj
71e19153ef nvflinger: Use jthread and stop_token for VSync thread 
Avoids a destruction data race that may occur on the vsync thread
 2021-10-03 00:35:57 -04:00
ameerj
6c0d902373 nvhost_ctrl: Refactor usage of gpu.LockSync() 
This seems to only be used to protect a later gpu function call. So we can move the lock into that call instead.
 2021-10-03 00:35:57 -04:00
ameerj
427bf76e62 gpu: Migrate implementation to the cpp file 2021-10-03 00:35:57 -04:00
bunnei
21ed944ff9
Merge pull request #6979 from german77/joycon_name 
input_common: Add alternative string for joycons
 2021-10-02 02:58:25 -07:00
Morph
2f5808b7ff service: am: Make use of Exit to exit the currently running application 
This also moves the call to the end to ensure services are properly destructed on exit.
 2021-10-01 23:39:55 -04:00
Morph
282bdfd1bf yuzu: main: Register a callback for Exit 2021-10-01 23:39:54 -04:00
Morph
d8467ca6c0 core: Add Exit and ExitCallback 
This allows ISelfController::Exit to stop the currently running application. This is typically used by homebrew to exit back to the homebrew menu after calling consoleExit with libnx.
 2021-10-01 23:39:54 -04:00
Morph
fadcee14f8 service: Replace service event creation with ServiceContext::CreateEvent 
The service context helps to manage all created events and allows us to close them upon destruction.
 2021-10-01 23:38:59 -04:00
Morph
219d0ba978 network: Do not log IP address 
Logging this may be a privacy concern for some users.
 2021-10-01 23:38:44 -04:00
bunnei
3a33519598
Merge pull request #7102 from Morph1984/remove-boxcat 
Remove Boxcat BCAT backend
 2021-10-01 18:41:41 -07:00
ameerj
579f4ea4bd common/logging: Reduce scope of fmt include 2021-10-01 20:48:49 -04:00
ameerj
5daf3abe65 common/logging: Move Log::Entry declaration to a separate header 
This reduces the load of requiring to include std::chrono in all files which include log.h
 2021-10-01 20:48:49 -04:00
bunnei
c3784b2a08
Merge pull request #7075 from v1993/power-of-tea 
applets: Use subdirectory of main data directory for QtWebEngine storage
 2021-09-30 16:29:28 -07:00
lat9nq
596323f89f main: Don't add an extra separator when the title version is absent 
Some titles, such as homebrew, do not have any version string. Because
yuzu hard codes the title bar string assuming a version string is
preset, booting homebrew causes yuzu to add an extra separator with no
content between.

This uses a lambda expression to prevent that from happening.
 2021-09-30 18:57:37 -04:00
bunnei
8bd5742349
Merge pull request #7061 from ameerj/dma-buffer-misc 
buffer_cache, maxwell_dma: Minor refactoring and code fixes
 2021-09-30 12:34:28 -07:00
Mai M
b9251155f8
Merge pull request #7104 from Morph1984/style 
style: Remove extra space preceding the :: operator
 2021-09-29 19:32:39 -04:00
Andrew Strelsky
4ce0a650d1
prevent access violation from iob in Memory::IsValidVirtualAddress 2021-09-29 19:26:44 -04:00
bunnei
91341b421d
Merge pull request #7036 from ameerj/ogl-bgr-v2 
gl_texture_cache: Unify BGR copy passes using PBOs
 2021-09-29 16:10:56 -07:00
Andrew Strelsky
3fc7aceea7
Fixed invalid iterator usage 2021-09-29 06:58:48 -04:00
Morph
e29f3b87f1 style: Remove extra space preceding the :: operator 2021-09-29 01:26:01 -04:00
Morph
839547dc90 CMakeLists: Remove BoxCat build option 2021-09-29 01:24:21 -04:00
Morph
8af9f3216e settings: Remove BCAT settings 2021-09-29 01:24:21 -04:00
Morph
673d37a7c2 configure_network: Remove BCAT 2021-09-29 01:24:21 -04:00
Morph
4acec5283e service: bcat: Remove BoxCat BCAT implementation 
The current implementation of BoxCat as it stands is non-functional due to the reliance on a server providing BCAT files.
This implementation will eventually be replaced with one that allows the use of local BCAT files dumped from a Nintendo Switch.
 2021-09-29 01:21:35 -04:00
Moonlacer
d09e618bd2 configure_tas: Remove help button from dialog window 2021-09-29 00:12:31 -04:00
Moonlacer
e55affe264 configure_tas: Ensure dialog buttons always stay at the bottom 
Previously, the dialog buttons would be floating in-place when the dialog is stretched downwards.
This change ensures that the dialog buttons always stay at the bottom of the window.
 2021-09-29 00:04:19 -04:00
Morph
5f6cd32c9e externals: Remove libzip 2021-09-28 23:18:39 -04:00
Morph
616d0236f5 file_sys: Remove vfs_libzip 2021-09-28 23:18:39 -04:00
Morph
781c1d8df8
Merge pull request #7018 from lat9nq/splat-stubs 
audin_u: stub Start, RegisterBufferEvent, AppendAudioInBufferAuto
 2021-09-28 22:06:11 -04:00
Feng Chen
5fbfc4c19e Fix KShareMemory object leak 2021-09-29 09:51:20 +08:00
Ameer J
fba301155b
Merge pull request #7042 from v1993/patch-7 
Hide XInput bypass on non-Windows OSes
 2021-09-28 17:07:12 -04:00
ameerj
6f35fb8d26 vk_graphics_pipeline: Force patch list topology when tessellation is used 
Fixes a crash on some drivers when tessellation is used but the IA topology is not patch list.
 2021-09-28 16:39:42 -04:00
bunnei
24c0dde958
Merge pull request #7076 from ameerj/amd-botw 
vk_texture_cache: Disable cube compatibility flag on non-mesa AMD GCN4 and earlier
 2021-09-28 10:46:56 -07:00
german77
bc4b4e3f56 service/es: Update to 13.0.0 2021-09-26 20:17:07 -05:00
german77
d780eab357 service/npns: Update to 13.0.0 2021-09-26 20:13:09 -05:00
german77
b0e83f949e service/vi: Update to 13.0.0 2021-09-26 20:12:02 -05:00
german77
321c64a122 service/am: Update to 13.0.0 2021-09-26 20:00:12 -05:00
german77
d103e2daf9 service/audio: Update to 13.0.0 2021-09-26 19:49:09 -05:00
german77
e401c77351 service/hid: Update to 13.0.0 2021-09-26 19:45:47 -05:00
german77
4b5f0af3fd service/btdrv: Update to 13.0.0 2021-09-26 19:32:45 -05:00
german77
f5b41068e6 service/usb: Update to 13.0.0 2021-09-26 19:26:52 -05:00
Morph
5114819b6b
Merge pull request #7078 from ameerj/vc-jthread-fixes 
video_core: Fix jthread related hangs when stopping emulation
 2021-09-26 16:40:13 -04:00
Feng Chen
7cd43b139a Fix KScopedAutoObject object leak when SendSyncRequest 2021-09-25 22:16:21 +08:00
Morph
7dd7c54add service: bsd: Stub Read 
- Used by Diablo II: Resurrected
 2021-09-25 08:04:33 -04:00
Morph
06f22c3d28 service: bsd: Implement Read 
- Used by Diablo II: Resurrected
 2021-09-24 16:46:52 -04:00
ameerj
73666fb262 general: Update style to clang-format-12 2021-09-24 15:52:05 -04:00
Morph
c8512839d7
Merge pull request #7069 from lioncash/uuid 
common/uuid: Add validity checking functions to interface
 2021-09-24 08:02:11 -04:00
ameerj
ab63a193d7 video_core: Fix jthread related hangs when stopping emulation 
jthread on some compilers is more picky when it comes to the order in which objects are destroyed.
 2021-09-23 20:34:02 -04:00
ameerj
1e1ecca691 vk_texture_cache: Disable cube compatibility flag on non-mesa AMD GCN4 and earlier 
Fixes rainbow textures on BOTW.
 2021-09-23 19:40:53 -04:00
Fernando Sahmkow
d702b393a4 Vulkan Query Cache: make sure to wait for the query result. 2021-09-24 01:14:17 +02:00
Fernando Sahmkow
8fdb51ab46 QueryCache: Flush queries in order of running. 2021-09-24 01:13:42 +02:00
bunnei
326a449ef0
Merge pull request #7068 from behunin/patch-3 
Debug Config Ui: Clean-up and nits
 2021-09-23 15:19:22 -07:00