ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-12-26 11:44:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Document undefined sprite template behavior

Browse Source
This commit is contained in:
Sierraffinity 2020-04-25 18:25:55 -07:00
parent b2d8c6793d
commit 072a98ca9a
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gflib/sprite.c
View File

@ -878,12 +878,14 @@ void ResetAllSprites(void)
ResetSprite(&gSprites[i]); ResetSprite(&gSprites[i]);
} }
// UB: template pointer may point to freed temporary storage
void FreeSpriteTiles(struct Sprite *sprite) void FreeSpriteTiles(struct Sprite *sprite)
{ {
if (sprite->template->tileTag != 0xFFFF) if (sprite->template->tileTag != 0xFFFF)
FreeSpriteTilesByTag(sprite->template->tileTag); FreeSpriteTilesByTag(sprite->template->tileTag);
} }
// UB: template pointer may point to freed temporary storage
void FreeSpritePalette(struct Sprite *sprite) void FreeSpritePalette(struct Sprite *sprite)
{ {
FreeSpritePaletteByTag(sprite->template->paletteTag); FreeSpritePaletteByTag(sprite->template->paletteTag);

4
gflib/sprite.h
View File

@ -182,6 +182,10 @@ struct SpriteTemplate
SpriteCallback callback; SpriteCallback callback;
}; };
// UB: template pointer is often used to point to temporary storage,
// then later dereferenced after being freed. Usually this won't
// be visible in-game, but this is (part of) what causes the item
// icon palette to flicker when changing items in the bag.
struct Sprite struct Sprite
{ {
/*0x00*/ struct OamData oam; /*0x00*/ struct OamData oam;

4
src/mevent2.c
View File

@ -484,9 +484,13 @@ static void sub_801B7D8(u32 command)
} }
if (dest == NULL) if (dest == NULL)
{
AGB_ASSERT(0); AGB_ASSERT(0);
}
else if (++(*dest) > 999) else if (++(*dest) > 999)
{
*dest = 999; *dest = 999;
}
} }
} }