ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-11-17 03:57:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1251 from ExpoSeed/patch-1

Browse Source 
Document bugged IV inheritance difference
This commit is contained in:
GriffinR 2020-11-17 14:25:36 -05:00 committed by GitHub
commit 0aa06c307b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/daycare.c
View File

@ -548,7 +548,12 @@ static void InheritIVs(struct Pokemon *egg, struct DayCare *daycare)
{ {
// Randomly pick an IV from the available list and stop from being chosen again. // Randomly pick an IV from the available list and stop from being chosen again.
selectedIvs[i] = availableIVs[Random() % (NUM_STATS - i)]; selectedIvs[i] = availableIVs[Random() % (NUM_STATS - i)];
RemoveIVIndexFromList(availableIVs, i); // BUG: Instead of removing the IV that was just picked (like in RS and FRLG), this
// removes position 0 (HP) then position 1 (DEF), then position 2. This is why HP and DEF
// have a lower chance to be inherited in Emerald and why the IV picked for inheritance can
// be repeated. Uncomment the inline comment and remove the existing expression to get the
// intended behavior and to match the other Gen 3 games.
RemoveIVIndexFromList(availableIVs, i /*selectedIvs[i]*/);
} }
// Determine which parent each of the selected IVs should inherit from. // Determine which parent each of the selected IVs should inherit from.