From 6c1cb7219e91b11fa4a96d33ffd337d676a9db3b Mon Sep 17 00:00:00 2001 From: Diegoisawesome Date: Mon, 21 Jan 2019 14:04:07 -0600 Subject: [PATCH 1/2] Update devkitPro version in Travis --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 302d10a72..52c8e35d5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,7 +14,7 @@ cache: apt: true install: - pushd $HOME - - travis_retry wget https://github.com/devkitPro/buildscripts/releases/download/devkitARM_r49/devkitARM_r49-linux.tar.xz + - travis_retry wget https://github.com/devkitPro/buildscripts/releases/download/devkitARM_r50/devkitARM_r50-linux.tar.xz - tar xJf devkitARM*.tar.xz - travis_retry git clone https://github.com/pret/agbcc.git - cd agbcc && ./build.sh && ./install.sh $TRAVIS_BUILD_DIR From 900f294011ea0eb06c48c28b4b4aea51e5cf32b7 Mon Sep 17 00:00:00 2001 From: Diegoisawesome Date: Mon, 21 Jan 2019 22:34:01 -0600 Subject: [PATCH 2/2] Add var const prefix for some missed var numbers --- asm/macros/event.inc | 10 +++++----- data/maps/PetalburgCity_Gym/scripts.inc | 2 +- include/constants/vars.h | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/asm/macros/event.inc b/asm/macros/event.inc index ba851d70a..091c32a2a 100644 --- a/asm/macros/event.inc +++ b/asm/macros/event.inc @@ -1626,11 +1626,11 @@ .endm .macro switch var:req - copyvar 0x8000, \var + copyvar VAR_0x8000, \var .endm .macro case condition:req, dest:req - compare 0x8000, \condition + compare VAR_0x8000, \condition goto_if_eq \dest .endm @@ -1650,13 +1650,13 @@ .endm .macro giveitem_std item:req, amount=1, function=0 - setorcopyvar 0x8000, \item - setorcopyvar 0x8001, \amount + setorcopyvar VAR_0x8000, \item + setorcopyvar VAR_0x8001, \amount callstd \function .endm .macro givedecoration_std decoration:req - setorcopyvar 0x8000, \decoration + setorcopyvar VAR_0x8000, \decoration callstd STD_OBTAIN_DECORATION .endm diff --git a/data/maps/PetalburgCity_Gym/scripts.inc b/data/maps/PetalburgCity_Gym/scripts.inc index 66dfab92a..915cdc93e 100644 --- a/data/maps/PetalburgCity_Gym/scripts.inc +++ b/data/maps/PetalburgCity_Gym/scripts.inc @@ -60,7 +60,7 @@ PetalburgCity_Gym_EventScript_204955:: @ 8204955 return PetalburgCity_Gym_EventScript_20495D:: @ 820495D - setorcopyvar 0x8015, 269 + setorcopyvar VAR_0x8015, 269 specialvar VAR_RESULT, IsTrainerReadyForRematch compare VAR_RESULT, 1 goto_if_eq PetalburgCity_Gym_EventScript_204985 diff --git a/include/constants/vars.h b/include/constants/vars.h index 30df01f55..c055c5baf 100644 --- a/include/constants/vars.h +++ b/include/constants/vars.h @@ -297,5 +297,6 @@ #define VAR_MON_BOX_ID 0x8012 #define VAR_MON_BOX_POS 0x8013 #define VAR_0x8014 0x8014 +#define VAR_0x8015 0x8015 #endif // GUARD_CONSTANTS_VARS_H