diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0b38a656c..9c61ba2be 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,17 +1,23 @@ -# Pull request into pret/pokeemerald + -## Instructions -Please complete both the questionnaire and the checklist below. This is required for the PR to be merged. Failure to do this may result in a ban from contributions. - -## Questionnaire -1. What is your Discord username? (name#numbers, e.g. PikalaxALT#5823) -2. What is the purpose of this pull request? (decompilation, documentation, bug fixes, typo correction, code style refactor) +## Description + +## Type of changes + +- [ ] Decompilation (matching, fixing nonmatching, fakematching, etc.) +- [ ] Documentation (naming symbols, commenting, etc.) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] Style (code style refactors, typo, etc.) +- [ ] Other: ## Checklist -- [ ] I am a member of the [pret discord server](https://discord.gg/d5dubZ3). -- [ ] I have run `make compare modern` on my local machine to ensure that the project compiles correctly. + +- [ ] I am a member of the [pret Discord server](https://discord.gg/d5dubZ3). +- [ ] `make compare` and `make compare modern` on my local machine outputs ![OK](https://cdn.discordapp.com/emojis/504128071524286475.png?v=1). +- [ ] My code follows the code style of this project. - [ ] If I am fixing a bug or undefined behavior in the modern build, I have documented the bug and tested the fix locally. -- [ ] My changes are not informed by the leaked source code, or I have disclosed my use of the leaks in the discord. -- [ ] I have answered all questions truthfully, including this one. -- [ ] I am not a robot. +- [ ] All my usage, if any, of the leaked source code has been disclosed in pret's server. + +## **Discord contact info** +