ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2025-01-18 09:24:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect bug description

Browse Source
This commit is contained in:
ExpoSeed 2020-12-09 16:45:27 -06:00 committed by GitHub
parent 628ade247b
commit 76e40fe2dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/daycare.c
View File

@ -547,13 +547,17 @@ static void InheritIVs(struct Pokemon *egg, struct DayCare *daycare)
for (i = 0; i < INHERITED_IV_COUNT; i++)
{
// Randomly pick an IV from the available list and stop from being chosen again.
selectedIvs[i] = availableIVs[Random() % (NUM_STATS - i)];
// BUG: Instead of removing the IV that was just picked (like in RS and FRLG), this
// BUG: Instead of removing the IV that was just picked, this
// removes position 0 (HP) then position 1 (DEF), then position 2. This is why HP and DEF
// have a lower chance to be inherited in Emerald and why the IV picked for inheritance can
// be repeated. Uncomment the inline comment and remove the existing expression to get the
// intended behavior and to match the other Gen 3 games.
RemoveIVIndexFromList(availableIVs, i /*selectedIvs[i]*/);
// be repeated. Amusingly, FRLG and RS also got this wrong. They remove selectedIvs[i], which
// is not an index! This means that it can sometimes remove the wrong stat. To fix, delete
// the following two lines and uncomment the rest of the block.
selectedIvs[i] = availableIVs[Random() % (NUM_STATS - i)];
RemoveIVIndexFromList(availableIVs, i);
// u8 index = Random() % (NUM_STATS - i);
// selectedIvs[i] = availableIVs[index];
// RemoveIVIndexFromList(availableIVs, index);
}
// Determine which parent each of the selected IVs should inherit from.