ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2025-03-19 03:58:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix UB: Destoyed task is modified.

Browse Source 
After destruction, task is no longer used, so updating its values is worthless.
This commit is contained in:
gAlfonso-bit 2021-05-14 13:41:22 -04:00 committed by huderlem
parent f62b42eb59
commit ab8318cc79
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/battle_transition.c
View File

@ -4328,7 +4328,10 @@ static bool8 Phase2_FrontierSquaresScroll_Func5(struct Task *task)
BlendPalettes(PALETTES_ALL, 0x10, 0); BlendPalettes(PALETTES_ALL, 0x10, 0);
DestroyTask(FindTaskIdByFunc(task->func)); DestroyTask(FindTaskIdByFunc(task->func));
#ifndef UBFIX
task->tState++; // UB: changing value of a destroyed task task->tState++; // UB: changing value of a destroyed task
#endif
return FALSE; return FALSE;
} }