ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-11-16 19:47:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #553 from Phlosioneer/main-menu-state-machine

Browse Source 
Document main_menu state machine, name window constants
This commit is contained in:
huderlem 2019-03-03 09:28:35 -06:00 committed by GitHub
commit c9d2fcabef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
85 changed files with 831 additions and 687 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
asm/rom_8011DC0.s
View File

@ -472,7 +472,7 @@ sub_8017020: @ 8017020
bl sub_81973A4 bl sub_81973A4
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldr r0, =gStringVar4 ldr r0, =gStringVar4
adds r1, r4, 0 adds r1, r4, 0
bl StringExpandPlaceholders bl StringExpandPlaceholders
@ -517,7 +517,7 @@ _08017076:
bl sub_81973A4 bl sub_81973A4
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldr r0, =gStringVar4 ldr r0, =gStringVar4
adds r1, r5, 0 adds r1, r5, 0
bl StringExpandPlaceholders bl StringExpandPlaceholders
@ -563,7 +563,7 @@ _080170CA:
negs r0, r0 negs r0, r0
b _08017110 b _08017110
_080170D4: _080170D4:
bl DisplayYesNoMenu bl DisplayYesNoMenuDefaultYes
ldrb r0, [r4] ldrb r0, [r4]
adds r0, 0x1 adds r0, 0x1
strb r0, [r4] strb r0, [r4]
@ -609,7 +609,7 @@ sub_8017118: @ 8017118
lsrs r4, 24 lsrs r4, 24
adds r0, r4, 0 adds r0, r4, 0
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawStdWindowFrame bl DrawStdWindowFrame
adds r0, r4, 0 adds r0, r4, 0
movs r1, 0xFF movs r1, 0xFF
bl FillWindowPixelBuffer bl FillWindowPixelBuffer
@ -705,7 +705,7 @@ _080171DC:
strb r0, [r5] strb r0, [r5]
ldrb r0, [r5] ldrb r0, [r5]
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawStdWindowFrame bl DrawStdWindowFrame
ldr r0, =gMultiuseListMenuTemplate ldr r0, =gMultiuseListMenuTemplate
adds r2, r0, 0 adds r2, r0, 0
ldr r1, [sp, 0x24] ldr r1, [sp, 0x24]
@ -745,7 +745,7 @@ _08017228:
bl DestroyListMenuTask bl DestroyListMenuTask
ldrb r0, [r5] ldrb r0, [r5]
movs r1, 0x1 movs r1, 0x1
bl sub_819746C bl ClearStdWindowAndFrame
ldrb r0, [r5] ldrb r0, [r5]
bl RemoveWindow bl RemoveWindow
movs r0, 0 movs r0, 0
@ -765,7 +765,7 @@ _08017264:
bl DestroyListMenuTask bl DestroyListMenuTask
ldrb r0, [r5] ldrb r0, [r5]
movs r1, 0x1 movs r1, 0x1
bl sub_819746C bl ClearStdWindowAndFrame
ldrb r0, [r5] ldrb r0, [r5]
bl RemoveWindow bl RemoveWindow
strb r4, [r7] strb r4, [r7]
@ -818,7 +818,7 @@ _080172C8:
strb r0, [r6] strb r0, [r6]
ldrb r0, [r6] ldrb r0, [r6]
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawStdWindowFrame bl DrawStdWindowFrame
ldr r0, =gMultiuseListMenuTemplate ldr r0, =gMultiuseListMenuTemplate
adds r2, r0, 0 adds r2, r0, 0
ldr r1, [sp, 0x24] ldr r1, [sp, 0x24]
@ -18242,7 +18242,7 @@ sub_801FEBC: @ 801FEBC
lsls r0, 24 lsls r0, 24
lsrs r0, 24 lsrs r0, 24
movs r1, 0 movs r1, 0
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldr r0, [r4] ldr r0, [r4]
ldrb r0, [r0, 0x18] ldrb r0, [r0, 0x18]
bl ClearWindowTilemap bl ClearWindowTilemap
@ -18470,7 +18470,7 @@ sub_8020094: @ 8020094
lsls r0, 24 lsls r0, 24
lsrs r0, 24 lsrs r0, 24
movs r1, 0 movs r1, 0
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldr r0, [r4] ldr r0, [r4]
ldrb r0, [r0, 0x1E] ldrb r0, [r0, 0x1E]
bl ClearWindowTilemap bl ClearWindowTilemap
@ -18913,7 +18913,7 @@ sub_802040C: @ 802040C
push {lr} push {lr}
movs r0, 0x3 movs r0, 0x3
movs r1, 0 movs r1, 0
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
movs r0, 0x3 movs r0, 0x3
bl ClearWindowTilemap bl ClearWindowTilemap
pop {r0} pop {r0}
@ -22378,7 +22378,7 @@ _0802210C:
movs r1, 0 movs r1, 0
adds r2, r4, 0 adds r2, r4, 0
movs r3, 0xD movs r3, 0xD
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
b _08022218 b _08022218
.pool .pool
_08022130: _08022130:
@ -22509,7 +22509,7 @@ sub_802222C: @ 802222C
adds r5, r4, r0 adds r5, r4, r0
ldrb r0, [r5] ldrb r0, [r5]
movs r1, 0x1 movs r1, 0x1
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldrb r0, [r5] ldrb r0, [r5]
bl RemoveWindow bl RemoveWindow
adds r0, r4, 0 adds r0, r4, 0
@ -22577,7 +22577,7 @@ _08022296:
movs r1, 0 movs r1, 0
adds r2, r4, 0 adds r2, r4, 0
movs r3, 0xD movs r3, 0xD
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
b _080224BA b _080224BA
.pool .pool
_080222D0: _080222D0:
@ -22773,7 +22773,7 @@ _08022480:
_08022494: _08022494:
ldrb r0, [r6, 0x2] ldrb r0, [r6, 0x2]
movs r1, 0x1 movs r1, 0x1
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldrb r0, [r6, 0x2] ldrb r0, [r6, 0x2]
bl ClearWindowTilemap bl ClearWindowTilemap
ldrb r0, [r6, 0x2] ldrb r0, [r6, 0x2]
@ -23864,7 +23864,7 @@ _08022D38:
_08022D42: _08022D42:
movs r0, 0 movs r0, 0
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldrb r1, [r5, 0x1] ldrb r1, [r5, 0x1]
movs r0, 0x2 movs r0, 0x2
mov r8, r0 mov r8, r0
@ -23946,7 +23946,7 @@ _08022DE8:
beq _08022DFA beq _08022DFA
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl sub_8197434 bl ClearDialogWindowAndFrame
_08022DFA: _08022DFA:
ldrb r0, [r7, 0xE] ldrb r0, [r7, 0xE]
movs r1, 0x1 movs r1, 0x1
@ -24250,7 +24250,7 @@ _0802301E:
_08023044: _08023044:
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl sub_8197434 bl ClearDialogWindowAndFrame
movs r0, 0xA movs r0, 0xA
movs r1, 0x1 movs r1, 0x1
movs r2, 0 movs r2, 0
@ -26462,7 +26462,7 @@ _080241A6:
beq _0802421E beq _0802421E
movs r0, 0 movs r0, 0
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldr r2, =gText_SavingDontTurnOffPower ldr r2, =gText_SavingDontTurnOffPower
movs r0, 0 movs r0, 0
str r0, [sp] str r0, [sp]
@ -26550,7 +26550,7 @@ _08024246:
strb r0, [r5, 0xC] strb r0, [r5, 0xC]
b _080242D8 b _080242D8
_0802426A: _0802426A:
bl DisplayYesNoMenu bl DisplayYesNoMenuDefaultYes
b _080242D0 b _080242D0
_08024270: _08024270:
bl Menu_ProcessInputNoWrapClearOnChoose bl Menu_ProcessInputNoWrapClearOnChoose
@ -26583,7 +26583,7 @@ _080242A4:
_080242A6: _080242A6:
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl sub_8197434 bl ClearDialogWindowAndFrame
movs r4, 0 movs r4, 0
str r4, [sp] str r4, [sp]
adds r0, r6, 0 adds r0, r6, 0
@ -26761,7 +26761,7 @@ _080243EA:
_080243F6: _080243F6:
movs r0, 0 movs r0, 0
movs r1, 0x1 movs r1, 0x1
bl sub_8197434 bl ClearDialogWindowAndFrame
adds r0, r5, 0 adds r0, r5, 0
bl sub_8021488 bl sub_8021488
movs r0, 0x1 movs r0, 0x1
@ -26819,7 +26819,7 @@ _0802445A:
_08024460: _08024460:
movs r0, 0 movs r0, 0
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldrh r1, [r5, 0x14] ldrh r1, [r5, 0x14]
cmp r1, 0x3 cmp r1, 0x3
bne _08024490 bne _08024490
@ -27347,7 +27347,7 @@ sub_802482C: @ 802482C
movs r1, 0 movs r1, 0
adds r2, r4, 0 adds r2, r4, 0
adds r3, r5, 0 adds r3, r5, 0
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
ldr r2, =gText_Powder ldr r2, =gText_Powder
movs r0, 0x1 movs r0, 0x1
str r0, [sp] str r0, [sp]
@ -27446,7 +27446,7 @@ sub_8024918: @ 8024918
bl ClearWindowTilemap bl ClearWindowTilemap
ldrb r0, [r4] ldrb r0, [r4]
movs r1, 0x1 movs r1, 0x1
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldrb r0, [r4] ldrb r0, [r4]
bl RemoveWindow bl RemoveWindow
pop {r4} pop {r4}
@ -38552,7 +38552,7 @@ _0802A3A4:
_0802A3AE: _0802A3AE:
movs r0, 0 movs r0, 0
movs r1, 0 movs r1, 0
bl NewMenuHelpers_DrawDialogueFrame bl DrawDialogueFrame
ldr r2, =gText_SavingDontTurnOffPower ldr r2, =gText_SavingDontTurnOffPower
str r4, [sp] str r4, [sp]
movs r0, 0x2 movs r0, 0x2

10
asm/rom_81D1C44.s
View File

@ -108,7 +108,7 @@ sub_81D1D04: @ 81D1D04
adds r4, r0 adds r4, r0
ldrb r0, [r4] ldrb r0, [r4]
movs r1, 0 movs r1, 0
bl sub_8198070 bl ClearStdWindowAndFrameToTransparent
ldrb r0, [r4] ldrb r0, [r4]
bl ClearWindowTilemap bl ClearWindowTilemap
ldrb r0, [r4] ldrb r0, [r4]
@ -1613,7 +1613,7 @@ _081D284A:
movs r1, 0 movs r1, 0
movs r2, 0x1 movs r2, 0x1
movs r3, 0xE movs r3, 0xE
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
b _081D288E b _081D288E
.pool .pool
_081D287C: _081D287C:
@ -1623,7 +1623,7 @@ _081D287C:
movs r1, 0 movs r1, 0
movs r2, 0x1 movs r2, 0x1
movs r3, 0xE movs r3, 0xE
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
_081D288E: _081D288E:
movs r0, 0x2 movs r0, 0x2
bl PutWindowTilemap bl PutWindowTilemap
@ -1633,12 +1633,12 @@ _081D288E:
movs r1, 0 movs r1, 0
movs r2, 0x1 movs r2, 0x1
movs r3, 0xE movs r3, 0xE
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
movs r0, 0x3 movs r0, 0x3
movs r1, 0 movs r1, 0
movs r2, 0x1 movs r2, 0x1
movs r3, 0xE movs r3, 0xE
bl SetWindowBorderStyle bl DrawStdFrameWithCustomTileAndPalette
bl nullsub_79 bl nullsub_79
movs r0, 0x1 movs r0, 0x1
bl schedule_bg_copy_tilemap_to_vram bl schedule_bg_copy_tilemap_to_vram

2
common_syms/window.txt
View File

@ -1,5 +1,5 @@
filler_03002F58 filler_03002F58
filler_03002F5C filler_03002F5C
gUnknown_03002F60 gTransparentTileNumber
filler_03002F64 filler_03002F64
gUnknown_03002F70 gUnknown_03002F70

20
include/menu.h
View File

@ -25,23 +25,23 @@ void InitStandardTextBoxWindows(void);
void sub_8197200(void); void sub_8197200(void);
u16 RunTextPrintersAndIsPrinter0Active(void); u16 RunTextPrintersAndIsPrinter0Active(void);
void sub_81973A4(void); void sub_81973A4(void);
void NewMenuHelpers_DrawDialogueFrame(u8, u8); void DrawDialogueFrame(u8, u8);
void sub_819746C(u8 windowId, bool8 copyToVram); void ClearStdWindowAndFrame(u8 windowId, bool8 copyToVram);
u16 AddTextPrinterParameterized2(u8 windowId, u8 fontId, const u8 *str, u8 speed, void (*callback)(struct TextPrinterTemplate *, u16), u8 fgColor, u8 bgColor, u8 shadowColor); u16 AddTextPrinterParameterized2(u8 windowId, u8 fontId, const u8 *str, u8 speed, void (*callback)(struct TextPrinterTemplate *, u16), u8 fgColor, u8 bgColor, u8 shadowColor);
void PrintPlayerNameOnWindow(u8, const u8*, u16, u16); void PrintPlayerNameOnWindow(u8, const u8*, u16, u16);
void DisplayItemMessageOnField(u8 taskId, const u8 *src, TaskFunc callback); void DisplayItemMessageOnField(u8 taskId, const u8 *src, TaskFunc callback);
void sub_8197434(u8 windowId, bool8 copyToVram); void ClearDialogWindowAndFrame(u8 windowId, bool8 copyToVram);
void SetStandardWindowBorderStyle(u8 a0, u8 a1); void SetStandardWindowBorderStyle(u8 a0, u8 a1);
void DisplayYesNoMenu(void); void DisplayYesNoMenuDefaultYes(void);
u32 GetPlayerTextSpeed(void); u32 GetPlayerTextSpeed(void);
u8 GetPlayerTextSpeedDelay(void); u8 GetPlayerTextSpeedDelay(void);
void sub_81978B0(u16 arg0); void sub_81978B0(u16 arg0);
void AddTextPrinterWithCallbackForMessage(bool8 a1, void (*callback)(struct TextPrinterTemplate *, u16)); void AddTextPrinterWithCallbackForMessage(bool8 a1, void (*callback)(struct TextPrinterTemplate *, u16));
void sub_8199DF0(u32 bg, u8 a1, int a2, int a3); void sub_8199DF0(u32 bg, u8 a1, int a2, int a3);
void AddTextPrinterParameterized3(u8 windowId, u8 fontId, u8 left, u8 top, const u8 *color, s8 speed, const u8 *str); void AddTextPrinterParameterized3(u8 windowId, u8 fontId, u8 left, u8 top, const u8 *color, s8 speed, const u8 *str);
void sub_8198070(u8 windowId, bool8 copyToVram); void ClearStdWindowAndFrameToTransparent(u8 windowId, bool8 copyToVram);
void SetWindowTemplateFields(struct WindowTemplate* template, u8 priority, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 palNum, u16 baseBlock); void SetWindowTemplateFields(struct WindowTemplate* template, u8 priority, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 palNum, u16 baseBlock);
void SetWindowBorderStyle(u8 windowId, bool8 copyToVram, u16 tileStart, u8 palette); void DrawStdFrameWithCustomTileAndPalette(u8 windowId, bool8 copyToVram, u16 tileStart, u8 palette);
void schedule_bg_copy_tilemap_to_vram(u8 bgNum); void schedule_bg_copy_tilemap_to_vram(u8 bgNum);
void PrintMenuTable(u8 windowId, u8 itemCount, const struct MenuAction *strs); void PrintMenuTable(u8 windowId, u8 itemCount, const struct MenuAction *strs);
u8 InitMenuInUpperLeftCornerPlaySoundWhenAPressed(u8 windowId, u8 numItems, u8 initialCursorPos); u8 InitMenuInUpperLeftCornerPlaySoundWhenAPressed(u8 windowId, u8 numItems, u8 initialCursorPos);
@ -60,9 +60,9 @@ s8 ProcessMenuInput_other(void);
void do_scheduled_bg_tilemap_copies_to_vram(void); void do_scheduled_bg_tilemap_copies_to_vram(void);
void clear_scheduled_bg_copies_to_vram(void); void clear_scheduled_bg_copies_to_vram(void);
void AddTextPrinterParameterized4(u8 windowId, u8 fontId, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, const u8 *color, s8 speed, const u8 *str); void AddTextPrinterParameterized4(u8 windowId, u8 fontId, u8 x, u8 y, u8 letterSpacing, u8 lineSpacing, const u8 *color, s8 speed, const u8 *str);
void sub_8197B1C(u8 windowId, bool8 copyToVram, u16 a2, u8 a3); void DrawDialogFrameWithCustomTileAndPalette(u8 windowId, bool8 copyToVram, u16 a2, u8 a3);
void sub_81995E4(u8 windowId, u8 optionsNo, const struct MenuAction *actions, const u8 *actionIds); void sub_81995E4(u8 windowId, u8 optionsNo, const struct MenuAction *actions, const u8 *actionIds);
void sub_8197DF8(u8 windowId, bool8 copyToVram); void ClearDialogWindowAndFrameToTransparent(u8 windowId, bool8 copyToVram);
u16 sub_8198AA4(u8, u8, u8, u8, u8, u8, u16); u16 sub_8198AA4(u8, u8, u8, u8, u8, u8, u16);
void *malloc_and_decompress(const void *src, u32 *sizeOut); void *malloc_and_decompress(const void *src, u32 *sizeOut);
u16 copy_decompressed_tile_data_to_vram(u8 bgId, const void *src, u16 size, u16 offset, u8 mode); u16 copy_decompressed_tile_data_to_vram(u8 bgId, const void *src, u16 size, u16 offset, u8 mode);
@ -75,13 +75,13 @@ u8 GetStartMenuWindowId(void);
void sub_819A2BC(u8, u8); void sub_819A2BC(u8, u8);
u8 Menu_MoveCursor(s8 cursorDelta); u8 Menu_MoveCursor(s8 cursorDelta);
u8 Menu_MoveCursorNoWrapAround(s8 cursorDelta); u8 Menu_MoveCursorNoWrapAround(s8 cursorDelta);
void NewMenuHelpers_DrawStdWindowFrame(u8 windowId, bool8 CopyToVram); void DrawStdWindowFrame(u8 windowId, bool8 CopyToVram);
u8 sub_81979C4(u8 a1); u8 sub_81979C4(u8 a1);
u8 sub_81983AC(u8 windowId, u8 fontId, u8 left, u8 top, u8 cursorHeight, u8 numChoices, u8 initialCursorPos); u8 sub_81983AC(u8 windowId, u8 fontId, u8 left, u8 top, u8 cursorHeight, u8 numChoices, u8 initialCursorPos);
void sub_819786C(u8 windowId, bool8 copyToVram); void sub_819786C(u8 windowId, bool8 copyToVram);
void AddTextPrinterForMessage_2(bool8 allowSkippingDelayWithButtonPress); void AddTextPrinterForMessage_2(bool8 allowSkippingDelayWithButtonPress);
void RemoveStartMenuWindow(void); void RemoveStartMenuWindow(void);
void sub_8197948(u8 initialCursorPos); void DisplayYesNoMenuWithDefault(u8 initialCursorPos);
void sub_819A344(u8 a0, u8 *dest, u8 color); void sub_819A344(u8 a0, u8 *dest, u8 color);
void RemoveMapNamePopUpWindow(void); void RemoveMapNamePopUpWindow(void);
u8 GetMapNamePopUpWindowId(void); u8 GetMapNamePopUpWindowId(void);

4
include/window.h
View File

@ -1,6 +1,8 @@
#ifndef GUARD_WINDOW_H #ifndef GUARD_WINDOW_H
#define GUARD_WINDOW_H #define GUARD_WINDOW_H
#define PIXEL_FILL(num) ((num) | ((num) << 4))
enum enum
{ {
WINDOW_BG, WINDOW_BG,
@ -73,6 +75,4 @@ extern u32 filler_03002F58;
extern u32 filler_03002F5C; extern u32 filler_03002F5C;
extern u32 filler_03002F64; extern u32 filler_03002F64;
extern u8 gUnknown_03002F60;
#endif // GUARD_WINDOW_H #endif // GUARD_WINDOW_H

4
src/apprentice.c
View File

@ -1619,7 +1619,7 @@ static u8 CreateAndShowWindow(u8 left, u8 top, u8 width, u8 height)
static void RemoveAndHideWindow(u8 windowId) static void RemoveAndHideWindow(u8 windowId)
{ {
sub_8198070(windowId, TRUE); ClearStdWindowAndFrameToTransparent(windowId, TRUE);
RemoveWindow(windowId); RemoveWindow(windowId);
} }
@ -1826,7 +1826,7 @@ static void Script_PrintMessage(void)
FreezeEventObjects(); FreezeEventObjects();
sub_808B864(); sub_808B864();
sub_808BCF4(); sub_808BCF4();
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
PrintMessage(); PrintMessage();
} }

10
src/battle_controller_link_partner.c
View File

@ -90,7 +90,7 @@ static void LinkPartnerHandleBattleAnimation(void);
static void LinkPartnerHandleLinkStandbyMsg(void); static void LinkPartnerHandleLinkStandbyMsg(void);
static void LinkPartnerHandleResetActionMoveSelection(void); static void LinkPartnerHandleResetActionMoveSelection(void);
static void LinkPartnerHandleCmd55(void); static void LinkPartnerHandleCmd55(void);
static void nullsub_113(void); static void SpriteCB_Null3(void);
static void LinkPartnerBufferRunCommand(void); static void LinkPartnerBufferRunCommand(void);
static void LinkPartnerBufferExecCompleted(void); static void LinkPartnerBufferExecCompleted(void);
@ -161,10 +161,10 @@ static void (*const sLinkPartnerBufferCommands[CONTROLLER_CMDS_COUNT])(void) =
LinkPartnerHandleLinkStandbyMsg, LinkPartnerHandleLinkStandbyMsg,
LinkPartnerHandleResetActionMoveSelection, LinkPartnerHandleResetActionMoveSelection,
LinkPartnerHandleCmd55, LinkPartnerHandleCmd55,
nullsub_113 SpriteCB_Null3
}; };
static void nullsub_112(void) static void SpriteCB_Null2(void)
{ {
} }
@ -1564,7 +1564,7 @@ static void LinkPartnerHandleIntroTrainerBallThrow(void)
gTasks[gBattlerStatusSummaryTaskId[gActiveBattler]].func = Task_HidePartyStatusSummary; gTasks[gBattlerStatusSummaryTaskId[gActiveBattler]].func = Task_HidePartyStatusSummary;
gBattleSpritesDataPtr->animationData->field_9_x1 = 1; gBattleSpritesDataPtr->animationData->field_9_x1 = 1;
gBattlerControllerFuncs[gActiveBattler] = nullsub_112; gBattlerControllerFuncs[gActiveBattler] = SpriteCB_Null2;
} }
static void sub_814DCCC(u8 taskId) static void sub_814DCCC(u8 taskId)
@ -1687,6 +1687,6 @@ static void LinkPartnerHandleCmd55(void)
gBattlerControllerFuncs[gActiveBattler] = sub_80587B0; gBattlerControllerFuncs[gActiveBattler] = sub_80587B0;
} }
static void nullsub_113(void) static void SpriteCB_Null3(void)
{ {
} }

6
src/battle_controller_recorded_opponent.c
View File

@ -93,7 +93,7 @@ static void RecordedOpponentHandleBattleAnimation(void);
static void RecordedOpponentHandleLinkStandbyMsg(void); static void RecordedOpponentHandleLinkStandbyMsg(void);
static void RecordedOpponentHandleResetActionMoveSelection(void); static void RecordedOpponentHandleResetActionMoveSelection(void);
static void RecordedOpponentHandleCmd55(void); static void RecordedOpponentHandleCmd55(void);
static void nullsub_119(void); static void SpriteCB_Null9(void);
static void RecordedOpponentBufferRunCommand(void); static void RecordedOpponentBufferRunCommand(void);
static void RecordedOpponentBufferExecCompleted(void); static void RecordedOpponentBufferExecCompleted(void);
@ -165,7 +165,7 @@ static void (*const sRecordedOpponentBufferCommands[CONTROLLER_CMDS_COUNT])(void
RecordedOpponentHandleLinkStandbyMsg, RecordedOpponentHandleLinkStandbyMsg,
RecordedOpponentHandleResetActionMoveSelection, RecordedOpponentHandleResetActionMoveSelection,
RecordedOpponentHandleCmd55, RecordedOpponentHandleCmd55,
nullsub_119 SpriteCB_Null9
}; };
static void nullsub_70(void) static void nullsub_70(void)
@ -1791,6 +1791,6 @@ static void RecordedOpponentHandleCmd55(void)
gBattlerControllerFuncs[gActiveBattler] = sub_80587B0; gBattlerControllerFuncs[gActiveBattler] = sub_80587B0;
} }
static void nullsub_119(void) static void SpriteCB_Null9(void)
{ {
} }

8
src/battle_controller_safari.c
View File

@ -84,7 +84,7 @@ static void SafariHandleBattleAnimation(void);
static void SafariHandleLinkStandbyMsg(void); static void SafariHandleLinkStandbyMsg(void);
static void SafariHandleResetActionMoveSelection(void); static void SafariHandleResetActionMoveSelection(void);
static void SafariHandleCmd55(void); static void SafariHandleCmd55(void);
static void nullsub_115(void); static void SpriteCB_Null5(void);
static void SafariBufferRunCommand(void); static void SafariBufferRunCommand(void);
static void SafariBufferExecCompleted(void); static void SafariBufferExecCompleted(void);
@ -148,10 +148,10 @@ static void (*const sSafariBufferCommands[CONTROLLER_CMDS_COUNT])(void) =
SafariHandleLinkStandbyMsg, SafariHandleLinkStandbyMsg,
SafariHandleResetActionMoveSelection, SafariHandleResetActionMoveSelection,
SafariHandleCmd55, SafariHandleCmd55,
nullsub_115 SpriteCB_Null5
}; };
static void nullsub_114(void) static void SpriteCB_Null4(void)
{ {
} }
@ -688,6 +688,6 @@ static void SafariHandleCmd55(void)
gBattlerControllerFuncs[gActiveBattler] = sub_81595E4; gBattlerControllerFuncs[gActiveBattler] = sub_81595E4;
} }
static void nullsub_115(void) static void SpriteCB_Null5(void)
{ {
} }

8
src/battle_controller_wally.c
View File

@ -92,7 +92,7 @@ static void WallyHandleBattleAnimation(void);
static void WallyHandleLinkStandbyMsg(void); static void WallyHandleLinkStandbyMsg(void);
static void WallyHandleResetActionMoveSelection(void); static void WallyHandleResetActionMoveSelection(void);
static void WallyHandleCmd55(void); static void WallyHandleCmd55(void);
static void nullsub_118(void); static void SpriteCB_Null8(void);
static void WallyBufferRunCommand(void); static void WallyBufferRunCommand(void);
static void WallyBufferExecCompleted(void); static void WallyBufferExecCompleted(void);
@ -161,10 +161,10 @@ static void (*const sWallyBufferCommands[CONTROLLER_CMDS_COUNT])(void) =
WallyHandleLinkStandbyMsg, WallyHandleLinkStandbyMsg,
WallyHandleResetActionMoveSelection, WallyHandleResetActionMoveSelection,
WallyHandleCmd55, WallyHandleCmd55,
nullsub_118 SpriteCB_Null8
}; };
static void nullsub_117(void) static void SpriteCB_Null7(void)
{ {
} }
@ -1559,6 +1559,6 @@ static void WallyHandleCmd55(void)
gBattlerControllerFuncs[gActiveBattler] = sub_80587B0; gBattlerControllerFuncs[gActiveBattler] = sub_80587B0;
} }
static void nullsub_118(void) static void SpriteCB_Null8(void)
{ {
} }

2
src/battle_dome.c
View File

@ -3794,7 +3794,7 @@ static void sub_8190CD4(u8 taskId)
for (i = windowId; i < windowId + 9; i++) for (i = windowId; i < windowId + 9; i++)
{ {
CopyWindowToVram(i, 2); CopyWindowToVram(i, 2);
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
gTasks[taskId].data[0] = 3; gTasks[taskId].data[0] = 3;
break; break;

48
src/battle_factory_screen.c
View File

@ -1786,14 +1786,14 @@ static void sub_819B958(u8 windowId)
{ {
gSprites[sFactorySelectScreen->menuCursor1SpriteId].invisible = TRUE; gSprites[sFactorySelectScreen->menuCursor1SpriteId].invisible = TRUE;
gSprites[sFactorySelectScreen->menuCursor2SpriteId].invisible = TRUE; gSprites[sFactorySelectScreen->menuCursor2SpriteId].invisible = TRUE;
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
CopyWindowToVram(windowId, 2); CopyWindowToVram(windowId, 2);
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
} }
static void Select_PrintRentalPkmnString(void) static void Select_PrintRentalPkmnString(void)
{ {
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
AddTextPrinterParameterized(0, 1, gText_RentalPkmn2, 2, 1, 0, NULL); AddTextPrinterParameterized(0, 1, gText_RentalPkmn2, 2, 1, 0, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
@ -1804,7 +1804,7 @@ static void Select_PrintMonSpecies(void)
u8 x; u8 x;
u8 monId = sFactorySelectScreen->cursorPos; u8 monId = sFactorySelectScreen->cursorPos;
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
species = GetMonData(&sFactorySelectScreen->mons[monId].monData, MON_DATA_SPECIES, NULL); species = GetMonData(&sFactorySelectScreen->mons[monId].monData, MON_DATA_SPECIES, NULL);
StringCopy(gStringVar4, gSpeciesNames[species]); StringCopy(gStringVar4, gSpeciesNames[species]);
x = GetStringRightAlignXOffset(1, gStringVar4, 86); x = GetStringRightAlignXOffset(1, gStringVar4, 86);
@ -1816,7 +1816,7 @@ static void Select_PrintSelectMonString(void)
{ {
const u8 *str = NULL; const u8 *str = NULL;
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
if (sFactorySelectScreen->selectingMonsState == 1) if (sFactorySelectScreen->selectingMonsState == 1)
str = gText_SelectFirstPkmn; str = gText_SelectFirstPkmn;
else if (sFactorySelectScreen->selectingMonsState == 2) else if (sFactorySelectScreen->selectingMonsState == 2)
@ -1832,7 +1832,7 @@ static void Select_PrintSelectMonString(void)
static void Select_PrintCantSelectSameMon(void) static void Select_PrintCantSelectSameMon(void)
{ {
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
AddTextPrinterParameterized(2, 1, gText_CantSelectSamePkmn, 2, 5, 0, NULL); AddTextPrinterParameterized(2, 1, gText_CantSelectSamePkmn, 2, 5, 0, NULL);
CopyWindowToVram(2, 2); CopyWindowToVram(2, 2);
} }
@ -1842,7 +1842,7 @@ static void Select_PrintMenuOptions(void)
u8 selectedId = sFactorySelectScreen->mons[sFactorySelectScreen->cursorPos].selectedId; u8 selectedId = sFactorySelectScreen->mons[sFactorySelectScreen->cursorPos].selectedId;
PutWindowTilemap(3); PutWindowTilemap(3);
FillWindowPixelBuffer(3, 0); FillWindowPixelBuffer(3, PIXEL_FILL(0));
AddTextPrinterParameterized3(3, 1, 7, 1, gUnknown_08610476, 0, gText_Summary); AddTextPrinterParameterized3(3, 1, 7, 1, gUnknown_08610476, 0, gText_Summary);
if (selectedId != 0) if (selectedId != 0)
AddTextPrinterParameterized3(3, 1, 7, 17, gUnknown_08610476, 0, gText_Deselect); AddTextPrinterParameterized3(3, 1, 7, 17, gUnknown_08610476, 0, gText_Deselect);
@ -1856,7 +1856,7 @@ static void Select_PrintMenuOptions(void)
static void Select_PrintYesNoOptions(void) static void Select_PrintYesNoOptions(void)
{ {
PutWindowTilemap(4); PutWindowTilemap(4);
FillWindowPixelBuffer(4, 0); FillWindowPixelBuffer(4, PIXEL_FILL(0));
AddTextPrinterParameterized3(4, 1, 7, 1, gUnknown_08610476, 0, gText_Yes2); AddTextPrinterParameterized3(4, 1, 7, 1, gUnknown_08610476, 0, gText_Yes2);
AddTextPrinterParameterized3(4, 1, 7, 17, gUnknown_08610476, 0, gText_No2); AddTextPrinterParameterized3(4, 1, 7, 17, gUnknown_08610476, 0, gText_No2);
CopyWindowToVram(4, 3); CopyWindowToVram(4, 3);
@ -1924,7 +1924,7 @@ static void Select_PrintMonCategory(void)
if (monId < SELECTABLE_MONS_COUNT) if (monId < SELECTABLE_MONS_COUNT)
{ {
PutWindowTilemap(5); PutWindowTilemap(5);
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
species = GetMonData(&sFactorySelectScreen->mons[monId].monData, MON_DATA_SPECIES, NULL); species = GetMonData(&sFactorySelectScreen->mons[monId].monData, MON_DATA_SPECIES, NULL);
CopyMonCategoryText(SpeciesToNationalPokedexNum(species), text); CopyMonCategoryText(SpeciesToNationalPokedexNum(species), text);
x = GetStringRightAlignXOffset(1, text, 0x76); x = GetStringRightAlignXOffset(1, text, 0x76);
@ -2873,7 +2873,7 @@ static void sub_819D588(u8 taskId)
case 3: case 3:
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
CopyWindowToVram(5, 2); CopyWindowToVram(5, 2);
if (sFactorySwapScreen->inEnemyScreen == TRUE) if (sFactorySwapScreen->inEnemyScreen == TRUE)
{ {
@ -3002,7 +3002,7 @@ static void sub_819D770(u8 taskId)
gTasks[taskId].data[0]++; gTasks[taskId].data[0]++;
break; break;
case 6: case 6:
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
CopyWindowToVram(5, 2); CopyWindowToVram(5, 2);
gTasks[taskId].data[0]++; gTasks[taskId].data[0]++;
break; break;
@ -3546,7 +3546,7 @@ static void sub_819EA64(u8 windowId)
{ {
gSprites[sFactorySwapScreen->menuCursor1SpriteId].invisible = TRUE; gSprites[sFactorySwapScreen->menuCursor1SpriteId].invisible = TRUE;
gSprites[sFactorySwapScreen->menuCursor2SpriteId].invisible = TRUE; gSprites[sFactorySwapScreen->menuCursor2SpriteId].invisible = TRUE;
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
CopyWindowToVram(windowId, 2); CopyWindowToVram(windowId, 2);
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
} }
@ -3554,14 +3554,14 @@ static void sub_819EA64(u8 windowId)
static void sub_819EAC0(void) static void sub_819EAC0(void)
{ {
PutWindowTilemap(1); PutWindowTilemap(1);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
CopyWindowToVram(1, 2); CopyWindowToVram(1, 2);
} }
static void sub_819EADC(void) static void sub_819EADC(void)
{ {
PutWindowTilemap(7); PutWindowTilemap(7);
FillWindowPixelBuffer(7, 0); FillWindowPixelBuffer(7, PIXEL_FILL(0));
CopyWindowToVram(7, 2); CopyWindowToVram(7, 2);
} }
@ -3569,13 +3569,13 @@ static void sub_819EAF8(void)
{ {
sub_819EAC0(); sub_819EAC0();
PutWindowTilemap(5); PutWindowTilemap(5);
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
CopyWindowToVram(5, 2); CopyWindowToVram(5, 2);
} }
static void Swap_PrintPkmnSwap(void) static void Swap_PrintPkmnSwap(void)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized(0, 1, gText_PkmnSwap, 2, 1, 0, NULL); AddTextPrinterParameterized(0, 1, gText_PkmnSwap, 2, 1, 0, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
@ -3585,7 +3585,7 @@ static void Swap_PrintMonSpecies(void)
u16 species; u16 species;
u8 x; u8 x;
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
if (sFactorySwapScreen->cursorPos > 2) if (sFactorySwapScreen->cursorPos > 2)
{ {
CopyWindowToVram(1, 2); CopyWindowToVram(1, 2);
@ -3606,7 +3606,7 @@ static void Swap_PrintMonSpecies(void)
static void Swap_PrintOnInfoWindow(const u8 *str) static void Swap_PrintOnInfoWindow(const u8 *str)
{ {
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
AddTextPrinterParameterized(2, 1, str, 2, 5, 0, NULL); AddTextPrinterParameterized(2, 1, str, 2, 5, 0, NULL);
CopyWindowToVram(2, 2); CopyWindowToVram(2, 2);
} }
@ -3614,7 +3614,7 @@ static void Swap_PrintOnInfoWindow(const u8 *str)
static void Swap_PrintMenuOptions(void) static void Swap_PrintMenuOptions(void)
{ {
PutWindowTilemap(3); PutWindowTilemap(3);
FillWindowPixelBuffer(3, 0); FillWindowPixelBuffer(3, PIXEL_FILL(0));
AddTextPrinterParameterized3(3, 1, 15, 1, gUnknown_08610922, 0, gText_Summary2); AddTextPrinterParameterized3(3, 1, 15, 1, gUnknown_08610922, 0, gText_Summary2);
AddTextPrinterParameterized3(3, 1, 15, 17, gUnknown_08610922, 0, gText_Swap); AddTextPrinterParameterized3(3, 1, 15, 17, gUnknown_08610922, 0, gText_Swap);
AddTextPrinterParameterized3(3, 1, 15, 33, gUnknown_08610922, 0, gText_Rechoose); AddTextPrinterParameterized3(3, 1, 15, 33, gUnknown_08610922, 0, gText_Rechoose);
@ -3624,7 +3624,7 @@ static void Swap_PrintMenuOptions(void)
static void Swap_PrintYesNoOptions(void) static void Swap_PrintYesNoOptions(void)
{ {
PutWindowTilemap(4); PutWindowTilemap(4);
FillWindowPixelBuffer(4, 0); FillWindowPixelBuffer(4, PIXEL_FILL(0));
AddTextPrinterParameterized3(4, 1, 7, 1, gUnknown_08610922, 0, gText_Yes3); AddTextPrinterParameterized3(4, 1, 7, 1, gUnknown_08610922, 0, gText_Yes3);
AddTextPrinterParameterized3(4, 1, 7, 17, gUnknown_08610922, 0, gText_No3); AddTextPrinterParameterized3(4, 1, 7, 17, gUnknown_08610922, 0, gText_No3);
CopyWindowToVram(4, 3); CopyWindowToVram(4, 3);
@ -3638,7 +3638,7 @@ static void Swap_PrintActionString(const u8 *str, u32 y, u32 windowId)
static void Swap_PrintActionStrings(void) static void Swap_PrintActionStrings(void)
{ {
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
switch (sFactorySwapScreen->inEnemyScreen) switch (sFactorySwapScreen->inEnemyScreen)
{ {
case TRUE: case TRUE:
@ -3652,7 +3652,7 @@ static void Swap_PrintActionStrings(void)
static void Swap_PrintActionStrings2(void) static void Swap_PrintActionStrings2(void)
{ {
FillWindowPixelBuffer(3, 0); FillWindowPixelBuffer(3, PIXEL_FILL(0));
switch (sFactorySwapScreen->inEnemyScreen) switch (sFactorySwapScreen->inEnemyScreen)
{ {
case TRUE: case TRUE:
@ -3693,7 +3693,7 @@ static void Swap_PrintMonSpecies2(void)
LoadPalette(pal, 0xF0, 0xA); LoadPalette(pal, 0xF0, 0xA);
PutWindowTilemap(7); PutWindowTilemap(7);
FillWindowPixelBuffer(7, 0); FillWindowPixelBuffer(7, PIXEL_FILL(0));
if (sFactorySwapScreen->cursorPos > 2) if (sFactorySwapScreen->cursorPos > 2)
{ {
CopyWindowToVram(7, 3); CopyWindowToVram(7, 3);
@ -3745,7 +3745,7 @@ static void Swap_PrintMonCategory(void)
u8 x; u8 x;
u8 monId = sFactorySwapScreen->cursorPos; u8 monId = sFactorySwapScreen->cursorPos;
FillWindowPixelBuffer(8, 0); FillWindowPixelBuffer(8, PIXEL_FILL(0));
if (monId > 2) if (monId > 2)
{ {
CopyWindowToVram(8, 2); CopyWindowToVram(8, 2);
@ -3940,7 +3940,7 @@ static void Task_SwapCantHaveSameMons(u8 taskId)
case 2: case 2:
if (sFactorySwapScreen->unk30 != TRUE) if (sFactorySwapScreen->unk30 != TRUE)
{ {
FillWindowPixelBuffer(5, 0); FillWindowPixelBuffer(5, PIXEL_FILL(0));
CopyWindowToVram(5, 2); CopyWindowToVram(5, 2);
gTasks[taskId].data[0]++; gTasks[taskId].data[0]++;
} }

2
src/battle_interface.c
View File

@ -2579,7 +2579,7 @@ static u8* AddTextPrinterAndCreateWindowOnHealthbox(const u8 *str, u32 x, u32 y,
struct WindowTemplate winTemplate = sHealthboxWindowTemplate; struct WindowTemplate winTemplate = sHealthboxWindowTemplate;
winId = AddWindow(&winTemplate); winId = AddWindow(&winTemplate);
FillWindowPixelBuffer(winId, (bgColor << 4) | (bgColor)); FillWindowPixelBuffer(winId, PIXEL_FILL(bgColor));
color[0] = bgColor; color[0] = bgColor;
color[1] = 1; color[1] = 1;

94
src/battle_message.c
View File

@ -1357,7 +1357,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
{ {
// The corresponding WindowTemplate is gStandardBattleWindowTemplates[] within src/battle_bg.c // The corresponding WindowTemplate is gStandardBattleWindowTemplates[] within src/battle_bg.c
{ // 0 Standard battle message { // 0 Standard battle message
.fillValue = 0xFF, .fillValue = PIXEL_FILL(0xF),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1369,7 +1369,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 1 "What will (pokemon) do?" { // 1 "What will (pokemon) do?"
.fillValue = 0xFF, .fillValue = PIXEL_FILL(0xF),
.fontId = 1, .fontId = 1,
.x = 1, .x = 1,
.y = 1, .y = 1,
@ -1381,7 +1381,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 2 "Fight/Pokemon/Bag/Run" { // 2 "Fight/Pokemon/Bag/Run"
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1393,7 +1393,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 3 Top left move { // 3 Top left move
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1405,7 +1405,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 4 Top right move { // 4 Top right move
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1417,7 +1417,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 5 Bottom left move { // 5 Bottom left move
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1429,7 +1429,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 6 Bottom right move { // 6 Bottom right move
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1441,7 +1441,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 7 "PP" { // 7 "PP"
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1453,7 +1453,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 11, .shadowColor = 11,
}, },
{ // 8 { // 8
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1465,7 +1465,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 9 PP remaining { // 9 PP remaining
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 2, .x = 2,
.y = 1, .y = 1,
@ -1477,7 +1477,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 11, .shadowColor = 11,
}, },
{ // 10 "type" { // 10 "type"
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1489,7 +1489,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 11 "switch which?" { // 11 "switch which?"
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1501,7 +1501,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 12 "gText_BattleYesNoChoice" { // 12 "gText_BattleYesNoChoice"
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1513,7 +1513,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 13 { // 13
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1525,7 +1525,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 14 { // 14
.fillValue = 0x0, .fillValue = PIXEL_FILL(0),
.fontId = 1, .fontId = 1,
.x = 32, .x = 32,
.y = 1, .y = 1,
@ -1537,7 +1537,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 2, .shadowColor = 2,
}, },
{ // 15 { // 15
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1549,7 +1549,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 16 { // 16
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1561,7 +1561,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 17 { // 17
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1573,7 +1573,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 18 { // 18
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1585,7 +1585,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 19 { // 19
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1597,7 +1597,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 20 { // 20
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1609,7 +1609,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 21 { // 21
.fillValue = 0x0, .fillValue = PIXEL_FILL(0),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1621,7 +1621,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 22 { // 22
.fillValue = 0x0, .fillValue = PIXEL_FILL(0),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1633,7 +1633,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 23 { // 23
.fillValue = 0x0, .fillValue = PIXEL_FILL(0x0),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1649,7 +1649,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Normal[] =
static const struct BattleWindowText sTextOnWindowsInfo_Arena[] = static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
{ {
{ // 0 { // 0
.fillValue = 0xFF, .fillValue = PIXEL_FILL(0xF),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1661,7 +1661,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 1 { // 1
.fillValue = 0xFF, .fillValue = PIXEL_FILL(0xF),
.fontId = 1, .fontId = 1,
.x = 1, .x = 1,
.y = 1, .y = 1,
@ -1673,7 +1673,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 6, .shadowColor = 6,
}, },
{ // 2 { // 2
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1685,7 +1685,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 3 { // 3
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1697,7 +1697,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 4 { // 4
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1709,7 +1709,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 5 { // 5
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1721,7 +1721,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 6 { // 6
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1733,7 +1733,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 7 { // 7
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1745,7 +1745,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 11, .shadowColor = 11,
}, },
{ // 8 { // 8
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1757,7 +1757,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 9 { // 9
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 2, .x = 2,
.y = 1, .y = 1,
@ -1769,7 +1769,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 11, .shadowColor = 11,
}, },
{ // 10 { // 10
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1781,7 +1781,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 11 { // 11
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 7, .fontId = 7,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1793,7 +1793,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 12 { // 12
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1805,7 +1805,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 13 { // 13
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,
@ -1817,7 +1817,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 14 { // 14
.fillValue = 0x0, .fillValue = PIXEL_FILL(0),
.fontId = 1, .fontId = 1,
.x = 32, .x = 32,
.y = 1, .y = 1,
@ -1829,7 +1829,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 2, .shadowColor = 2,
}, },
{ // 15 { // 15
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1841,7 +1841,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 16 { // 16
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1853,7 +1853,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 17 { // 17
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1865,7 +1865,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 18 { // 18
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1877,7 +1877,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 19 { // 19
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1889,7 +1889,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 20 { // 20
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1901,7 +1901,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 21 { // 21
.fillValue = 0xEE, .fillValue = PIXEL_FILL(0xE),
.fontId = 1, .fontId = 1,
.x = -1, .x = -1,
.y = 1, .y = 1,
@ -1913,7 +1913,7 @@ static const struct BattleWindowText sTextOnWindowsInfo_Arena[] =
.shadowColor = 15, .shadowColor = 15,
}, },
{ // 22 { // 22
.fillValue = 0x11, .fillValue = PIXEL_FILL(0x1),
.fontId = 1, .fontId = 1,
.x = 0, .x = 0,
.y = 1, .y = 1,

33
src/battle_pyramid_bag.c
View File

@ -651,7 +651,7 @@ static void PrintItemDescription(s32 listMenuId)
StringExpandPlaceholders(gStringVar4, gText_ReturnToVar1); StringExpandPlaceholders(gStringVar4, gText_ReturnToVar1);
desc = gStringVar4; desc = gStringVar4;
} }
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, desc, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, desc, 3, 0, 0, 1, 0, 0);
} }
@ -804,7 +804,7 @@ static void sub_81C5A98(u8 listMenuTaskId, u8 arg1)
static void sub_81C5AB8(u8 y, u8 arg1) static void sub_81C5AB8(u8 y, u8 arg1)
{ {
if (arg1 == 0xFF) if (arg1 == 0xFF)
FillWindowPixelRect(0, 0, 0, y, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1)); FillWindowPixelRect(0, PIXEL_FILL(0), 0, y, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1));
else else
PrintOnWindow_Font1(0, gText_SelectorArrow2, 0, y, 0, 0, 0, arg1); PrintOnWindow_Font1(0, gText_SelectorArrow2, 0, y, 0, 0, 0, arg1);
} }
@ -911,7 +911,7 @@ static void sub_81C5D20(u8 taskId)
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_Var1IsSelected); StringExpandPlaceholders(gStringVar4, gText_Var1IsSelected);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0);
if (gPyramidBagResources->menuActionsCount == 1) if (gPyramidBagResources->menuActionsCount == 1)
sub_81C5EAC(sub_81C6D24(0)); sub_81C5EAC(sub_81C6D24(0));
@ -1048,7 +1048,7 @@ static void BagAction_UseOnField(u8 taskId)
else if (ItemId_GetFieldFunc(gSpecialVar_ItemId) != NULL) else if (ItemId_GetFieldFunc(gSpecialVar_ItemId) != NULL)
{ {
sub_81C61A8(); sub_81C61A8();
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
ItemId_GetFieldFunc(gSpecialVar_ItemId)(taskId); ItemId_GetFieldFunc(gSpecialVar_ItemId)(taskId);
} }
@ -1086,7 +1086,7 @@ static void BagAction_Toss(u8 taskId)
{ {
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_TossHowManyVar1s); StringExpandPlaceholders(gStringVar4, gText_TossHowManyVar1s);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0);
sub_81C6404(); sub_81C6404();
gTasks[taskId].func = sub_81C64B4; gTasks[taskId].func = sub_81C64B4;
@ -1100,7 +1100,7 @@ static void sub_81C6350(u8 taskId)
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
ConvertIntToDecimalStringN(gStringVar2, data[8], STR_CONV_MODE_LEFT_ALIGN, 2); ConvertIntToDecimalStringN(gStringVar2, data[8], STR_CONV_MODE_LEFT_ALIGN, 2);
StringExpandPlaceholders(gStringVar4, gText_ConfirmTossItems); StringExpandPlaceholders(gStringVar4, gText_ConfirmTossItems);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0);
sub_81C6DAC(taskId, &sYesNoTossFuncions); sub_81C6DAC(taskId, &sYesNoTossFuncions);
} }
@ -1146,7 +1146,7 @@ static void sub_81C64B4(u8 taskId)
else if (gMain.newKeys & A_BUTTON) else if (gMain.newKeys & A_BUTTON)
{ {
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(3, 0); ClearStdWindowAndFrameToTransparent(3, 0);
ClearWindowTilemap(3); ClearWindowTilemap(3);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
sub_81C6350(taskId); sub_81C6350(taskId);
@ -1154,7 +1154,7 @@ static void sub_81C64B4(u8 taskId)
else if (gMain.newKeys & B_BUTTON) else if (gMain.newKeys & B_BUTTON)
{ {
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(3, 0); ClearStdWindowAndFrameToTransparent(3, 0);
ClearWindowTilemap(3); ClearWindowTilemap(3);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
DontTossItem(taskId); DontTossItem(taskId);
@ -1168,7 +1168,7 @@ static void TossItem(u8 taskId)
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
ConvertIntToDecimalStringN(gStringVar2, data[8], STR_CONV_MODE_LEFT_ALIGN, 2); ConvertIntToDecimalStringN(gStringVar2, data[8], STR_CONV_MODE_LEFT_ALIGN, 2);
StringExpandPlaceholders(gStringVar4, gText_ThrewAwayVar2Var1s); StringExpandPlaceholders(gStringVar4, gText_ThrewAwayVar2Var1s);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0);
gTasks[taskId].func = sub_81C65CC; gTasks[taskId].func = sub_81C65CC;
} }
@ -1265,7 +1265,7 @@ static void Task_BeginItemSwap(u8 taskId)
ListMenuSetUnkIndicatorsStructField(data[0], 0x10, 1); ListMenuSetUnkIndicatorsStructField(data[0], 0x10, 1);
CopyItemName(gSaveBlock2Ptr->frontier.pyramidBag.itemId[gSaveBlock2Ptr->frontier.lvlMode][data[1]], gStringVar1); CopyItemName(gSaveBlock2Ptr->frontier.pyramidBag.itemId[gSaveBlock2Ptr->frontier.lvlMode][data[1]], gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_MoveVar1Where); StringExpandPlaceholders(gStringVar4, gText_MoveVar1Where);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0); PrintOnWindow_Font1(1, gStringVar4, 3, 0, 0, 1, 0, 0);
sub_81C5A98(data[0], 1); sub_81C5A98(data[0], 1);
sub_81C704C(data[1]); sub_81C704C(data[1]);
@ -1395,7 +1395,7 @@ static void sub_81C6BD8(void)
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
for (i = 0; i < 5; i++) for (i = 0; i < 5; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
PutWindowTilemap(1); PutWindowTilemap(1);
@ -1415,7 +1415,7 @@ static void PrintOnWindow_Font7(u8 windowId, const u8 *src, u8 x, u8 y, u8 lette
static void sub_81C6CEC(u8 windowId) static void sub_81C6CEC(u8 windowId)
{ {
SetWindowBorderStyle(windowId, 0, 1, 0xE); DrawStdFrameWithCustomTileAndPalette(windowId, 0, 1, 0xE);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }
@ -1430,7 +1430,7 @@ static u8 sub_81C6D24(u8 windowArrayId)
if (*windowId == 0xFF) if (*windowId == 0xFF)
{ {
*windowId = AddWindow(&gUnknown_0861F350[windowArrayId]); *windowId = AddWindow(&gUnknown_0861F350[windowArrayId]);
SetWindowBorderStyle(*windowId, FALSE, 1, 0xE); DrawStdFrameWithCustomTileAndPalette(*windowId, FALSE, 1, 0xE);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }
return *windowId; return *windowId;
@ -1441,7 +1441,7 @@ static void sub_81C6D6C(u8 windowArrayId)
u8 *windowId = &gPyramidBagResources->windowIds[windowArrayId]; u8 *windowId = &gPyramidBagResources->windowIds[windowArrayId];
if (*windowId != 0xFF) if (*windowId != 0xFF)
{ {
sub_8198070(*windowId, FALSE); ClearStdWindowAndFrameToTransparent(*windowId, FALSE);
ClearWindowTilemap(*windowId); ClearWindowTilemap(*windowId);
RemoveWindow(*windowId); RemoveWindow(*windowId);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
@ -1456,14 +1456,15 @@ static void sub_81C6DAC(u8 taskId, const struct YesNoFuncTable *yesNoTable)
void DisplayItemMessageInBattlePyramid(u8 taskId, const u8 *str, void (*callback)(u8 taskId)) void DisplayItemMessageInBattlePyramid(u8 taskId, const u8 *str, void (*callback)(u8 taskId))
{ {
FillWindowPixelBuffer(2, 0x11); FillWindowPixelBuffer(2, PIXEL_FILL(1));
DisplayMessageAndContinueTask(taskId, 2, 0xA, 0xD, 1, GetPlayerTextSpeedDelay(), str, callback); DisplayMessageAndContinueTask(taskId, 2, 0xA, 0xD, 1, GetPlayerTextSpeedDelay(), str, callback);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }
static void sub_81C6E1C(void) static void sub_81C6E1C(void)
{ {
sub_8197DF8(2, FALSE); ClearDialogWindowAndFrameToTransparent(2, FALSE);
// This ClearWindowTilemap call is redundant, since ClearDialogWindowAndFrameToTransparent already calls it.
ClearWindowTilemap(2); ClearWindowTilemap(2);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }

8
src/battle_records.c
View File

@ -320,8 +320,8 @@ void ShowLinkBattleRecords(void)
s32 i, x; s32 i, x;
gRecordsWindowId = AddWindow(&sLinkBattleRecordsWindow); gRecordsWindowId = AddWindow(&sLinkBattleRecordsWindow);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
StringExpandPlaceholders(gStringVar4, gText_PlayersBattleResults); StringExpandPlaceholders(gStringVar4, gText_PlayersBattleResults);
x = GetStringCenterAlignXOffset(1, gStringVar4, 208); x = GetStringCenterAlignXOffset(1, gStringVar4, 208);
@ -342,7 +342,7 @@ void ShowLinkBattleRecords(void)
void RemoveRecordsWindow(void) void RemoveRecordsWindow(void)
{ {
sub_819746C(gRecordsWindowId, FALSE); ClearStdWindowAndFrame(gRecordsWindowId, FALSE);
RemoveWindow(gRecordsWindowId); RemoveWindow(gRecordsWindowId);
} }
@ -383,7 +383,7 @@ static void Task_ExitTrainerHillRecords(u8 taskId)
static void RemoveTrainerHillRecordsWindow(u8 windowId) static void RemoveTrainerHillRecordsWindow(u8 windowId)
{ {
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
CopyWindowToVram(windowId, 2); CopyWindowToVram(windowId, 2);
RemoveWindow(windowId); RemoveWindow(windowId);

6
src/battle_tower.c
View File

@ -51,7 +51,7 @@ static void AwardBattleTowerRibbons(void);
static void SaveBattleTowerProgress(void); static void SaveBattleTowerProgress(void);
static void sub_8163914(void); static void sub_8163914(void);
static void nullsub_61(void); static void nullsub_61(void);
static void nullsub_116(void); static void SpriteCB_Null6(void);
static void sub_81642A0(void); static void sub_81642A0(void);
static void sub_8164828(void); static void sub_8164828(void);
static void sub_8164B74(void); static void sub_8164B74(void);
@ -1061,7 +1061,7 @@ static void (* const gUnknown_085DF96C[])(void) =
SaveBattleTowerProgress, SaveBattleTowerProgress,
sub_8163914, sub_8163914,
nullsub_61, nullsub_61,
nullsub_116, SpriteCB_Null6,
sub_81642A0, sub_81642A0,
sub_8164828, sub_8164828,
sub_8164B74, sub_8164B74,
@ -2437,7 +2437,7 @@ static void nullsub_61(void)
} }
static void nullsub_116(void) static void SpriteCB_Null6(void)
{ {
} }

16
src/berry_blender.c
View File

@ -940,7 +940,7 @@ static void InitBerryBlenderWindows(void)
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
for (i = 0; i < 5; i++) for (i = 0; i < 5; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x1E, 0x14); FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x1E, 0x14);
sub_81978B0(0xE0); sub_81978B0(0xE0);
@ -1246,7 +1246,7 @@ static void sub_8080018(void)
case 10: case 10:
if (++sBerryBlenderData->framesToWait > 20) if (++sBerryBlenderData->framesToWait > 20)
{ {
sub_8197DF8(4, TRUE); ClearDialogWindowAndFrameToTransparent(4, TRUE);
if (GetBlockReceivedStatus() == sub_800A9D8()) if (GetBlockReceivedStatus() == sub_800A9D8())
{ {
for (i = 0; i < GetLinkPlayerCount(); i++) for (i = 0; i < GetLinkPlayerCount(); i++)
@ -3320,7 +3320,7 @@ static bool8 Blender_PrintBlendingResults(void)
sBerryBlenderData->mainState++; sBerryBlenderData->mainState++;
break; break;
case 5: case 5:
sub_8198070(5, 1); ClearStdWindowAndFrameToTransparent(5, 1);
for (i = 0; i < BLENDER_MAX_PLAYERS; i++) for (i = 0; i < BLENDER_MAX_PLAYERS; i++)
{ {
@ -3461,7 +3461,7 @@ static bool8 Blender_PrintBlendingRanking(void)
} }
break; break;
case 3: case 3:
SetWindowBorderStyle(5, 0, 1, 0xD); DrawStdFrameWithCustomTileAndPalette(5, 0, 1, 0xD);
xPos = GetStringCenterAlignXOffset(1, sText_Ranking, 0xA8); xPos = GetStringCenterAlignXOffset(1, sText_Ranking, 0xA8);
Blender_AddTextPrinter(5, sText_Ranking, xPos, 1, TEXT_SPEED_FF, 0); Blender_AddTextPrinter(5, sText_Ranking, xPos, 1, TEXT_SPEED_FF, 0);
@ -3532,8 +3532,8 @@ void ShowBerryBlenderRecordWindow(void)
winTemplate = sBlenderRecordWindowTemplate; winTemplate = sBlenderRecordWindowTemplate;
gRecordsWindowId = AddWindow(&winTemplate); gRecordsWindowId = AddWindow(&winTemplate);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, 0); DrawStdWindowFrame(gRecordsWindowId, 0);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
xPos = GetStringCenterAlignXOffset(1, gText_BlenderMaxSpeedRecord, 0x90); xPos = GetStringCenterAlignXOffset(1, gText_BlenderMaxSpeedRecord, 0x90);
AddTextPrinterParameterized(gRecordsWindowId, 1, gText_BlenderMaxSpeedRecord, xPos, 1, 0, NULL); AddTextPrinterParameterized(gRecordsWindowId, 1, gText_BlenderMaxSpeedRecord, xPos, 1, 0, NULL);
@ -3642,7 +3642,7 @@ static void Blender_AddTextPrinter(u8 windowId, const u8 *string, u8 x, u8 y, s3
if (caseId != 3) if (caseId != 3)
{ {
FillWindowPixelBuffer(windowId, txtColor[0] | (txtColor[0] << 4)); FillWindowPixelBuffer(windowId, PIXEL_FILL(txtColor[0]));
} }
AddTextPrinterParameterized4(windowId, 1, x, y, letterSpacing, 1, txtColor, speed, string); AddTextPrinterParameterized4(windowId, 1, x, y, letterSpacing, 1, txtColor, speed, string);
@ -3653,7 +3653,7 @@ static bool32 Blender_PrintText(s16 *textState, const u8 *string, s32 textSpeed)
switch (*textState) switch (*textState)
{ {
case 0: case 0:
sub_8197B1C(4, FALSE, 0x14, 0xF); DrawDialogFrameWithCustomTileAndPalette(4, FALSE, 0x14, 0xF);
Blender_AddTextPrinter(4, string, 0, 1, textSpeed, 0); Blender_AddTextPrinter(4, string, 0, 1, textSpeed, 0);
PutWindowTilemap(4); PutWindowTilemap(4);
CopyWindowToVram(4, 3); CopyWindowToVram(4, 3);

8
src/berry_fix_program.c
View File

@ -226,9 +226,9 @@ static void berry_fix_gpu_set(void)
DmaCopy32(3, sUnknown_08618138, BG_PLTT + 0x1E0, 0x20); DmaCopy32(3, sUnknown_08618138, BG_PLTT + 0x1E0, 0x20);
SetGpuReg(REG_OFFSET_DISPCNT, DISPCNT_OBJ_1D_MAP); SetGpuReg(REG_OFFSET_DISPCNT, DISPCNT_OBJ_1D_MAP);
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
FillWindowPixelBuffer(3, 0); FillWindowPixelBuffer(3, PIXEL_FILL(0));
FillWindowPixelBuffer(0, 0xAA); FillWindowPixelBuffer(0, PIXEL_FILL(0xA));
width = GetStringWidth(0, sUnknown_08617E9B, 0); width = GetStringWidth(0, sUnknown_08617E9B, 0);
left = (0x78 - width) / 2; left = (0x78 - width) / 2;
@ -273,7 +273,7 @@ static int berry_fix_text_update(int checkval)
static void berry_fix_text_print(int scene) static void berry_fix_text_print(int scene)
{ {
FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 32, 32); FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 32, 32);
FillWindowPixelBuffer(1, 0xAA); FillWindowPixelBuffer(1, PIXEL_FILL(0xA));
AddTextPrinterParameterized3(1, 1, 0, 0, sUnknown_08618158, -1, gUnknown_08618160[scene]); AddTextPrinterParameterized3(1, 1, 0, 0, sUnknown_08618158, -1, gUnknown_08618160[scene]);
PutWindowTilemap(1); PutWindowTilemap(1);
CopyWindowToVram(1, 2); CopyWindowToVram(1, 2);

14
src/berry_tag_screen.c
View File

@ -381,7 +381,7 @@ static void PrintTextInBerryTagScreen(u8 windowId, const u8 *text, u8 x, u8 y, s
static void AddBerryTagTextToBg0(void) static void AddBerryTagTextToBg0(void)
{ {
memcpy(GetBgTilemapBuffer(0), sBerryTag->tilemapBuffers[2], sizeof(sBerryTag->tilemapBuffers[2])); memcpy(GetBgTilemapBuffer(0), sBerryTag->tilemapBuffers[2], sizeof(sBerryTag->tilemapBuffers[2]));
FillWindowPixelBuffer(WIN_BERRY_TAG, 0xFF); FillWindowPixelBuffer(WIN_BERRY_TAG, PIXEL_FILL(15));
PrintTextInBerryTagScreen(WIN_BERRY_TAG, gText_BerryTag, GetStringCenterAlignXOffset(1, gText_BerryTag, 0x40), 1, 0, 1); PrintTextInBerryTagScreen(WIN_BERRY_TAG, gText_BerryTag, GetStringCenterAlignXOffset(1, gText_BerryTag, 0x40), 1, 0, 1);
PutWindowTilemap(WIN_BERRY_TAG); PutWindowTilemap(WIN_BERRY_TAG);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -598,7 +598,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
switch (data[0]) switch (data[0])
{ {
case 0x30: case 0x30:
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
break; break;
case 0x40: case 0x40:
PrintBerryNumberAndName(); PrintBerryNumberAndName();
@ -608,7 +608,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
CreateBerrySprite(); CreateBerrySprite();
break; break;
case 0x60: case 0x60:
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
break; break;
case 0x70: case 0x70:
PrintBerrySize(); PrintBerrySize();
@ -620,7 +620,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
SetFlavorCirclesVisiblity(); SetFlavorCirclesVisiblity();
break; break;
case 0xA0: case 0xA0:
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
break; break;
case 0xB0: case 0xB0:
PrintBerryDescription1(); PrintBerryDescription1();
@ -635,7 +635,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
switch (data[0]) switch (data[0])
{ {
case 0x30: case 0x30:
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
break; break;
case 0x40: case 0x40:
PrintBerryDescription2(); PrintBerryDescription2();
@ -647,7 +647,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
SetFlavorCirclesVisiblity(); SetFlavorCirclesVisiblity();
break; break;
case 0x70: case 0x70:
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
break; break;
case 0x80: case 0x80:
PrintBerryFirmness(); PrintBerryFirmness();
@ -660,7 +660,7 @@ static void Task_DisplayAnotherBerry(u8 taskId)
CreateBerrySprite(); CreateBerrySprite();
break; break;
case 0xB0: case 0xB0:
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
break; break;
case 0xC0: case 0xC0:
PrintBerryNumberAndName(); PrintBerryNumberAndName();

4
src/cable_club.c
View File

@ -92,7 +92,9 @@ static void sub_80B23B0(u16 windowId, u32 value)
static void sub_80B241C(u16 windowId) static void sub_80B241C(u16 windowId)
{ {
sub_819746C(windowId, FALSE); // Following this call with a copy-to-vram with mode 3 is identical to
// calling ClearStdWindowAndFrame(windowId, TRUE).
ClearStdWindowAndFrame(windowId, FALSE);
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }

6
src/clear_save_data_screen.c
View File

@ -79,7 +79,7 @@ void CB2_InitClearSaveDataScreen(void)
static void Task_DoClearSaveDataScreenYesNo(u8 taskId) static void Task_DoClearSaveDataScreenYesNo(u8 taskId)
{ {
SetWindowBorderStyle(0, 0, 2, 14); DrawStdFrameWithCustomTileAndPalette(0, 0, 2, 14);
AddTextPrinterParameterized(0, 1, gText_ClearAllSaveData, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_ClearAllSaveData, 0, 1, 0, 0);
CreateYesNoMenu(sClearSaveYesNo, 2, 14, 1); CreateYesNoMenu(sClearSaveYesNo, 2, 14, 1);
gTasks[taskId].func = Task_ClearSaveDataScreenYesNoChoice; gTasks[taskId].func = Task_ClearSaveDataScreenYesNoChoice;
@ -90,7 +90,7 @@ static void Task_ClearSaveDataScreenYesNoChoice(u8 taskId)
switch (Menu_ProcessInputNoWrapClearOnChoose()) switch (Menu_ProcessInputNoWrapClearOnChoose())
{ {
case 0: case 0:
FillWindowPixelBuffer(0, 17); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized(0, 1, gText_ClearingData, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_ClearingData, 0, 1, 0, 0);
gTasks[taskId].func = Task_ClearSaveData; gTasks[taskId].func = Task_ClearSaveData;
break; break;
@ -203,7 +203,7 @@ static void InitClearSaveDataScreenWindows(void)
{ {
InitWindows(sClearSaveTextWindow); InitWindows(sClearSaveTextWindow);
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
LoadWindowGfx(0, 0, 2, 224); LoadWindowGfx(0, 0, 2, 224);
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
} }

6
src/coins.c
View File

@ -27,15 +27,15 @@ void ShowCoinsWindow(u32 coinAmount, u8 x, u8 y)
struct WindowTemplate template; struct WindowTemplate template;
SetWindowTemplateFields(&template, 0, x, y, 8, 2, 0xF, 0x141); SetWindowTemplateFields(&template, 0, x, y, 8, 2, 0xF, 0x141);
sCoinsWindowId = AddWindow(&template); sCoinsWindowId = AddWindow(&template);
FillWindowPixelBuffer(sCoinsWindowId, 0); FillWindowPixelBuffer(sCoinsWindowId, PIXEL_FILL(0));
PutWindowTilemap(sCoinsWindowId); PutWindowTilemap(sCoinsWindowId);
SetWindowBorderStyle(sCoinsWindowId, FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(sCoinsWindowId, FALSE, 0x214, 0xE);
PrintCoinsString(coinAmount); PrintCoinsString(coinAmount);
} }
void HideCoinsWindow(void) void HideCoinsWindow(void)
{ {
sub_819746C(sCoinsWindowId, TRUE); ClearStdWindowAndFrame(sCoinsWindowId, TRUE);
RemoveWindow(sCoinsWindowId); RemoveWindow(sCoinsWindowId);
} }

14
src/contest.c
View File

@ -819,7 +819,7 @@ static void sub_80D8490(u8 taskId)
} }
r5 = StringCopy(r5, gMoveNames[move]); r5 = StringCopy(r5, gMoveNames[move]);
FillWindowPixelBuffer(i + 5, 0); FillWindowPixelBuffer(i + 5, PIXEL_FILL(0));
Contest_PrintTextToBg0WindowAt(i + 5, sp8, 5, 1, 7); Contest_PrintTextToBg0WindowAt(i + 5, sp8, 5, 1, 7);
} }
@ -941,7 +941,7 @@ static void sub_80D895C(u8 taskId)
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
FillWindowPixelBuffer(5 + i, 0); FillWindowPixelBuffer(5 + i, PIXEL_FILL(0));
PutWindowTilemap(5 + i); PutWindowTilemap(5 + i);
CopyWindowToVram(5 + i, 2); CopyWindowToVram(5 + i, 2);
} }
@ -2258,7 +2258,7 @@ static void sub_80DAEA4(void)
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
FillWindowPixelBuffer(gUnknown_02039F26[i], 0); FillWindowPixelBuffer(gUnknown_02039F26[i], PIXEL_FILL(0));
sub_80DAF04(i); sub_80DAF04(i);
sub_80DAF88(i); sub_80DAF88(i);
} }
@ -2478,7 +2478,7 @@ static void prints_contest_move_description(u16 a)
ContestBG_FillBoxWithTile(0, 0x5036, 0x15, 0x20, 0x08, 0x01, 0x11); ContestBG_FillBoxWithTile(0, 0x5036, 0x15, 0x20, 0x08, 0x01, 0x11);
ContestBG_FillBoxWithTile(0, 0x5014, 0x15, 0x20, numHearts, 0x01, 0x11); ContestBG_FillBoxWithTile(0, 0x5014, 0x15, 0x20, numHearts, 0x01, 0x11);
FillWindowPixelBuffer(10, 0); FillWindowPixelBuffer(10, PIXEL_FILL(0));
Contest_PrintTextToBg0WindowStd(10, gContestEffectDescriptionPointers[gContestMoves[a].effect]); Contest_PrintTextToBg0WindowStd(10, gContestEffectDescriptionPointers[gContestMoves[a].effect]);
Contest_PrintTextToBg0WindowStd(9, gText_Slash); Contest_PrintTextToBg0WindowStd(9, gText_Slash);
} }
@ -2621,7 +2621,7 @@ static void sub_80DB884(void)
static void sub_80DB89C(void) static void sub_80DB89C(void)
{ {
FillWindowPixelBuffer(4, 0); FillWindowPixelBuffer(4, PIXEL_FILL(0));
CopyWindowToVram(4, 2); CopyWindowToVram(4, 2);
Contest_SetBgCopyFlags(0); Contest_SetBgCopyFlags(0);
} }
@ -3456,7 +3456,7 @@ static void sub_80DCD48(void)
break; break;
default: default:
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
value = sContestantStatus[i].unk4; value = sContestantStatus[i].unk4;
@ -5038,7 +5038,7 @@ static void sub_80DF750(void)
return; return;
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
if (gHeap[0x1A000] == 2) if (gHeap[0x1A000] == 2)
{ {

2
src/contest_link_80F57C4.c
View File

@ -935,7 +935,7 @@ static void sub_80F6AE8(void)
// windowTemplate.width = 30; // windowTemplate.width = 30;
// windowTemplate.height = 2; // windowTemplate.height = 2;
// windowId = AddWindow(&windowTemplate); // windowId = AddWindow(&windowTemplate);
// FillWindowPixelBuffer(windowId, 0x11); // FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
// origWidth = GetStringWidth(1, text, 0) + 9; // origWidth = GetStringWidth(1, text, 0) + 9;
// strWidth = origWidth; // strWidth = origWidth;
// if (strWidth < 0) // if (strWidth < 0)

2
src/contest_painting.c
View File

@ -279,7 +279,7 @@ static void InitContestPaintingWindow(void)
SetBgTilemapBuffer(1, AllocZeroed(BG_SCREEN_SIZE)); SetBgTilemapBuffer(1, AllocZeroed(BG_SCREEN_SIZE));
gContestPaintingWindowId = AddWindow(&gUnknown_085B07EC); gContestPaintingWindowId = AddWindow(&gUnknown_085B07EC);
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
FillWindowPixelBuffer(gContestPaintingWindowId, 0); FillWindowPixelBuffer(gContestPaintingWindowId, PIXEL_FILL(0));
PutWindowTilemap(gContestPaintingWindowId); PutWindowTilemap(gContestPaintingWindowId);
CopyWindowToVram(gContestPaintingWindowId, 3); CopyWindowToVram(gContestPaintingWindowId, 3);
ShowBg(1); ShowBg(1);

2
src/credits.c
View File

@ -1592,7 +1592,7 @@ static void sub_8175DA0(u8 taskIdB)
case 5: case 5:
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
CopyWindowToVram(0, 2); CopyWindowToVram(0, 2);
gTasks[taskIdB].data[TDB_0] = 2; gTasks[taskIdB].data[TDB_0] = 2;
} }

6
src/daycare.c
View File

@ -1259,7 +1259,7 @@ static void Task_HandleDaycareLevelMenuInput(u8 taskId)
break; break;
} }
DestroyListMenuTask(gTasks[taskId].tMenuListTaskId, NULL, NULL); DestroyListMenuTask(gTasks[taskId].tMenuListTaskId, NULL, NULL);
sub_819746C(gTasks[taskId].tWindowId, TRUE); ClearStdWindowAndFrame(gTasks[taskId].tWindowId, TRUE);
RemoveWindow(gTasks[taskId].tWindowId); RemoveWindow(gTasks[taskId].tWindowId);
DestroyTask(taskId); DestroyTask(taskId);
EnableBothScriptContexts(); EnableBothScriptContexts();
@ -1268,7 +1268,7 @@ static void Task_HandleDaycareLevelMenuInput(u8 taskId)
{ {
gSpecialVar_Result = 2; gSpecialVar_Result = 2;
DestroyListMenuTask(gTasks[taskId].tMenuListTaskId, NULL, NULL); DestroyListMenuTask(gTasks[taskId].tMenuListTaskId, NULL, NULL);
sub_819746C(gTasks[taskId].tWindowId, TRUE); ClearStdWindowAndFrame(gTasks[taskId].tWindowId, TRUE);
RemoveWindow(gTasks[taskId].tWindowId); RemoveWindow(gTasks[taskId].tWindowId);
DestroyTask(taskId); DestroyTask(taskId);
EnableBothScriptContexts(); EnableBothScriptContexts();
@ -1283,7 +1283,7 @@ void ShowDaycareLevelMenu(void)
u8 daycareMenuTaskId; u8 daycareMenuTaskId;
windowId = AddWindow(&sDaycareLevelMenuWindowTemplate); windowId = AddWindow(&sDaycareLevelMenuWindowTemplate);
NewMenuHelpers_DrawStdWindowFrame(windowId, FALSE); DrawStdWindowFrame(windowId, FALSE);
menuTemplate = sDaycareListMenuLevelTemplate; menuTemplate = sDaycareListMenuLevelTemplate;
menuTemplate.windowId = windowId; menuTemplate.windowId = windowId;

48
src/decoration.c
View File

@ -463,14 +463,14 @@ u8 sub_81269D4(u8 idx)
{ {
*winidx = AddWindow(&gUnknown_085A6B90[idx]); *winidx = AddWindow(&gUnknown_085A6B90[idx]);
} }
SetWindowBorderStyle(*winidx, 0, 0x214, 0xe); DrawStdFrameWithCustomTileAndPalette(*winidx, 0, 0x214, 0xe);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
return *winidx; return *winidx;
} }
void sub_8126A58(u8 idx) void sub_8126A58(u8 idx)
{ {
sub_8198070(sDecorMenuWindowIndices[idx], FALSE); ClearStdWindowAndFrameToTransparent(sDecorMenuWindowIndices[idx], FALSE);
ClearWindowTilemap(sDecorMenuWindowIndices[idx]); ClearWindowTilemap(sDecorMenuWindowIndices[idx]);
RemoveWindow(sDecorMenuWindowIndices[idx]); RemoveWindow(sDecorMenuWindowIndices[idx]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -543,7 +543,7 @@ void sub_8126B80(u8 taskId)
void sub_8126C08(void) void sub_8126C08(void)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, sSecretBasePCMenuItemDescriptions[sSecretBasePCMenuCursorPos], 0, 0, 2, 1, 3); AddTextPrinterParameterized2(0, 1, sSecretBasePCMenuItemDescriptions[sSecretBasePCMenuCursorPos], 0, 0, 2, 1, 3);
} }
@ -572,7 +572,7 @@ void SecretBasePC_PutAway(u8 taskId)
else else
{ {
sub_8126A58(0); sub_8126A58(0);
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
FadeScreen(1, 0); FadeScreen(1, 0);
gTasks[taskId].data[2] = 0; gTasks[taskId].data[2] = 0;
gTasks[taskId].func = sub_8129ABC; gTasks[taskId].func = sub_8129ABC;
@ -617,7 +617,7 @@ void sub_8126DA4(u8 taskId)
void SecretBasePC_PrepMenuForSelectingStoredDecors(u8 taskId) void SecretBasePC_PrepMenuForSelectingStoredDecors(u8 taskId)
{ {
LoadPalette(gUnknown_085A6BB0, 0xd0, 0x20); LoadPalette(gUnknown_085A6BB0, 0xd0, 0x20);
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_8126A58(0); sub_8126A58(0);
sub_8126DFC(taskId); sub_8126DFC(taskId);
} }
@ -634,7 +634,7 @@ void sub_8126DFC(u8 taskId)
void sub_8126E44(u8 taskId) void sub_8126E44(u8 taskId)
{ {
FillWindowPixelBuffer(sDecorMenuWindowIndices[1], 0x11); FillWindowPixelBuffer(sDecorMenuWindowIndices[1], PIXEL_FILL(1));
sub_8126E8C(taskId); sub_8126E8C(taskId);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(sDecorMenuWindowIndices[1], 9, sCurDecorationCategory); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(sDecorMenuWindowIndices[1], 9, sCurDecorationCategory);
gTasks[taskId].func = sub_8127088; gTasks[taskId].func = sub_8127088;
@ -751,7 +751,7 @@ void sub_81270E8(u8 taskId)
void sub_8127180(u8 taskId) void sub_8127180(u8 taskId)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_8126DFC(taskId); sub_8126DFC(taskId);
} }
@ -771,7 +771,7 @@ void sub_81271CC(u8 taskId)
{ {
sub_8126A58(1); sub_8126A58(1);
sub_8126A88(); sub_8126A88();
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
sub_8126C08(); sub_8126C08();
gTasks[taskId].func = sub_8126B80; gTasks[taskId].func = sub_8126B80;
} }
@ -779,7 +779,7 @@ void sub_81271CC(u8 taskId)
void sub_8127208(u8 taskId) void sub_8127208(u8 taskId)
{ {
LoadPalette(gUnknown_085A6BB0, 0xd0, 0x20); LoadPalette(gUnknown_085A6BB0, 0xd0, 0x20);
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
gTasks[taskId].data[11] = 2; gTasks[taskId].data[11] = 2;
sCurDecorationCategory = DECORCAT_DESK; sCurDecorationCategory = DECORCAT_DESK;
sub_8126DFC(taskId); sub_8126DFC(taskId);
@ -968,7 +968,7 @@ void sub_8127744(u32 a0)
const u8 *txt; const u8 *txt;
winidx = sDecorMenuWindowIndices[3]; winidx = sDecorMenuWindowIndices[3];
FillWindowPixelBuffer(winidx, 0x11); FillWindowPixelBuffer(winidx, PIXEL_FILL(1));
if (a0 >= sCurDecorCatCount) if (a0 >= sCurDecorCatCount)
{ {
txt = gText_GoBackPrevMenu; txt = gText_GoBackPrevMenu;
@ -1095,7 +1095,7 @@ void sub_8127A14(u8 taskId)
void sub_8127A30(u8 taskId) void sub_8127A30(u8 taskId)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
gTasks[taskId].func = sub_8127A14; gTasks[taskId].func = sub_8127A14;
} }
@ -1103,7 +1103,7 @@ void sub_8127A5C(u8 taskId)
{ {
if (gMain.newKeys & (A_BUTTON | B_BUTTON)) if (gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_81269D4(1); sub_81269D4(1);
sub_8127620(taskId); sub_8127620(taskId);
} }
@ -1628,13 +1628,13 @@ void sub_8128950(u8 taskId)
void sub_81289D0(u8 taskId) void sub_81289D0(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_085A72C4); DoYesNoFuncWithChoice(taskId, &gUnknown_085A72C4);
} }
void sub_81289F0(u8 taskId) void sub_81289F0(u8 taskId)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_8128AAC(taskId); sub_8128AAC(taskId);
if (gDecorations[gCurDecorInventoryItems[gCurDecorationIndex]].permission != DECORPERM_SOLID_MAT) if (gDecorations[gCurDecorInventoryItems[gCurDecorationIndex]].permission != DECORPERM_SOLID_MAT)
{ {
@ -1693,13 +1693,13 @@ void sub_8128AAC(u8 taskId)
void sub_8128B80(u8 taskId) void sub_8128B80(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_085A72CC); DoYesNoFuncWithChoice(taskId, &gUnknown_085A72CC);
} }
void sub_8128BA0(u8 taskId) void sub_8128BA0(u8 taskId)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_8128BBC(taskId); sub_8128BBC(taskId);
} }
@ -1887,7 +1887,7 @@ void sub_8128E18(u8 taskId)
void sub_8128FD8(u8 taskId) void sub_8128FD8(u8 taskId)
{ {
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
gSprites[sDecor_CameraSpriteObjectIdx1].data[7] = 0; gSprites[sDecor_CameraSpriteObjectIdx1].data[7] = 0;
gTasks[taskId].data[10] = 0; gTasks[taskId].data[10] = 0;
gTasks[taskId].func = sub_8128E18; gTasks[taskId].func = sub_8128E18;
@ -2251,7 +2251,7 @@ void sub_81298EC(u8 taskId)
if (!gPaletteFade.active) { if (!gPaletteFade.active) {
DrawWholeMapView(); DrawWholeMapView();
ScriptContext1_SetupScript(EventScript_275D2E); ScriptContext1_SetupScript(EventScript_275D2E);
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
gTasks[taskId].data[2] = 2; gTasks[taskId].data[2] = 2;
} }
break; break;
@ -2343,7 +2343,7 @@ void sub_8129ABC(u8 taskId)
void sub_8129B34(u8 taskId) void sub_8129B34(u8 taskId)
{ {
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
gSprites[sDecor_CameraSpriteObjectIdx1].data[7] = 0; gSprites[sDecor_CameraSpriteObjectIdx1].data[7] = 0;
gSprites[sDecor_CameraSpriteObjectIdx1].invisible = FALSE; gSprites[sDecor_CameraSpriteObjectIdx1].invisible = FALSE;
gSprites[sDecor_CameraSpriteObjectIdx1].callback = sub_812A36C; gSprites[sDecor_CameraSpriteObjectIdx1].callback = sub_812A36C;
@ -2588,7 +2588,7 @@ void sub_812A0E8(u8 taskId)
void sub_812A1A0(u8 taskId) void sub_812A1A0(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_085A7348); DoYesNoFuncWithChoice(taskId, &gUnknown_085A7348);
} }
@ -2601,13 +2601,13 @@ void sub_812A1C0(u8 taskId)
void sub_812A1F0(u8 taskId) void sub_812A1F0(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_085A7350); DoYesNoFuncWithChoice(taskId, &gUnknown_085A7350);
} }
void sub_812A210(u8 taskId) void sub_812A210(u8 taskId)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
sub_812A22C(taskId); sub_812A22C(taskId);
} }
@ -2671,7 +2671,7 @@ void sub_812A334(void)
u8 taskId; u8 taskId;
pal_fill_black(); pal_fill_black();
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
sub_8126ABC(); sub_8126ABC();
taskId = CreateTask(sub_812A2C4, 8); taskId = CreateTask(sub_812A2C4, 8);
gTasks[taskId].data[2] = 0; gTasks[taskId].data[2] = 0;
@ -2725,7 +2725,7 @@ void sub_812A3D4(u8 taskId)
void sub_812A458(u8 taskId) void sub_812A458(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_085A741C); DoYesNoFuncWithChoice(taskId, &gUnknown_085A741C);
} }

2
src/diploma.c
View File

@ -197,7 +197,7 @@ static void InitDiplomaWindow(void)
InitWindows(sDiplomaWinTemplates); InitWindows(sDiplomaWinTemplates);
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
} }

16
src/easy_chat.c
View File

@ -3697,7 +3697,7 @@ static void sub_811CFCC(void)
return; return;
xOffset = GetStringCenterAlignXOffset(1, titleText, 144); xOffset = GetStringCenterAlignXOffset(1, titleText, 144);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
sub_811D058(0, 1, titleText, xOffset, 1, 0xFF, 0, 2, 3); sub_811D058(0, 1, titleText, xOffset, 1, 0xFF, 0, 2, 3);
PutWindowTilemap(0); PutWindowTilemap(0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
@ -3767,7 +3767,7 @@ static void sub_811D104(u8 arg0)
break; break;
} }
FillWindowPixelBuffer(1, 0x11); FillWindowPixelBuffer(1, PIXEL_FILL(1));
if (text1) if (text1)
sub_811D028(1, 1, text1, 0, 1, 0xFF, 0); sub_811D028(1, 1, text1, 0, 1, 0xFF, 0);
@ -3817,7 +3817,7 @@ static void sub_811D2C8(void)
if (frameId == 7) if (frameId == 7)
var1 = 1; var1 = 1;
FillWindowPixelBuffer(sUnknown_0203A11C->windowId, 0x11); FillWindowPixelBuffer(sUnknown_0203A11C->windowId, PIXEL_FILL(1));
for (i = 0; i < numRows; i++) for (i = 0; i < numRows; i++)
{ {
memcpy(spC, sText_Clear17, sizeof(sText_Clear17)); memcpy(spC, sText_Clear17, sizeof(sText_Clear17));
@ -3957,7 +3957,7 @@ static void sub_811D684(void)
static void sub_811D698(u32 arg0) static void sub_811D698(u32 arg0)
{ {
sub_811DD84(); sub_811DD84();
FillWindowPixelBuffer(2, 0x11); FillWindowPixelBuffer(2, PIXEL_FILL(1));
switch (arg0) switch (arg0)
{ {
case 0: case 0:
@ -4114,14 +4114,14 @@ static void sub_811D950(u8 arg0, u8 arg1)
var1 = 0; var1 = 0;
} }
FillWindowPixelRect(2, 0x11, 0, y, 224, var2); FillWindowPixelRect(2, PIXEL_FILL(1), 0, y, 224, var2);
if (var1) if (var1)
FillWindowPixelRect(2, 0x11, 0, 0, 224, var1); FillWindowPixelRect(2, PIXEL_FILL(1), 0, 0, 224, var1);
} }
static void sub_811D9B4(void) static void sub_811D9B4(void)
{ {
FillWindowPixelBuffer(2, 0x11); FillWindowPixelBuffer(2, PIXEL_FILL(1));
CopyWindowToVram(2, 2); CopyWindowToVram(2, 2);
} }
@ -4791,7 +4791,7 @@ static void sub_811E948(void)
template.paletteNum = 11; template.paletteNum = 11;
template.baseBlock = 0x34; template.baseBlock = 0x34;
windowId = AddWindow(&template); windowId = AddWindow(&template);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
const u8 *str = sFooterTextOptions[footerId][i]; const u8 *str = sFooterTextOptions[footerId][i];

4
src/egg_hatch.c
View File

@ -606,7 +606,7 @@ static void CB2_EggHatch_1(void)
case 1: case 1:
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
FillWindowPixelBuffer(sEggHatchData->windowId, 0); FillWindowPixelBuffer(sEggHatchData->windowId, PIXEL_FILL(0));
sEggHatchData->CB2_PalCounter = 0; sEggHatchData->CB2_PalCounter = 0;
sEggHatchData->CB2_state++; sEggHatchData->CB2_state++;
} }
@ -857,7 +857,7 @@ static void CreateEggShardSprite(u8 x, u8 y, s16 data1, s16 data2, s16 data3, u8
static void EggHatchPrintMessage(u8 windowId, u8* string, u8 x, u8 y, u8 speed) static void EggHatchPrintMessage(u8 windowId, u8* string, u8 x, u8 y, u8 speed)
{ {
FillWindowPixelBuffer(windowId, 0xFF); FillWindowPixelBuffer(windowId, PIXEL_FILL(15));
sEggHatchData->textColor[0] = 0; sEggHatchData->textColor[0] = 0;
sEggHatchData->textColor[1] = 5; sEggHatchData->textColor[1] = 5;
sEggHatchData->textColor[2] = 6; sEggHatchData->textColor[2] = 6;

6
src/field_message_box.c
View File

@ -33,7 +33,7 @@ static void sub_8098154(u8 taskId)
task->data[0]++; task->data[0]++;
break; break;
case 1: case 1:
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
task->data[0]++; task->data[0]++;
break; break;
case 2: case 2:
@ -127,7 +127,7 @@ static void textbox_auto_and_task_add(void)
void HideFieldMessageBox(void) void HideFieldMessageBox(void)
{ {
task_del_textbox(); task_del_textbox();
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
sFieldMessageBoxMode = 0; sFieldMessageBoxMode = 0;
} }
@ -146,7 +146,7 @@ bool8 IsFieldMessageBoxHidden(void)
void sub_8098358(void) void sub_8098358(void)
{ {
task_del_textbox(); task_del_textbox();
NewMenuHelpers_DrawStdWindowFrame(0, 1); DrawStdWindowFrame(0, 1);
sFieldMessageBoxMode = 0; sFieldMessageBoxMode = 0;
} }

10
src/field_player_avatar.c
View File

@ -1918,7 +1918,7 @@ static bool8 Fishing9(struct Task *task)
static bool8 Fishing10(struct Task *task) static bool8 Fishing10(struct Task *task)
{ {
AlignFishingAnimationFrames(); AlignFishingAnimationFrames();
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gText_PokemonOnHook, 1, 0, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_PokemonOnHook, 1, 0, 2, 1, 3);
task->tStep++; task->tStep++;
task->tFrameCounter = 0; task->tFrameCounter = 0;
@ -1944,7 +1944,7 @@ static bool8 Fishing11(struct Task *task)
sub_8155604(gEventObjects[gPlayerAvatar.eventObjectId].fieldEffectSpriteId, 0, 0); sub_8155604(gEventObjects[gPlayerAvatar.eventObjectId].fieldEffectSpriteId, 0, 0);
gSprites[gPlayerAvatar.spriteId].pos2.x = 0; gSprites[gPlayerAvatar.spriteId].pos2.x = 0;
gSprites[gPlayerAvatar.spriteId].pos2.y = 0; gSprites[gPlayerAvatar.spriteId].pos2.y = 0;
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
task->tFrameCounter++; task->tFrameCounter++;
return FALSE; return FALSE;
} }
@ -1966,7 +1966,7 @@ static bool8 Fishing12(struct Task *task)
{ {
AlignFishingAnimationFrames(); AlignFishingAnimationFrames();
StartSpriteAnim(&gSprites[gPlayerAvatar.spriteId], GetFishingNoCatchDirectionAnimNum(GetPlayerFacingDirection())); StartSpriteAnim(&gSprites[gPlayerAvatar.spriteId], GetFishingNoCatchDirectionAnimNum(GetPlayerFacingDirection()));
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gText_NotEvenANibble, 1, 0, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_NotEvenANibble, 1, 0, 2, 1, 3);
task->tStep = FISHING_SHOW_RESULT; task->tStep = FISHING_SHOW_RESULT;
return TRUE; return TRUE;
@ -1977,7 +1977,7 @@ static bool8 Fishing13(struct Task *task)
{ {
AlignFishingAnimationFrames(); AlignFishingAnimationFrames();
StartSpriteAnim(&gSprites[gPlayerAvatar.spriteId], GetFishingNoCatchDirectionAnimNum(GetPlayerFacingDirection())); StartSpriteAnim(&gSprites[gPlayerAvatar.spriteId], GetFishingNoCatchDirectionAnimNum(GetPlayerFacingDirection()));
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gText_ItGotAway, 1, 0, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_ItGotAway, 1, 0, 2, 1, 3);
task->tStep++; task->tStep++;
return TRUE; return TRUE;
@ -2017,7 +2017,7 @@ static bool8 Fishing16(struct Task *task)
gPlayerAvatar.preventStep = FALSE; gPlayerAvatar.preventStep = FALSE;
ScriptContext2_Disable(); ScriptContext2_Disable();
UnfreezeEventObjects(); UnfreezeEventObjects();
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sub_80ED950(0); sub_80ED950(0);
DestroyTask(FindTaskIdByFunc(Task_Fishing)); DestroyTask(FindTaskIdByFunc(Task_Fishing));
} }

8
src/field_region_map.c
View File

@ -139,11 +139,11 @@ static void FieldUpdateRegionMap(void)
sFieldRegionMapHandler->state++; sFieldRegionMapHandler->state++;
break; break;
case 1: case 1:
SetWindowBorderStyle(1, 0, 0x27, 0xd); DrawStdFrameWithCustomTileAndPalette(1, 0, 0x27, 0xd);
offset = GetStringCenterAlignXOffset(1, gText_Hoenn, 0x38); offset = GetStringCenterAlignXOffset(1, gText_Hoenn, 0x38);
AddTextPrinterParameterized(1, 1, gText_Hoenn, offset, 1, 0, NULL); AddTextPrinterParameterized(1, 1, gText_Hoenn, offset, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
SetWindowBorderStyle(0, 0, 0x27, 0xd); DrawStdFrameWithCustomTileAndPalette(0, 0, 0x27, 0xd);
PrintRegionMapSecName(); PrintRegionMapSecName();
BeginNormalPaletteFade(0xFFFFFFFF, 0, 16, 0, 0); BeginNormalPaletteFade(0xFFFFFFFF, 0, 16, 0, 0);
sFieldRegionMapHandler->state++; sFieldRegionMapHandler->state++;
@ -196,13 +196,13 @@ static void PrintRegionMapSecName(void)
{ {
if (sFieldRegionMapHandler->regionMap.iconDrawType != MAPSECTYPE_NONE) if (sFieldRegionMapHandler->regionMap.iconDrawType != MAPSECTYPE_NONE)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized(0, 1, sFieldRegionMapHandler->regionMap.mapSecName, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, sFieldRegionMapHandler->regionMap.mapSecName, 0, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }
else else
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
} }

20
src/field_specials.c
View File

@ -1860,7 +1860,7 @@ void sub_8139B60(void)
void sub_8139C10(void) void sub_8139C10(void)
{ {
sub_8198070(gUnknown_0203AB5E, TRUE); ClearStdWindowAndFrameToTransparent(gUnknown_0203AB5E, TRUE);
RemoveWindow(gUnknown_0203AB5E); RemoveWindow(gUnknown_0203AB5E);
} }
@ -2645,8 +2645,8 @@ static void sub_813A570(u8 taskId)
sub_813A738(taskId); sub_813A738(taskId);
DestroyListMenuTask(task->data[14], NULL, NULL); DestroyListMenuTask(task->data[14], NULL, NULL);
Free(gUnknown_0203AB64); Free(gUnknown_0203AB64);
sub_8198070(task->data[13], 1); ClearStdWindowAndFrameToTransparent(task->data[13], 1);
FillWindowPixelBuffer(task->data[13], 0); FillWindowPixelBuffer(task->data[13], PIXEL_FILL(0));
CopyWindowToVram(task->data[13], 2); CopyWindowToVram(task->data[13], 2);
RemoveWindow(task->data[13]); RemoveWindow(task->data[13]);
DestroyTask(taskId); DestroyTask(taskId);
@ -2890,7 +2890,7 @@ void sub_813A958(void)
void sub_813A988(void) void sub_813A988(void)
{ {
sub_8198070(gUnknown_0203AB6D, TRUE); ClearStdWindowAndFrameToTransparent(gUnknown_0203AB6D, TRUE);
RemoveWindow(gUnknown_0203AB6D); RemoveWindow(gUnknown_0203AB6D);
} }
@ -2942,7 +2942,7 @@ void sub_813AA18(void)
void sub_813AA44(void) void sub_813AA44(void)
{ {
sub_8198070(gUnknown_0203AB6E, TRUE); ClearStdWindowAndFrameToTransparent(gUnknown_0203AB6E, TRUE);
RemoveWindow(gUnknown_0203AB6E); RemoveWindow(gUnknown_0203AB6E);
} }
@ -3001,7 +3001,7 @@ static void sub_813AA60(u16 a0, u16 a1)
if (a0 > 2 && a0 < 7) if (a0 > 2 && a0 < 7)
{ {
FillWindowPixelRect(0, 0x11, 0, 0, 216, 32); FillWindowPixelRect(0, PIXEL_FILL(1), 0, 0, 216, 32);
switch (a0) switch (a0)
{ {
case 3: case 3:
@ -3140,7 +3140,7 @@ static void sub_813AD34(u8 a0, u16 a1)
if (a0 == 9 || a0 == 10) if (a0 == 9 || a0 == 10)
{ {
FillWindowPixelRect(gUnknown_0203AB5E, 0x11, 0, 0, 96, 48); FillWindowPixelRect(gUnknown_0203AB5E, PIXEL_FILL(1), 0, 0, 96, 48);
if (a0 == 10) if (a0 == 10)
{ {
AddTextPrinterParameterized(gUnknown_0203AB5E, 1, gUnknown_085B3254[a1], 0, 1, 0, NULL); AddTextPrinterParameterized(gUnknown_0203AB5E, 1, gUnknown_085B3254[a1], 0, 1, 0, NULL);
@ -3154,7 +3154,7 @@ static void sub_813AD34(u8 a0, u16 a1)
void sub_813ADB8(void) void sub_813ADB8(void)
{ {
sub_8198070(gUnknown_0203AB5E, TRUE); ClearStdWindowAndFrameToTransparent(gUnknown_0203AB5E, TRUE);
RemoveWindow(gUnknown_0203AB5E); RemoveWindow(gUnknown_0203AB5E);
} }
@ -3226,8 +3226,8 @@ void sub_813AF48(void)
struct Task *task = &gTasks[taskId]; struct Task *task = &gTasks[taskId];
DestroyListMenuTask(task->data[14], NULL, NULL); DestroyListMenuTask(task->data[14], NULL, NULL);
Free(gUnknown_0203AB64); Free(gUnknown_0203AB64);
sub_8198070(task->data[13], TRUE); ClearStdWindowAndFrameToTransparent(task->data[13], TRUE);
FillWindowPixelBuffer(task->data[13], 0); FillWindowPixelBuffer(task->data[13], PIXEL_FILL(0));
ClearWindowTilemap(task->data[13]); ClearWindowTilemap(task->data[13]);
CopyWindowToVram(task->data[13], 2); CopyWindowToVram(task->data[13], 2);
RemoveWindow(task->data[13]); RemoveWindow(task->data[13]);

2
src/fldeff_softboiled.c
View File

@ -86,7 +86,7 @@ static void sub_8161724(u8 taskId)
sub_81B0FCC(gUnknown_0203CEC8.unk9, 0); sub_81B0FCC(gUnknown_0203CEC8.unk9, 0);
gUnknown_0203CEC8.unk9 = gUnknown_0203CEC8.unkA; gUnknown_0203CEC8.unk9 = gUnknown_0203CEC8.unkA;
sub_81B0FCC(gUnknown_0203CEC8.unkA, 1); sub_81B0FCC(gUnknown_0203CEC8.unkA, 1);
sub_8198070(0x6, FALSE); ClearStdWindowAndFrameToTransparent(0x6, FALSE);
ClearWindowTilemap(0x6); ClearWindowTilemap(0x6);
display_pokemon_menu_message(0); display_pokemon_menu_message(0);
gTasks[taskId].func = sub_81B1370; gTasks[taskId].func = sub_81B1370;

8
src/frontier_pass.c
View File

@ -1090,7 +1090,7 @@ static void ShowAndPrintWindows(void)
for (i = 0; i < WINDOW_COUNT; i++) for (i = 0; i < WINDOW_COUNT; i++)
{ {
PutWindowTilemap(i); PutWindowTilemap(i);
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
x = GetStringCenterAlignXOffset(1, gText_SymbolsEarned, 96); x = GetStringCenterAlignXOffset(1, gText_SymbolsEarned, 96);
@ -1116,7 +1116,7 @@ static void ShowAndPrintWindows(void)
static void PrintAreaDescription(u8 cursorArea) static void PrintAreaDescription(u8 cursorArea)
{ {
FillWindowPixelBuffer(WINDOW_DESCRIPTION, 0); FillWindowPixelBuffer(WINDOW_DESCRIPTION, PIXEL_FILL(0));
if (cursorArea == CURSOR_AREA_RECORD && !sPassData->hasBattleRecord) if (cursorArea == CURSOR_AREA_RECORD && !sPassData->hasBattleRecord)
AddTextPrinterParameterized3(WINDOW_DESCRIPTION, 1, 2, 0, sTextColors[1], 0, sPassAreaDescriptions[0]); AddTextPrinterParameterized3(WINDOW_DESCRIPTION, 1, 2, 0, sTextColors[1], 0, sPassAreaDescriptions[0]);
else if (cursorArea != CURSOR_AREA_NOTHING) else if (cursorArea != CURSOR_AREA_NOTHING)
@ -1656,7 +1656,7 @@ static void PrintOnFrontierMap(void)
for (i = 0; i < MAP_WINDOW_COUNT; i++) for (i = 0; i < MAP_WINDOW_COUNT; i++)
{ {
PutWindowTilemap(i); PutWindowTilemap(i);
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
for (i = 0; i < NUM_FRONTIER_FACILITIES; i++) for (i = 0; i < NUM_FRONTIER_FACILITIES; i++)
@ -1698,7 +1698,7 @@ static void HandleFrontierMapCursorMove(u8 direction)
StartSpriteAnim(sMapData->mapIndicatorSprite, sMapLandmarks[sMapData->cursorPos].animNum); StartSpriteAnim(sMapData->mapIndicatorSprite, sMapLandmarks[sMapData->cursorPos].animNum);
sMapData->mapIndicatorSprite->pos1.x = sMapLandmarks[sMapData->cursorPos].x; sMapData->mapIndicatorSprite->pos1.x = sMapLandmarks[sMapData->cursorPos].x;
sMapData->mapIndicatorSprite->pos1.y = sMapLandmarks[sMapData->cursorPos].y; sMapData->mapIndicatorSprite->pos1.y = sMapLandmarks[sMapData->cursorPos].y;
FillWindowPixelBuffer(MAP_WINDOW_DESCRIPTION, 0); FillWindowPixelBuffer(MAP_WINDOW_DESCRIPTION, PIXEL_FILL(0));
AddTextPrinterParameterized3(MAP_WINDOW_DESCRIPTION, 1, 4, 0, sTextColors[0], 0, sMapLandmarks[sMapData->cursorPos].description); AddTextPrinterParameterized3(MAP_WINDOW_DESCRIPTION, 1, 4, 0, sTextColors[0], 0, sMapLandmarks[sMapData->cursorPos].description);
for (i = 0; i < 3; i++) for (i = 0; i < 3; i++)

38
src/frontier_util.c
View File

@ -1044,8 +1044,8 @@ static void TowerPrintPrevOrCurrentStreak(u8 battleMode, u8 lvlMode, u8 x1, u8 x
static void ShowTowerResultsWindow(u8 battleMode) static void ShowTowerResultsWindow(u8 battleMode)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
if (battleMode == FRONTIER_MODE_SINGLES) if (battleMode == FRONTIER_MODE_SINGLES)
StringExpandPlaceholders(gStringVar4, gText_SingleBattleRoomResults); StringExpandPlaceholders(gStringVar4, gText_SingleBattleRoomResults);
else if (battleMode == FRONTIER_MODE_DOUBLES) else if (battleMode == FRONTIER_MODE_DOUBLES)
@ -1115,8 +1115,8 @@ static void DomePrintPrevOrCurrentStreak(u8 battleMode, u8 lvlMode, u8 x1, u8 x2
static void ShowDomeResultsWindow(u8 battleMode) static void ShowDomeResultsWindow(u8 battleMode)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
if (battleMode == FRONTIER_MODE_SINGLES) if (battleMode == FRONTIER_MODE_SINGLES)
StringExpandPlaceholders(gStringVar4, gText_SingleBattleTourneyResults); StringExpandPlaceholders(gStringVar4, gText_SingleBattleTourneyResults);
else else
@ -1191,8 +1191,8 @@ static void PalacePrintPrevOrCurrentStreak(u8 battleMode, u8 lvlMode, u8 x1, u8
static void ShowPalaceResultsWindow(u8 battleMode) static void ShowPalaceResultsWindow(u8 battleMode)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
if (battleMode == FRONTIER_MODE_SINGLES) if (battleMode == FRONTIER_MODE_SINGLES)
StringExpandPlaceholders(gStringVar4, gText_SingleBattleHallResults); StringExpandPlaceholders(gStringVar4, gText_SingleBattleHallResults);
else else
@ -1247,8 +1247,8 @@ static void PikePrintPrevOrCurrentStreak(u8 lvlMode, u8 x1, u8 x2, u8 y)
static void ShowPikeResultsWindow(void) static void ShowPikeResultsWindow(void)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
StringExpandPlaceholders(gStringVar4, gText_BattleChoiceResults); StringExpandPlaceholders(gStringVar4, gText_BattleChoiceResults);
PrintAligned(gStringVar4, 0); PrintAligned(gStringVar4, 0);
AddTextPrinterParameterized(gRecordsWindowId, 1, gText_Lv502, 8, 33, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gRecordsWindowId, 1, gText_Lv502, 8, 33, TEXT_SPEED_FF, NULL);
@ -1309,8 +1309,8 @@ static void ArenaPrintPrevOrCurrentStreak(u8 lvlMode, u8 x1, u8 x2, u8 y)
static void ShowArenaResultsWindow(void) static void ShowArenaResultsWindow(void)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
PrintHyphens(10); PrintHyphens(10);
StringExpandPlaceholders(gStringVar4, gText_SetKOTourneyResults); StringExpandPlaceholders(gStringVar4, gText_SetKOTourneyResults);
PrintAligned(gStringVar4, 2); PrintAligned(gStringVar4, 2);
@ -1395,8 +1395,8 @@ static void FactoryPrintPrevOrCurrentStreak(u8 battleMode, u8 lvlMode, u8 x1, u8
static void ShowFactoryResultsWindow(u8 battleMode) static void ShowFactoryResultsWindow(u8 battleMode)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
if (battleMode == FRONTIER_MODE_SINGLES) if (battleMode == FRONTIER_MODE_SINGLES)
StringExpandPlaceholders(gStringVar4, gText_BattleSwapSingleResults); StringExpandPlaceholders(gStringVar4, gText_BattleSwapSingleResults);
else else
@ -1460,8 +1460,8 @@ static void PyramidPrintPrevOrCurrentStreak(u8 lvlMode, u8 x1, u8 x2, u8 y)
static void ShowPyramidResultsWindow(void) static void ShowPyramidResultsWindow(void)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C74); gRecordsWindowId = AddWindow(&gUnknown_08611C74);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
StringExpandPlaceholders(gStringVar4, gText_BattleQuestResults); StringExpandPlaceholders(gStringVar4, gText_BattleQuestResults);
PrintAligned(gStringVar4, 2); PrintAligned(gStringVar4, 2);
AddTextPrinterParameterized(gRecordsWindowId, 1, gText_Lv502, 8, 49, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gRecordsWindowId, 1, gText_Lv502, 8, 49, TEXT_SPEED_FF, NULL);
@ -1483,8 +1483,8 @@ static void ShowLinkContestResultsWindow(void)
s32 x; s32 x;
gRecordsWindowId = AddWindow(&gUnknown_08611C7C); gRecordsWindowId = AddWindow(&gUnknown_08611C7C);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
StringExpandPlaceholders(gStringVar4, gText_LinkContestResults); StringExpandPlaceholders(gStringVar4, gText_LinkContestResults);
x = GetStringCenterAlignXOffset(1, gStringVar4, 208); x = GetStringCenterAlignXOffset(1, gStringVar4, 208);
@ -2353,8 +2353,8 @@ static void PrintHallRecords(s32 hallFacilityId, s32 lvlMode)
void ShowRankingHallRecordsWindow(void) void ShowRankingHallRecordsWindow(void)
{ {
gRecordsWindowId = AddWindow(&gUnknown_08611C84); gRecordsWindowId = AddWindow(&gUnknown_08611C84);
NewMenuHelpers_DrawStdWindowFrame(gRecordsWindowId, FALSE); DrawStdWindowFrame(gRecordsWindowId, FALSE);
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
PrintHallRecords(gSpecialVar_0x8005, FRONTIER_LVL_50); PrintHallRecords(gSpecialVar_0x8005, FRONTIER_LVL_50);
PutWindowTilemap(gRecordsWindowId); PutWindowTilemap(gRecordsWindowId);
CopyWindowToVram(gRecordsWindowId, 3); CopyWindowToVram(gRecordsWindowId, 3);
@ -2362,7 +2362,7 @@ void ShowRankingHallRecordsWindow(void)
void ScrollRankingHallRecordsWindow(void) void ScrollRankingHallRecordsWindow(void)
{ {
FillWindowPixelBuffer(gRecordsWindowId, 0x11); FillWindowPixelBuffer(gRecordsWindowId, PIXEL_FILL(1));
PrintHallRecords(gSpecialVar_0x8005, FRONTIER_LVL_OPEN); PrintHallRecords(gSpecialVar_0x8005, FRONTIER_LVL_OPEN);
CopyWindowToVram(gRecordsWindowId, 2); CopyWindowToVram(gRecordsWindowId, 2);
} }

18
src/hall_of_fame.c
View File

@ -490,7 +490,7 @@ static void Task_Hof_InitTeamSaveData(u8 taskId)
} }
*lastSavedTeam = *sHofMonPtr; *lastSavedTeam = *sHofMonPtr;
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized2(0, 1, gText_SavingDontTurnOffPower, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_SavingDontTurnOffPower, 0, NULL, 2, 1, 3);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = Task_Hof_TrySaveData; gTasks[taskId].func = Task_Hof_TrySaveData;
@ -570,7 +570,7 @@ static void Task_Hof_DisplayMon(u8 taskId)
gSprites[spriteId].tSpecies = currMon->species; gSprites[spriteId].tSpecies = currMon->species;
gSprites[spriteId].callback = SpriteCB_GetOnScreenAndAnimate; gSprites[spriteId].callback = SpriteCB_GetOnScreenAndAnimate;
gTasks[taskId].tMonSpriteId(currMonId) = spriteId; gTasks[taskId].tMonSpriteId(currMonId) = spriteId;
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
gTasks[taskId].func = Task_Hof_PrintMonInfoAfterAnimating; gTasks[taskId].func = Task_Hof_PrintMonInfoAfterAnimating;
} }
@ -649,7 +649,7 @@ static void sub_8173DC0(u8 taskId)
gSprites[gTasks[taskId].tMonSpriteId(i)].oam.priority = 1; gSprites[gTasks[taskId].tMonSpriteId(i)].oam.priority = 1;
} }
BeginNormalPaletteFade(sUnknown_0203BCD4, 0, 12, 12, RGB(16, 29, 24)); BeginNormalPaletteFade(sUnknown_0203BCD4, 0, 12, 12, RGB(16, 29, 24));
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].tFrameCount = 7; gTasks[taskId].tFrameCount = 7;
gTasks[taskId].func = sub_8173EA4; gTasks[taskId].func = sub_8173EA4;
@ -697,7 +697,7 @@ static void Task_Hof_WaitAndPrintPlayerInfo(u8 taskId)
{ {
FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x20, 0x20); FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x20, 0x20);
HallOfFame_PrintPlayerInfo(1, 2); HallOfFame_PrintPlayerInfo(1, 2);
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized2(0, 1, gText_LeagueChamp, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_LeagueChamp, 0, NULL, 2, 1, 3);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = Task_Hof_ExitOnKeyPressed; gTasks[taskId].func = Task_Hof_ExitOnKeyPressed;
@ -1066,7 +1066,7 @@ static void Task_HofPC_HandleExit(u8 taskId)
static void Task_HofPC_PrintDataIsCorrupted(u8 taskId) static void Task_HofPC_PrintDataIsCorrupted(u8 taskId)
{ {
sub_8198180(gText_UnkCtrlF800Exit, 8, TRUE); sub_8198180(gText_UnkCtrlF800Exit, 8, TRUE);
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized2(0, 1, gText_HOFCorrupted, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_HOFCorrupted, 0, NULL, 2, 1, 3);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = Task_HofPC_ExitOnButtonPress; gTasks[taskId].func = Task_HofPC_ExitOnButtonPress;
@ -1086,7 +1086,7 @@ static void Task_HofPC_ExitOnButtonPress(u8 taskId)
static void HallOfFame_PrintWelcomeText(u8 unusedPossiblyWindowId, u8 unused2) static void HallOfFame_PrintWelcomeText(u8 unusedPossiblyWindowId, u8 unused2)
{ {
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
AddTextPrinterParameterized3(0, 1, GetStringCenterAlignXOffset(1, gText_WelcomeToHOF, 0xD0), 1, sUnknown_085E5388, 0, gText_WelcomeToHOF); AddTextPrinterParameterized3(0, 1, GetStringCenterAlignXOffset(1, gText_WelcomeToHOF, 0xD0), 1, sUnknown_085E5388, 0, gText_WelcomeToHOF);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
@ -1099,7 +1099,7 @@ static void HallOfFame_PrintMonInfo(struct HallofFameMon* currMon, u8 unused1, u
s32 dexNumber; s32 dexNumber;
s32 width; s32 width;
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
// dex number // dex number
@ -1180,9 +1180,9 @@ static void HallOfFame_PrintPlayerInfo(u8 unused1, u8 unused2)
u32 width; u32 width;
u16 trainerId; u16 trainerId;
FillWindowPixelBuffer(1, 0x11); FillWindowPixelBuffer(1, PIXEL_FILL(1));
PutWindowTilemap(1); PutWindowTilemap(1);
SetWindowBorderStyle(1, FALSE, 0x21D, 0xD); DrawStdFrameWithCustomTileAndPalette(1, FALSE, 0x21D, 0xD);
AddTextPrinterParameterized3(1, 1, 0, 1, sUnknown_085E538C, -1, gText_Name); AddTextPrinterParameterized3(1, 1, 0, 1, sUnknown_085E538C, -1, gText_Name);
width = GetStringRightAlignXOffset(1, gSaveBlock2Ptr->playerName, 0x70); width = GetStringRightAlignXOffset(1, gSaveBlock2Ptr->playerName, 0x70);

37
src/item_menu.c
View File

@ -884,7 +884,7 @@ void bag_menu_print_description_box_text(int a)
StringExpandPlaceholders(gStringVar4, gText_ReturnToVar1); StringExpandPlaceholders(gStringVar4, gText_ReturnToVar1);
str = gStringVar4; str = gStringVar4;
} }
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, str, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, str, 3, 1, 0, 0, 0, 0);
} }
@ -896,7 +896,7 @@ void bag_menu_print_cursor_(u8 a, u8 b)
void bag_menu_print_cursor(u8 a, u8 b) void bag_menu_print_cursor(u8 a, u8 b)
{ {
if (b == 0xFF) if (b == 0xFF)
FillWindowPixelRect(0, 0, 0, a, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1)); FillWindowPixelRect(0, PIXEL_FILL(0), 0, a, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1));
else else
bag_menu_print(0, 1, gText_SelectorArrow2, 0, a, 0, 0, 0, b); bag_menu_print(0, 1, gText_SelectorArrow2, 0, a, 0, 0, 0, b);
@ -1028,7 +1028,7 @@ void DisplayItemMessage(u8 taskId, u8 fontId, const u8 *str, void ( *callback)(u
s16* data = gTasks[taskId].data; s16* data = gTasks[taskId].data;
data[10] = AddItemMessageWindow(4); data[10] = AddItemMessageWindow(4);
FillWindowPixelBuffer(data[10], 17); FillWindowPixelBuffer(data[10], PIXEL_FILL(1));
DisplayMessageAndContinueTask(taskId, data[10], 10, 13, fontId, GetPlayerTextSpeedDelay(), str, callback); DisplayMessageAndContinueTask(taskId, data[10], 10, 13, fontId, GetPlayerTextSpeedDelay(), str, callback);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }
@ -1293,7 +1293,7 @@ void bag_menu_swap_items(u8 taskId)
gUnknown_0203CE54->unk81A = data[1]; gUnknown_0203CE54->unk81A = data[1];
CopyItemName(BagGetItemIdByPocketPosition(gUnknown_0203CE58.pocket + 1, data[1]), gStringVar1); CopyItemName(BagGetItemIdByPocketPosition(gUnknown_0203CE58.pocket + 1, data[1]), gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_MoveVar1Where); StringExpandPlaceholders(gStringVar4, gText_MoveVar1Where);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
sub_80D4FEC(data[1]); sub_80D4FEC(data[1]);
sub_81AB89C(); sub_81AB89C();
@ -1505,7 +1505,7 @@ void sub_81AC644(u8 unused)
{ {
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_Var1IsSelected); StringExpandPlaceholders(gStringVar4, gText_Var1IsSelected);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
} }
if (gUnknown_0203CE54->unk828 == 1) if (gUnknown_0203CE54->unk828 == 1)
@ -1646,7 +1646,7 @@ void ItemMenu_UseOutOfBattle(u8 taskId)
bag_menu_print_there_is_no_pokemon(taskId); bag_menu_print_there_is_no_pokemon(taskId);
else else
{ {
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
if (gUnknown_0203CE58.pocket != BERRIES_POCKET) if (gUnknown_0203CE58.pocket != BERRIES_POCKET)
ItemId_GetFieldFunc(gSpecialVar_ItemId)(taskId); ItemId_GetFieldFunc(gSpecialVar_ItemId)(taskId);
@ -1670,7 +1670,7 @@ void ItemMenu_Toss(u8 taskId)
{ {
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_TossHowManyVar1s); StringExpandPlaceholders(gStringVar4, gText_TossHowManyVar1s);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
sub_81ABC3C(7); sub_81ABC3C(7);
gTasks[taskId].func = Task_ChooseHowManyToToss; gTasks[taskId].func = Task_ChooseHowManyToToss;
@ -1684,7 +1684,7 @@ void BagMenuConfirmToss(u8 taskId)
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
ConvertIntToDecimalStringN(gStringVar2, data[8], 0, 3); ConvertIntToDecimalStringN(gStringVar2, data[8], 0, 3);
StringExpandPlaceholders(gStringVar4, gText_ConfirmTossItems); StringExpandPlaceholders(gStringVar4, gText_ConfirmTossItems);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
bag_menu_yes_no(taskId, 5, &gUnknown_08614084); bag_menu_yes_no(taskId, 5, &gUnknown_08614084);
} }
@ -1727,7 +1727,7 @@ void BagMenuActuallyToss(u8 taskId)
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
ConvertIntToDecimalStringN(gStringVar2, data[8], 0, 3); ConvertIntToDecimalStringN(gStringVar2, data[8], 0, 3);
StringExpandPlaceholders(gStringVar4, gText_ThrewAwayVar2Var1s); StringExpandPlaceholders(gStringVar4, gText_ThrewAwayVar2Var1s);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
gTasks[taskId].func = Task_ActuallyToss; gTasks[taskId].func = Task_ActuallyToss;
} }
@ -2043,7 +2043,7 @@ void display_deposit_item_ask_str(u8 taskId)
{ {
CopyItemName(gSpecialVar_ItemId, gStringVar1); CopyItemName(gSpecialVar_ItemId, gStringVar1);
StringExpandPlaceholders(gStringVar4, gText_DepositHowManyVar1); StringExpandPlaceholders(gStringVar4, gText_DepositHowManyVar1);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gStringVar4, 3, 1, 0, 0, 0, 0);
sub_81ABC3C(7); sub_81ABC3C(7);
gTasks[taskId].func = sub_81ADA7C; gTasks[taskId].func = sub_81ADA7C;
@ -2078,7 +2078,7 @@ void sub_81ADB14(u8 taskId)
{ {
s16* data = gTasks[taskId].data; s16* data = gTasks[taskId].data;
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
if (ItemId_GetImportance(gSpecialVar_ItemId)) if (ItemId_GetImportance(gSpecialVar_ItemId))
{ {
bag_menu_print(1, 1, gText_CantStoreImportantItems, 3, 1, 0, 0, 0, 0); bag_menu_print(1, 1, gText_CantStoreImportantItems, 3, 1, 0, 0, 0, 0);
@ -2244,7 +2244,7 @@ void bag_menu_print_pocket_names(const u8 *pocketName1, const u8 *pocketName2)
window.width = 16; window.width = 16;
window.height = 2; window.height = 2;
windowId = AddWindow(&window); windowId = AddWindow(&window);
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
offset = GetStringCenterAlignXOffset(1, pocketName1, 0x40); offset = GetStringCenterAlignXOffset(1, pocketName1, 0x40);
bag_menu_print(windowId, 1, pocketName1, offset, 1, 0, 0, -1, 1); bag_menu_print(windowId, 1, pocketName1, offset, 1, 0, 0, -1, 1);
if (pocketName2) if (pocketName2)
@ -2283,7 +2283,7 @@ void setup_bag_menu_textboxes(void)
LoadPalette(&gUnknown_0860F074, 0xF0, 0x20); LoadPalette(&gUnknown_0860F074, 0xF0, 0x20);
for (i = 0; i < 3; i++) for (i = 0; i < 3; i++)
{ {
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
PutWindowTilemap(i); PutWindowTilemap(i);
} }
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -2306,7 +2306,7 @@ u8 bag_menu_add_window(u8 a)
if (*ptr == 0xFF) if (*ptr == 0xFF)
{ {
*ptr = AddWindow(&gUnknown_086141AC[a]); *ptr = AddWindow(&gUnknown_086141AC[a]);
SetWindowBorderStyle(*ptr, 0, 1, 14); DrawStdFrameWithCustomTileAndPalette(*ptr, 0, 1, 14);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
} }
return *ptr; return *ptr;
@ -2317,7 +2317,7 @@ void bag_menu_remove_window(u8 a)
u8 *ptr = &gUnknown_0203CE54->windowPointers[a]; u8 *ptr = &gUnknown_0203CE54->windowPointers[a];
if (*ptr != 0xFF) if (*ptr != 0xFF)
{ {
sub_8198070(*ptr, 0); ClearStdWindowAndFrameToTransparent(*ptr, 0);
ClearWindowTilemap(*ptr); ClearWindowTilemap(*ptr);
RemoveWindow(*ptr); RemoveWindow(*ptr);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
@ -2338,7 +2338,8 @@ void bag_menu_RemoveBagItem_message_window(u8 a)
u8 *ptr = &gUnknown_0203CE54->windowPointers[a]; u8 *ptr = &gUnknown_0203CE54->windowPointers[a];
if (*ptr != 0xFF) if (*ptr != 0xFF)
{ {
sub_8197DF8(*ptr, 0); ClearDialogWindowAndFrameToTransparent(*ptr, FALSE);
// This ClearWindowTilemap call is redundant, since ClearDialogWindowAndFrameToTransparent already calls it.
ClearWindowTilemap(*ptr); ClearWindowTilemap(*ptr);
RemoveWindow(*ptr); RemoveWindow(*ptr);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
@ -2366,7 +2367,7 @@ void bag_menu_remove_money_window(void)
void bag_menu_prepare_tmhm_move_window(void) void bag_menu_prepare_tmhm_move_window(void)
{ {
FillWindowPixelBuffer(3, 0); FillWindowPixelBuffer(3, PIXEL_FILL(0));
blit_move_info_icon(3, 19, 0, 0); blit_move_info_icon(3, 19, 0, 0);
blit_move_info_icon(3, 20, 0, 12); blit_move_info_icon(3, 20, 0, 12);
blit_move_info_icon(3, 21, 0, 24); blit_move_info_icon(3, 21, 0, 24);
@ -2380,7 +2381,7 @@ void PrintTMHMMoveData(u16 itemId)
u16 moveId; u16 moveId;
const u8* text; const u8* text;
FillWindowPixelBuffer(4, 0); FillWindowPixelBuffer(4, PIXEL_FILL(0));
if (itemId == ITEM_NONE) if (itemId == ITEM_NONE)
{ {
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)

4
src/item_use.c
View File

@ -188,7 +188,7 @@ void DisplayCannotDismountBikeMessage(u8 taskId, bool8 isUsingRegisteredKeyItemO
void CleanUpAfterFailingToUseRegisteredKeyItemOnField(u8 taskId) void CleanUpAfterFailingToUseRegisteredKeyItemOnField(u8 taskId)
{ {
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
DestroyTask(taskId); DestroyTask(taskId);
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
ScriptContext2_Disable(); ScriptContext2_Disable();
@ -350,7 +350,7 @@ void sub_80FD504(u8 taskId)
void sub_80FD5CC(u8 taskId) void sub_80FD5CC(u8 taskId)
{ {
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
ScriptContext2_Disable(); ScriptContext2_Disable();
DestroyTask(taskId); DestroyTask(taskId);

6
src/learn_move.c
View File

@ -498,7 +498,7 @@ static void LearnMoveMain(void)
case 27: case 27:
if (!sub_81D2C3C()) if (!sub_81D2C3C())
{ {
FillWindowPixelBuffer(3, 0x11); FillWindowPixelBuffer(3, PIXEL_FILL(1));
if (sLearnMoveStruct2.showContestInfo == FALSE) if (sLearnMoveStruct2.showContestInfo == FALSE)
{ {
sLearnMoveStruct->state = 3; sLearnMoveStruct->state = 3;
@ -631,7 +631,7 @@ static void HideSpritesAndPrintTeachText(bool8 a)
if (!a) if (!a)
{ {
StringExpandPlaceholders(gStringVar4, gText_TeachWhichMoveToPkmn); StringExpandPlaceholders(gStringVar4, gText_TeachWhichMoveToPkmn);
FillWindowPixelBuffer(3, 0x11); FillWindowPixelBuffer(3, PIXEL_FILL(1));
AddTextPrinterParameterized(3, 1, gStringVar4, 0, 1, 0, NULL); AddTextPrinterParameterized(3, 1, gStringVar4, 0, 1, 0, NULL);
} }
} }
@ -695,7 +695,7 @@ static void ShowTeachMoveText(bool8 showContest)
if (showContest == FALSE) if (showContest == FALSE)
{ {
StringExpandPlaceholders(gStringVar4, gText_TeachWhichMoveToPkmn); StringExpandPlaceholders(gStringVar4, gText_TeachWhichMoveToPkmn);
FillWindowPixelBuffer(3, 0x11); FillWindowPixelBuffer(3, PIXEL_FILL(1));
AddTextPrinterParameterized(3, 1, gStringVar4, 0, 1, 0, NULL); AddTextPrinterParameterized(3, 1, gStringVar4, 0, 1, 0, NULL);
} }
} }

8
src/link.c
View File

@ -1685,8 +1685,8 @@ static void sub_800B080(void)
CopyToBgTilemapBuffer(1, gWirelessLinkDisplayTilemap, 0, 0); CopyToBgTilemapBuffer(1, gWirelessLinkDisplayTilemap, 0, 0);
CopyBgTilemapBufferToVram(1); CopyBgTilemapBufferToVram(1);
LoadPalette(gWirelessLinkDisplayPal, 0, 0x20); LoadPalette(gWirelessLinkDisplayPal, 0, 0x20);
FillWindowPixelBuffer(0, 0x00); FillWindowPixelBuffer(0, PIXEL_FILL(0));
FillWindowPixelBuffer(2, 0x00); FillWindowPixelBuffer(2, PIXEL_FILL(0));
AddTextPrinterParameterized3(0, 3, 2, 6, gUnknown_082ED224, 0, gText_CommErrorEllipsis); AddTextPrinterParameterized3(0, 3, 2, 6, gUnknown_082ED224, 0, gText_CommErrorEllipsis);
AddTextPrinterParameterized3(2, 3, 2, 1, gUnknown_082ED224, 0, gText_MoveCloserToLinkPartner); AddTextPrinterParameterized3(2, 3, 2, 1, gUnknown_082ED224, 0, gText_MoveCloserToLinkPartner);
PutWindowTilemap(0); PutWindowTilemap(0);
@ -1698,8 +1698,8 @@ static void sub_800B080(void)
static void sub_800B138(void) static void sub_800B138(void)
{ {
LoadBgTiles(0, g2BlankTilesGfx, 0x20, 0); LoadBgTiles(0, g2BlankTilesGfx, 0x20, 0);
FillWindowPixelBuffer(1, 0x00); FillWindowPixelBuffer(1, PIXEL_FILL(0));
FillWindowPixelBuffer(2, 0x00); FillWindowPixelBuffer(2, PIXEL_FILL(0));
AddTextPrinterParameterized3(1, 3, 2, 0, gUnknown_082ED224, 0, gText_CommErrorCheckConnections); AddTextPrinterParameterized3(1, 3, 2, 0, gUnknown_082ED224, 0, gText_CommErrorCheckConnections);
PutWindowTilemap(1); PutWindowTilemap(1);
PutWindowTilemap(2); PutWindowTilemap(2);

20
src/list_menu.c
View File

@ -355,11 +355,11 @@ s32 DoMysteryGiftListMenu(struct WindowTemplate *windowTemplate, struct ListMenu
switch (arg2) switch (arg2)
{ {
case 0: // can never be reached, because of the if statement above case 0: // can never be reached, because of the if statement above
sub_819746C(sMysteryGiftLinkMenu.windowId, FALSE); ClearStdWindowAndFrame(sMysteryGiftLinkMenu.windowId, FALSE);
break; break;
case 2: case 2:
case 1: case 1:
sub_819746C(sMysteryGiftLinkMenu.windowId, FALSE); ClearStdWindowAndFrame(sMysteryGiftLinkMenu.windowId, FALSE);
break; break;
} }
} }
@ -486,7 +486,7 @@ void RedrawListMenu(u8 listTaskId)
{ {
struct ListMenu *list = (void*) gTasks[listTaskId].data; struct ListMenu *list = (void*) gTasks[listTaskId].data;
FillWindowPixelBuffer(list->template.windowId, (list->template.fillValue << 4) | (list->template.fillValue)); FillWindowPixelBuffer(list->template.windowId, PIXEL_FILL(list->template.fillValue));
ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed); ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed);
ListMenuDrawCursor(list); ListMenuDrawCursor(list);
CopyWindowToVram(list->template.windowId, 2); CopyWindowToVram(list->template.windowId, 2);
@ -584,7 +584,7 @@ static u8 ListMenuInitInternal(struct ListMenuTemplate *listMenuTemplate, u16 sc
if (list->template.totalItems < list->template.maxShowed) if (list->template.totalItems < list->template.maxShowed)
list->template.maxShowed = list->template.totalItems; list->template.maxShowed = list->template.totalItems;
FillWindowPixelBuffer(list->template.windowId, (list->template.fillValue << 4) | (list->template.fillValue)); FillWindowPixelBuffer(list->template.windowId, PIXEL_FILL(list->template.fillValue));
ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed); ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed);
ListMenuDrawCursor(list); ListMenuDrawCursor(list);
ListMenuCallSelectionChangedCallback(list, TRUE); ListMenuCallSelectionChangedCallback(list, TRUE);
@ -698,7 +698,7 @@ static void ListMenuErasePrintedCursor(struct ListMenu *list, u16 selectedRow)
u8 width = GetMenuCursorDimensionByFont(list->template.fontId, 0); u8 width = GetMenuCursorDimensionByFont(list->template.fontId, 0);
u8 height = GetMenuCursorDimensionByFont(list->template.fontId, 1); u8 height = GetMenuCursorDimensionByFont(list->template.fontId, 1);
FillWindowPixelRect(list->template.windowId, FillWindowPixelRect(list->template.windowId,
(list->template.fillValue << 4) | (list->template.fillValue), PIXEL_FILL(list->template.fillValue),
list->template.cursor_X, list->template.cursor_X,
selectedRow * yMultiplier + list->template.upText_Y, selectedRow * yMultiplier + list->template.upText_Y,
width, width,
@ -795,7 +795,7 @@ static void ListMenuScroll(struct ListMenu *list, u8 count, bool8 movingDown)
{ {
if (count >= list->template.maxShowed) if (count >= list->template.maxShowed)
{ {
FillWindowPixelBuffer(list->template.windowId, (list->template.fillValue << 4) | (list->template.fillValue)); FillWindowPixelBuffer(list->template.windowId, PIXEL_FILL(list->template.fillValue));
ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed); ListMenuPrintEntries(list, list->scrollOffset, 0, list->template.maxShowed);
} }
else else
@ -806,26 +806,26 @@ static void ListMenuScroll(struct ListMenu *list, u8 count, bool8 movingDown)
{ {
u16 y, width, height; u16 y, width, height;
ScrollWindow(list->template.windowId, 1, count * yMultiplier, (list->template.fillValue << 4) | (list->template.fillValue)); ScrollWindow(list->template.windowId, 1, count * yMultiplier, PIXEL_FILL(list->template.fillValue));
ListMenuPrintEntries(list, list->scrollOffset, 0, count); ListMenuPrintEntries(list, list->scrollOffset, 0, count);
y = (list->template.maxShowed * yMultiplier) + list->template.upText_Y; y = (list->template.maxShowed * yMultiplier) + list->template.upText_Y;
width = GetWindowAttribute(list->template.windowId, WINDOW_WIDTH) * 8; width = GetWindowAttribute(list->template.windowId, WINDOW_WIDTH) * 8;
height = (GetWindowAttribute(list->template.windowId, WINDOW_HEIGHT) * 8) - y; height = (GetWindowAttribute(list->template.windowId, WINDOW_HEIGHT) * 8) - y;
FillWindowPixelRect(list->template.windowId, FillWindowPixelRect(list->template.windowId,
(list->template.fillValue << 4) | (list->template.fillValue), PIXEL_FILL(list->template.fillValue),
0, y, width, height); 0, y, width, height);
} }
else else
{ {
u16 width; u16 width;
ScrollWindow(list->template.windowId, 0, count * yMultiplier, (list->template.fillValue << 4) | (list->template.fillValue)); ScrollWindow(list->template.windowId, 0, count * yMultiplier, PIXEL_FILL(list->template.fillValue));
ListMenuPrintEntries(list, list->scrollOffset + (list->template.maxShowed - count), list->template.maxShowed - count, count); ListMenuPrintEntries(list, list->scrollOffset + (list->template.maxShowed - count), list->template.maxShowed - count, count);
width = GetWindowAttribute(list->template.windowId, WINDOW_WIDTH) * 8; width = GetWindowAttribute(list->template.windowId, WINDOW_WIDTH) * 8;
FillWindowPixelRect(list->template.windowId, FillWindowPixelRect(list->template.windowId,
(list->template.fillValue << 4) | (list->template.fillValue), PIXEL_FILL(list->template.fillValue),
0, 0, width, list->template.upText_Y); 0, 0, width, list->template.upText_Y);
} }
} }

4
src/mail.c
View File

@ -477,8 +477,8 @@ static void sub_8121B1C(void)
y = 0; y = 0;
PutWindowTilemap(0); PutWindowTilemap(0);
PutWindowTilemap(1); PutWindowTilemap(1);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
for (i = 0; i < sMailRead->layout->numSubStructs; i ++) for (i = 0; i < sMailRead->layout->numSubStructs; i ++)
{ {
if (sMailRead->strbuf[i][0] == EOS || sMailRead->strbuf[i][0] == CHAR_SPACE) if (sMailRead->strbuf[i][0] == EOS || sMailRead->strbuf[i][0] == CHAR_SPACE)

217
src/main_menu.c
View File

@ -39,6 +39,135 @@
#include "title_screen.h" #include "title_screen.h"
#include "window.h" #include "window.h"
/*
* Main menu state machine
* -----------------------
*
* Entry point: CB2_InitMainMenu
*
* Note: States advance sequentially unless otherwise stated.
*
* CB2_InitMainMenu / CB2_ReinitMainMenu
* - Both of these states call InitMainMenu, which does all the work.
* - In the Reinit case, the init code will check if the user came from
* the options screen. If they did, then the options menu item is
* pre-selected.
*
* Task_MainMenuCheckSaveFile
* - Determines how many menu options to show based on whether
* the save file is Ok, empty, corrupted, etc.
* - If there was an error loading the save file, advance to
* Task_WaitForSaveFileErrorWindow.
* - If there were no errors, advance to Task_MainMenuCheckBattery.
* - Note that the check to enable Mystery Events would normally happen
* here, but this version of Emerald has them disabled.
*
* Task_WaitForSaveFileErrorWindow
* - Wait for the text to finish printing and then for the A button
* to be pressed.
*
* Task_MainMenuCheckBattery
* - If the battery is OK, advance to Task_DisplayMainMenu.
* - If the battery is dry, advance to Task_WaitForBatteryDryErrorWindow.
*
* Task_WaitForBatteryDryErrorWindow
* - Wait for the text to finish printing and then for the A button
* to be pressed.
*
* Task_DisplayMainWindow
* - Display the buttons to the user. If the menu is in HAS_MYSTERY_EVENTS
* mode, there are too many buttons for one screen and a scrollbar is added,
* and the scrollbar task is spawned (Task_ScrollIndicatorArrowPairOnMainMenu).
*
* Task_HighlightSelectedMainMenuItem
* - Update the UI to match the currently selected item.
*
* Task_HandleMainMenuInput
* - If A is pressed, advance to Task_HandleMainMenuAPressed.
* - If B is pressed, return to the title screen via CB2_InitTitleScreen.
* - If Up or Down is pressed, handle scrolling if there is a scroll bar, change
* the selection, then go back to Task_HighlightSelectedMainMenuItem.
*
* Task_HandleMainMenuAPressed
* - If the user selected New Game, advance to Task_NewGameBirchSpeech_Init.
* - If the user selected Continue, advance to CB2_ContinueSavedGame.
* - If the user selected the Options menu, advance to CB2_InitOptionMenu.
* - If the user selected Mystery Gift, advance to CB2_MysteryGift. However,
* if the wireless adapter was removed, instead advance to
* Task_DisplayMainMenuInvalidActionError.
* - Code to start a Mystery Event is present here, but is unreachable in this
* version.
*
* Task_HandleMainMenuBPressed
* - Clean up the main menu and go back to CB2_InitTitleScreen.
*
* Task_DisplayMainMenuInvalidActionError
* - Print one of three different error messages, wait for the text to stop
* printing, and then wait for A or B to be pressed.
* - Then advance to Task_HandleMainMenuBPressed.
*
* Task_NewGameBirchSpeechInit
* - Load the sprites for the intro speech, start playing music
* Task_NewGameBirchSpeech_WaitToShowBirch
* - Spawn Task_NewGameBirchSpeech_FadeInTarget1OutTarget2
* - Spawn Task_NewGameBirchSpeech_FadePlatformOut
* - Both of these tasks destroy themselves when done.
* Task_NewGameBirchSpeech_WaitForSpriteFadeInWelcome
* Task_NewGameBirchSpeech_ThisIsAPokemon
* - When the text is done printing, spawns Task_NewGameBirchSpeechSub_InitPokeball
* Task_NewGameBirchSpeech_MainSpeech
* Task_NewGameBirchSpeech_AndYouAre
* Task_NewGameBirchSpeech_StartBirchLotadPlatformFade
* Task_NewGameBirchSpeech_StartBirchLotadPlatformFade
* Task_NewGameBirchSpeech_SlidePlatformAway
* Task_NewGameBirchSpeech_StartPlayerFadeIn
* Task_NewGameBirchSpeech_WaitForPlayerFadeIn
* Task_NewGameBirchSpeech_BoyOrGirl
* Task_NewGameBirchSpeech_WaitToShowGenderMenu
* Task_NewGameBirchSpeech_ChooseGender
* - Animates by advancing to Task_NewGameBirchSpeech_SlideOutOldGenderSprite
* whenever the player's selection changes.
* - Advances to Task_NewGameBirchSpeech_WhatsYourName when done.
*
* Task_NewGameBirchSpeech_SlideOutOldGenderSprite
* Task_NewGameBirchSpeech_SlideInNewGenderSprite
* - Returns back to Task_NewGameBirchSpeech_ChooseGender.
*
* Task_NewGameBirchSpeech_WhatsYourName
* Task_NewGameBirchSpeech_WaitForWhatsYourNameToPrint
* Task_NewGameBirchSpeech_WaitPressBeforeNameChoice
* Task_NewGameBirchSpeech_StartNamingScreen
* C2_NamingScreen
* - Returns to CB2_NewGameBirchSpeech_ReturnFromNamingScreen when done
* CB2_NewGameBirchSpeech_ReturnFromNamingScreen
* Task_NewGameBirchSpeech_ReturnFromNamingScreenShowTextbox
* Task_NewGameBirchSpeech_SoItsPlayerName
* Task_NewGameBirchSpeech_CreateNameYesNo
* Task_NewGameBirchSpeech_ProcessNameYesNoMenu
* - If confirmed, advance to Task_NewGameBirchSpeech_SlidePlatformAway2.
* - Otherwise, return to Task_NewGameBirchSpeech_BoyOrGirl.
*
* Task_NewGameBirchSpeech_SlidePlatformAway2
* Task_NewGameBirchSpeech_ReshowBirchLotad
* Task_NewGameBirchSpeech_WaitForSpriteFadeInAndTextPrinter
* Task_NewGameBirchSpeech_AreYouReady
* Task_NewGameBirchSpeech_ShrinkPlayer
* Task_NewGameBirchSpeech_WaitForPlayerShrink
* Task_NewGameBirchSpeech_FadePlayerToWhite
* Task_NewGameBirchSpeech_Cleanup
* - Advances to CB2_NewGame.
*
* Task_NewGameBirchSpeechSub_InitPokeball
* - Advances to Task_NewGameBirchSpeechSub_WaitForLotad
* Task_NewGameBirchSpeechSub_WaitForLotad
* - Destroys itself when done.
*/
// These two defines are used with the sCurrItemAndOptionsMenuCheck,
// to distinguish between its two parts.
#define OPTION_MENU_FLAG 0x8000
#define CURRENT_ITEM_MASK 0x7FFF
// Static type declarations // Static type declarations
// Static RAM declarations // Static RAM declarations
@ -112,7 +241,7 @@ static void SpriteCB_MovePlayerDownWhileShrinking(struct Sprite*);
static void Task_NewGameBirchSpeech_WaitForPlayerShrink(u8); static void Task_NewGameBirchSpeech_WaitForPlayerShrink(u8);
static void Task_NewGameBirchSpeech_FadePlayerToWhite(u8); static void Task_NewGameBirchSpeech_FadePlayerToWhite(u8);
static void Task_NewGameBirchSpeech_Cleanup(u8); static void Task_NewGameBirchSpeech_Cleanup(u8);
static void nullsub_11(); static void SpriteCB_Null();
static void Task_NewGameBirchSpeech_ReturnFromNamingScreenShowTextbox(u8); static void Task_NewGameBirchSpeech_ReturnFromNamingScreenShowTextbox(u8);
static void MainMenu_FormatSavegamePlayer(void); static void MainMenu_FormatSavegamePlayer(void);
static void MainMenu_FormatSavegamePokedex(void); static void MainMenu_FormatSavegamePokedex(void);
@ -247,7 +376,7 @@ static const struct WindowTemplate sWindowTemplates_MainMenu[] =
DUMMY_WIN_TEMPLATE DUMMY_WIN_TEMPLATE
}; };
static const struct WindowTemplate gUnknown_082FF080[] = static const struct WindowTemplate gNewGameBirchSpeechTextWindows[] =
{ {
{ {
.bg = 0, .bg = 0,
@ -542,7 +671,7 @@ static void Task_MainMenuCheckSaveFile(u8 taskId)
gTasks[taskId].func = Task_WaitForSaveFileErrorWindow; gTasks[taskId].func = Task_WaitForSaveFileErrorWindow;
break; break;
} }
if (sCurrItemAndOptionMenuCheck & 0x8000) // are we returning from the options menu? if (sCurrItemAndOptionMenuCheck & OPTION_MENU_FLAG) // are we returning from the options menu?
{ {
switch (tMenuType) // if so, highlight the OPTIONS item switch (tMenuType) // if so, highlight the OPTIONS item
{ {
@ -558,7 +687,7 @@ static void Task_MainMenuCheckSaveFile(u8 taskId)
break; break;
} }
} }
sCurrItemAndOptionMenuCheck &= 0x7FFF; // turn off the "returning from options menu" flag sCurrItemAndOptionMenuCheck &= CURRENT_ITEM_MASK; // turn off the "returning from options menu" flag
tCurrItem = sCurrItemAndOptionMenuCheck; tCurrItem = sCurrItemAndOptionMenuCheck;
tItemCount = tMenuType + 2; tItemCount = tMenuType + 2;
} }
@ -637,6 +766,8 @@ static void Task_DisplayMainMenu(u8 taskId)
palette = RGB(26, 26, 25); palette = RGB(26, 26, 25);
LoadPalette(&palette, 252, 2); LoadPalette(&palette, 252, 2);
// Note: If there is no save file, the save block is zeroed out,
// so the default gender is MALE.
if (gSaveBlock2Ptr->playerGender == MALE) if (gSaveBlock2Ptr->playerGender == MALE)
{ {
palette = RGB(4, 16, 31); palette = RGB(4, 16, 31);
@ -652,8 +783,8 @@ static void Task_DisplayMainMenu(u8 taskId)
{ {
case HAS_NO_SAVED_GAME: case HAS_NO_SAVED_GAME:
default: default:
FillWindowPixelBuffer(0, 0xAA); FillWindowPixelBuffer(0, PIXEL_FILL(0xA));
FillWindowPixelBuffer(1, 0xAA); FillWindowPixelBuffer(1, PIXEL_FILL(0xA));
AddTextPrinterParameterized3(0, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame); AddTextPrinterParameterized3(0, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame);
AddTextPrinterParameterized3(1, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuOption); AddTextPrinterParameterized3(1, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuOption);
PutWindowTilemap(0); PutWindowTilemap(0);
@ -664,9 +795,9 @@ static void Task_DisplayMainMenu(u8 taskId)
DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[1], MAIN_MENU_BORDER_TILE); DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[1], MAIN_MENU_BORDER_TILE);
break; break;
case HAS_SAVED_GAME: case HAS_SAVED_GAME:
FillWindowPixelBuffer(2, 0xAA); FillWindowPixelBuffer(2, PIXEL_FILL(0xA));
FillWindowPixelBuffer(3, 0xAA); FillWindowPixelBuffer(3, PIXEL_FILL(0xA));
FillWindowPixelBuffer(4, 0xAA); FillWindowPixelBuffer(4, PIXEL_FILL(0xA));
AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue); AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue);
AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame); AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame);
AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuOption); AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuOption);
@ -682,10 +813,10 @@ static void Task_DisplayMainMenu(u8 taskId)
DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[4], MAIN_MENU_BORDER_TILE); DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[4], MAIN_MENU_BORDER_TILE);
break; break;
case HAS_MYSTERY_GIFT: case HAS_MYSTERY_GIFT:
FillWindowPixelBuffer(2, 0xAA); FillWindowPixelBuffer(2, PIXEL_FILL(0xA));
FillWindowPixelBuffer(3, 0xAA); FillWindowPixelBuffer(3, PIXEL_FILL(0xA));
FillWindowPixelBuffer(4, 0xAA); FillWindowPixelBuffer(4, PIXEL_FILL(0xA));
FillWindowPixelBuffer(5, 0xAA); FillWindowPixelBuffer(5, PIXEL_FILL(0xA));
AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue); AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue);
AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame); AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame);
AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuMysteryGift); AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuMysteryGift);
@ -705,11 +836,11 @@ static void Task_DisplayMainMenu(u8 taskId)
DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[5], MAIN_MENU_BORDER_TILE); DrawMainMenuWindowBorder(&sWindowTemplates_MainMenu[5], MAIN_MENU_BORDER_TILE);
break; break;
case HAS_MYSTERY_EVENTS: case HAS_MYSTERY_EVENTS:
FillWindowPixelBuffer(2, 0xAA); FillWindowPixelBuffer(2, PIXEL_FILL(0xA));
FillWindowPixelBuffer(3, 0xAA); FillWindowPixelBuffer(3, PIXEL_FILL(0xA));
FillWindowPixelBuffer(4, 0xAA); FillWindowPixelBuffer(4, PIXEL_FILL(0xA));
FillWindowPixelBuffer(5, 0xAA); FillWindowPixelBuffer(5, PIXEL_FILL(0xA));
FillWindowPixelBuffer(6, 0xAA); FillWindowPixelBuffer(6, PIXEL_FILL(0xA));
AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue); AddTextPrinterParameterized3(2, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuContinue);
AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame); AddTextPrinterParameterized3(3, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuNewGame);
AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuMysteryGift2); AddTextPrinterParameterized3(4, 1, 0, 1, sTextColor_Headers, -1, gText_MainMenuMysteryGift2);
@ -813,14 +944,14 @@ static void Task_HandleMainMenuAPressed(u8 taskId)
{ {
if (gTasks[taskId].tMenuType == HAS_MYSTERY_EVENTS) if (gTasks[taskId].tMenuType == HAS_MYSTERY_EVENTS)
RemoveScrollIndicatorArrowPair(gTasks[taskId].tScrollArrowTaskId); RemoveScrollIndicatorArrowPair(gTasks[taskId].tScrollArrowTaskId);
sub_819746C(0, 1); ClearStdWindowAndFrame(0, TRUE);
sub_819746C(1, 1); ClearStdWindowAndFrame(1, TRUE);
sub_819746C(2, 1); ClearStdWindowAndFrame(2, TRUE);
sub_819746C(3, 1); ClearStdWindowAndFrame(3, TRUE);
sub_819746C(4, 1); ClearStdWindowAndFrame(4, TRUE);
sub_819746C(5, 1); ClearStdWindowAndFrame(5, TRUE);
sub_819746C(6, 1); ClearStdWindowAndFrame(6, TRUE);
sub_819746C(7, 1); ClearStdWindowAndFrame(7, TRUE);
wirelessAdapterConnected = IsWirelessAdapterConnected(); wirelessAdapterConnected = IsWirelessAdapterConnected();
switch (gTasks[taskId].tMenuType) switch (gTasks[taskId].tMenuType)
{ {
@ -973,7 +1104,7 @@ static void Task_HandleMainMenuAPressed(u8 taskId)
if (action != ACTION_OPTION) if (action != ACTION_OPTION)
sCurrItemAndOptionMenuCheck = 0; sCurrItemAndOptionMenuCheck = 0;
else else
sCurrItemAndOptionMenuCheck |= 0x8000; // entering the options menu sCurrItemAndOptionMenuCheck |= OPTION_MENU_FLAG; // entering the options menu
} }
} }
@ -981,7 +1112,7 @@ static void Task_HandleMainMenuBPressed(u8 taskId)
{ {
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
if (gTasks[taskId].tMenuType == 3) if (gTasks[taskId].tMenuType == HAS_MYSTERY_EVENTS)
RemoveScrollIndicatorArrowPair(gTasks[taskId].tScrollArrowTaskId); RemoveScrollIndicatorArrowPair(gTasks[taskId].tScrollArrowTaskId);
sCurrItemAndOptionMenuCheck = 0; sCurrItemAndOptionMenuCheck = 0;
FreeAllWindowBuffers(); FreeAllWindowBuffers();
@ -1199,7 +1330,7 @@ static void Task_NewGameBirchSpeech_WaitForSpriteFadeInWelcome(u8 taskId)
} }
else else
{ {
InitWindows(gUnknown_082FF080); InitWindows(gNewGameBirchSpeechTextWindows);
LoadMainMenuWindowFrameTiles(0, 0xF3); LoadMainMenuWindowFrameTiles(0, 0xF3);
LoadMessageBoxGfx(0, 0xFC, 0xF0); LoadMessageBoxGfx(0, 0xFC, 0xF0);
NewGameBirchSpeech_ShowDialogueWindow(0, 1); NewGameBirchSpeech_ShowDialogueWindow(0, 1);
@ -1642,7 +1773,7 @@ static void Task_NewGameBirchSpeech_FadePlayerToWhite(u8 taskId)
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
spriteId = gTasks[taskId].tPlayerSpriteId; spriteId = gTasks[taskId].tPlayerSpriteId;
gSprites[spriteId].callback = nullsub_11; gSprites[spriteId].callback = SpriteCB_Null;
SetGpuReg(REG_OFFSET_DISPCNT, DISPCNT_OBJ_ON | DISPCNT_OBJ_1D_MAP); SetGpuReg(REG_OFFSET_DISPCNT, DISPCNT_OBJ_ON | DISPCNT_OBJ_1D_MAP);
BeginNormalPaletteFade(0xFFFF0000, 0, 0, 16, RGB_WHITEALPHA); BeginNormalPaletteFade(0xFFFF0000, 0, 0, 16, RGB_WHITEALPHA);
gTasks[taskId].func = Task_NewGameBirchSpeech_Cleanup; gTasks[taskId].func = Task_NewGameBirchSpeech_Cleanup;
@ -1730,14 +1861,14 @@ static void CB2_NewGameBirchSpeech_ReturnFromNamingScreen(void)
REG_IME = savedIme; REG_IME = savedIme;
SetVBlankCallback(VBlankCB_MainMenu); SetVBlankCallback(VBlankCB_MainMenu);
SetMainCallback2(CB2_MainMenu); SetMainCallback2(CB2_MainMenu);
InitWindows(gUnknown_082FF080); InitWindows(gNewGameBirchSpeechTextWindows);
LoadMainMenuWindowFrameTiles(0, 0xF3); LoadMainMenuWindowFrameTiles(0, 0xF3);
LoadMessageBoxGfx(0, 0xFC, 0xF0); LoadMessageBoxGfx(0, 0xFC, 0xF0);
PutWindowTilemap(0); PutWindowTilemap(0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
static void nullsub_11(struct Sprite *sprite) static void SpriteCB_Null(struct Sprite *sprite)
{ {
} }
@ -1763,22 +1894,22 @@ static void AddBirchSpeechObjects(u8 taskId)
u8 maySpriteId; u8 maySpriteId;
birchSpriteId = AddNewGameBirchObject(0x88, 0x3C, 1); birchSpriteId = AddNewGameBirchObject(0x88, 0x3C, 1);
gSprites[birchSpriteId].callback = nullsub_11; gSprites[birchSpriteId].callback = SpriteCB_Null;
gSprites[birchSpriteId].oam.priority = 0; gSprites[birchSpriteId].oam.priority = 0;
gSprites[birchSpriteId].invisible = TRUE; gSprites[birchSpriteId].invisible = TRUE;
gTasks[taskId].tBirchSpriteId = birchSpriteId; gTasks[taskId].tBirchSpriteId = birchSpriteId;
lotadSpriteId = NewGameBirchSpeech_CreateLotadSprite(100, 0x4B); lotadSpriteId = NewGameBirchSpeech_CreateLotadSprite(100, 0x4B);
gSprites[lotadSpriteId].callback = nullsub_11; gSprites[lotadSpriteId].callback = SpriteCB_Null;
gSprites[lotadSpriteId].oam.priority = 0; gSprites[lotadSpriteId].oam.priority = 0;
gSprites[lotadSpriteId].invisible = TRUE; gSprites[lotadSpriteId].invisible = TRUE;
gTasks[taskId].tLotadSpriteId = lotadSpriteId; gTasks[taskId].tLotadSpriteId = lotadSpriteId;
brendanSpriteId = CreateTrainerSprite(FacilityClassToPicIndex(FACILITY_CLASS_BRENDAN), 120, 60, 0, &gDecompressionBuffer[0]); brendanSpriteId = CreateTrainerSprite(FacilityClassToPicIndex(FACILITY_CLASS_BRENDAN), 120, 60, 0, &gDecompressionBuffer[0]);
gSprites[brendanSpriteId].callback = nullsub_11; gSprites[brendanSpriteId].callback = SpriteCB_Null;
gSprites[brendanSpriteId].invisible = TRUE; gSprites[brendanSpriteId].invisible = TRUE;
gSprites[brendanSpriteId].oam.priority = 0; gSprites[brendanSpriteId].oam.priority = 0;
gTasks[taskId].tBrendanSpriteId = brendanSpriteId; gTasks[taskId].tBrendanSpriteId = brendanSpriteId;
maySpriteId = CreateTrainerSprite(FacilityClassToPicIndex(FACILITY_CLASS_MAY), 120, 60, 0, &gDecompressionBuffer[0x800]); maySpriteId = CreateTrainerSprite(FacilityClassToPicIndex(FACILITY_CLASS_MAY), 120, 60, 0, &gDecompressionBuffer[0x800]);
gSprites[maySpriteId].callback = nullsub_11; gSprites[maySpriteId].callback = SpriteCB_Null;
gSprites[maySpriteId].invisible = TRUE; gSprites[maySpriteId].invisible = TRUE;
gSprites[maySpriteId].oam.priority = 0; gSprites[maySpriteId].oam.priority = 0;
gTasks[taskId].tMaySpriteId = maySpriteId; gTasks[taskId].tMaySpriteId = maySpriteId;
@ -1966,8 +2097,8 @@ static void NewGameBirchSpeech_StartFadePlatformOut(u8 taskId, u8 delay)
static void NewGameBirchSpeech_ShowGenderMenu(void) static void NewGameBirchSpeech_ShowGenderMenu(void)
{ {
DrawMainMenuWindowBorder(&gUnknown_082FF080[1], 0xF3); DrawMainMenuWindowBorder(&gNewGameBirchSpeechTextWindows[1], 0xF3);
FillWindowPixelBuffer(1, 17); FillWindowPixelBuffer(1, PIXEL_FILL(1));
PrintMenuTable(1, 2, sMenuActions_Gender); PrintMenuTable(1, 2, sMenuActions_Gender);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(1, 2, 0); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(1, 2, 0);
PutWindowTilemap(1); PutWindowTilemap(1);
@ -1995,7 +2126,7 @@ static void NewGameBirchSpeech_SetDefaultPlayerName(u8 nameId)
static void CreateMainMenuErrorWindow(const u8* str) static void CreateMainMenuErrorWindow(const u8* str)
{ {
FillWindowPixelBuffer(7, 17); FillWindowPixelBuffer(7, PIXEL_FILL(1));
AddTextPrinterParameterized(7, 1, str, 0, 1, 2, 0); AddTextPrinterParameterized(7, 1, str, 0, 1, 2, 0);
PutWindowTilemap(7); PutWindowTilemap(7);
CopyWindowToVram(7, 2); CopyWindowToVram(7, 2);
@ -2105,12 +2236,12 @@ static void NewGameBirchSpeech_ClearGenderWindowTilemap(u8 a, u8 b, u8 c, u8 d,
FillBgTilemapBufferRect(a, 0, b + 0xFF, c + 0xFF, d + 2, e + 2, 2); FillBgTilemapBufferRect(a, 0, b + 0xFF, c + 0xFF, d + 2, e + 2, 2);
} }
static void NewGameBirchSpeech_ClearGenderWindow(u8 windowId, u8 a) static void NewGameBirchSpeech_ClearGenderWindow(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, NewGameBirchSpeech_ClearGenderWindowTilemap); CallWindowFunction(windowId, NewGameBirchSpeech_ClearGenderWindowTilemap);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
if (a == 1) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
@ -2146,7 +2277,7 @@ void CreateYesNoMenuParameterized(u8 a, u8 b, u16 c, u16 d, u8 e, u8 f)
static void NewGameBirchSpeech_ShowDialogueWindow(u8 windowId, u8 copyToVram) static void NewGameBirchSpeech_ShowDialogueWindow(u8 windowId, u8 copyToVram)
{ {
CallWindowFunction(windowId, NewGameBirchSpeech_CreateDialogueWindowBorder); CallWindowFunction(windowId, NewGameBirchSpeech_CreateDialogueWindowBorder);
FillWindowPixelBuffer(windowId, 17); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);

4
src/map_name_popup.c
View File

@ -276,7 +276,7 @@ static void Task_MapNamePopUpWindow(u8 taskId)
} }
break; break;
case 4: case 4:
sub_819746C(GetMapNamePopUpWindowId(), TRUE); ClearStdWindowAndFrame(GetMapNamePopUpWindowId(), TRUE);
task->data[0] = 5; task->data[0] = 5;
break; break;
case 5: case 5:
@ -290,7 +290,7 @@ void HideMapNamePopUpWindow(void)
{ {
if (FuncIsActiveTask(Task_MapNamePopUpWindow)) if (FuncIsActiveTask(Task_MapNamePopUpWindow))
{ {
sub_819746C(GetMapNamePopUpWindowId(), TRUE); ClearStdWindowAndFrame(GetMapNamePopUpWindowId(), TRUE);
RemoveMapNamePopUpWindow(); RemoveMapNamePopUpWindow();
SetGpuReg_ForcedBlank(REG_OFFSET_BG0VOFS, 0); SetGpuReg_ForcedBlank(REG_OFFSET_BG0VOFS, 0);
DestroyTask(sPopupTaskId); DestroyTask(sPopupTaskId);

6
src/match_call.c
View File

@ -1191,7 +1191,7 @@ static bool32 LoadMatchCallWindowGfx(u8 taskId)
return FALSE; return FALSE;
} }
FillWindowPixelBuffer(taskData[2], 0x88); FillWindowPixelBuffer(taskData[2], PIXEL_FILL(8));
LoadPalette(sUnknown_0860EA4C, 0xE0, 0x20); LoadPalette(sUnknown_0860EA4C, 0xE0, 0x20);
LoadPalette(sPokeNavIconPalette, 0xF0, 0x20); LoadPalette(sPokeNavIconPalette, 0xF0, 0x20);
ChangeBgY(0, -0x2000, 0); ChangeBgY(0, -0x2000, 0);
@ -1241,7 +1241,7 @@ static bool32 sub_81962D8(u8 taskId)
s16 *taskData = gTasks[taskId].data; s16 *taskData = gTasks[taskId].data;
if (!ExecuteMatchCallTextPrinter(taskData[2])) if (!ExecuteMatchCallTextPrinter(taskData[2]))
{ {
FillWindowPixelBuffer(taskData[2], 0x88); FillWindowPixelBuffer(taskData[2], PIXEL_FILL(8));
if (!gMatchCallState.triggeredFromScript) if (!gMatchCallState.triggeredFromScript)
SelectMatchCallMessage(gMatchCallState.trainerId, gStringVar4); SelectMatchCallMessage(gMatchCallState.trainerId, gStringVar4);
@ -1257,7 +1257,7 @@ static bool32 sub_8196330(u8 taskId)
s16 *taskData = gTasks[taskId].data; s16 *taskData = gTasks[taskId].data;
if (!ExecuteMatchCallTextPrinter(taskData[2]) && !IsSEPlaying() && gMain.newKeys & (A_BUTTON | B_BUTTON)) if (!ExecuteMatchCallTextPrinter(taskData[2]) && !IsSEPlaying() && gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
FillWindowPixelBuffer(taskData[2], 0x88); FillWindowPixelBuffer(taskData[2], PIXEL_FILL(8));
CopyWindowToVram(taskData[2], 2); CopyWindowToVram(taskData[2], 2);
PlaySE(SE_TOREOFF); PlaySE(SE_TOREOFF);
return TRUE; return TRUE;

2
src/mauville_old_man.c
View File

@ -437,7 +437,7 @@ static void BardSong_TextSubPrinter(struct TextPrinterTemplate * printer, u16 a1
static void sub_8120708(const u8 * src) static void sub_8120708(const u8 * src)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, src, 0, 1, 1, BardSong_TextSubPrinter); AddTextPrinterParameterized(0, 1, src, 0, 1, 1, BardSong_TextSubPrinter);
gUnknown_03002F84 = TRUE; gUnknown_03002F84 = TRUE;
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);

121
src/menu.c
View File

@ -124,14 +124,14 @@ const struct MoveMenuInfoIcon gMoveMenuInfoIcons[] =
// Forward declarations // Forward declarations
extern void sub_81973A4(void); extern void sub_81973A4(void);
extern void DrawStandardFrame(u8, u8, u8, u8, u8, u8); extern void WindowFunc_DrawStandardFrame(u8, u8, u8, u8, u8, u8);
extern void DrawDialogueFrame(u8, u8, u8, u8, u8, u8); extern void WindowFunc_DrawDialogueFrame(u8, u8, u8, u8, u8, u8);
extern void sub_81977BC(u8, u8, u8, u8, u8, u8); extern void WindowFunc_ClearStdWindowAndFrame(u8, u8, u8, u8, u8, u8);
extern void sub_8197804(u8, u8, u8, u8, u8, u8); extern void WindowFunc_ClearDialogWindowAndFrame(u8, u8, u8, u8, u8, u8);
extern void sub_8197BB4(u8, u8, u8, u8, u8, u8); extern void WindowFunc_DrawDialogFrameWithCustomTileAndPalette(u8, u8, u8, u8, u8, u8);
extern void sub_8197E30(u8, u8, u8, u8, u8, u8); extern void WindowFunc_ClearDialogWindowAndFrameNullPalette(u8, u8, u8, u8, u8, u8);
extern void DrawWindowBorder(u8, u8, u8, u8, u8, u8); extern void WindowFunc_DrawStdFrameWithCustomTileAndPalette(u8, u8, u8, u8, u8, u8);
extern void sub_81980A8(u8, u8, u8, u8, u8, u8); extern void WindowFunc_ClearStdWindowAndFrameToTransparent(u8, u8, u8, u8, u8, u8);
extern u8 Menu_MoveCursor(s8); extern u8 Menu_MoveCursor(s8);
extern u8 sub_8199134(s8, s8); extern u8 sub_8199134(s8, s8);
extern void sub_8198C78(void); extern void sub_8198C78(void);
@ -210,43 +210,43 @@ void sub_81973A4(void)
LoadUserWindowBorderGfx(0, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM * 0x10); LoadUserWindowBorderGfx(0, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM * 0x10);
} }
void NewMenuHelpers_DrawDialogueFrame(u8 windowId, bool8 copyToVram) void DrawDialogueFrame(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, DrawDialogueFrame); CallWindowFunction(windowId, WindowFunc_DrawDialogueFrame);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void NewMenuHelpers_DrawStdWindowFrame(u8 windowId, bool8 copyToVram) void DrawStdWindowFrame(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, DrawStandardFrame); CallWindowFunction(windowId, WindowFunc_DrawStandardFrame);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_8197434(u8 windowId, bool8 copyToVram) void ClearDialogWindowAndFrame(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, sub_8197804); CallWindowFunction(windowId, WindowFunc_ClearDialogWindowAndFrame);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_819746C(u8 windowId, bool8 copyToVram) void ClearStdWindowAndFrame(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, sub_81977BC); CallWindowFunction(windowId, WindowFunc_ClearStdWindowAndFrame);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void DrawStandardFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_DrawStandardFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
int i; int i;
@ -313,7 +313,7 @@ void DrawStandardFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height
STD_WINDOW_PALETTE_NUM); STD_WINDOW_PALETTE_NUM);
} }
void DrawDialogueFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_DrawDialogueFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, FillBgTilemapBufferRect(bg,
DLG_WINDOW_BASE_TILE_NUM + 1, DLG_WINDOW_BASE_TILE_NUM + 1,
@ -408,25 +408,25 @@ void DrawDialogueFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height
DLG_WINDOW_PALETTE_NUM); DLG_WINDOW_PALETTE_NUM);
} }
void sub_81977BC(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_ClearStdWindowAndFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, 0, tilemapLeft - 1, tilemapTop - 1, width + 2, height + 2, STD_WINDOW_PALETTE_NUM); FillBgTilemapBufferRect(bg, 0, tilemapLeft - 1, tilemapTop - 1, width + 2, height + 2, STD_WINDOW_PALETTE_NUM);
} }
void sub_8197804(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_ClearDialogWindowAndFrame(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, 0, tilemapLeft - 3, tilemapTop - 1, width + 6, height + 2, STD_WINDOW_PALETTE_NUM); FillBgTilemapBufferRect(bg, 0, tilemapLeft - 3, tilemapTop - 1, width + 6, height + 2, STD_WINDOW_PALETTE_NUM);
} }
void SetStandardWindowBorderStyle(u8 windowId, bool8 copyToVram) void SetStandardWindowBorderStyle(u8 windowId, bool8 copyToVram)
{ {
SetWindowBorderStyle(windowId, copyToVram, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM); DrawStdFrameWithCustomTileAndPalette(windowId, copyToVram, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM);
} }
void sub_819786C(u8 windowId, bool8 copyToVram) void sub_819786C(u8 windowId, bool8 copyToVram)
{ {
LoadMessageBoxGfx(windowId, DLG_WINDOW_BASE_TILE_NUM, DLG_WINDOW_PALETTE_NUM * 0x10); LoadMessageBoxGfx(windowId, DLG_WINDOW_BASE_TILE_NUM, DLG_WINDOW_PALETTE_NUM * 0x10);
sub_8197B1C(windowId, copyToVram, DLG_WINDOW_BASE_TILE_NUM, 0xF); DrawDialogFrameWithCustomTileAndPalette(windowId, copyToVram, DLG_WINDOW_BASE_TILE_NUM, 0xF);
} }
void sub_819789C(void) void sub_819789C(void)
@ -458,12 +458,12 @@ void DisplayItemMessageOnField(u8 taskId, const u8 *string, TaskFunc callback)
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
void DisplayYesNoMenu(void) void DisplayYesNoMenuDefaultYes(void)
{ {
CreateYesNoMenu(&sYesNo_WindowTemplates, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM, 0); CreateYesNoMenu(&sYesNo_WindowTemplates, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM, 0);
} }
void sub_8197948(u8 initialCursorPos) void DisplayYesNoMenuWithDefault(u8 initialCursorPos)
{ {
CreateYesNoMenu(&sYesNo_WindowTemplates, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM, initialCursorPos); CreateYesNoMenu(&sYesNo_WindowTemplates, STD_WINDOW_BASE_TILE_NUM, STD_WINDOW_PALETTE_NUM, initialCursorPos);
} }
@ -549,29 +549,30 @@ void sub_8197AE8(bool8 copyToVram)
CopyBgTilemapBufferToVram(0); CopyBgTilemapBufferToVram(0);
} }
void sub_8197B1C(u8 windowId, bool8 copyToVram, u16 tileNum, u8 paletteNum) void DrawDialogFrameWithCustomTileAndPalette(u8 windowId, bool8 copyToVram, u16 tileNum, u8 paletteNum)
{ {
sTileNum = tileNum; sTileNum = tileNum;
sPaletteNum = paletteNum; sPaletteNum = paletteNum;
CallWindowFunction(windowId, sub_8197BB4); CallWindowFunction(windowId, WindowFunc_DrawDialogFrameWithCustomTileAndPalette);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_8197B64(u8 windowId, bool8 copyToVram, u16 tileNum) // Never used.
void DrawDialogFrameWithCustomTile(u8 windowId, bool8 copyToVram, u16 tileNum)
{ {
sTileNum = tileNum; sTileNum = tileNum;
sPaletteNum = GetWindowAttribute(windowId, WINDOW_PALETTE_NUM); sPaletteNum = GetWindowAttribute(windowId, WINDOW_PALETTE_NUM);
CallWindowFunction(windowId, sub_8197BB4); CallWindowFunction(windowId, WindowFunc_DrawDialogFrameWithCustomTileAndPalette);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_8197BB4(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_DrawDialogFrameWithCustomTileAndPalette(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, FillBgTilemapBufferRect(bg,
sTileNum + 1, sTileNum + 1,
@ -666,43 +667,45 @@ void sub_8197BB4(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 p
sPaletteNum); sPaletteNum);
} }
void sub_8197DF8(u8 windowId, bool8 copyToVram) void ClearDialogWindowAndFrameToTransparent(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, sub_8197E30); // The palette slot doesn't matter, since the tiles are transparent.
FillWindowPixelBuffer(windowId, 0); CallWindowFunction(windowId, WindowFunc_ClearDialogWindowAndFrameNullPalette);
FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_8197E30(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_ClearDialogWindowAndFrameNullPalette(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, 0, tilemapLeft - 3, tilemapTop - 1, width + 6, height + 2, 0); FillBgTilemapBufferRect(bg, 0, tilemapLeft - 3, tilemapTop - 1, width + 6, height + 2, 0);
} }
void SetWindowBorderStyle(u8 windowId, bool8 copyToVram, u16 baseTileNum, u8 paletteNum) void DrawStdFrameWithCustomTileAndPalette(u8 windowId, bool8 copyToVram, u16 baseTileNum, u8 paletteNum)
{ {
sTileNum = baseTileNum; sTileNum = baseTileNum;
sPaletteNum = paletteNum; sPaletteNum = paletteNum;
CallWindowFunction(windowId, DrawWindowBorder); CallWindowFunction(windowId, WindowFunc_DrawStdFrameWithCustomTileAndPalette);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_8197EC8(u8 windowId, bool8 copyToVram, u16 baseTileNum) // Never used.
void DrawStdFrameWithCustomTile(u8 windowId, bool8 copyToVram, u16 baseTileNum)
{ {
sTileNum = baseTileNum; sTileNum = baseTileNum;
sPaletteNum = GetWindowAttribute(windowId, WINDOW_PALETTE_NUM); sPaletteNum = GetWindowAttribute(windowId, WINDOW_PALETTE_NUM);
CallWindowFunction(windowId, DrawWindowBorder); CallWindowFunction(windowId, WindowFunc_DrawStdFrameWithCustomTileAndPalette);
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
PutWindowTilemap(windowId); PutWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void DrawWindowBorder(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_DrawStdFrameWithCustomTileAndPalette(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, FillBgTilemapBufferRect(bg,
sTileNum + 0, sTileNum + 0,
@ -762,16 +765,16 @@ void DrawWindowBorder(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height,
sPaletteNum); sPaletteNum);
} }
void sub_8198070(u8 windowId, bool8 copyToVram) void ClearStdWindowAndFrameToTransparent(u8 windowId, bool8 copyToVram)
{ {
CallWindowFunction(windowId, sub_81980A8); CallWindowFunction(windowId, WindowFunc_ClearStdWindowAndFrameToTransparent);
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
ClearWindowTilemap(windowId); ClearWindowTilemap(windowId);
if (copyToVram == TRUE) if (copyToVram == TRUE)
CopyWindowToVram(windowId, 3); CopyWindowToVram(windowId, 3);
} }
void sub_81980A8(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum) void WindowFunc_ClearStdWindowAndFrameToTransparent(u8 bg, u8 tilemapLeft, u8 tilemapTop, u8 width, u8 height, u8 paletteNum)
{ {
FillBgTilemapBufferRect(bg, 0, tilemapLeft - 1, tilemapTop - 1, width + 2, height + 2, 0); FillBgTilemapBufferRect(bg, 0, tilemapLeft - 1, tilemapTop - 1, width + 2, height + 2, 0);
} }
@ -811,7 +814,7 @@ void sub_8198180(const u8 *string, u8 a2, bool8 copyToVram)
if (sWindowId != 0xFF) if (sWindowId != 0xFF)
{ {
PutWindowTilemap(sWindowId); PutWindowTilemap(sWindowId);
FillWindowPixelBuffer(sWindowId, 0xFF); FillWindowPixelBuffer(sWindowId, PIXEL_FILL(15));
width = GetStringWidth(0, string, 0); width = GetStringWidth(0, string, 0);
AddTextPrinterParameterized3(sWindowId, AddTextPrinterParameterized3(sWindowId,
0, 0,
@ -845,7 +848,7 @@ void sub_8198204(const u8 *string, const u8 *string2, u8 a3, u8 a4, bool8 copyTo
color[2] = 2; color[2] = 2;
} }
PutWindowTilemap(sWindowId); PutWindowTilemap(sWindowId);
FillWindowPixelBuffer(sWindowId, 0xFF); FillWindowPixelBuffer(sWindowId, PIXEL_FILL(15));
if (string2 != NULL) if (string2 != NULL)
{ {
width = GetStringWidth(0, string2, 0); width = GetStringWidth(0, string2, 0);
@ -873,7 +876,7 @@ void sub_81982F0(void)
{ {
if (sWindowId != 0xFF) if (sWindowId != 0xFF)
{ {
FillWindowPixelBuffer(sWindowId, 0xFF); FillWindowPixelBuffer(sWindowId, PIXEL_FILL(15));
CopyWindowToVram(sWindowId, 3); CopyWindowToVram(sWindowId, 3);
} }
} }
@ -882,7 +885,7 @@ void sub_8198314(void)
{ {
if (sWindowId != 0xFF) if (sWindowId != 0xFF)
{ {
FillWindowPixelBuffer(sWindowId, 0); FillWindowPixelBuffer(sWindowId, PIXEL_FILL(0));
ClearWindowTilemap(sWindowId); ClearWindowTilemap(sWindowId);
CopyWindowToVram(sWindowId, 3); CopyWindowToVram(sWindowId, 3);
RemoveWindow(sWindowId); RemoveWindow(sWindowId);
@ -931,7 +934,7 @@ void RedrawMenuCursor(u8 oldPos, u8 newPos)
width = GetMenuCursorDimensionByFont(sMenu.fontId, 0); width = GetMenuCursorDimensionByFont(sMenu.fontId, 0);
height = GetMenuCursorDimensionByFont(sMenu.fontId, 1); height = GetMenuCursorDimensionByFont(sMenu.fontId, 1);
FillWindowPixelRect(sMenu.windowId, 0x11, sMenu.left, sMenu.optionHeight * oldPos + sMenu.top, width, height); FillWindowPixelRect(sMenu.windowId, PIXEL_FILL(1), sMenu.left, sMenu.optionHeight * oldPos + sMenu.top, width, height);
AddTextPrinterParameterized(sMenu.windowId, sMenu.fontId, gText_SelectorArrow3, sMenu.left, sMenu.optionHeight * newPos + sMenu.top, 0, 0); AddTextPrinterParameterized(sMenu.windowId, sMenu.fontId, gText_SelectorArrow3, sMenu.left, sMenu.optionHeight * newPos + sMenu.top, 0, 0);
} }
@ -1175,7 +1178,7 @@ void sub_8198AF8(const struct WindowTemplate *window, u8 fontId, u8 left, u8 top
struct TextPrinterTemplate printer; struct TextPrinterTemplate printer;
sYesNoWindowId = AddWindow(window); sYesNoWindowId = AddWindow(window);
SetWindowBorderStyle(sYesNoWindowId, TRUE, baseTileNum, paletteNum); DrawStdFrameWithCustomTileAndPalette(sYesNoWindowId, TRUE, baseTileNum, paletteNum);
printer.currentChar = gText_YesNo; printer.currentChar = gText_YesNo;
printer.windowId = sYesNoWindowId; printer.windowId = sYesNoWindowId;
@ -1211,7 +1214,7 @@ s8 Menu_ProcessInputNoWrapClearOnChoose(void)
void sub_8198C78(void) void sub_8198C78(void)
{ {
sub_8198070(sYesNoWindowId, TRUE); ClearStdWindowAndFrameToTransparent(sYesNoWindowId, TRUE);
RemoveWindow(sYesNoWindowId); RemoveWindow(sYesNoWindowId);
} }
@ -1310,7 +1313,7 @@ void sub_8199060(u8 oldCursorPos, u8 newCursorPos)
u8 xPos = (oldCursorPos % sMenu.horizontalCount) * sMenu.optionWidth + sMenu.left; u8 xPos = (oldCursorPos % sMenu.horizontalCount) * sMenu.optionWidth + sMenu.left;
u8 yPos = (oldCursorPos / sMenu.horizontalCount) * sMenu.optionHeight + sMenu.top; u8 yPos = (oldCursorPos / sMenu.horizontalCount) * sMenu.optionHeight + sMenu.top;
FillWindowPixelRect(sMenu.windowId, FillWindowPixelRect(sMenu.windowId,
0x11, PIXEL_FILL(1),
xPos, xPos,
yPos, yPos,
cursorWidth, cursorWidth,
@ -1640,7 +1643,7 @@ void CreateYesNoMenu(const struct WindowTemplate *window, u16 baseTileNum, u8 pa
struct TextPrinterTemplate printer; struct TextPrinterTemplate printer;
sYesNoWindowId = AddWindow(window); sYesNoWindowId = AddWindow(window);
SetWindowBorderStyle(sYesNoWindowId, TRUE, baseTileNum, paletteNum); DrawStdFrameWithCustomTileAndPalette(sYesNoWindowId, TRUE, baseTileNum, paletteNum);
printer.currentChar = gText_YesNo; printer.currentChar = gText_YesNo;
printer.windowId = sYesNoWindowId; printer.windowId = sYesNoWindowId;

2
src/menu_helpers.c
View File

@ -129,7 +129,7 @@ void SetVBlankHBlankCallbacksToNull(void)
void DisplayMessageAndContinueTask(u8 taskId, u8 windowId, u16 arg2, u8 arg3, u8 fontId, u8 textSpeed, const u8 *string, void *taskFunc) void DisplayMessageAndContinueTask(u8 taskId, u8 windowId, u16 arg2, u8 arg3, u8 fontId, u8 textSpeed, const u8 *string, void *taskFunc)
{ {
gUnknown_0203A140 = windowId; gUnknown_0203A140 = windowId;
sub_8197B1C(windowId, TRUE, arg2, arg3); DrawDialogFrameWithCustomTileAndPalette(windowId, TRUE, arg2, arg3);
if (string != gStringVar4) if (string != gStringVar4)
StringExpandPlaceholders(gStringVar4, string); StringExpandPlaceholders(gStringVar4, string);

6
src/money.c
View File

@ -154,7 +154,7 @@ void PrintMoneyAmount(u8 windowId, u8 x, u8 y, int amount, u8 speed)
void PrintMoneyAmountInMoneyBoxWithBorder(u8 windowId, u16 tileStart, u8 pallete, int amount) void PrintMoneyAmountInMoneyBoxWithBorder(u8 windowId, u16 tileStart, u8 pallete, int amount)
{ {
SetWindowBorderStyle(windowId, FALSE, tileStart, pallete); DrawStdFrameWithCustomTileAndPalette(windowId, FALSE, tileStart, pallete);
PrintMoneyAmountInMoneyBox(windowId, amount, 0); PrintMoneyAmountInMoneyBox(windowId, amount, 0);
} }
@ -169,7 +169,7 @@ void DrawMoneyBox(int amount, u8 x, u8 y)
SetWindowTemplateFields(&template, 0, x + 1, y + 1, 10, 2, 15, 8); SetWindowTemplateFields(&template, 0, x + 1, y + 1, 10, 2, 15, 8);
sMoneyBoxWindowId = AddWindow(&template); sMoneyBoxWindowId = AddWindow(&template);
FillWindowPixelBuffer(sMoneyBoxWindowId, 0); FillWindowPixelBuffer(sMoneyBoxWindowId, PIXEL_FILL(0));
PutWindowTilemap(sMoneyBoxWindowId); PutWindowTilemap(sMoneyBoxWindowId);
CopyWindowToVram(sMoneyBoxWindowId, 1); CopyWindowToVram(sMoneyBoxWindowId, 1);
PrintMoneyAmountInMoneyBoxWithBorder(sMoneyBoxWindowId, 0x214, 14, amount); PrintMoneyAmountInMoneyBoxWithBorder(sMoneyBoxWindowId, 0x214, 14, amount);
@ -179,7 +179,7 @@ void DrawMoneyBox(int amount, u8 x, u8 y)
void HideMoneyBox(void) void HideMoneyBox(void)
{ {
RemoveMoneyLabelObject(); RemoveMoneyLabelObject();
sub_8198070(sMoneyBoxWindowId, FALSE); ClearStdWindowAndFrameToTransparent(sMoneyBoxWindowId, FALSE);
CopyWindowToVram(sMoneyBoxWindowId, 2); CopyWindowToVram(sMoneyBoxWindowId, 2);
RemoveWindow(sMoneyBoxWindowId); RemoveWindow(sMoneyBoxWindowId);
} }

8
src/mystery_event_menu.c
View File

@ -90,7 +90,7 @@ void CB2_InitMysteryEventMenu(void)
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
for (i = 0; i < 2; i++) for (i = 0; i < 2; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x1E, 0x14); FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x1E, 0x14);
LoadUserWindowBorderGfx(0, 1u, 0xD0u); LoadUserWindowBorderGfx(0, 1u, 0xD0u);
@ -133,7 +133,7 @@ static void CB2_MysteryEventMenu(void)
switch (gMain.state) switch (gMain.state)
{ {
case 0: case 0:
SetWindowBorderStyle(0, 1, 1, 0xD); DrawStdFrameWithCustomTileAndPalette(0, 1, 1, 0xD);
PutWindowTilemap(0); PutWindowTilemap(0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
ShowBg(0); ShowBg(0);
@ -180,7 +180,7 @@ static void CB2_MysteryEventMenu(void)
{ {
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
CheckShouldAdvanceLinkState(); CheckShouldAdvanceLinkState();
SetWindowBorderStyle(1, 1, 1, 0xD); DrawStdFrameWithCustomTileAndPalette(1, 1, 1, 0xD);
PrintMysteryMenuText(1, gText_LoadingEvent, 1, 2, 0); PrintMysteryMenuText(1, gText_LoadingEvent, 1, 2, 0);
PutWindowTilemap(1); PutWindowTilemap(1);
CopyWindowToVram(1, 3); CopyWindowToVram(1, 3);
@ -313,6 +313,6 @@ static void PrintMysteryMenuText(u8 windowId, const u8 *text, u8 x, u8 y, s32 sp
textColor[1] = 2; textColor[1] = 2;
textColor[2] = 3; textColor[2] = 3;
FillWindowPixelBuffer(windowId, (textColor[0]) | (textColor[0] << 4)); FillWindowPixelBuffer(windowId, PIXEL_FILL(textColor[0]));
AddTextPrinterParameterized4(windowId, 1, x, y, letterSpacing, lineSpacing, textColor, speed, text); AddTextPrinterParameterized4(windowId, 1, x, y, letterSpacing, lineSpacing, textColor, speed, text);
} }

14
src/naming_screen.c
View File

@ -557,7 +557,7 @@ static void DisplaySentToPCMessage(void)
stringToDisplay++; stringToDisplay++;
StringExpandPlaceholders(gStringVar4, gUnknown_0858BDB8[stringToDisplay]); StringExpandPlaceholders(gStringVar4, gUnknown_0858BDB8[stringToDisplay]);
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
gTextFlags.canABSpeedUpPrint = TRUE; gTextFlags.canABSpeedUpPrint = TRUE;
AddTextPrinterParameterized2(0, 1, gStringVar4, GetPlayerTextSpeedDelay(), 0, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gStringVar4, GetPlayerTextSpeedDelay(), 0, 2, 1, 3);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
@ -1474,7 +1474,7 @@ static void HandleDpadMovement(struct Task *task)
static void sub_80E4894(void) static void sub_80E4894(void)
{ {
FillWindowPixelBuffer(gNamingScreenData->windows[3], 0x11); FillWindowPixelBuffer(gNamingScreenData->windows[3], PIXEL_FILL(1));
AddTextPrinterParameterized(gNamingScreenData->windows[3], 1, gNamingScreenData->template->title, 8, 1, 0, 0); AddTextPrinterParameterized(gNamingScreenData->windows[3], 1, gNamingScreenData->template->title, 8, 1, 0, 0);
PutWindowTilemap(gNamingScreenData->windows[3]); PutWindowTilemap(gNamingScreenData->windows[3]);
} }
@ -1485,7 +1485,7 @@ static void sub_80E48E8(void)
StringCopy(buffer, gSpeciesNames[gNamingScreenData->monSpecies]); StringCopy(buffer, gSpeciesNames[gNamingScreenData->monSpecies]);
StringAppendN(buffer, gNamingScreenData->template->title, 15); StringAppendN(buffer, gNamingScreenData->template->title, 15);
FillWindowPixelBuffer(gNamingScreenData->windows[3], 0x11); FillWindowPixelBuffer(gNamingScreenData->windows[3], PIXEL_FILL(1));
AddTextPrinterParameterized(gNamingScreenData->windows[3], 1, buffer, 8, 1, 0, 0); AddTextPrinterParameterized(gNamingScreenData->windows[3], 1, buffer, 8, 1, 0, 0);
PutWindowTilemap(gNamingScreenData->windows[3]); PutWindowTilemap(gNamingScreenData->windows[3]);
} }
@ -1672,7 +1672,7 @@ static void sub_80E4D10(void)
u8 maxChars = gNamingScreenData->template->maxChars; u8 maxChars = gNamingScreenData->template->maxChars;
u16 unk = gNamingScreenData->inputCharBaseXPos - 0x40; u16 unk = gNamingScreenData->inputCharBaseXPos - 0x40;
FillWindowPixelBuffer(gNamingScreenData->windows[2], 0x11); FillWindowPixelBuffer(gNamingScreenData->windows[2], PIXEL_FILL(1));
for (i = 0; i < maxChars; i++) for (i = 0; i < maxChars; i++)
{ {
@ -1704,7 +1704,9 @@ static const struct TextColorThing sUnkColorStruct =
static const u8 sFillValues[3] = static const u8 sFillValues[3] =
{ {
0xEE, 0xDD, 0xFF PIXEL_FILL(0xE),
PIXEL_FILL(0xD),
PIXEL_FILL(0xF)
}; };
static const u8 *const sUnkColors[3] = static const u8 *const sUnkColors[3] =
@ -1766,7 +1768,7 @@ static void sub_80E4EF0(void)
{ {
const u8 color[3] = { 15, 1, 2 }; const u8 color[3] = { 15, 1, 2 };
FillWindowPixelBuffer(gNamingScreenData->windows[4], 0xFF); FillWindowPixelBuffer(gNamingScreenData->windows[4], PIXEL_FILL(15));
AddTextPrinterParameterized3(gNamingScreenData->windows[4], 0, 2, 1, color, 0, gText_MoveOkBack); AddTextPrinterParameterized3(gNamingScreenData->windows[4], 0, 2, 1, color, 0, gText_MoveOkBack);
PutWindowTilemap(gNamingScreenData->windows[4]); PutWindowTilemap(gNamingScreenData->windows[4]);
CopyWindowToVram(gNamingScreenData->windows[4], 3); CopyWindowToVram(gNamingScreenData->windows[4], 3);

4
src/option_menu.c
View File

@ -620,7 +620,7 @@ static void ButtonMode_DrawChoices(u8 selection)
static void DrawTextOption(void) static void DrawTextOption(void)
{ {
FillWindowPixelBuffer(WIN_TEXT_OPTION, 0x11); FillWindowPixelBuffer(WIN_TEXT_OPTION, PIXEL_FILL(1));
AddTextPrinterParameterized(WIN_TEXT_OPTION, 1, gText_Option, 8, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(WIN_TEXT_OPTION, 1, gText_Option, 8, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(WIN_TEXT_OPTION, 3); CopyWindowToVram(WIN_TEXT_OPTION, 3);
} }
@ -629,7 +629,7 @@ static void DrawOptionMenuTexts(void)
{ {
u8 i; u8 i;
FillWindowPixelBuffer(WIN_OPTIONS, 0x11); FillWindowPixelBuffer(WIN_OPTIONS, PIXEL_FILL(1));
for (i = 0; i < MENUITEM_COUNT; i++) for (i = 0; i < MENUITEM_COUNT; i++)
{ {
AddTextPrinterParameterized(WIN_OPTIONS, 1, sOptionMenuItemsNames[i], 8, (i * 16) + 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(WIN_OPTIONS, 1, sOptionMenuItemsNames[i], 8, (i * 16) + 1, TEXT_SPEED_FF, NULL);

25
src/party_menu.c
View File

@ -2754,7 +2754,7 @@ static void sub_81B1B8C(u8 taskId)
{ {
if (gTasks[taskId].data[0] == 0) if (gTasks[taskId].data[0] == 0)
{ {
sub_8198070(6, 0); ClearStdWindowAndFrameToTransparent(6, 0);
ClearWindowTilemap(6); ClearWindowTilemap(6);
} }
DestroyTask(taskId); DestroyTask(taskId);
@ -2779,7 +2779,7 @@ static void sub_81B1C1C(u8 taskId)
{ {
if (sub_81B1BD4() != TRUE) if (sub_81B1BD4() != TRUE)
{ {
sub_8198070(6, 0); ClearStdWindowAndFrameToTransparent(6, 0);
ClearWindowTilemap(6); ClearWindowTilemap(6);
if (sub_81221AC() == TRUE) if (sub_81221AC() == TRUE)
{ {
@ -3109,7 +3109,7 @@ static void sub_81B239C(u8 a)
} }
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
for (i = 0; i < PARTY_SIZE; i++) for (i = 0; i < PARTY_SIZE; i++)
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
LoadUserWindowBorderGfx(0, 0x4F, 0xD0); LoadUserWindowBorderGfx(0, 0x4F, 0xD0);
LoadPalette(GetOverworldTextboxPalettePtr(), 0xE0, 0x20); LoadPalette(GetOverworldTextboxPalettePtr(), 0xE0, 0x20);
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
@ -3127,7 +3127,7 @@ static void sub_81B2428(bool8 a)
if (a == TRUE) if (a == TRUE)
{ {
firstWindowId = AddWindow(&gUnknown_08615918); firstWindowId = AddWindow(&gUnknown_08615918);
FillWindowPixelBuffer(firstWindowId, 0); FillWindowPixelBuffer(firstWindowId, PIXEL_FILL(0));
mainOffset = GetStringCenterAlignXOffset(0, gMenuText_Confirm, 48); mainOffset = GetStringCenterAlignXOffset(0, gMenuText_Confirm, 48);
AddTextPrinterParameterized4(firstWindowId, 0, mainOffset, 1, 0, 0, gUnknown_086157FC[0], -1, gMenuText_Confirm); AddTextPrinterParameterized4(firstWindowId, 0, mainOffset, 1, 0, 0, gUnknown_086157FC[0], -1, gMenuText_Confirm);
PutWindowTilemap(firstWindowId); PutWindowTilemap(firstWindowId);
@ -3140,7 +3140,7 @@ static void sub_81B2428(bool8 a)
windowId = AddWindow(&gUnknown_08615908); windowId = AddWindow(&gUnknown_08615908);
offset = 3; offset = 3;
} }
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
if (gUnknown_0203CEC8.unk8_0 != 10) if (gUnknown_0203CEC8.unk8_0 != 10)
{ {
mainOffset = GetStringCenterAlignXOffset(0, gText_Cancel, 48); mainOffset = GetStringCenterAlignXOffset(0, gText_Cancel, 48);
@ -3480,8 +3480,9 @@ static void DisplayPartyPokemonHPBar(u16 hp, u16 maxhp, struct Struct203CEDC *pt
FillWindowPixelRect(ptr->windowId, gUnknown_08615AB8[0], ptr->unk0->unk4[20], ptr->unk0->unk4[21] + 1, hpFraction, 2); FillWindowPixelRect(ptr->windowId, gUnknown_08615AB8[0], ptr->unk0->unk4[20], ptr->unk0->unk4[21] + 1, hpFraction, 2);
if (hpFraction != ptr->unk0->unk4[22]) if (hpFraction != ptr->unk0->unk4[22])
{ {
FillWindowPixelRect(ptr->windowId, 13, ptr->unk0->unk4[20] + hpFraction, ptr->unk0->unk4[21], ptr->unk0->unk4[22] - hpFraction, 1); // This appears to be an alternating fill
FillWindowPixelRect(ptr->windowId, 2, ptr->unk0->unk4[20] + hpFraction, ptr->unk0->unk4[21] + 1, ptr->unk0->unk4[22] - hpFraction, 2); FillWindowPixelRect(ptr->windowId, 0x0D, ptr->unk0->unk4[20] + hpFraction, ptr->unk0->unk4[21], ptr->unk0->unk4[22] - hpFraction, 1);
FillWindowPixelRect(ptr->windowId, 0x02, ptr->unk0->unk4[20] + hpFraction, ptr->unk0->unk4[21] + 1, ptr->unk0->unk4[22] - hpFraction, 2);
} }
CopyWindowToVram(ptr->windowId, 2); CopyWindowToVram(ptr->windowId, 2);
} }
@ -3502,7 +3503,7 @@ static void sub_81B302C(u8 *ptr)
{ {
if (*ptr != 0xFF) if (*ptr != 0xFF)
{ {
sub_8198070(*ptr, 0); ClearStdWindowAndFrameToTransparent(*ptr, 0);
RemoveWindow(*ptr); RemoveWindow(*ptr);
*ptr = 0xFF; *ptr = 0xFF;
schedule_bg_copy_tilemap_to_vram(2); schedule_bg_copy_tilemap_to_vram(2);
@ -3547,7 +3548,7 @@ void display_pokemon_menu_message(u32 stringID)
else if (sub_81B314C() == FALSE) else if (sub_81B314C() == FALSE)
stringID = 1; stringID = 1;
} }
SetWindowBorderStyle(*windowPtr, FALSE, 0x4F, 0xD); DrawStdFrameWithCustomTileAndPalette(*windowPtr, FALSE, 0x4F, 0xD);
StringExpandPlaceholders(gStringVar4, gUnknown_08615AF4[stringID]); StringExpandPlaceholders(gStringVar4, gUnknown_08615AF4[stringID]);
AddTextPrinterParameterized(*windowPtr, 1, gStringVar4, 0, 1, 0, 0); AddTextPrinterParameterized(*windowPtr, 1, gStringVar4, 0, 1, 0, 0);
schedule_bg_copy_tilemap_to_vram(2); schedule_bg_copy_tilemap_to_vram(2);
@ -3597,7 +3598,7 @@ static u8 sub_81B31B0(u8 a)
} }
gUnknown_0203CEC4->unkC[0] = AddWindow(&window); gUnknown_0203CEC4->unkC[0] = AddWindow(&window);
SetWindowBorderStyle(gUnknown_0203CEC4->unkC[0], FALSE, 0x4F, 13); DrawStdFrameWithCustomTileAndPalette(gUnknown_0203CEC4->unkC[0], FALSE, 0x4F, 13);
if (a == 3) if (a == 3)
return gUnknown_0203CEC4->unkC[0]; return gUnknown_0203CEC4->unkC[0];
cursorDimension = GetMenuCursorDimensionByFont(1, 0); cursorDimension = GetMenuCursorDimensionByFont(1, 0);
@ -3617,7 +3618,7 @@ static u8 sub_81B31B0(u8 a)
static void sub_81B3300(const u8 *text) static void sub_81B3300(const u8 *text)
{ {
SetWindowBorderStyle(6, FALSE, 0x4F, 13); DrawStdFrameWithCustomTileAndPalette(6, FALSE, 0x4F, 13);
gTextFlags.canABSpeedUpPrint = TRUE; gTextFlags.canABSpeedUpPrint = TRUE;
AddTextPrinterParameterized2(6, 1, text, GetPlayerTextSpeedDelay(), 0, 2, 1, 3); AddTextPrinterParameterized2(6, 1, text, GetPlayerTextSpeedDelay(), 0, 2, 1, 3);
} }
@ -3630,7 +3631,7 @@ static void sub_81B334C(void)
static u8 sub_81B3364(void) static u8 sub_81B3364(void)
{ {
gUnknown_0203CEC4->unkC[0] = AddWindow(&gUnknown_08615970); gUnknown_0203CEC4->unkC[0] = AddWindow(&gUnknown_08615970);
SetWindowBorderStyle(gUnknown_0203CEC4->unkC[0], FALSE, 0x4F, 13); DrawStdFrameWithCustomTileAndPalette(gUnknown_0203CEC4->unkC[0], FALSE, 0x4F, 13);
return gUnknown_0203CEC4->unkC[0]; return gUnknown_0203CEC4->unkC[0];
} }

30
src/player_pc.c
View File

@ -361,14 +361,14 @@ static void PlayerPCProcessMenuInput(u8 taskId)
break; break;
case MENU_B_PRESSED: case MENU_B_PRESSED:
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(data[4], FALSE); ClearStdWindowAndFrameToTransparent(data[4], FALSE);
ClearWindowTilemap(data[4]); ClearWindowTilemap(data[4]);
RemoveWindow(data[4]); RemoveWindow(data[4]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
gTasks[taskId].func = PlayerPC_TurnOff; gTasks[taskId].func = PlayerPC_TurnOff;
break; break;
default: default:
sub_8198070(data[4], FALSE); ClearStdWindowAndFrameToTransparent(data[4], FALSE);
ClearWindowTilemap(data[4]); ClearWindowTilemap(data[4]);
RemoveWindow(data[4]); RemoveWindow(data[4]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -403,7 +403,7 @@ static void PlayerPC_Mailbox(u8 taskId)
ItemStorage_SetItemAndMailCount(taskId); ItemStorage_SetItemAndMailCount(taskId);
if (sub_81D1C44(playerPCItemPageInfo.count) == TRUE) if (sub_81D1C44(playerPCItemPageInfo.count) == TRUE)
{ {
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
Mailbox_DrawMailboxMenu(taskId); Mailbox_DrawMailboxMenu(taskId);
gTasks[taskId].func = Mailbox_ProcessInput; gTasks[taskId].func = Mailbox_ProcessInput;
} }
@ -451,7 +451,7 @@ static void InitItemStorageMenu(u8 taskId, u8 var)
static void ItemStorageMenuPrint(const u8 *textPtr) static void ItemStorageMenuPrint(const u8 *textPtr)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, textPtr, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, textPtr, 0, 1, 0, 0);
} }
@ -506,7 +506,7 @@ void sub_816B31C(void)
void Mailbox_DoRedrawMailboxMenuAfterReturn(void) void Mailbox_DoRedrawMailboxMenuAfterReturn(void)
{ {
sub_81973A4(); sub_81973A4();
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
InitItemStorageMenu(CreateTask(ItemStorage_HandleReturnToProcessInput, 0), 1); InitItemStorageMenu(CreateTask(ItemStorage_HandleReturnToProcessInput, 0), 1);
pal_fill_black(); pal_fill_black();
} }
@ -560,7 +560,7 @@ static void ItemStorage_WithdrawToss_Helper(u8 taskId, bool8 toss)
FreeAndReserveObjectSpritePalettes(); FreeAndReserveObjectSpritePalettes();
LoadListMenuArrowsGfx(); LoadListMenuArrowsGfx();
sub_8122344(gUnknown_0203BCC4->spriteIds, 7); sub_8122344(gUnknown_0203BCC4->spriteIds, 7);
sub_8197434(0,0); ClearDialogWindowAndFrame(0,0);
gTasks[taskId].func = ItemStorage_ProcessWithdrawTossInput; gTasks[taskId].func = ItemStorage_ProcessWithdrawTossInput;
} }
@ -583,7 +583,7 @@ static void sub_816B4DC(u8 taskId)
{ {
u16 *data = gTasks[taskId].data; u16 *data = gTasks[taskId].data;
sub_8198070(data[4], FALSE); ClearStdWindowAndFrameToTransparent(data[4], FALSE);
ClearWindowTilemap(data[4]); ClearWindowTilemap(data[4]);
RemoveWindow(data[4]); RemoveWindow(data[4]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -761,7 +761,7 @@ static void Mailbox_MoveToBag(u8 taskId)
static void Mailbox_DrawYesNoBeforeMove(u8 taskId) static void Mailbox_DrawYesNoBeforeMove(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
gTasks[taskId].func = Mailbox_MoveToBagYesNoPrompt; gTasks[taskId].func = Mailbox_MoveToBagYesNoPrompt;
} }
@ -863,7 +863,7 @@ static void Mailbox_NoPokemonForMail(u8 taskId)
static void Mailbox_Cancel(u8 taskId) static void Mailbox_Cancel(u8 taskId)
{ {
sub_81D1D04(2); sub_81D1D04(2);
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
Mailbox_DrawMailboxMenu(taskId); Mailbox_DrawMailboxMenu(taskId);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
gTasks[taskId].func = Mailbox_ProcessInput; gTasks[taskId].func = Mailbox_ProcessInput;
@ -892,7 +892,7 @@ static u8 sub_816BC7C(u8 a)
if (*windowIdLoc == 0xFF) if (*windowIdLoc == 0xFF)
{ {
*windowIdLoc = AddWindow(&gUnknown_085DFF5C[a]); *windowIdLoc = AddWindow(&gUnknown_085DFF5C[a]);
SetWindowBorderStyle(*windowIdLoc, FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(*windowIdLoc, FALSE, 0x214, 0xE);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }
return *windowIdLoc; return *windowIdLoc;
@ -903,7 +903,7 @@ static void sub_816BCC4(u8 a)
u8 *windowIdLoc = &(gUnknown_0203BCC4->windowIds[a]); u8 *windowIdLoc = &(gUnknown_0203BCC4->windowIds[a]);
if (*windowIdLoc != 0xFF) if (*windowIdLoc != 0xFF)
{ {
sub_8198070(*windowIdLoc, FALSE); ClearStdWindowAndFrameToTransparent(*windowIdLoc, FALSE);
ClearWindowTilemap(*windowIdLoc); ClearWindowTilemap(*windowIdLoc);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
RemoveWindow(*windowIdLoc); RemoveWindow(*windowIdLoc);
@ -977,7 +977,7 @@ static void sub_816BEF0(s32 id)
description = (u8 *)ItemId_GetDescription(gSaveBlock1Ptr->pcItems[id].itemId); description = (u8 *)ItemId_GetDescription(gSaveBlock1Ptr->pcItems[id].itemId);
else else
description = ItemStorage_GetItemPcResponse(ITEMPC_GO_BACK_TO_PREV); description = ItemStorage_GetItemPcResponse(ITEMPC_GO_BACK_TO_PREV);
FillWindowPixelBuffer(windowId, 17); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
AddTextPrinterParameterized(windowId, 1, description, 0, 1, 0, NULL); AddTextPrinterParameterized(windowId, 1, description, 0, 1, 0, NULL);
} }
@ -1005,7 +1005,7 @@ static void sub_816BFE0(u8 y, u8 b, u8 speed)
{ {
u8 windowId = gUnknown_0203BCC4->windowIds[0]; u8 windowId = gUnknown_0203BCC4->windowIds[0];
if (b == 0xFF) if (b == 0xFF)
FillWindowPixelRect(windowId, 17, 0, y, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1)); FillWindowPixelRect(windowId, PIXEL_FILL(1), 0, y, GetMenuCursorDimensionByFont(1, 0), GetMenuCursorDimensionByFont(1, 1));
else else
AddTextPrinterParameterized4(windowId, 1, 0, y, 0, 0, gUnknown_085DFF8C, speed, gText_SelectorArrow2); AddTextPrinterParameterized4(windowId, 1, 0, y, 0, 0, gUnknown_085DFF8C, speed, gText_SelectorArrow2);
} }
@ -1123,7 +1123,7 @@ static const u8* ItemStorage_GetItemPcResponse(u16 itemId)
static void ItemStorage_PrintItemPcResponse(const u8 *string) static void ItemStorage_PrintItemPcResponse(const u8 *string)
{ {
u8 windowId = gUnknown_0203BCC4->windowIds[1]; u8 windowId = gUnknown_0203BCC4->windowIds[1];
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
StringExpandPlaceholders(gStringVar4, string); StringExpandPlaceholders(gStringVar4, string);
AddTextPrinterParameterized(windowId, 1, gStringVar4, 0, 1, 0, NULL); AddTextPrinterParameterized(windowId, 1, gStringVar4, 0, 1, 0, NULL);
} }
@ -1170,7 +1170,7 @@ static void ItemStorage_GoBackToPlayerPCMenu_InitStorage(u8 taskId)
data = gTasks[taskId].data; data = gTasks[taskId].data;
if (!IsDma3ManagerBusyWithBgCopy()) if (!IsDma3ManagerBusyWithBgCopy())
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
if (!data[3]) if (!data[3])
InitItemStorageMenu(taskId, ITEMPC_MENU_WITHDRAW); InitItemStorageMenu(taskId, ITEMPC_MENU_WITHDRAW);
else else

12
src/pokeblock.c
View File

@ -665,7 +665,7 @@ static void HandleInitWindows(void)
for (i = 0; i < ARRAY_COUNT(sWindowTemplatesForPokeblockMenu) - 1; i++) for (i = 0; i < ARRAY_COUNT(sWindowTemplatesForPokeblockMenu) - 1; i++)
{ {
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -749,7 +749,7 @@ static void sub_8135FCC(s32 pkblId)
struct Pokeblock *pokeblock; struct Pokeblock *pokeblock;
u16 rectTilemapSrc[2]; u16 rectTilemapSrc[2];
FillWindowPixelBuffer(7, 0); FillWindowPixelBuffer(7, PIXEL_FILL(0));
if (pkblId != LIST_B_PRESSED) if (pkblId != LIST_B_PRESSED)
{ {
@ -1120,7 +1120,7 @@ static void PutPokeblockOptionsWindow(u8 taskId)
data[1] = 9; data[1] = 9;
sub_8136418(); sub_8136418();
SetWindowBorderStyle(data[1], 0, 1, 0xE); DrawStdFrameWithCustomTileAndPalette(data[1], 0, 1, 0xE);
sub_81995E4(data[1], sPokeblockMenu->optionsNo, sPokeblockMenuActions, sPokeblockMenu->pokeblockOptionsIds); sub_81995E4(data[1], sPokeblockMenu->optionsNo, sPokeblockMenuActions, sPokeblockMenu->pokeblockOptionsIds);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(data[1], sPokeblockMenu->optionsNo, 0); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(data[1], sPokeblockMenu->optionsNo, 0);
PutWindowTilemap(data[1]); PutWindowTilemap(data[1]);
@ -1173,7 +1173,7 @@ static void PokeblockAction_Toss(u8 taskId)
{ {
s16 *data = gTasks[taskId].data; s16 *data = gTasks[taskId].data;
sub_8198070(data[1], FALSE); ClearStdWindowAndFrameToTransparent(data[1], FALSE);
StringCopy(gStringVar1, gPokeblockNames[gSaveBlock1Ptr->pokeblocks[gSpecialVar_ItemId].color]); StringCopy(gStringVar1, gPokeblockNames[gSaveBlock1Ptr->pokeblocks[gSpecialVar_ItemId].color]);
StringExpandPlaceholders(gStringVar4, gText_ThrowAwayVar1); StringExpandPlaceholders(gStringVar4, gText_ThrowAwayVar1);
DisplayMessageAndContinueTask(taskId, 10, 10, 13, 1, GetPlayerTextSpeedDelay(), gStringVar4, CreateTossPokeblockYesNoMenu); DisplayMessageAndContinueTask(taskId, 10, 10, 13, 1, GetPlayerTextSpeedDelay(), gStringVar4, CreateTossPokeblockYesNoMenu);
@ -1219,7 +1219,7 @@ static void HandleErasePokeblock(u8 taskId)
static void TossPokeblockChoice_No(u8 taskId) static void TossPokeblockChoice_No(u8 taskId)
{ {
sub_8197DF8(10, FALSE); ClearDialogWindowAndFrameToTransparent(10, FALSE);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
sub_81363BC(); sub_81363BC();
gTasks[taskId].func = Task_HandlePokeblockMenuInput; gTasks[taskId].func = Task_HandlePokeblockMenuInput;
@ -1266,7 +1266,7 @@ static void PokeblockAction_Cancel(u8 taskId)
{ {
s16 *data = gTasks[taskId].data; s16 *data = gTasks[taskId].data;
sub_8198070(data[1], FALSE); ClearStdWindowAndFrameToTransparent(data[1], FALSE);
schedule_bg_copy_tilemap_to_vram(1); schedule_bg_copy_tilemap_to_vram(1);
sub_81363BC(); sub_81363BC();
gTasks[taskId].func = Task_HandlePokeblockMenuInput; gTasks[taskId].func = Task_HandlePokeblockMenuInput;

4
src/pokeblock_feed.c
View File

@ -581,7 +581,7 @@ static bool8 TransitionToPokeblockFeedScene(void)
gMain.state++; gMain.state++;
break; break;
case 10: case 10:
SetWindowBorderStyle(0, 1, 1, 14); DrawStdFrameWithCustomTileAndPalette(0, 1, 1, 14);
gMain.state++; gMain.state++;
break; break;
case 11: case 11:
@ -704,7 +704,7 @@ static void HandleInitWindows(void)
DeactivateAllTextPrinters(); DeactivateAllTextPrinters();
LoadUserWindowBorderGfx(0, 1, 0xE0); LoadUserWindowBorderGfx(0, 1, 0xE0);
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }

14
src/pokedex.c
View File

@ -2152,7 +2152,7 @@ static void CreateCaughtBall(u16 a, u8 x, u8 y, u16 unused)
if (a) if (a)
BlitBitmapToWindow(0, gUnknown_0855D2BE, x * 8, y * 8, 8, 16); BlitBitmapToWindow(0, gUnknown_0855D2BE, x * 8, y * 8, 8, 16);
else else
FillWindowPixelRect(0, 0, x * 8, y * 8, 8, 16); FillWindowPixelRect(0, PIXEL_FILL(0), x * 8, y * 8, 8, 16);
} }
static u8 CreateMonName(u16 num, u8 left, u8 top) static u8 CreateMonName(u16 num, u8 left, u8 top)
@ -2170,7 +2170,7 @@ static u8 CreateMonName(u16 num, u8 left, u8 top)
void sub_80BD28C(u8 x, u8 y, u16 unused) void sub_80BD28C(u8 x, u8 y, u16 unused)
{ {
FillWindowPixelRect(0, 0, x * 8, y * 8, 0x60, 16); FillWindowPixelRect(0, PIXEL_FILL(0), x * 8, y * 8, 0x60, 16);
} }
static void CreateInitialPokemonSprites(u16 selectedMon, u16 b) static void CreateInitialPokemonSprites(u16 selectedMon, u16 b)
@ -2927,7 +2927,7 @@ void sub_80BEA24(u8 taskId)
case 1: case 1:
DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0); DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0);
CopyToBgTilemapBuffer(3, gPokedexTilemap_DescriptionScreen, 0, 0); CopyToBgTilemapBuffer(3, gPokedexTilemap_DescriptionScreen, 0, 0);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
PutWindowTilemap(1); PutWindowTilemap(1);
sub_80C0D30(1, sPokedexListItem->dexNum); sub_80C0D30(1, sPokedexListItem->dexNum);
@ -3222,7 +3222,7 @@ void sub_80BF250(u8 taskId)
case 1: case 1:
DecompressAndLoadBgGfxUsingHeap(3, &gPokedexMenu_Gfx, 0x2000, 0, 0); DecompressAndLoadBgGfxUsingHeap(3, &gPokedexMenu_Gfx, 0x2000, 0, 0);
CopyToBgTilemapBuffer(3, &gPokedexTilemap_CryScreen, 0, 0); CopyToBgTilemapBuffer(3, &gPokedexTilemap_CryScreen, 0, 0);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
PutWindowTilemap(3); PutWindowTilemap(3);
PutWindowTilemap(2); PutWindowTilemap(2);
@ -3416,7 +3416,7 @@ void sub_80BF82C(u8 taskId)
case 1: case 1:
DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0); DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0);
CopyToBgTilemapBuffer(3, gPokedexTilemap_SizeScreen, 0, 0); CopyToBgTilemapBuffer(3, gPokedexTilemap_SizeScreen, 0, 0);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
gMain.state++; gMain.state++;
break; break;
@ -3766,7 +3766,7 @@ void sub_80BFE38(u8 taskId)
case 1: case 1:
DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0); DecompressAndLoadBgGfxUsingHeap(3, gPokedexMenu_Gfx, 0x2000, 0, 0);
CopyToBgTilemapBuffer(3, gPokedexTilemap_DescriptionScreen, 0, 0); CopyToBgTilemapBuffer(3, gPokedexTilemap_DescriptionScreen, 0, 0);
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
PutWindowTilemap(0); PutWindowTilemap(0);
PutWindowTilemap(1); PutWindowTilemap(1);
sub_80C0D30(1, gTasks[taskId].data[1]); sub_80C0D30(1, gTasks[taskId].data[1]);
@ -4784,7 +4784,7 @@ void sub_80C1270(const u8 *str, u32 left, u32 top)
void sub_80C12B0(u32 x, u32 y, u32 width, u32 height) void sub_80C12B0(u32 x, u32 y, u32 width, u32 height)
{ {
FillWindowPixelRect(0, 0, x, y, width, height); FillWindowPixelRect(0, PIXEL_FILL(0), x, y, width, height);
} }
void sub_80C12E0(u8 taskId) void sub_80C12E0(u8 taskId)

44
src/pokemon_storage_system.c
View File

@ -1552,7 +1552,7 @@ void sub_80C6D80(const u8 *string, void *dst, u8 arg2, u8 arg3, s32 arg4)
winTemplate.width = 24; winTemplate.width = 24;
winTemplate.height = 2; winTemplate.height = 2;
windowId = AddWindow(&winTemplate); windowId = AddWindow(&winTemplate);
FillWindowPixelBuffer(windowId, (arg3 << 4) | arg3); FillWindowPixelBuffer(windowId, PIXEL_FILL(arg3));
tileData1 = (u8*) GetWindowAttribute(windowId, WINDOW_TILE_DATA); tileData1 = (u8*) GetWindowAttribute(windowId, WINDOW_TILE_DATA);
tileData2 = (winTemplate.width * 32) + tileData1; tileData2 = (winTemplate.width * 32) + tileData1;
@ -1599,7 +1599,7 @@ void sub_80C6EAC(const u8 *string, void *dst, u16 arg2, u8 arg3, u8 clr2, u8 clr
winTemplate.height = 2; winTemplate.height = 2;
var = winTemplate.width * 32; var = winTemplate.width * 32;
windowId = AddWindow(&winTemplate); windowId = AddWindow(&winTemplate);
FillWindowPixelBuffer(windowId, (arg3 << 4) | arg3); FillWindowPixelBuffer(windowId, PIXEL_FILL(arg3));
tileData1 = (u8*) GetWindowAttribute(windowId, WINDOW_TILE_DATA); tileData1 = (u8*) GetWindowAttribute(windowId, WINDOW_TILE_DATA);
tileData2 = (winTemplate.width * 32) + tileData1; tileData2 = (winTemplate.width * 32) + tileData1;
txtColor[0] = arg3; txtColor[0] = arg3;
@ -1736,8 +1736,8 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
case 0: case 0:
CreatePCMenu(task->data[1], &task->data[15]); CreatePCMenu(task->data[1], &task->data[15]);
sub_81973A4(); sub_81973A4();
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, TEXT_SPEED_FF, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, TEXT_SPEED_FF, NULL, 2, 1, 3);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
CopyWindowToVram(task->data[15], 3); CopyWindowToVram(task->data[15], 3);
@ -1763,13 +1763,13 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
if (task->data[1] != task->data[3]) if (task->data[1] != task->data[3])
{ {
task->data[1] = task->data[3]; task->data[1] = task->data[3];
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3);
} }
break; break;
case MENU_B_PRESSED: case MENU_B_PRESSED:
case 4: case 4:
sub_819746C(task->data[15], TRUE); ClearStdWindowAndFrame(task->data[15], TRUE);
ScriptContext2_Disable(); ScriptContext2_Disable();
EnableBothScriptContexts(); EnableBothScriptContexts();
RemoveWindow(task->data[15]); RemoveWindow(task->data[15]);
@ -1778,13 +1778,13 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
default: default:
if (task->data[2] == 0 && CountPartyMons() == PARTY_SIZE) if (task->data[2] == 0 && CountPartyMons() == PARTY_SIZE)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gText_PartyFull, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_PartyFull, 0, NULL, 2, 1, 3);
task->data[0] = 3; task->data[0] = 3;
} }
else if (task->data[2] == 1 && CountPartyMons() == 1) else if (task->data[2] == 1 && CountPartyMons() == 1)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gText_JustOnePkmn, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gText_JustOnePkmn, 0, NULL, 2, 1, 3);
task->data[0] = 3; task->data[0] = 3;
} }
@ -1799,7 +1799,7 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
case 3: case 3:
if (gMain.newKeys & (A_BUTTON | B_BUTTON)) if (gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3);
task->data[0] = 2; task->data[0] = 2;
} }
@ -1809,7 +1809,7 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
task->data[1] = 4; task->data[1] = 4;
Menu_MoveCursor(-1); Menu_MoveCursor(-1);
task->data[1] = Menu_GetCursorPos(); task->data[1] = Menu_GetCursorPos();
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3);
task->data[0] = 2; task->data[0] = 2;
} }
@ -1819,7 +1819,7 @@ static void Task_PokemonStorageSystemPC(u8 taskId)
task->data[1] = 0; task->data[1] = 0;
Menu_MoveCursor(1); Menu_MoveCursor(1);
task->data[1] = Menu_GetCursorPos(); task->data[1] = Menu_GetCursorPos();
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_085716C0[task->data[1]].desc, 0, NULL, 2, 1, 3);
task->data[0] = 2; task->data[0] = 2;
} }
@ -1865,7 +1865,7 @@ static void CreatePCMenu(u8 whichMenu, s16 *windowIdPtr)
winTemplate.width = GetMaxWidthInMenuTable((void *)gUnknown_085716C0, ARRAY_COUNT(gUnknown_085716C0)); winTemplate.width = GetMaxWidthInMenuTable((void *)gUnknown_085716C0, ARRAY_COUNT(gUnknown_085716C0));
windowId = AddWindow(&winTemplate); windowId = AddWindow(&winTemplate);
NewMenuHelpers_DrawStdWindowFrame(windowId, FALSE); DrawStdWindowFrame(windowId, FALSE);
PrintMenuTable(windowId, ARRAY_COUNT(gUnknown_085716C0), (void *)gUnknown_085716C0); PrintMenuTable(windowId, ARRAY_COUNT(gUnknown_085716C0), (void *)gUnknown_085716C0);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(windowId, ARRAY_COUNT(gUnknown_085716C0), whichMenu); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(windowId, ARRAY_COUNT(gUnknown_085716C0), whichMenu);
*windowIdPtr = windowId; *windowIdPtr = windowId;
@ -2103,7 +2103,7 @@ static void sub_80C7BE4(void)
winTemplate.height = 4; winTemplate.height = 4;
windowId = AddWindow(&winTemplate); windowId = AddWindow(&winTemplate);
FillWindowPixelBuffer(windowId, 0x44); FillWindowPixelBuffer(windowId, PIXEL_FILL(4));
center = GetStringCenterAlignXOffset(1, boxName, 64); center = GetStringCenterAlignXOffset(1, boxName, 64);
AddTextPrinterParameterized3(windowId, 1, center, 1, gUnknown_08571734, TEXT_SPEED_FF, boxName); AddTextPrinterParameterized3(windowId, 1, center, 1, gUnknown_08571734, TEXT_SPEED_FF, boxName);
@ -4107,7 +4107,7 @@ static void LoadCursorMonGfx(u16 species, u32 pid)
static void PrintCursorMonInfo(void) static void PrintCursorMonInfo(void)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
if (sPSSData->boxOption != BOX_OPTION_MOVE_ITEMS) if (sPSSData->boxOption != BOX_OPTION_MOVE_ITEMS)
{ {
AddTextPrinterParameterized(0, 1, sPSSData->cursorMonNickText, 6, 0, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, sPSSData->cursorMonNickText, 6, 0, TEXT_SPEED_FF, NULL);
@ -4416,7 +4416,7 @@ static void PrintStorageActionText(u8 id)
} }
DynamicPlaceholderTextUtil_ExpandPlaceholders(sPSSData->field_2190, gPCStorageActionTexts[id].text); DynamicPlaceholderTextUtil_ExpandPlaceholders(sPSSData->field_2190, gPCStorageActionTexts[id].text);
FillWindowPixelBuffer(1, 0x11); FillWindowPixelBuffer(1, PIXEL_FILL(1));
AddTextPrinterParameterized(1, 1, sPSSData->field_2190, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(1, 1, sPSSData->field_2190, 0, 1, TEXT_SPEED_FF, NULL);
sub_8098858(1, 2, 14); sub_8098858(1, 2, 14);
PutWindowTilemap(1); PutWindowTilemap(1);
@ -4432,7 +4432,7 @@ static void ShowYesNoWindow(s8 cursorPos)
static void ClearBottomWindow(void) static void ClearBottomWindow(void)
{ {
sub_8198070(1, FALSE); ClearStdWindowAndFrameToTransparent(1, FALSE);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }
@ -8733,7 +8733,7 @@ static void AddMenu(void)
sPSSData->menuWindow.tilemapTop = 15 - sPSSData->menuWindow.height; sPSSData->menuWindow.tilemapTop = 15 - sPSSData->menuWindow.height;
sPSSData->field_CB0 = AddWindow(&sPSSData->menuWindow); sPSSData->field_CB0 = AddWindow(&sPSSData->menuWindow);
ClearWindowTilemap(sPSSData->field_CB0); ClearWindowTilemap(sPSSData->field_CB0);
SetWindowBorderStyle(sPSSData->field_CB0, FALSE, 11, 14); DrawStdFrameWithCustomTileAndPalette(sPSSData->field_CB0, FALSE, 11, 14);
PrintMenuTable(sPSSData->field_CB0, sPSSData->menuItemsCount, (void*)sPSSData->menuItems); PrintMenuTable(sPSSData->field_CB0, sPSSData->menuItemsCount, (void*)sPSSData->menuItems);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(sPSSData->field_CB0, sPSSData->menuItemsCount, 0); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(sPSSData->field_CB0, sPSSData->menuItemsCount, 0);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -8787,7 +8787,7 @@ static s16 sub_80D00AC(void)
static void sub_80D013C(void) static void sub_80D013C(void)
{ {
sub_8198070(sPSSData->field_CB0, TRUE); ClearStdWindowAndFrameToTransparent(sPSSData->field_CB0, TRUE);
RemoveWindow(sPSSData->field_CB0); RemoveWindow(sPSSData->field_CB0);
} }
@ -8835,7 +8835,7 @@ static bool8 sub_80D0164(void)
sPSSData->field_2200 = AddWindow8Bit(&gUnknown_0857BB1C); sPSSData->field_2200 = AddWindow8Bit(&gUnknown_0857BB1C);
if (sPSSData->field_2200 != 0xFF) if (sPSSData->field_2200 != 0xFF)
{ {
FillWindowPixelBuffer(sPSSData->field_2200, 0); FillWindowPixelBuffer(sPSSData->field_2200, PIXEL_FILL(0));
return TRUE; return TRUE;
} }
} }
@ -8892,7 +8892,7 @@ static bool8 sub_80D024C(void)
ChangeBgX(0, -1024, 0); ChangeBgX(0, -1024, 0);
ChangeBgY(0, -1024, 0); ChangeBgY(0, -1024, 0);
FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x20, 0x20); FillBgTilemapBufferRect_Palette0(0, 0, 0, 0, 0x20, 0x20);
FillWindowPixelBuffer8Bit(sPSSData->field_2200, 0); FillWindowPixelBuffer8Bit(sPSSData->field_2200, PIXEL_FILL(0));
sub_80D07B0(sMoveMonsPtr->fromRow, sMoveMonsPtr->fromColumn); sub_80D07B0(sMoveMonsPtr->fromRow, sMoveMonsPtr->fromColumn);
SetBgAttribute(0, BG_ATTR_PALETTEMODE, 1); SetBgAttribute(0, BG_ATTR_PALETTEMODE, 1);
PutWindowTilemap(sPSSData->field_2200); PutWindowTilemap(sPSSData->field_2200);
@ -9194,7 +9194,7 @@ static void sub_80D0834(u8 arg0, u8 arg1)
if (species != SPECIES_NONE) if (species != SPECIES_NONE)
{ {
FillWindowPixelRect8Bit(sPSSData->field_2200, FillWindowPixelRect8Bit(sPSSData->field_2200,
0, PIXEL_FILL(0),
24 * arg0, 24 * arg0,
24 * arg1, 24 * arg1,
32, 32,
@ -9911,7 +9911,7 @@ static void PrintItemDescription(void)
else else
description = ItemId_GetDescription(sPSSData->cursorMonItem); description = ItemId_GetDescription(sPSSData->cursorMonItem);
FillWindowPixelBuffer(2, 0x11); FillWindowPixelBuffer(2, PIXEL_FILL(1));
AddTextPrinterParameterized5(2, 1, description, 4, 0, 0, NULL, 0, 1); AddTextPrinterParameterized5(2, 1, description, 4, 0, 0, NULL, 0, 1);
} }

28
src/pokemon_summary_screen.c
View File

@ -2629,7 +2629,7 @@ static void ResetWindows(void)
for (i = 0; i < 20; i++) for (i = 0; i < 20; i++)
{ {
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
for (i = 0; i < ARRAY_COUNT(pssData->windowIds); i++) for (i = 0; i < ARRAY_COUNT(pssData->windowIds); i++)
{ {
@ -2644,9 +2644,9 @@ static void SummaryScreen_PrintTextOnWindow(u8 windowId, const u8 *string, u8 x,
static void sub_81C25E8(void) static void sub_81C25E8(void)
{ {
FillWindowPixelBuffer(17, 0); FillWindowPixelBuffer(17, PIXEL_FILL(0));
FillWindowPixelBuffer(18, 0); FillWindowPixelBuffer(18, PIXEL_FILL(0));
FillWindowPixelBuffer(19, 0); FillWindowPixelBuffer(19, PIXEL_FILL(0));
if (!pssData->summary.isEgg) if (!pssData->summary.isEgg)
sub_81C2628(); sub_81C2628();
else else
@ -2898,7 +2898,7 @@ static u8 AddWindowFromTemplateList(const struct WindowTemplate *template, u8 te
if (*windowIdPtr == 0xFF) if (*windowIdPtr == 0xFF)
{ {
*windowIdPtr = AddWindow(&template[templateId]); *windowIdPtr = AddWindow(&template[templateId]);
FillWindowPixelBuffer(*windowIdPtr, 0); FillWindowPixelBuffer(*windowIdPtr, PIXEL_FILL(0));
} }
return *windowIdPtr; return *windowIdPtr;
} }
@ -2920,7 +2920,7 @@ static void PrintPageSpecificText(u8 pageIndex)
for (i = 0; i < ARRAY_COUNT(pssData->windowIds); i++) for (i = 0; i < ARRAY_COUNT(pssData->windowIds); i++)
{ {
if (pssData->windowIds[i] != 0xFF) if (pssData->windowIds[i] != 0xFF)
FillWindowPixelBuffer(pssData->windowIds[i], 0); FillWindowPixelBuffer(pssData->windowIds[i], PIXEL_FILL(0));
} }
sTextPrinterFunctions[pageIndex](); sTextPrinterFunctions[pageIndex]();
} }
@ -3469,7 +3469,7 @@ static void PrintMovePowerAndAccuracy(u16 moveIndex)
const u8 *text; const u8 *text;
if (moveIndex != 0) if (moveIndex != 0)
{ {
FillWindowPixelRect(14, 0, 53, 0, 19, 32); FillWindowPixelRect(14, PIXEL_FILL(0), 53, 0, 19, 32);
if (gBattleMoves[moveIndex].power < 2) if (gBattleMoves[moveIndex].power < 2)
{ {
@ -3567,7 +3567,7 @@ static void PrintContestMoveDescription(u8 moveSlot)
static void PrintMoveDetails(u16 move) static void PrintMoveDetails(u16 move)
{ {
u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 2); u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 2);
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
if (move != MOVE_NONE) if (move != MOVE_NONE)
{ {
if (pssData->currPageIndex == 2) if (pssData->currPageIndex == 2)
@ -3619,7 +3619,7 @@ static void PrintNewMoveDetailsOrCancelText(void)
static void sub_81C4064(void) static void sub_81C4064(void)
{ {
u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 0); u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 0);
FillWindowPixelRect(windowId, 0, 0, 66, 72, 16); FillWindowPixelRect(windowId, PIXEL_FILL(0), 0, 66, 72, 16);
CopyWindowToVram(windowId, 2); CopyWindowToVram(windowId, 2);
} }
@ -3628,11 +3628,11 @@ static void sub_81C40A0(u8 moveIndex1, u8 moveIndex2)
u8 windowId1 = AddWindowFromTemplateList(sPageMovesTemplate, 0); u8 windowId1 = AddWindowFromTemplateList(sPageMovesTemplate, 0);
u8 windowId2 = AddWindowFromTemplateList(sPageMovesTemplate, 1); u8 windowId2 = AddWindowFromTemplateList(sPageMovesTemplate, 1);
FillWindowPixelRect(windowId1, 0, 0, moveIndex1 * 16, 0x48, 0x10); FillWindowPixelRect(windowId1, PIXEL_FILL(0), 0, moveIndex1 * 16, 0x48, 0x10);
FillWindowPixelRect(windowId1, 0, 0, moveIndex2 * 16, 0x48, 0x10); FillWindowPixelRect(windowId1, PIXEL_FILL(0), 0, moveIndex2 * 16, 0x48, 0x10);
FillWindowPixelRect(windowId2, 0, 0, moveIndex1 * 16, 0x30, 0x10); FillWindowPixelRect(windowId2, PIXEL_FILL(0), 0, moveIndex1 * 16, 0x30, 0x10);
FillWindowPixelRect(windowId2, 0, 0, moveIndex2 * 16, 0x30, 0x10); FillWindowPixelRect(windowId2, PIXEL_FILL(0), 0, moveIndex2 * 16, 0x30, 0x10);
PrintMoveNameAndPP(moveIndex1); PrintMoveNameAndPP(moveIndex1);
PrintMoveNameAndPP(moveIndex2); PrintMoveNameAndPP(moveIndex2);
@ -3641,7 +3641,7 @@ static void sub_81C40A0(u8 moveIndex1, u8 moveIndex2)
static void PrintHMMovesCantBeForgotten(void) static void PrintHMMovesCantBeForgotten(void)
{ {
u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 2); u8 windowId = AddWindowFromTemplateList(sPageMovesTemplate, 2);
FillWindowPixelBuffer(windowId, 0); FillWindowPixelBuffer(windowId, PIXEL_FILL(0));
SummaryScreen_PrintTextOnWindow(windowId, gText_HMMovesCantBeForgotten2, 6, 1, 0, 0); SummaryScreen_PrintTextOnWindow(windowId, gText_HMMovesCantBeForgotten2, 6, 1, 0, 0);
} }

4
src/pokenav.c
View File

@ -1138,8 +1138,8 @@ bool32 IsDma3ManagerBusyWithBgCopy_(void)
void sub_81C7BF8(u32 windowId) void sub_81C7BF8(u32 windowId)
{ {
FillWindowPixelBuffer(windowId, 0x44); FillWindowPixelBuffer(windowId, PIXEL_FILL(4));
FillWindowPixelRect(windowId, 0x55, 0, 0, 0x80, 1); FillWindowPixelRect(windowId, PIXEL_FILL(5), 0, 0, 0x80, 1);
} }
void sub_81C7C28(void) void sub_81C7C28(void)

4
src/record_mixing.c
View File

@ -293,7 +293,7 @@ static void ReceiveExchangePacket(u32 which)
static void PrintTextOnRecordMixing(const u8 *src) static void PrintTextOnRecordMixing(const u8 *src)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, src, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, src, 0, 1, 0, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
@ -372,7 +372,7 @@ static void Task_RecordMixing_Main(u8 taskId)
{ {
CreateTask(sub_80AF2B4, 10); CreateTask(sub_80AF2B4, 10);
} }
sub_8197434(0, 1); ClearDialogWindowAndFrame(0, 1);
DestroyTask(taskId); DestroyTask(taskId);
EnableBothScriptContexts(); EnableBothScriptContexts();
} }

18
src/region_map.c
View File

@ -1622,7 +1622,7 @@ void MCB2_FlyMap(void)
case 7: case 7:
LoadPalette(sRegionMapFramePal, 0x10, 0x20); LoadPalette(sRegionMapFramePal, 0x10, 0x20);
PutWindowTilemap(2); PutWindowTilemap(2);
FillWindowPixelBuffer(2, 0x00); FillWindowPixelBuffer(2, PIXEL_FILL(0));
AddTextPrinterParameterized(2, 1, gText_FlyToWhere, 0, 1, 0, NULL); AddTextPrinterParameterized(2, 1, gText_FlyToWhere, 0, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
gMain.state++; gMain.state++;
@ -1687,8 +1687,8 @@ static void sub_8124904(void)
{ {
StringLength(gUnknown_085A1EDC[i].name[sFlyMap->regionMap.posWithinMapSec]); StringLength(gUnknown_085A1EDC[i].name[sFlyMap->regionMap.posWithinMapSec]);
flag = TRUE; flag = TRUE;
sub_8198070(0, FALSE); ClearStdWindowAndFrameToTransparent(0, FALSE);
SetWindowBorderStyle(1, FALSE, 0x65, 0x0d); DrawStdFrameWithCustomTileAndPalette(1, FALSE, 0x65, 0x0d);
AddTextPrinterParameterized(1, 1, sFlyMap->regionMap.mapSecName, 0, 1, 0, NULL); AddTextPrinterParameterized(1, 1, sFlyMap->regionMap.mapSecName, 0, 1, 0, NULL);
name = gUnknown_085A1EDC[i].name[sFlyMap->regionMap.posWithinMapSec]; name = gUnknown_085A1EDC[i].name[sFlyMap->regionMap.posWithinMapSec];
AddTextPrinterParameterized(1, 1, name, GetStringRightAlignXOffset(1, name, 0x60), 0x11, 0, NULL); AddTextPrinterParameterized(1, 1, name, GetStringRightAlignXOffset(1, name, 0x60), 0x11, 0, NULL);
@ -1702,12 +1702,12 @@ static void sub_8124904(void)
{ {
if (gUnknown_03001180 == TRUE) if (gUnknown_03001180 == TRUE)
{ {
sub_8198070(1, FALSE); ClearStdWindowAndFrameToTransparent(1, FALSE);
SetWindowBorderStyle(0, FALSE, 0x65, 0x0d); DrawStdFrameWithCustomTileAndPalette(0, FALSE, 0x65, 0x0d);
} }
else else
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
} }
AddTextPrinterParameterized(0, 1, sFlyMap->regionMap.mapSecName, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, sFlyMap->regionMap.mapSecName, 0, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -1718,10 +1718,10 @@ static void sub_8124904(void)
{ {
if (gUnknown_03001180 == TRUE) if (gUnknown_03001180 == TRUE)
{ {
sub_8198070(1, FALSE); ClearStdWindowAndFrameToTransparent(1, FALSE);
SetWindowBorderStyle(0, FALSE, 0x65, 0x0d); DrawStdFrameWithCustomTileAndPalette(0, FALSE, 0x65, 0x0d);
} }
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
CopyWindowToVram(0, 2); CopyWindowToVram(0, 2);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
gUnknown_03001180 = FALSE; gUnknown_03001180 = FALSE;

10
src/reset_rtc_screen.c
View File

@ -290,7 +290,7 @@ static void FreeCursorPalette(void)
static void HideChooseTimeWindow(u8 windowId) static void HideChooseTimeWindow(u8 windowId)
{ {
sub_8198070(windowId, FALSE); ClearStdWindowAndFrameToTransparent(windowId, FALSE);
RemoveWindow(windowId); RemoveWindow(windowId);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }
@ -319,7 +319,7 @@ static void PrintTime(u8 windowId, u8 x, u8 y, u16 days, u8 hours, u8 minutes, u
static void ShowChooseTimeWindow(u8 windowId, u16 days, u8 hours, u8 minutes, u8 seconds) static void ShowChooseTimeWindow(u8 windowId, u16 days, u8 hours, u8 minutes, u8 seconds)
{ {
SetWindowBorderStyle(windowId, FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(windowId, FALSE, 0x214, 0xE);
PrintTime(windowId, 0, 1, days, hours, minutes, seconds); PrintTime(windowId, 0, 1, days, hours, minutes, seconds);
AddTextPrinterParameterized(windowId, 1, gText_Confirm2, 126, 1, 0, NULL); AddTextPrinterParameterized(windowId, 1, gText_Confirm2, 126, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -495,7 +495,7 @@ static void VBlankCB(void)
static void ShowMessage(const u8 *str) static void ShowMessage(const u8 *str)
{ {
sub_8197B1C(1, FALSE, 0x200, 0xF); DrawDialogFrameWithCustomTileAndPalette(1, FALSE, 0x200, 0xF);
AddTextPrinterParameterized(1, 1, str, 0, 1, 0, NULL); AddTextPrinterParameterized(1, 1, str, 0, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
} }
@ -507,7 +507,7 @@ static void Task_ShowResetRtcPrompt(u8 taskId)
switch (data[0]) switch (data[0])
{ {
case 0: case 0:
SetWindowBorderStyle(0, FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(0, FALSE, 0x214, 0xE);
AddTextPrinterParameterized(0, 1, gText_PresentTime, 0, 1, TEXT_SPEED_FF, 0); AddTextPrinterParameterized(0, 1, gText_PresentTime, 0, 1, TEXT_SPEED_FF, 0);
PrintTime( PrintTime(
0, 0,
@ -574,7 +574,7 @@ static void Task_ResetRtcScreen(u8 taskId)
case 2: case 2:
if (gTasks[data[1]].isActive != TRUE) if (gTasks[data[1]].isActive != TRUE)
{ {
sub_8198070(0, FALSE); ClearStdWindowAndFrameToTransparent(0, FALSE);
ShowMessage(gText_PleaseResetTime); ShowMessage(gText_PleaseResetTime);
gLocalTime = gSaveBlock2Ptr->lastBerryTreeUpdate; gLocalTime = gSaveBlock2Ptr->lastBerryTreeUpdate;
data[1] = CreateTask(Task_ResetRtc_0, 80); data[1] = CreateTask(Task_ResetRtc_0, 80);

24
src/rom_8011DC0.c
View File

@ -387,7 +387,7 @@ void nullsub_89(void)
void sub_80124EC(u8 windowId, u8 arg1, u8 stringId) void sub_80124EC(u8 windowId, u8 arg1, u8 stringId)
{ {
FillWindowPixelBuffer(windowId, 0x11); FillWindowPixelBuffer(windowId, PIXEL_FILL(1));
switch (arg1 << 8) switch (arg1 << 8)
{ {
case 0x200: case 0x200:
@ -506,17 +506,17 @@ void sub_8012780(u8 taskId)
} }
data->field_11 = AddWindow(&gUnknown_082F012C); data->field_11 = AddWindow(&gUnknown_082F012C);
FillWindowPixelBuffer(data->field_10, 0x22); FillWindowPixelBuffer(data->field_10, PIXEL_FILL(2));
sub_80173E0(data->field_10, 0, gUnknown_082EDBC4, 8, 1, 4); sub_80173E0(data->field_10, 0, gUnknown_082EDBC4, 8, 1, 4);
PutWindowTilemap(data->field_10); PutWindowTilemap(data->field_10);
CopyWindowToVram(data->field_10, 2); CopyWindowToVram(data->field_10, 2);
NewMenuHelpers_DrawStdWindowFrame(data->listWindowId, FALSE); DrawStdWindowFrame(data->listWindowId, FALSE);
gMultiuseListMenuTemplate = gUnknown_082F015C; gMultiuseListMenuTemplate = gUnknown_082F015C;
gMultiuseListMenuTemplate.windowId = data->listWindowId; gMultiuseListMenuTemplate.windowId = data->listWindowId;
data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0); data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0);
NewMenuHelpers_DrawStdWindowFrame(data->field_11, FALSE); DrawStdWindowFrame(data->field_11, FALSE);
PutWindowTilemap(data->field_11); PutWindowTilemap(data->field_11);
CopyWindowToVram(data->field_11, 2); CopyWindowToVram(data->field_11, 2);
@ -786,10 +786,10 @@ void sub_8012780(u8 taskId)
void sub_8012F64(struct UnkStruct_Leader *data) void sub_8012F64(struct UnkStruct_Leader *data)
{ {
ClearWindowTilemap(data->field_11); ClearWindowTilemap(data->field_11);
sub_819746C(data->field_11, FALSE); ClearStdWindowAndFrame(data->field_11, FALSE);
DestroyListMenuTask(data->listTaskId, 0, 0); DestroyListMenuTask(data->listTaskId, 0, 0);
ClearWindowTilemap(data->field_10); ClearWindowTilemap(data->field_10);
sub_819746C(data->listWindowId, FALSE); ClearStdWindowAndFrame(data->listWindowId, FALSE);
CopyBgTilemapBufferToVram(0); CopyBgTilemapBufferToVram(0);
RemoveWindow(data->field_11); RemoveWindow(data->field_11);
RemoveWindow(data->listWindowId); RemoveWindow(data->listWindowId);
@ -1075,17 +1075,17 @@ void sub_80134E8(u8 taskId)
data->listWindowId = AddWindow(&gUnknown_082F0174); data->listWindowId = AddWindow(&gUnknown_082F0174);
data->field_D = AddWindow(&gUnknown_082F017C); data->field_D = AddWindow(&gUnknown_082F017C);
FillWindowPixelBuffer(data->field_C, 0x22); FillWindowPixelBuffer(data->field_C, PIXEL_FILL(2));
sub_80173E0(data->field_C, 0, gUnknown_082EF7DC, 8, 1, 4); sub_80173E0(data->field_C, 0, gUnknown_082EF7DC, 8, 1, 4);
PutWindowTilemap(data->field_C); PutWindowTilemap(data->field_C);
CopyWindowToVram(data->field_C, 2); CopyWindowToVram(data->field_C, 2);
NewMenuHelpers_DrawStdWindowFrame(data->listWindowId, FALSE); DrawStdWindowFrame(data->listWindowId, FALSE);
gMultiuseListMenuTemplate = gUnknown_082F0204; gMultiuseListMenuTemplate = gUnknown_082F0204;
gMultiuseListMenuTemplate.windowId = data->listWindowId; gMultiuseListMenuTemplate.windowId = data->listWindowId;
data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0); data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0);
NewMenuHelpers_DrawStdWindowFrame(data->field_D, FALSE); DrawStdWindowFrame(data->field_D, FALSE);
PutWindowTilemap(data->field_D); PutWindowTilemap(data->field_D);
sub_80125BC(data->field_D); sub_80125BC(data->field_D);
CopyWindowToVram(data->field_D, 2); CopyWindowToVram(data->field_D, 2);
@ -1254,10 +1254,10 @@ void sub_80134E8(u8 taskId)
case 18: case 18:
case 20: case 20:
ClearWindowTilemap(data->field_D); ClearWindowTilemap(data->field_D);
sub_819746C(data->field_D, FALSE); ClearStdWindowAndFrame(data->field_D, FALSE);
DestroyListMenuTask(data->listTaskId, 0, 0); DestroyListMenuTask(data->listTaskId, 0, 0);
ClearWindowTilemap(data->field_C); ClearWindowTilemap(data->field_C);
sub_819746C(data->listWindowId, FALSE); ClearStdWindowAndFrame(data->listWindowId, FALSE);
CopyBgTilemapBufferToVram(0); CopyBgTilemapBufferToVram(0);
RemoveWindow(data->field_D); RemoveWindow(data->field_D);
RemoveWindow(data->listWindowId); RemoveWindow(data->listWindowId);
@ -2155,7 +2155,7 @@ void sub_8014F48(u8 taskId)
data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0); data->listTaskId = ListMenuInit(&gMultiuseListMenuTemplate, 0, 0);
sub_8018784(data->field_D); sub_8018784(data->field_D);
FillWindowPixelBuffer(data->field_D, 0x11); FillWindowPixelBuffer(data->field_D, PIXEL_FILL(1));
PutWindowTilemap(data->field_D); PutWindowTilemap(data->field_D);
sub_80125BC(data->field_D); sub_80125BC(data->field_D);
CopyWindowToVram(data->field_D, 2); CopyWindowToVram(data->field_D, 2);

40
src/roulette.c
View File

@ -973,7 +973,7 @@ static void sub_81405CC(void)
sub_814372C(6); sub_814372C(6);
sub_81436D0(0); sub_81436D0(0);
sub_81424FC(0); sub_81424FC(0);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5B89, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5B89, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
gSpriteCoordOffsetX = -60; gSpriteCoordOffsetX = -60;
@ -1043,8 +1043,8 @@ static void sub_81408A8(u8 taskId)
static void sub_8140914(u8 taskId) static void sub_8140914(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, 0); DrawStdWindowFrame(gUnknown_0203AB8C, 0);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C13, 0, 1, TEXT_SPEED_FF, 0); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C13, 0, 1, TEXT_SPEED_FF, 0);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
DoYesNoFuncWithChoice(taskId, &gUnknown_085B6410); DoYesNoFuncWithChoice(taskId, &gUnknown_085B6410);
@ -1052,7 +1052,7 @@ static void sub_8140914(u8 taskId)
static void sub_8140968(u8 taskId) static void sub_8140968(u8 taskId)
{ {
sub_819746C(0, TRUE); ClearStdWindowAndFrame(0, TRUE);
gTasks[taskId].func = sub_8140BD0; gTasks[taskId].func = sub_8140BD0;
} }
@ -1808,14 +1808,14 @@ static void sub_814189C(u8 taskId)
if (gTasks[taskId].data[2] == 12) if (gTasks[taskId].data[2] == 12)
{ {
PlayFanfare(MUS_ME_B_BIG); PlayFanfare(MUS_ME_B_BIG);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BD7, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BD7, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
} }
else else
{ {
PlayFanfare(MUS_ME_B_SMALL); PlayFanfare(MUS_ME_B_SMALL);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BCB, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BCB, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
} }
@ -1823,7 +1823,7 @@ static void sub_814189C(u8 taskId)
case 0: case 0:
default: default:
m4aSongNumStart(SE_HAZURE); m4aSongNumStart(SE_HAZURE);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BE0, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5BE0, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
break; break;
@ -1867,7 +1867,7 @@ static void sub_8141A18(u8 taskId)
{ {
ConvertIntToDecimalStringN(gStringVar1, (gUnknown_0203AB88->var19 * gTasks[taskId].data[2]), STR_CONV_MODE_LEFT_ALIGN, 2); ConvertIntToDecimalStringN(gStringVar1, (gUnknown_0203AB88->var19 * gTasks[taskId].data[2]), STR_CONV_MODE_LEFT_ALIGN, 2);
StringExpandPlaceholders(gStringVar4, gUnknown_082A5BEF); StringExpandPlaceholders(gStringVar4, gUnknown_082A5BEF);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
gTasks[taskId].data[1] = (gUnknown_0203AB88->var19 * gTasks[taskId].data[2]); gTasks[taskId].data[1] = (gUnknown_0203AB88->var19 * gTasks[taskId].data[2]);
@ -1900,14 +1900,14 @@ static void sub_8141B58(u8 taskId)
{ {
if (gTasks[taskId].data[6] == 6) if (gTasks[taskId].data[6] == 6)
{ {
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C21, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C21, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
sub_8141F7C(taskId, dp01t_12_3_battle_menu, 0xFFFF, 3); sub_8141F7C(taskId, dp01t_12_3_battle_menu, 0xFFFF, 3);
} }
else if (gTasks[taskId].data[13] == 9999) else if (gTasks[taskId].data[13] == 9999)
{ {
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C61, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C61, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
sub_8141F7C(taskId, sub_8140914, 0xFFFF, 0x3); sub_8141F7C(taskId, sub_8140914, 0xFFFF, 0x3);
@ -1919,7 +1919,7 @@ static void sub_8141B58(u8 taskId)
} }
else else
{ {
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C04, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C04, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
sub_8141F7C(taskId, sub_8140994, 0x3C, 0x3); sub_8141F7C(taskId, sub_8140994, 0x3C, 0x3);
@ -1944,7 +1944,7 @@ static void dp01t_12_3_battle_menu(u8 taskId)
if (gTasks[taskId].data[13] == 9999) if (gTasks[taskId].data[13] == 9999)
{ {
NewMenuHelpers_DrawStdWindowFrame(gUnknown_0203AB8C, FALSE); DrawStdWindowFrame(gUnknown_0203AB8C, FALSE);
AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C61, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(gUnknown_0203AB8C, 1, gUnknown_082A5C61, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(gUnknown_0203AB8C, 3); CopyWindowToVram(gUnknown_0203AB8C, 3);
sub_8141F7C(taskId, sub_8140914, 0xFFFF, 3); sub_8141F7C(taskId, sub_8140914, 0xFFFF, 3);
@ -3256,7 +3256,7 @@ static const struct SpriteTemplate gUnknown_085B7AEC =
static void sub_81428C4(u8 r0) static void sub_81428C4(u8 r0)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(r0, &gUnknown_085B6408); DoYesNoFuncWithChoice(r0, &gUnknown_085B6408);
} }
@ -3272,7 +3272,7 @@ static void sub_81428E4(u8 taskId)
static void sub_8142918(u8 taskId) static void sub_8142918(u8 taskId)
{ {
sub_819746C(0, TRUE); ClearStdWindowAndFrame(0, TRUE);
HideCoinsWindow(); HideCoinsWindow();
FreeAllWindowBuffers(); FreeAllWindowBuffers();
BeginNormalPaletteFade(0xFFFFFFFF, 0, 0, 16, RGB_BLACK); BeginNormalPaletteFade(0xFFFFFFFF, 0, 0, 16, RGB_BLACK);
@ -3283,7 +3283,7 @@ static void sub_8142918(u8 taskId)
static void sub_814297C(u8 taskId) static void sub_814297C(u8 taskId)
{ {
sub_819746C(0, FALSE); ClearStdWindowAndFrame(0, FALSE);
HideCoinsWindow(); HideCoinsWindow();
ScriptContext2_Disable(); ScriptContext2_Disable();
DestroyTask(taskId); DestroyTask(taskId);
@ -3296,7 +3296,7 @@ static void sub_81429A0(u8 taskId)
{ {
gSpecialVar_0x8004 = 1; gSpecialVar_0x8004 = 1;
HideCoinsWindow(); HideCoinsWindow();
sub_819746C(0, TRUE); ClearStdWindowAndFrame(0, TRUE);
ScriptContext2_Disable(); ScriptContext2_Disable();
DestroyTask(taskId); DestroyTask(taskId);
} }
@ -3309,7 +3309,7 @@ static void sub_81429F0(u8 taskId)
u32 temp = gUnknown_085B6344[(gSpecialVar_0x8004 & 1) + (gSpecialVar_0x8004 >> 7 << 1)]; u32 temp = gUnknown_085B6344[(gSpecialVar_0x8004 & 1) + (gSpecialVar_0x8004 >> 7 << 1)];
ConvertIntToDecimalStringN(gStringVar1, temp, STR_CONV_MODE_LEADING_ZEROS, 1); ConvertIntToDecimalStringN(gStringVar1, temp, STR_CONV_MODE_LEADING_ZEROS, 1);
StringExpandPlaceholders(gStringVar4, gUnknown_082A5B12); StringExpandPlaceholders(gStringVar4, gUnknown_082A5B12);
NewMenuHelpers_DrawStdWindowFrame(0, FALSE); DrawStdWindowFrame(0, FALSE);
AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = sub_81428C4; gTasks[taskId].func = sub_81428C4;
@ -3326,7 +3326,7 @@ static void Task_Roulette_0(u8 taskId)
{ {
if ((gSpecialVar_0x8004 & 0x80) && (gSpecialVar_0x8004 & 1)) if ((gSpecialVar_0x8004 & 0x80) && (gSpecialVar_0x8004 & 1))
{ {
NewMenuHelpers_DrawStdWindowFrame(0, FALSE); DrawStdWindowFrame(0, FALSE);
AddTextPrinterParameterized(0, 1, gUnknown_082A5B6B, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, gUnknown_082A5B6B, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = sub_81429F0; gTasks[taskId].func = sub_81429F0;
@ -3334,7 +3334,7 @@ static void Task_Roulette_0(u8 taskId)
else else
{ {
StringExpandPlaceholders(gStringVar4, gUnknown_082A5B12); StringExpandPlaceholders(gStringVar4, gUnknown_082A5B12);
NewMenuHelpers_DrawStdWindowFrame(0, FALSE); DrawStdWindowFrame(0, FALSE);
AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = sub_81428C4; gTasks[taskId].func = sub_81428C4;
@ -3343,7 +3343,7 @@ static void Task_Roulette_0(u8 taskId)
else else
{ {
StringExpandPlaceholders(gStringVar4, gUnknown_082A5B4E); StringExpandPlaceholders(gStringVar4, gUnknown_082A5B4E);
NewMenuHelpers_DrawStdWindowFrame(0, FALSE); DrawStdWindowFrame(0, FALSE);
AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, gStringVar4, 0, 1, TEXT_SPEED_FF, NULL);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gTasks[taskId].func = sub_81429A0; gTasks[taskId].func = sub_81429A0;

20
src/save_failed_screen.c
View File

@ -229,10 +229,10 @@ static void CB2_SaveFailedScreen(void)
LoadPalette(sSaveFailedClockPal, 0x100, 0x20); LoadPalette(sSaveFailedClockPal, 0x100, 0x20);
LoadPalette(gTextWindowFrame1_Pal, 0xE0, 0x20); LoadPalette(gTextWindowFrame1_Pal, 0xE0, 0x20);
LoadPalette(gUnknown_0860F074, 0xF0, 0x20); LoadPalette(gUnknown_0860F074, 0xF0, 0x20);
SetWindowBorderStyle(gSaveFailedWindowIds[TEXT_WIN_ID], FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(gSaveFailedWindowIds[TEXT_WIN_ID], FALSE, 0x214, 0xE);
SetWindowBorderStyle(gSaveFailedWindowIds[CLOCK_WIN_ID], FALSE, 0x214, 0xE); DrawStdFrameWithCustomTileAndPalette(gSaveFailedWindowIds[CLOCK_WIN_ID], FALSE, 0x214, 0xE);
FillWindowPixelBuffer(gSaveFailedWindowIds[CLOCK_WIN_ID], 0x11); // backwards? FillWindowPixelBuffer(gSaveFailedWindowIds[CLOCK_WIN_ID], PIXEL_FILL(1)); // backwards?
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
CopyWindowToVram(gSaveFailedWindowIds[CLOCK_WIN_ID], 2); // again? CopyWindowToVram(gSaveFailedWindowIds[CLOCK_WIN_ID], 2); // again?
CopyWindowToVram(gSaveFailedWindowIds[TEXT_WIN_ID], 1); CopyWindowToVram(gSaveFailedWindowIds[TEXT_WIN_ID], 1);
SaveFailedScreenTextPrint(gText_SaveFailedCheckingBackup, 1, 0); SaveFailedScreenTextPrint(gText_SaveFailedCheckingBackup, 1, 0);
@ -265,19 +265,19 @@ static void CB2_WipeSave(void)
{ {
if (WipeSectors(gDamagedSaveSectors) != FALSE) if (WipeSectors(gDamagedSaveSectors) != FALSE)
{ {
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
SaveFailedScreenTextPrint(gText_BackupMemoryDamaged, 1, 0); SaveFailedScreenTextPrint(gText_BackupMemoryDamaged, 1, 0);
SetMainCallback2(CB2_GameplayCannotBeContinued); SetMainCallback2(CB2_GameplayCannotBeContinued);
return; return;
} }
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
SaveFailedScreenTextPrint(gText_CheckCompleted, 1, 0); SaveFailedScreenTextPrint(gText_CheckCompleted, 1, 0);
HandleSavingData(gSaveFailedType); HandleSavingData(gSaveFailedType);
if (gDamagedSaveSectors != 0) if (gDamagedSaveSectors != 0)
{ {
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
SaveFailedScreenTextPrint(gText_SaveFailedCheckingBackup, 1, 0); SaveFailedScreenTextPrint(gText_SaveFailedCheckingBackup, 1, 0);
} }
@ -286,12 +286,12 @@ static void CB2_WipeSave(void)
if (wipeTries == 3) if (wipeTries == 3)
{ {
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
SaveFailedScreenTextPrint(gText_BackupMemoryDamaged, 1, 0); SaveFailedScreenTextPrint(gText_BackupMemoryDamaged, 1, 0);
} }
else else
{ {
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
if (gGameContinueCallback == NULL) if (gGameContinueCallback == NULL)
SaveFailedScreenTextPrint(gText_SaveCompleteGameCannotContinue, 1, 0); SaveFailedScreenTextPrint(gText_SaveCompleteGameCannotContinue, 1, 0);
@ -308,7 +308,7 @@ static void CB2_GameplayCannotBeContinued(void)
if (gMain.newKeys & A_BUTTON) if (gMain.newKeys & A_BUTTON)
{ {
FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], 0x11); FillWindowPixelBuffer(gSaveFailedWindowIds[TEXT_WIN_ID], PIXEL_FILL(1));
SaveFailedScreenTextPrint(gText_GamePlayCannotBeContinued, 1, 0); SaveFailedScreenTextPrint(gText_GamePlayCannotBeContinued, 1, 0);
SetVBlankCallback(VBlankCB); SetVBlankCallback(VBlankCB);
SetMainCallback2(CB2_FadeAndReturnToTitleScreen); SetMainCallback2(CB2_FadeAndReturnToTitleScreen);

8
src/scrcmd.c
View File

@ -1302,7 +1302,7 @@ bool8 ScrCmd_cmdDB(struct ScriptContext *ctx)
if (msg == NULL) if (msg == NULL)
msg = (const u8 *)ctx->data[0]; msg = (const u8 *)ctx->data[0];
sub_81973A4(); sub_81973A4();
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
AddTextPrinterParameterized(0, 1, msg, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, msg, 0, 1, 0, 0);
return FALSE; return FALSE;
} }
@ -1517,9 +1517,9 @@ bool8 ScrCmd_braillemessage(struct ScriptContext *ctx)
winTemplate = CreateWindowTemplate(0, xWindow, yWindow + 1, width, height, 0xF, 0x1); winTemplate = CreateWindowTemplate(0, xWindow, yWindow + 1, width, height, 0xF, 0x1);
gUnknown_03000F30 = AddWindow(&winTemplate); gUnknown_03000F30 = AddWindow(&winTemplate);
LoadUserWindowBorderGfx(gUnknown_03000F30, 0x214, 0xE0); LoadUserWindowBorderGfx(gUnknown_03000F30, 0x214, 0xE0);
NewMenuHelpers_DrawStdWindowFrame(gUnknown_03000F30, 0); DrawStdWindowFrame(gUnknown_03000F30, 0);
PutWindowTilemap(gUnknown_03000F30); PutWindowTilemap(gUnknown_03000F30);
FillWindowPixelBuffer(gUnknown_03000F30, 0x11); FillWindowPixelBuffer(gUnknown_03000F30, PIXEL_FILL(1));
AddTextPrinterParameterized(gUnknown_03000F30, 6, gStringVar4, xText, yText, 0xFF, 0x0); AddTextPrinterParameterized(gUnknown_03000F30, 6, gStringVar4, xText, yText, 0xFF, 0x0);
CopyWindowToVram(gUnknown_03000F30, 3); CopyWindowToVram(gUnknown_03000F30, 3);
return FALSE; return FALSE;
@ -2254,7 +2254,7 @@ bool8 ScrCmd_setmonmetlocation(struct ScriptContext *ctx)
void sub_809BDB4(void) void sub_809BDB4(void)
{ {
sub_819746C(gUnknown_03000F30, 1); ClearStdWindowAndFrame(gUnknown_03000F30, 1);
RemoveWindow(gUnknown_03000F30); RemoveWindow(gUnknown_03000F30);
} }

16
src/script_menu.c
View File

@ -1202,7 +1202,7 @@ bool8 ScriptMenu_YesNo(u8 left, u8 top)
else else
{ {
gSpecialVar_Result = 0xFF; gSpecialVar_Result = 0xFF;
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
taskId = CreateTask(Task_HandleYesNoInput, 0x50); taskId = CreateTask(Task_HandleYesNoInput, 0x50);
return TRUE; return TRUE;
} }
@ -1630,7 +1630,7 @@ u8 CreateWindowFromRect(u8 x, u8 y, u8 width, u8 height)
void sub_80E2A78(u8 windowId) void sub_80E2A78(u8 windowId)
{ {
sub_8198070(windowId, TRUE); ClearStdWindowAndFrameToTransparent(windowId, TRUE);
RemoveWindow(windowId); RemoveWindow(windowId);
} }
@ -1639,27 +1639,27 @@ static void sub_80E2A94(u8 multichoiceId)
switch (multichoiceId) switch (multichoiceId)
{ {
case 77: case 77:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BBAC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BBAC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
case 76: case 76:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BB9C[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BB9C[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
case 78: case 78:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BBBC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BBBC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
case 79: case 79:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BBCC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BBCC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
case 75: case 75:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BBEC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BBEC[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
case 74: case 74:
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, 1, gUnknown_0858BBE0[Menu_GetCursorPos()], 0, NULL, 2, 1, 3); AddTextPrinterParameterized2(0, 1, gUnknown_0858BBE0[Menu_GetCursorPos()], 0, NULL, 2, 1, 3);
break; break;
} }

16
src/secret_base.c
View File

@ -871,7 +871,7 @@ void sub_80E9C9C(u8 taskId)
{ {
data[1] = 0; data[1] = 0;
data[2] = 0; data[2] = 0;
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
gUnknown_0203A020 = calloc(1, sizeof(struct SecretBaseListMenuBuffer)); gUnknown_0203A020 = calloc(1, sizeof(struct SecretBaseListMenuBuffer));
data[6] = AddWindow(&gUnknown_0858D06C[0]); data[6] = AddWindow(&gUnknown_0858D06C[0]);
game_continue(taskId); game_continue(taskId);
@ -963,7 +963,7 @@ void sub_80E9E90(u8 taskId)
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
DestroyListMenuTask(data[5], NULL, NULL); DestroyListMenuTask(data[5], NULL, NULL);
RemoveScrollIndicatorArrowPair(data[8]); RemoveScrollIndicatorArrowPair(data[8]);
sub_819746C(data[6], 0); ClearStdWindowAndFrame(data[6], 0);
ClearWindowTilemap(data[6]); ClearWindowTilemap(data[6]);
RemoveWindow(data[6]); RemoveWindow(data[6]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -1020,8 +1020,8 @@ void sub_80E9FFC(u8 taskId)
s16 *data; s16 *data;
data = gTasks[taskId].data; data = gTasks[taskId].data;
sub_819746C(data[6], FALSE); ClearStdWindowAndFrame(data[6], FALSE);
sub_819746C(data[7], FALSE); ClearStdWindowAndFrame(data[7], FALSE);
ClearWindowTilemap(data[6]); ClearWindowTilemap(data[6]);
ClearWindowTilemap(data[7]); ClearWindowTilemap(data[7]);
RemoveWindow(data[7]); RemoveWindow(data[7]);
@ -1033,7 +1033,7 @@ void sub_80E9FFC(u8 taskId)
void sub_80EA06C(u8 taskId) void sub_80EA06C(u8 taskId)
{ {
DisplayYesNoMenu(); DisplayYesNoMenuDefaultYes();
DoYesNoFuncWithChoice(taskId, &gUnknown_0858D058); DoYesNoFuncWithChoice(taskId, &gUnknown_0858D058);
} }
@ -1042,7 +1042,7 @@ void sub_80EA08C(u8 taskId)
s16 *data; s16 *data;
data = gTasks[taskId].data; data = gTasks[taskId].data;
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
DestroyListMenuTask(data[5], &data[2], &data[1]); DestroyListMenuTask(data[5], &data[2], &data[1]);
gSaveBlock1Ptr->secretBases[data[4]].sbr_field_1_6 = 0; gSaveBlock1Ptr->secretBases[data[4]].sbr_field_1_6 = 0;
game_continue(taskId); game_continue(taskId);
@ -1061,7 +1061,7 @@ void sub_80EA13C(u8 taskId)
s16 *data; s16 *data;
data = gTasks[taskId].data; data = gTasks[taskId].data;
sub_8197434(0, 0); ClearDialogWindowAndFrame(0, 0);
DestroyListMenuTask(data[5], &data[2], &data[1]); DestroyListMenuTask(data[5], &data[2], &data[1]);
sub_80E9E00(taskId); sub_80E9E00(taskId);
gTasks[taskId].func = sub_80E9E90; gTasks[taskId].func = sub_80E9E90;
@ -1073,7 +1073,7 @@ void sub_80EA18C(u8 taskId)
data = gTasks[taskId].data; data = gTasks[taskId].data;
sub_80E9E44(taskId); sub_80E9E44(taskId);
sub_819746C(data[7], 0); ClearStdWindowAndFrame(data[7], 0);
ClearWindowTilemap(data[7]); ClearWindowTilemap(data[7]);
RemoveWindow(data[7]); RemoveWindow(data[7]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);

20
src/shop.c
View File

@ -366,7 +366,7 @@ void CB2_ExitSellMenu(void)
static void Task_HandleShopMenuQuit(u8 taskId) static void Task_HandleShopMenuQuit(u8 taskId)
{ {
sub_8198070(gMartInfo.windowId, 2); ClearStdWindowAndFrameToTransparent(gMartInfo.windowId, 2);
RemoveWindow(gMartInfo.windowId); RemoveWindow(gMartInfo.windowId);
SaveRecordedItemPurchasesForTVShow(); SaveRecordedItemPurchasesForTVShow();
ScriptContext2_Disable(); ScriptContext2_Disable();
@ -545,7 +545,7 @@ static void BuyMenuPrintItemDescriptionAndShowItemIcon(int item, bool8 onInit, s
description = gText_QuitShopping; description = gText_QuitShopping;
} }
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
BuyMenuPrint(2, description, 3, 1, 0, 0); BuyMenuPrint(2, description, 3, 1, 0, 0);
} }
@ -981,12 +981,12 @@ static void Task_BuyHowManyDialogueInit(u8 taskId)
u16 quantityInBag = CountTotalItemQuantityInBag(tItemId); u16 quantityInBag = CountTotalItemQuantityInBag(tItemId);
u16 maxQuantity; u16 maxQuantity;
SetWindowBorderStyle(3, FALSE, 1, 13); DrawStdFrameWithCustomTileAndPalette(3, FALSE, 1, 13);
ConvertIntToDecimalStringN(gStringVar1, quantityInBag, STR_CONV_MODE_RIGHT_ALIGN, 4); ConvertIntToDecimalStringN(gStringVar1, quantityInBag, STR_CONV_MODE_RIGHT_ALIGN, 4);
StringExpandPlaceholders(gStringVar4, gText_InBagVar1); StringExpandPlaceholders(gStringVar4, gText_InBagVar1);
BuyMenuPrint(3, gStringVar4, 0, 1, 0, 0); BuyMenuPrint(3, gStringVar4, 0, 1, 0, 0);
tItemCount = 1; tItemCount = 1;
SetWindowBorderStyle(4, FALSE, 1, 13); DrawStdFrameWithCustomTileAndPalette(4, FALSE, 1, 13);
BuyMenuPrintItemQuantityAndPrice(taskId); BuyMenuPrintItemQuantityAndPrice(taskId);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -1018,8 +1018,8 @@ static void Task_BuyHowManyDialogueHandleInput(u8 taskId)
if (gMain.newKeys & A_BUTTON) if (gMain.newKeys & A_BUTTON)
{ {
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(4, 0); ClearStdWindowAndFrameToTransparent(4, 0);
sub_8198070(3, 0); ClearStdWindowAndFrameToTransparent(3, 0);
ClearWindowTilemap(4); ClearWindowTilemap(4);
ClearWindowTilemap(3); ClearWindowTilemap(3);
PutWindowTilemap(1); PutWindowTilemap(1);
@ -1031,8 +1031,8 @@ static void Task_BuyHowManyDialogueHandleInput(u8 taskId)
else if (gMain.newKeys & B_BUTTON) else if (gMain.newKeys & B_BUTTON)
{ {
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(4, 0); ClearStdWindowAndFrameToTransparent(4, 0);
sub_8198070(3, 0); ClearStdWindowAndFrameToTransparent(3, 0);
ClearWindowTilemap(4); ClearWindowTilemap(4);
ClearWindowTilemap(3); ClearWindowTilemap(3);
BuyMenuReturnToItemList(taskId); BuyMenuReturnToItemList(taskId);
@ -1131,7 +1131,7 @@ static void BuyMenuReturnToItemList(u8 taskId)
{ {
s16 *data = gTasks[taskId].data; s16 *data = gTasks[taskId].data;
sub_8197DF8(5, 0); ClearDialogWindowAndFrameToTransparent(5, 0);
BuyMenuPrintCursor(tListTaskId, 1); BuyMenuPrintCursor(tListTaskId, 1);
PutWindowTilemap(1); PutWindowTilemap(1);
PutWindowTilemap(2); PutWindowTilemap(2);
@ -1144,7 +1144,7 @@ static void BuyMenuPrintItemQuantityAndPrice(u8 taskId)
{ {
s16 *data = gTasks[taskId].data; s16 *data = gTasks[taskId].data;
FillWindowPixelBuffer(4, 0x11); FillWindowPixelBuffer(4, PIXEL_FILL(1));
PrintMoneyAmount(4, 38, 1, gShopDataPtr->totalCost, TEXT_SPEED_FF); PrintMoneyAmount(4, 38, 1, gShopDataPtr->totalCost, TEXT_SPEED_FF);
ConvertIntToDecimalStringN(gStringVar1, tItemCount, 2, 2); ConvertIntToDecimalStringN(gStringVar1, tItemCount, 2, 2);
StringExpandPlaceholders(gStringVar4, gText_xVar1); StringExpandPlaceholders(gStringVar4, gText_xVar1);

22
src/slot_machine.c
View File

@ -1025,7 +1025,7 @@ static bool8 SlotAction_AwaitPlayerInput(struct Task *task)
static bool8 SlotAction_PrintYouDontHaveThreeCoins(struct Task *task) static bool8 SlotAction_PrintYouDontHaveThreeCoins(struct Task *task)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, gText_YouDontHaveThreeCoins, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_YouDontHaveThreeCoins, 0, 1, 0, 0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
sSlotMachine->state = 7; sSlotMachine->state = 7;
@ -1036,7 +1036,7 @@ static bool8 SlotAction_ExitYouDontHaveThreeCoinsMessage(struct Task *task)
{ {
if (gMain.newKeys & (A_BUTTON | B_BUTTON)) if (gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sSlotMachine->state = 5; sSlotMachine->state = 5;
} }
return FALSE; return FALSE;
@ -1274,7 +1274,7 @@ static bool8 SlotAction_NoMatches(struct Task *task)
static bool8 SlotAction_PrintQuitTheGame(struct Task *task) static bool8 SlotAction_PrintQuitTheGame(struct Task *task)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, gText_QuitTheGame, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_QuitTheGame, 0, 1, 0, 0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
CreateYesNoMenuParameterized(0x15, 7, 0x214, 0x180, 0xE, 0xF); CreateYesNoMenuParameterized(0x15, 7, 0x214, 0x180, 0xE, 0xF);
@ -1287,7 +1287,7 @@ static bool8 SlotAction_SeeIfPlayerQuits(struct Task *task)
s8 input = Menu_ProcessInputNoWrapClearOnChoose(); s8 input = Menu_ProcessInputNoWrapClearOnChoose();
if (input == 0) // player chooses to quit if (input == 0) // player chooses to quit
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sub_8103D8C(0); sub_8103D8C(0);
sub_8103D8C(1); sub_8103D8C(1);
sub_8103D8C(2); sub_8103D8C(2);
@ -1296,7 +1296,7 @@ static bool8 SlotAction_SeeIfPlayerQuits(struct Task *task)
} }
else if (input == 1 || input == -1) // player chooses not to quit else if (input == 1 || input == -1) // player chooses not to quit
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sSlotMachine->state = 5; sSlotMachine->state = 5;
} }
return FALSE; return FALSE;
@ -1304,7 +1304,7 @@ static bool8 SlotAction_SeeIfPlayerQuits(struct Task *task)
static bool8 SlotAction_PrintMessage_9999Coins(struct Task *task) static bool8 SlotAction_PrintMessage_9999Coins(struct Task *task)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, gText_YouveGot9999Coins, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_YouveGot9999Coins, 0, 1, 0, 0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
sSlotMachine->state = 24; sSlotMachine->state = 24;
@ -1315,7 +1315,7 @@ static bool8 SlotAction_ExitMessage_9999Coins(struct Task *task)
{ {
if (gMain.newKeys & (A_BUTTON | B_BUTTON)) if (gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sSlotMachine->state = 5; sSlotMachine->state = 5;
} }
return FALSE; return FALSE;
@ -1323,7 +1323,7 @@ static bool8 SlotAction_ExitMessage_9999Coins(struct Task *task)
static bool8 SlotAction_PrintMessage_NoMoreCoins(struct Task *task) static bool8 SlotAction_PrintMessage_NoMoreCoins(struct Task *task)
{ {
NewMenuHelpers_DrawDialogueFrame(0, 0); DrawDialogueFrame(0, 0);
AddTextPrinterParameterized(0, 1, gText_YouveRunOutOfCoins, 0, 1, 0, 0); AddTextPrinterParameterized(0, 1, gText_YouveRunOutOfCoins, 0, 1, 0, 0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
sSlotMachine->state = 26; sSlotMachine->state = 26;
@ -1334,7 +1334,7 @@ static bool8 SlotAction_ExitMessage_NoMoreCoins(struct Task *task)
{ {
if (gMain.newKeys & (A_BUTTON | B_BUTTON)) if (gMain.newKeys & (A_BUTTON | B_BUTTON))
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
sSlotMachine->state = 27; sSlotMachine->state = 27;
} }
return FALSE; return FALSE;
@ -3120,7 +3120,7 @@ static void InfoBox_8104B80(struct Task *task)
sub_81065DC(); sub_81065DC();
AddWindow(&gUnknown_085A7444); AddWindow(&gUnknown_085A7444);
PutWindowTilemap(1); PutWindowTilemap(1);
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
task->data[0]++; task->data[0]++;
} }
@ -3136,7 +3136,7 @@ static void InfoBox_AwaitPlayerInput(struct Task *task)
{ {
if (gMain.newKeys & (B_BUTTON | SELECT_BUTTON)) if (gMain.newKeys & (B_BUTTON | SELECT_BUTTON))
{ {
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
ClearWindowTilemap(1); ClearWindowTilemap(1);
CopyWindowToVram(1, 1); CopyWindowToVram(1, 1);
RemoveWindow(1); RemoveWindow(1);

46
src/start_menu.c
View File

@ -123,7 +123,7 @@ static u8 SaveConfirmSaveCallback(void);
static u8 SaveYesNoCallback(void); static u8 SaveYesNoCallback(void);
static u8 SaveConfirmInputCallback(void); static u8 SaveConfirmInputCallback(void);
static u8 SaveFileExistsCallback(void); static u8 SaveFileExistsCallback(void);
static u8 SaveConfirmOverwriteNoCallback(void); static u8 SaveConfirmOverwriteDefaultNoCallback(void);
static u8 SaveConfirmOverwriteCallback(void); static u8 SaveConfirmOverwriteCallback(void);
static u8 SaveOverwriteInputCallback(void); static u8 SaveOverwriteInputCallback(void);
static u8 SaveSavingMessageCallback(void); static u8 SaveSavingMessageCallback(void);
@ -376,7 +376,7 @@ static void ShowSafariBallsWindow(void)
{ {
sSafariBallsWindowId = AddWindow(&sSafariBallsWindowTemplate); sSafariBallsWindowId = AddWindow(&sSafariBallsWindowTemplate);
PutWindowTilemap(sSafariBallsWindowId); PutWindowTilemap(sSafariBallsWindowId);
NewMenuHelpers_DrawStdWindowFrame(sSafariBallsWindowId, FALSE); DrawStdWindowFrame(sSafariBallsWindowId, FALSE);
ConvertIntToDecimalStringN(gStringVar1, gNumSafariBalls, STR_CONV_MODE_RIGHT_ALIGN, 2); ConvertIntToDecimalStringN(gStringVar1, gNumSafariBalls, STR_CONV_MODE_RIGHT_ALIGN, 2);
StringExpandPlaceholders(gStringVar4, gText_SafariBallStock); StringExpandPlaceholders(gStringVar4, gText_SafariBallStock);
AddTextPrinterParameterized(sSafariBallsWindowId, 1, gStringVar4, 0, 1, 0xFF, NULL); AddTextPrinterParameterized(sSafariBallsWindowId, 1, gStringVar4, 0, 1, 0xFF, NULL);
@ -391,7 +391,7 @@ static void ShowPyramidFloorWindow(void)
sBattlePyramidFloorWindowId = AddWindow(&sPyramidFloorWindowTemplate_2); sBattlePyramidFloorWindowId = AddWindow(&sPyramidFloorWindowTemplate_2);
PutWindowTilemap(sBattlePyramidFloorWindowId); PutWindowTilemap(sBattlePyramidFloorWindowId);
NewMenuHelpers_DrawStdWindowFrame(sBattlePyramidFloorWindowId, FALSE); DrawStdWindowFrame(sBattlePyramidFloorWindowId, FALSE);
StringCopy(gStringVar1, sPyramindFloorNames[gSaveBlock2Ptr->frontier.curChallengeBattleNum]); StringCopy(gStringVar1, sPyramindFloorNames[gSaveBlock2Ptr->frontier.curChallengeBattleNum]);
StringExpandPlaceholders(gStringVar4, gText_BattlePyramidFloor); StringExpandPlaceholders(gStringVar4, gText_BattlePyramidFloor);
AddTextPrinterParameterized(sBattlePyramidFloorWindowId, 1, gStringVar4, 0, 1, 0xFF, NULL); AddTextPrinterParameterized(sBattlePyramidFloorWindowId, 1, gStringVar4, 0, 1, 0xFF, NULL);
@ -402,13 +402,13 @@ static void RemoveExtraStartMenuWindows(void)
{ {
if (GetSafariZoneFlag()) if (GetSafariZoneFlag())
{ {
sub_8198070(sSafariBallsWindowId, FALSE); ClearStdWindowAndFrameToTransparent(sSafariBallsWindowId, FALSE);
CopyWindowToVram(sSafariBallsWindowId, 2); CopyWindowToVram(sSafariBallsWindowId, 2);
RemoveWindow(sSafariBallsWindowId); RemoveWindow(sSafariBallsWindowId);
} }
if (InBattlePyramid()) if (InBattlePyramid())
{ {
sub_8198070(sBattlePyramidFloorWindowId, FALSE); ClearStdWindowAndFrameToTransparent(sBattlePyramidFloorWindowId, FALSE);
RemoveWindow(sBattlePyramidFloorWindowId); RemoveWindow(sBattlePyramidFloorWindowId);
} }
} }
@ -459,7 +459,7 @@ static bool32 InitStartMenuStep(void)
break; break;
case 2: case 2:
sub_81973A4(); sub_81973A4();
NewMenuHelpers_DrawStdWindowFrame(sub_81979C4(sNumStartMenuActions), FALSE); DrawStdWindowFrame(sub_81979C4(sNumStartMenuActions), FALSE);
sUnknown_02037619[1] = 0; sUnknown_02037619[1] = 0;
sUnknown_02037619[0]++; sUnknown_02037619[0]++;
break; break;
@ -751,7 +751,7 @@ static bool8 StartMenuBattlePyramidRetireCallback(void)
void sub_809FDD4(void) void sub_809FDD4(void)
{ {
sub_8197DF8(0, FALSE); ClearDialogWindowAndFrameToTransparent(0, FALSE);
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
CreateStartMenuTask(sub_809FA34); CreateStartMenuTask(sub_809FA34);
ScriptContext2_Enable(); ScriptContext2_Enable();
@ -787,13 +787,13 @@ static bool8 SaveCallback(void)
case SAVE_IN_PROGRESS: case SAVE_IN_PROGRESS:
return FALSE; return FALSE;
case SAVE_CANCELED: // Back to start menu case SAVE_CANCELED: // Back to start menu
sub_8197DF8(0, FALSE); ClearDialogWindowAndFrameToTransparent(0, FALSE);
InitStartMenu(); InitStartMenu();
gMenuCallback = HandleStartMenuInput; gMenuCallback = HandleStartMenuInput;
return FALSE; return FALSE;
case SAVE_SUCCESS: case SAVE_SUCCESS:
case SAVE_ERROR: // Close start menu case SAVE_ERROR: // Close start menu
sub_8197DF8(0, TRUE); ClearDialogWindowAndFrameToTransparent(0, TRUE);
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
ScriptContext2_Disable(); ScriptContext2_Disable();
SoftResetInBattlePyramid(); SoftResetInBattlePyramid();
@ -830,7 +830,7 @@ static bool8 BattlePyramidRetireCallback(void)
case SAVE_IN_PROGRESS: case SAVE_IN_PROGRESS:
return FALSE; return FALSE;
case SAVE_CANCELED: // Yes (Retire from battle pyramid) case SAVE_CANCELED: // Yes (Retire from battle pyramid)
sub_8197DF8(0, TRUE); ClearDialogWindowAndFrameToTransparent(0, TRUE);
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
ScriptContext2_Disable(); ScriptContext2_Disable();
ScriptContext1_SetupScript(BattleFrontier_BattlePyramidEmptySquare_EventScript_252C88); ScriptContext1_SetupScript(BattleFrontier_BattlePyramidEmptySquare_EventScript_252C88);
@ -897,7 +897,7 @@ static void SaveGameTask(u8 taskId)
static void sub_80A0014(void) static void sub_80A0014(void)
{ {
sub_8197434(0, TRUE); ClearDialogWindowAndFrame(0, TRUE);
} }
static void HideSaveInfoWindow(void) static void HideSaveInfoWindow(void)
@ -943,7 +943,7 @@ static bool8 SaveErrorTimer(void)
static u8 SaveConfirmSaveCallback(void) static u8 SaveConfirmSaveCallback(void)
{ {
sub_819746C(GetStartMenuWindowId(), FALSE); ClearStdWindowAndFrame(GetStartMenuWindowId(), FALSE);
RemoveStartMenuWindow(); RemoveStartMenuWindow();
ShowSaveInfoWindow(); ShowSaveInfoWindow();
@ -961,7 +961,7 @@ static u8 SaveConfirmSaveCallback(void)
static u8 SaveYesNoCallback(void) static u8 SaveYesNoCallback(void)
{ {
DisplayYesNoMenu(); // Show Yes/No menu DisplayYesNoMenuDefaultYes(); // Show Yes/No menu
sSaveDialogCallback = SaveConfirmInputCallback; sSaveDialogCallback = SaveConfirmInputCallback;
return SAVE_IN_PROGRESS; return SAVE_IN_PROGRESS;
} }
@ -1002,7 +1002,7 @@ static u8 SaveFileExistsCallback(void)
{ {
if (gDifferentSaveFile == TRUE) if (gDifferentSaveFile == TRUE)
{ {
ShowSaveMessage(gText_DifferentSaveFile, SaveConfirmOverwriteNoCallback); ShowSaveMessage(gText_DifferentSaveFile, SaveConfirmOverwriteDefaultNoCallback);
} }
else else
{ {
@ -1012,16 +1012,16 @@ static u8 SaveFileExistsCallback(void)
return SAVE_IN_PROGRESS; return SAVE_IN_PROGRESS;
} }
static u8 SaveConfirmOverwriteNoCallback(void) static u8 SaveConfirmOverwriteDefaultNoCallback(void)
{ {
sub_8197948(1); // Show Yes/No menu (No selected as default) DisplayYesNoMenuWithDefault(1); // Show Yes/No menu (No selected as default)
sSaveDialogCallback = SaveOverwriteInputCallback; sSaveDialogCallback = SaveOverwriteInputCallback;
return SAVE_IN_PROGRESS; return SAVE_IN_PROGRESS;
} }
static u8 SaveConfirmOverwriteCallback(void) static u8 SaveConfirmOverwriteCallback(void)
{ {
DisplayYesNoMenu(); // Show Yes/No menu DisplayYesNoMenuDefaultYes(); // Show Yes/No menu
sSaveDialogCallback = SaveOverwriteInputCallback; sSaveDialogCallback = SaveOverwriteInputCallback;
return SAVE_IN_PROGRESS; return SAVE_IN_PROGRESS;
} }
@ -1135,7 +1135,7 @@ static void InitBattlePyramidRetire(void)
static u8 BattlePyramidConfirmRetireCallback(void) static u8 BattlePyramidConfirmRetireCallback(void)
{ {
sub_819746C(GetStartMenuWindowId(), FALSE); ClearStdWindowAndFrame(GetStartMenuWindowId(), FALSE);
RemoveStartMenuWindow(); RemoveStartMenuWindow();
ShowSaveMessage(gText_BattlePyramidConfirmRetire, BattlePyramidRetireYesNoCallback); ShowSaveMessage(gText_BattlePyramidConfirmRetire, BattlePyramidRetireYesNoCallback);
@ -1144,7 +1144,7 @@ static u8 BattlePyramidConfirmRetireCallback(void)
static u8 BattlePyramidRetireYesNoCallback(void) static u8 BattlePyramidRetireYesNoCallback(void)
{ {
sub_8197948(1); // Show Yes/No menu (No selected as default) DisplayYesNoMenuWithDefault(1); // Show Yes/No menu (No selected as default)
sSaveDialogCallback = BattlePyramidRetireInputCallback; sSaveDialogCallback = BattlePyramidRetireInputCallback;
return SAVE_IN_PROGRESS; return SAVE_IN_PROGRESS;
@ -1232,7 +1232,7 @@ static void sub_80A0550(u8 taskId)
switch (*step) switch (*step)
{ {
case 0: case 0:
FillWindowPixelBuffer(0, 17); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized2(0, AddTextPrinterParameterized2(0,
1, 1,
gText_SavingDontTurnOffPower, gText_SavingDontTurnOffPower,
@ -1313,7 +1313,7 @@ static void ShowSaveInfoWindow(void)
} }
sSaveInfoWindowId = AddWindow(&saveInfoWindow); sSaveInfoWindowId = AddWindow(&saveInfoWindow);
NewMenuHelpers_DrawStdWindowFrame(sSaveInfoWindowId, FALSE); DrawStdWindowFrame(sSaveInfoWindowId, FALSE);
gender = gSaveBlock2Ptr->playerGender; gender = gSaveBlock2Ptr->playerGender;
color = TEXT_COLOR_RED; // Red when female, blue when male. color = TEXT_COLOR_RED; // Red when female, blue when male.
@ -1364,7 +1364,7 @@ static void ShowSaveInfoWindow(void)
static void RemoveSaveInfoWindow(void) static void RemoveSaveInfoWindow(void)
{ {
sub_819746C(sSaveInfoWindowId, FALSE); ClearStdWindowAndFrame(sSaveInfoWindowId, FALSE);
RemoveWindow(sSaveInfoWindowId); RemoveWindow(sSaveInfoWindowId);
} }
@ -1386,7 +1386,7 @@ void sub_80A08CC(void) // Referenced in data/specials.inc and data/scripts/maps/
static void HideStartMenuWindow(void) static void HideStartMenuWindow(void)
{ {
sub_819746C(GetStartMenuWindowId(), TRUE); ClearStdWindowAndFrame(GetStartMenuWindowId(), TRUE);
RemoveStartMenuWindow(); RemoveStartMenuWindow();
ScriptUnfreezeEventObjects(); ScriptUnfreezeEventObjects();
ScriptContext2_Disable(); ScriptContext2_Disable();

8
src/starter_choose.c
View File

@ -469,7 +469,7 @@ static void MainCallback2_StarterChoose(void)
static void Task_StarterChoose1(u8 taskId) static void Task_StarterChoose1(u8 taskId)
{ {
CreateStarterPokemonLabel(gTasks[taskId].tStarterSelection); CreateStarterPokemonLabel(gTasks[taskId].tStarterSelection);
SetWindowBorderStyle(0, FALSE, 0x2A8, 0xD); DrawStdFrameWithCustomTileAndPalette(0, FALSE, 0x2A8, 0xD);
AddTextPrinterParameterized(0, 1, gText_BirchInTrouble, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, gText_BirchInTrouble, 0, 1, 0, NULL);
PutWindowTilemap(0); PutWindowTilemap(0);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -523,7 +523,7 @@ static void Task_StarterChoose3(u8 taskId)
static void Task_StarterChoose4(u8 taskId) static void Task_StarterChoose4(u8 taskId)
{ {
PlayCry1(GetStarterPokemon(gTasks[taskId].tStarterSelection), 0); PlayCry1(GetStarterPokemon(gTasks[taskId].tStarterSelection), 0);
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized(0, 1, gText_ConfirmStarterChoice, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, gText_ConfirmStarterChoice, 0, 1, 0, NULL);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
CreateYesNoMenu(&gUnknown_085B1DDC, 0x2A8, 0xD, 0); CreateYesNoMenu(&gUnknown_085B1DDC, 0x2A8, 0xD, 0);
@ -579,7 +579,7 @@ static void CreateStarterPokemonLabel(u8 selection)
winTemplate.tilemapTop = gStarterChoose_LabelCoords[selection][1]; winTemplate.tilemapTop = gStarterChoose_LabelCoords[selection][1];
sStarterChooseWindowId = AddWindow(&winTemplate); sStarterChooseWindowId = AddWindow(&winTemplate);
FillWindowPixelBuffer(sStarterChooseWindowId, 0); FillWindowPixelBuffer(sStarterChooseWindowId, PIXEL_FILL(0));
width = GetStringCenterAlignXOffset(7, text, 0x68); width = GetStringCenterAlignXOffset(7, text, 0x68);
AddTextPrinterParameterized3(sStarterChooseWindowId, 7, width, 1, gUnknown_085B1E0C, 0, text); AddTextPrinterParameterized3(sStarterChooseWindowId, 7, width, 1, gUnknown_085B1E0C, 0, text);
@ -600,7 +600,7 @@ static void CreateStarterPokemonLabel(u8 selection)
static void sub_8134604(void) static void sub_8134604(void)
{ {
FillWindowPixelBuffer(sStarterChooseWindowId, 0); FillWindowPixelBuffer(sStarterChooseWindowId, PIXEL_FILL(0));
ClearWindowTilemap(sStarterChooseWindowId); ClearWindowTilemap(sStarterChooseWindowId);
RemoveWindow(sStarterChooseWindowId); RemoveWindow(sStarterChooseWindowId);
sStarterChooseWindowId = 0xFF; sStarterChooseWindowId = 0xFF;

8
src/text.c
View File

@ -1581,7 +1581,7 @@ u16 RenderText(struct TextPrinter *textPrinter)
textPrinter->printerTemplate.currentChar++; textPrinter->printerTemplate.currentChar++;
return 2; return 2;
case 15: case 15:
FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, textPrinter->printerTemplate.bgColor | textPrinter->printerTemplate.bgColor << 4); FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x; textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x;
textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y; textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y;
return 2; return 2;
@ -1702,7 +1702,7 @@ u16 RenderText(struct TextPrinter *textPrinter)
case 2: case 2:
if (TextPrinterWaitWithDownArrow(textPrinter)) if (TextPrinterWaitWithDownArrow(textPrinter))
{ {
FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, (textPrinter->printerTemplate.bgColor << 4) | textPrinter->printerTemplate.bgColor); FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x; textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x;
textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y; textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y;
textPrinter->state = 0; textPrinter->state = 0;
@ -1724,12 +1724,12 @@ u16 RenderText(struct TextPrinter *textPrinter)
int speed = gWindowVerticalScrollSpeeds[scrollSpeed]; int speed = gWindowVerticalScrollSpeeds[scrollSpeed];
if (textPrinter->scrollDistance < speed) if (textPrinter->scrollDistance < speed)
{ {
ScrollWindow(textPrinter->printerTemplate.windowId, 0, textPrinter->scrollDistance, textPrinter->printerTemplate.bgColor << 4 | textPrinter->printerTemplate.bgColor); ScrollWindow(textPrinter->printerTemplate.windowId, 0, textPrinter->scrollDistance, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->scrollDistance = 0; textPrinter->scrollDistance = 0;
} }
else else
{ {
ScrollWindow(textPrinter->printerTemplate.windowId, 0, speed, textPrinter->printerTemplate.bgColor << 4 | textPrinter->printerTemplate.bgColor); ScrollWindow(textPrinter->printerTemplate.windowId, 0, speed, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->scrollDistance -= speed; textPrinter->scrollDistance -= speed;
} }
CopyWindowToVram(textPrinter->printerTemplate.windowId, 2); CopyWindowToVram(textPrinter->printerTemplate.windowId, 2);

18
src/trade.c
View File

@ -1418,7 +1418,7 @@ static void sub_80772A4(void)
for (i = 0; i < 18; i++) for (i = 0; i < 18; i++)
{ {
ClearWindowTilemap(i); ClearWindowTilemap(i);
FillWindowPixelBuffer(i, 0); FillWindowPixelBuffer(i, PIXEL_FILL(0));
} }
FillBgTilemapBufferRect(0, 0, 0, 0, 30, 20, 15); FillBgTilemapBufferRect(0, 0, 0, 0, 30, 20, 15);
@ -2461,7 +2461,7 @@ static void sub_8078DBC(void)
if (gUnknown_0203229C->tradeMenuCursorPosition < 6) if (gUnknown_0203229C->tradeMenuCursorPosition < 6)
{ {
sub_8098858(1, 1, 14); sub_8098858(1, 1, 14);
FillWindowPixelBuffer(1, 0x11); FillWindowPixelBuffer(1, PIXEL_FILL(1));
PrintMenuTable(1, 2, gUnknown_0832DEAC); PrintMenuTable(1, 2, gUnknown_0832DEAC);
InitMenuInUpperLeftCornerPlaySoundWhenAPressed(1, 2, 0); InitMenuInUpperLeftCornerPlaySoundWhenAPressed(1, 2, 0);
PutWindowTilemap(1); PutWindowTilemap(1);
@ -2724,7 +2724,7 @@ static void sub_8079408(void)
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
FillWindowPixelBuffer(i + 14, 0); FillWindowPixelBuffer(i + 14, PIXEL_FILL(0));
rbox_fill_rectangle(i + 14); rbox_fill_rectangle(i + 14);
} }
@ -3256,7 +3256,7 @@ static void sub_807A0C4(void)
static void sub_807A19C(u8 a0) static void sub_807A19C(u8 a0)
{ {
FillWindowPixelBuffer(0, 0x11); FillWindowPixelBuffer(0, PIXEL_FILL(1));
AddTextPrinterParameterized(0, 1, gUnknown_0832DEBC[a0], 0, 1, TEXT_SPEED_FF, NULL); AddTextPrinterParameterized(0, 1, gUnknown_0832DEBC[a0], 0, 1, TEXT_SPEED_FF, NULL);
sub_8098858(0, 20, 12); sub_8098858(0, 20, 12);
PutWindowTilemap(0); PutWindowTilemap(0);
@ -4185,7 +4185,7 @@ void sub_807B140(void)
void sub_807B154(void) void sub_807B154(void)
{ {
FillWindowPixelBuffer(0, 0xFF); FillWindowPixelBuffer(0, PIXEL_FILL(15));
PutWindowTilemap(0); PutWindowTilemap(0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
} }
@ -4263,7 +4263,7 @@ static void sub_807B270(void)
break; break;
case 8: case 8:
sub_807ACFC(1, 1); sub_807ACFC(1, 1);
FillWindowPixelBuffer(0, 0xFF); FillWindowPixelBuffer(0, PIXEL_FILL(15));
PutWindowTilemap(0); PutWindowTilemap(0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gMain.state++; gMain.state++;
@ -4654,7 +4654,7 @@ static bool8 sub_807BBEC(void)
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
sub_807B62C(4); sub_807B62C(4);
FillWindowPixelBuffer(0, 0xFF); FillWindowPixelBuffer(0, PIXEL_FILL(15));
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gUnknown_020322A0->state++; gUnknown_020322A0->state++;
} }
@ -5146,7 +5146,7 @@ static bool8 sub_807CFC8(void)
if (!gPaletteFade.active) if (!gPaletteFade.active)
{ {
sub_807B62C(4); sub_807B62C(4);
FillWindowPixelBuffer(0, 0xFF); FillWindowPixelBuffer(0, PIXEL_FILL(15));
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
gUnknown_020322A0->state++; gUnknown_020322A0->state++;
} }
@ -6085,7 +6085,7 @@ void sub_807F19C(void)
void sub_807F1A8(u8 windowId, const u8 *str, u8 speed) void sub_807F1A8(u8 windowId, const u8 *str, u8 speed)
{ {
FillWindowPixelBuffer(windowId, 0xFF); FillWindowPixelBuffer(windowId, PIXEL_FILL(15));
gUnknown_020322A0->unk_F6[0] = 15; gUnknown_020322A0->unk_F6[0] = 15;
gUnknown_020322A0->unk_F6[1] = 1; gUnknown_020322A0->unk_F6[1] = 1;
gUnknown_020322A0->unk_F6[2] = 6; gUnknown_020322A0->unk_F6[2] = 6;

4
src/trader.c
View File

@ -73,7 +73,7 @@ void CreateAvailableDecorationsMenu(u8 taskId)
} }
windowTemplate.width = convert_pixel_width_to_tile_width(windowWidth); windowTemplate.width = convert_pixel_width_to_tile_width(windowWidth);
data[3] = AddWindow(&windowTemplate); data[3] = AddWindow(&windowTemplate);
SetWindowBorderStyle(data[3], FALSE, 0x214, 14); DrawStdFrameWithCustomTileAndPalette(data[3], FALSE, 0x214, 14);
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
{ {
if (trader->decorIds[i] > NUM_DECORATIONS) if (trader->decorIds[i] > NUM_DECORATIONS)
@ -98,7 +98,7 @@ void sub_8133BE4(u8 taskId, u8 decorationId)
gSpecialVar_0x8004 = decorationId; gSpecialVar_0x8004 = decorationId;
} }
sub_8198070(data[3], FALSE); ClearStdWindowAndFrameToTransparent(data[3], FALSE);
ClearWindowTilemap(data[3]); ClearWindowTilemap(data[3]);
RemoveWindow(data[3]); RemoveWindow(data[3]);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);

12
src/trainer_card.c
View File

@ -350,7 +350,7 @@ static void sub_80C2760(u8 taskId)
case 0: case 0:
if (!IsDma3ManagerBusyWithBgCopy()) if (!IsDma3ManagerBusyWithBgCopy())
{ {
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
sData->var_0++; sData->var_0++;
} }
break; break;
@ -363,7 +363,7 @@ static void sub_80C2760(u8 taskId)
sData->var_0++; sData->var_0++;
break; break;
case 3: case 3:
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
sub_80C4FF0(); sub_80C4FF0();
sub_80C438C(2); sub_80C438C(2);
sData->var_0++; sData->var_0++;
@ -469,7 +469,7 @@ static void sub_80C2760(u8 taskId)
break; break;
case 15: case 15:
sub_800AC34(); sub_800AC34();
NewMenuHelpers_DrawDialogueFrame(0, 1); DrawDialogueFrame(0, 1);
AddTextPrinterParameterized(0, 1, gText_WaitingTrainerFinishReading, 0, 1, 255, 0); AddTextPrinterParameterized(0, 1, gText_WaitingTrainerFinishReading, 0, 1, 255, 0);
CopyWindowToVram(0, 3); CopyWindowToVram(0, 3);
sData->var_0 = 16; sData->var_0 = 16;
@ -1103,7 +1103,7 @@ static void PrintTimeOnCard(void)
r10 = width + 30; r10 = width + 30;
r7 -= r10; r7 -= r10;
FillWindowPixelRect(1, 0, r7, r4, r10, 15); FillWindowPixelRect(1, PIXEL_FILL(0), r7, r4, r10, 15);
ConvertIntToDecimalStringN(gStringVar4, hours, 1, 3); ConvertIntToDecimalStringN(gStringVar4, hours, 1, 3);
AddTextPrinterParameterized3(1, 1, r7, r4, gUnknown_0856FB0C, TEXT_SPEED_FF, gStringVar4); AddTextPrinterParameterized3(1, 1, r7, r4, gUnknown_0856FB0C, TEXT_SPEED_FF, gStringVar4);
r7 += 18; r7 += 18;
@ -1634,7 +1634,7 @@ static bool8 sub_80C4B08(struct Task* task)
switch (sData->var_4) switch (sData->var_4)
{ {
case 0: case 0:
FillWindowPixelBuffer(1, 0); FillWindowPixelBuffer(1, PIXEL_FILL(0));
FillBgTilemapBufferRect_Palette0(3, 0, 0, 0, 0x20, 0x20); FillBgTilemapBufferRect_Palette0(3, 0, 0, 0, 0x20, 0x20);
break; break;
case 1: case 1:
@ -1659,7 +1659,7 @@ static bool8 sub_80C4B08(struct Task* task)
if (!sData->var_8) if (!sData->var_8)
sub_80C474C(); sub_80C474C();
else else
FillWindowPixelBuffer(2, 0); FillWindowPixelBuffer(2, PIXEL_FILL(0));
break; break;
case 4: case 4:
if (sData->var_8) if (sData->var_8)

2
src/trainer_hill.c
View File

@ -613,7 +613,7 @@ void PrintOnTrainerHillRecordsWindow(void)
u32 total, minutes, secondsWhole, secondsFraction; u32 total, minutes, secondsWhole, secondsFraction;
SetUpDataStruct(); SetUpDataStruct();
FillWindowPixelBuffer(0, 0); FillWindowPixelBuffer(0, PIXEL_FILL(0));
x = GetStringCenterAlignXOffset(1, gText_TimeBoard, 0xD0); x = GetStringCenterAlignXOffset(1, gText_TimeBoard, 0xD0);
AddTextPrinterParameterized3(0, 1, x, 2, sRecordWinColors, TEXT_SPEED_FF, gText_TimeBoard); AddTextPrinterParameterized3(0, 1, x, 2, sRecordWinColors, TEXT_SPEED_FF, gText_TimeBoard);

8
src/unk_text_util_2.c
View File

@ -114,7 +114,7 @@ u16 Font6Func(struct TextPrinter *textPrinter)
textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y + *textPrinter->printerTemplate.currentChar++; textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y + *textPrinter->printerTemplate.currentChar++;
return 2; return 2;
case 15: case 15:
FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, textPrinter->printerTemplate.bgColor | (textPrinter->printerTemplate.bgColor << 4)); FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
return 2; return 2;
} }
break; break;
@ -146,7 +146,7 @@ u16 Font6Func(struct TextPrinter *textPrinter)
case 2: case 2:
if (TextPrinterWaitWithDownArrow(textPrinter)) if (TextPrinterWaitWithDownArrow(textPrinter))
{ {
FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, textPrinter->printerTemplate.bgColor | (textPrinter->printerTemplate.bgColor << 4)); FillWindowPixelBuffer(textPrinter->printerTemplate.windowId, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x; textPrinter->printerTemplate.currentX = textPrinter->printerTemplate.x;
textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y; textPrinter->printerTemplate.currentY = textPrinter->printerTemplate.y;
textPrinter->state = 0; textPrinter->state = 0;
@ -166,12 +166,12 @@ u16 Font6Func(struct TextPrinter *textPrinter)
{ {
if (textPrinter->scrollDistance < sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed]) if (textPrinter->scrollDistance < sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed])
{ {
ScrollWindow(textPrinter->printerTemplate.windowId, 0, textPrinter->scrollDistance, textPrinter->printerTemplate.bgColor | (textPrinter->printerTemplate.bgColor << 4)); ScrollWindow(textPrinter->printerTemplate.windowId, 0, textPrinter->scrollDistance, PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->scrollDistance = 0; textPrinter->scrollDistance = 0;
} }
else else
{ {
ScrollWindow(textPrinter->printerTemplate.windowId, 0, sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed], textPrinter->printerTemplate.bgColor | (textPrinter->printerTemplate.bgColor << 4)); ScrollWindow(textPrinter->printerTemplate.windowId, 0, sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed], PIXEL_FILL(textPrinter->printerTemplate.bgColor));
textPrinter->scrollDistance -= sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed]; textPrinter->scrollDistance -= sUnknown_08616124[gSaveBlock2Ptr->optionsTextSpeed];
} }
CopyWindowToVram(textPrinter->printerTemplate.windowId, 2); CopyWindowToVram(textPrinter->printerTemplate.windowId, 2);

4
src/wallclock.c
View File

@ -793,7 +793,7 @@ static void Task_SetClock2(u8 taskId)
static void Task_SetClock3(u8 taskId) static void Task_SetClock3(u8 taskId)
{ {
SetWindowBorderStyle(0, FALSE, 0x250, 0x0d); DrawStdFrameWithCustomTileAndPalette(0, FALSE, 0x250, 0x0d);
AddTextPrinterParameterized(0, 1, gText_IsThisTheCorrectTime, 0, 1, 0, NULL); AddTextPrinterParameterized(0, 1, gText_IsThisTheCorrectTime, 0, 1, 0, NULL);
PutWindowTilemap(0); PutWindowTilemap(0);
schedule_bg_copy_tilemap_to_vram(0); schedule_bg_copy_tilemap_to_vram(0);
@ -812,7 +812,7 @@ static void Task_SetClock4(u8 taskId)
case 1: //B button case 1: //B button
case -1: //NO case -1: //NO
PlaySE(SE_SELECT); PlaySE(SE_SELECT);
sub_8198070(0, FALSE); ClearStdWindowAndFrameToTransparent(0, FALSE);
ClearWindowTilemap(0); ClearWindowTilemap(0);
gTasks[taskId].func = Task_SetClock2; gTasks[taskId].func = Task_SetClock2;
break; break;

9
src/window.c
View File

@ -6,7 +6,8 @@
u32 filler_03002F58; u32 filler_03002F58;
u32 filler_03002F5C; u32 filler_03002F5C;
u8 gUnknown_03002F60; // This global is set to 0 and never changed.
u8 gTransparentTileNumber;
u32 filler_03002F64; u32 filler_03002F64;
void *gUnknown_03002F70[4]; void *gUnknown_03002F70[4];
extern u32 gUnneededFireRedVariable; extern u32 gUnneededFireRedVariable;
@ -106,7 +107,7 @@ bool16 InitWindows(const struct WindowTemplate *templates)
} }
} }
gUnknown_03002F60 = 0; gTransparentTileNumber = 0;
return TRUE; return TRUE;
} }
@ -359,13 +360,14 @@ void PutWindowRectTilemapOverridePalette(u8 windowId, u8 x, u8 y, u8 width, u8 h
} }
} }
// Fills a window with transparent tiles.
void ClearWindowTilemap(u8 windowId) void ClearWindowTilemap(u8 windowId)
{ {
struct Window windowLocal = gWindows[windowId]; struct Window windowLocal = gWindows[windowId];
FillBgTilemapBufferRect( FillBgTilemapBufferRect(
windowLocal.window.bg, windowLocal.window.bg,
gUnknown_03002F60, gTransparentTileNumber,
windowLocal.window.tilemapLeft, windowLocal.window.tilemapLeft,
windowLocal.window.tilemapTop, windowLocal.window.tilemapTop,
windowLocal.window.width, windowLocal.window.width,
@ -451,6 +453,7 @@ void CopyToWindowPixelBuffer(u8 windowId, const void *src, u16 size, u16 tileOff
LZ77UnCompWram(src, gWindows[windowId].tileData + (0x20 * tileOffset)); LZ77UnCompWram(src, gWindows[windowId].tileData + (0x20 * tileOffset));
} }
// Sets all pixels within the window to the fillValue color.
void FillWindowPixelBuffer(u8 windowId, u8 fillValue) void FillWindowPixelBuffer(u8 windowId, u8 fillValue)
{ {
int fillSize = gWindows[windowId].window.width * gWindows[windowId].window.height; int fillSize = gWindows[windowId].window.width * gWindows[windowId].window.height;