mirror of
https://github.com/Ninjdai1/pokeemerald.git
synced 2024-12-26 03:34:15 +01:00
Update bugs_and_glitches.md
Add fix for item image flicker
This commit is contained in:
parent
0a982edf4e
commit
ed02120062
@ -14,6 +14,7 @@ Fixes are written in the `diff` format. If you've used Git before, this should l
|
|||||||
## Contents
|
## Contents
|
||||||
|
|
||||||
- [RNG does not get seeded](#rng-does-not-get-seeded)
|
- [RNG does not get seeded](#rng-does-not-get-seeded)
|
||||||
|
- [Scrolling through items in the bag causes the image to flicker](#scrolling-through-items-in-the-bag-causes-the-image-to-flicker)
|
||||||
|
|
||||||
|
|
||||||
## RNG does not get seeded
|
## RNG does not get seeded
|
||||||
@ -39,4 +40,38 @@ And edit `AgbMain`:
|
|||||||
+ SeedRngWithRtc();
|
+ SeedRngWithRtc();
|
||||||
ClearDma3Requests();
|
ClearDma3Requests();
|
||||||
...
|
...
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Scrolling through items in the bag causes the image to flicker
|
||||||
|
|
||||||
|
**Fix:** Add the following function to [src/item_menu_icons.c](https://github.com/pret/pokeemerald/blob/master/src/item_menu_icons.c):
|
||||||
|
```diff
|
||||||
|
+void HideBagItemIconSprite(u8 id)
|
||||||
|
+{
|
||||||
|
+ u8 *spriteId = &gBagMenu->spriteId[10];
|
||||||
|
+ if (spriteId[id] != 0xFF)
|
||||||
|
+ {
|
||||||
|
+ gSprites[spriteId[id]].invisible = TRUE;
|
||||||
|
+ }
|
||||||
|
+}
|
||||||
|
|
||||||
|
```
|
||||||
|
|
||||||
|
and its corresponding declaration in [include/item_menu_icons.h](https://github.com/pret/pokeemerald/blob/master/include/item_menu_icons.h):
|
||||||
|
|
||||||
|
```diff
|
||||||
|
+void HideBagItemIconSprite(u8 id);
|
||||||
|
|
||||||
|
```
|
||||||
|
|
||||||
|
Then edit `BagMenu_MoveCursorCallback` in [src/item_menu.c](https://github.com/pret/pokeemerald/blob/master/src/item_menu.c):
|
||||||
|
|
||||||
|
```diff
|
||||||
|
...
|
||||||
|
{
|
||||||
|
- RemoveBagItemIconSprite(1 ^ gBagMenu->unk81B_1);
|
||||||
|
+ HideBagItemIconSprite(gBagMenu->unk81B_1 ^ 1);
|
||||||
|
+ RemoveBagItemIconSprite(gBagMenu->unk81B_1);
|
||||||
|
if (a != -2)
|
||||||
|
...
|
||||||
|
```
|
||||||
|
Loading…
Reference in New Issue
Block a user