ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-11-17 03:57:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix AI corruption bug.

Browse Source
This commit is contained in:
luckytyphlosion 2021-01-12 18:43:16 -05:00
parent fba17a96a4
commit f626fac9dc
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/battle_controllers.c
View File

@ -62,7 +62,20 @@ void SetUpBattleVarsAndBirchZigzagoon(void)
ClearBattleMonForms();
BattleAI_SetupItems();
BattleAI_SetupFlags();
BattleAI_SetupAIData(0xF);
// this isn't necessary, and is dangerous
// if we just finished a double battle
// as this function modifies array elements
// by using gActiveBattler as the index
// and gActiveBattler isn't reset upon
// entering a battle
// this bug affects vanilla as well, but vanilla
// does not perform any array element writes
// and any garbage values due to the result of
// reading an invalid array element are reset
// when the AI chooses its move
// BattleAI_SetupAIData(0xF);
if (gBattleTypeFlags & BATTLE_TYPE_FIRST_BATTLE)
{