Anthony
37f8efcda0
Merge pull request #6471 from JosJuice/qt-strings-consistent
...
Make strings more consistent between DolphinWX and DolphinQt2
2018-03-19 11:00:24 -07:00
JosJuice
a71c615435
Make strings more consistent between DolphinWX and DolphinQt2
...
Reduces the number of strings to translate.
2018-03-19 18:52:46 +01:00
Léo Lam
16f74cee70
Merge pull request #6467 from lioncash/breakpoint
...
Breakpoints: Remove direct usages of the JIT global
2018-03-19 18:42:10 +01:00
Léo Lam
f335790623
Merge pull request #6460 from lioncash/datareader
...
DataReader: Minor API changes
2018-03-19 15:02:50 +01:00
Markus Wick
8c1be29cef
Merge pull request #6466 from lioncash/mffs
...
Interpreter_SystemRegisters: Handle mffs, mtfsb0, mtfsb1, mtfsf and mtfsfi with the record bit set
2018-03-19 09:37:01 +01:00
Markus Wick
523031f037
Merge pull request #6444 from stenzek/d3d-bbox
...
D3D: Fix broken bounding box
2018-03-19 09:21:22 +01:00
Markus Wick
98b4716902
Merge pull request #6442 from stenzek/async-compiler-priority
...
ShaderCache: Implement compile priority
2018-03-19 09:16:53 +01:00
Markus Wick
0c0a342483
Merge pull request #6464 from lioncash/using
...
JitArm64_RegCache: Remove using namespace declaration from header
2018-03-19 09:11:45 +01:00
Markus Wick
22aba8c56d
Merge pull request #6468 from lioncash/downcast
...
JitInterface: Remove a downcast within InitJitCore
2018-03-19 09:00:56 +01:00
Markus Wick
3d49bdb488
Merge pull request #6462 from lioncash/ppc
...
PPCTables: Make the op type enum an enum class
2018-03-19 08:55:32 +01:00
Markus Wick
8002bfbc41
Merge pull request #6461 from lioncash/emitter
...
x64Emitter: Move FloatOp and NormalOp enum definitions into the cpp file
2018-03-19 08:53:00 +01:00
Markus Wick
79b21e1381
Merge pull request #6459 from lioncash/enum
...
VertexShaderGen: Convert defines to an enum
2018-03-19 08:48:25 +01:00
Markus Wick
768cd7ede5
Merge pull request #6458 from lioncash/remove-mainbase
...
VideoBackendBase: Migrate functions from MainBase.cpp to VideoBackendBase.cpp
2018-03-19 08:46:35 +01:00
Lioncash
14b204a9bb
JitInterface: Remove a downcast within InitJitCore
...
This isn't necessary as JitBase is already within the type hierarchy that
CPUCoreBase is.
2018-03-19 03:13:16 -04:00
Lioncash
a0164e14bc
BreakPoints: Avoid direct use of the JIT global
...
Trims the direct usages of the global by making the code go through the
JIT interface (where it should have been going in the first place).
This also removes direct JIT header dependencies from the breakpoints as
well. Now, no code uses the JIT global other than JIT code itself, and
the unit tests.
2018-03-19 03:08:57 -04:00
Lioncash
b4cd11c7c9
BreakPoints: Invert if statements where reasonable
...
Puts the early-exit condition first, unindenting code that doesn't need
to be.
2018-03-19 03:08:53 -04:00
Lioncash
3137d4f75f
BreakPoints: Use std algorithms where applicable
2018-03-19 03:08:17 -04:00
Lioncash
eea99de118
Interpreter_SystemRegisters: Handle mffs, mtfsb0, mtfsb1, mtfsf, and mtfsfi with the record bit set
...
All of these with the record bit set update condition register 1 with the
contents of the FPSCR's FX, FEX, VX and OX bits.
Helper_UpdateCR1() does exactly that, so we use it here to perform this
for us.
2018-03-19 00:05:00 -04:00
Lioncash
6ae8a2b5f8
JitArm64_RegCache: Remove using namespace declaration from header
...
Dumping a namespace in a header file should be avoided since it can
cause random name and type clashing in unexpected ways.
2018-03-18 19:39:58 -04:00
Lioncash
6428cee939
PPCTables: Make the op type enum an enum class
...
Reduces the amount of identifiers dropped into the global namespace when
the PPCTables header is included.
2018-03-18 18:53:58 -04:00
Lioncash
975ba4abf0
x64Emitter: Make FloatOp and NormalOp enum classes
...
Reduces the amount of identifiers placed in the Gen namespace internally.
2018-03-18 18:04:54 -04:00
Lioncash
c22a6f4551
x64Emitter: Move FloatOp and NormalOp enums to the cpp file
...
These are only used internally. This also allows us to eliminate some
symbols that get dumped into the exposed Gen namespace.
By extension this also hides the Write[X] functions from OpArg's public
interface. This is only used internally by XEmitter, so they shouldn't
be usable by anything else.
2018-03-18 18:04:48 -04:00
Lioncash
b21a00d290
DataReader: Provide a const qualified variant of GetPointer()
...
This wouldn't be much of a data reader if it can't access the
read-only data pointer in read-only contexts. Especially if it
can get a writable equivalent in contexts that aren't read-only.
2018-03-18 16:53:04 -04:00
Lioncash
ce29c1c42f
DataReader: Correct return type of operator=
...
It's questionable to not return a reference to the instance being
assigned to. It's also quite misleading in terms of expected behavior
relative to everything else. This fixes it to make it consistent with
other classes.
2018-03-18 16:50:59 -04:00
Lioncash
ffade65c55
DataReader: Remove __forceinline from trivial functions
2018-03-18 16:49:50 -04:00
Lioncash
4c2ec39199
DataReader: In-class initialize member variables where applicable
...
Allows the default constructor to be defaulted and ensures the default
values are associated with the member variables directly.
Also corrects a prefixed underscore in the two parameter constructor.
2018-03-18 16:34:51 -04:00
Lioncash
fd956f6c69
DataReader: Make size() and Peek() const member functions
...
These don't modify class state, so they can be const qualified.
2018-03-18 16:33:14 -04:00
Lioncash
2b3b1e8d09
VertexShaderGen: Convert defines to an enum
...
Unlike defines, these will actually obey namespacing (should one be
added), and also provide a symbol when debugging, as opposed to a magic
value.
2018-03-18 15:45:20 -04:00
Pierre Bourdon
0c128f3abe
Merge pull request #6450 from leoetlino/nandboot
...
Boot: Set TYPE_NANDBOOT when booting from NAND
2018-03-18 20:44:44 +01:00
Lioncash
b68e8b872e
VideoBackendBase: Migrate functions from MainBase.cpp to VideoBackendBase.cpp
...
Given that this only contains functions from the VideoBackendBase class,
it makes more sense to move these to the relevant cpp file to keep them
all together.
2018-03-18 15:33:59 -04:00
Léo Lam
b86947264b
Merge pull request #6453 from leoetlino/remove-unused
...
State: Remove unused Verify functions
2018-03-18 11:24:37 +01:00
Léo Lam
4b3542558a
Merge pull request #6456 from lioncash/video-static
...
MainBase: Remove unused file-scope variables
2018-03-18 11:24:16 +01:00
Pierre Bourdon
7465906a0f
Merge pull request #6455 from JosJuice/qt-trans-iterator
...
DolphinQt2: Fix issues with MoIterator
2018-03-17 23:19:26 +01:00
Lioncash
13ed716419
MainBase: Remove effectively unused s_FifoShuttingDown variable
...
This is only ever set and cleared, which is fine, however nothing else
ever actually reads its state to perform differing behavior.
2018-03-17 18:10:43 -04:00
Lioncash
826c11ba3b
MainBase: Remove unused s_beginFieldArgs struct
...
This is only ever memset to zero and never used again.
This also gets rid of an instance of undefined behavior considering the
draft standard for C++17 (N4659) states at [dcl.type.cv] paragraph 5:
"
The semantics of an access through a volatile glvalue are implementation-defined.
If an attempt is made to access an object defined with a volatile-qualified type
through the use of a non-volatile glvalue, the behavior is undefined.
"
2018-03-17 18:07:08 -04:00
JosJuice
9970f05ec8
DolphinQt2: Fix issues with MoIterator
...
Before this, DolphinQt2 would crash at boot with an assertion error
when using a Windows debug build, at least if the Dolphin GUI
language was set to English.
2018-03-17 21:54:39 +01:00
Pierre Bourdon
1667980470
Merge pull request #6454 from JosJuice/qt-vs-launch
...
Fix launching DolphinQt2 from Visual Studio
2018-03-17 19:11:44 +01:00
JosJuice
ffb672286a
Fix launching DolphinQt2 from Visual Studio
...
Fourth time now...
2018-03-17 19:10:57 +01:00
Anthony
87c6ed3e00
Merge pull request #6436 from spycrab/qt_layout
...
Qt: Improve spacing
2018-03-17 09:57:51 -07:00
spycrab
c421848559
Qt: Improve spacing
2018-03-17 16:14:56 +01:00
Stenzek
56fd7bded4
Merge pull request #6452 from lioncash/shader
...
OGLShader: Fix mismatched assignment in compute shader constructor
2018-03-17 12:42:36 +10:00
Léo Lam
6aa6be2804
State: Remove unused Verify functions
...
These were unused in the entire codebase.
2018-03-16 22:56:54 +01:00
Lioncash
882d1c1256
OGLShader: Ensure m_id and m_compute_program_id are always initialized
...
Depending on which constructor is invoked, m_id or m_compute_program_id
can end up in an uninitialized state. We should ensure that the object
is completely initialized to something deterministic regardless of the
constructor taken.
2018-03-16 17:49:34 -04:00
Lioncash
83f17ac59f
OGLShader: Fix mismatched assignment in compute shader constructor
...
This shouldn't be assigning to the regular ID.
2018-03-16 17:44:23 -04:00
Léo Lam
917f0e2182
Merge pull request #6441 from spycrab/qt_exec
...
Qt/Main: Add option to launch file without -e
2018-03-16 20:25:13 +01:00
Léo Lam
25704a2494
Boot: Set TYPE_NANDBOOT when booting from NAND
...
It makes more sense to set TYPE_NANDBOOT than TYPE_RETURN. The latter
is normally only set when returning to the system menu from a game.
2018-03-16 20:17:43 +01:00
JosJuice
bdaa7be299
Merge pull request #6448 from lioncash/qt
...
DolphinQt2: Fix project loading in VS
2018-03-16 20:17:01 +01:00
Lioncash
293d84b9be
DolphinQt2: Fix project loading in VS
...
These headers are already specified in the QtMoc item section, so these
are seen as a duplicate definition of the file, causing a project load
error.
2018-03-16 15:07:44 -04:00
spycrab
0911b44f60
Qt/Main: Add option to launch file without -e
2018-03-16 19:41:54 +01:00
Pierre Bourdon
6fdac685d6
Merge pull request #6409 from leoetlino/timing
...
IOS: Minor IPC fixes
2018-03-16 18:54:01 +01:00