Commit Graph

42293 Commits

Author SHA1 Message Date
OatmealDome
cc3ff347b4
Merge pull request #12928 from LillyJadeKatrin/retroachievements-disable-lboard-tab
Disable Leaderboards Tab
2024-07-15 21:33:08 -04:00
OatmealDome
802abbb288
Merge pull request #12937 from AdmiralCurtiss/achievements-login-error-message
AchievementManager: Don't point to stack for login error message
2024-07-15 18:53:01 -04:00
Admiral H. Curtiss
63e1419396
AchievementManager: Don't point to stack for login error message 2024-07-15 23:24:04 +02:00
OatmealDome
505fe5cc0e
Merge pull request #12935 from AdmiralCurtiss/achievements-default-badges
AchievementManager: Improve player/game badge handling and fix crash when no badge is loaded
2024-07-15 16:40:51 -04:00
Admiral H. Curtiss
50b318cc31
Qt/AchievementHeaderWidget: Don't crash when we get an empty player or game badge 2024-07-15 21:55:47 +02:00
Admiral H. Curtiss
d665175a2b
AchievementManager: Return the default player and game badges if the current one isn't loaded yet
This saves some copying and fixes an issue where the default badges disappear after a game was closed
2024-07-15 21:55:23 +02:00
JMC47
549b16d442
Merge pull request #12932 from AdmiralCurtiss/colo-xd-gci-patches
GameINI: Enable Pokémon Colosseum/XD save patches by default
2024-07-15 15:00:38 -04:00
Admiral H. Curtiss
b18661f15d
Merge pull request #12931 from AdmiralCurtiss/cannot-pause-message
AchievementManager: Improve error message for repeated pausing
2024-07-15 12:05:45 +02:00
Admiral H. Curtiss
7e7273a335
GameINI: Enable Pokémon Colosseum/XD save patches by default 2024-07-15 03:44:05 +02:00
OatmealDome
12a1607385
Merge pull request #12749 from LillyJadeKatrin/retroachievements-menubar
Show Achievements in Menu Bar always
2024-07-14 19:13:08 -04:00
Admiral H. Curtiss
7a36d5373a
AchievementManager: Improve error message for repeated pausing 2024-07-14 23:09:53 +02:00
Admiral H. Curtiss
a0fc8e6b13
Merge pull request #12929 from LillyJadeKatrin/retroachievements-leaderboard-fixes
Fix Leaderboards Tab
2024-07-14 16:47:59 +02:00
LillyJadeKatrin
0108ecebcb Fix Leaderboards Tab
Now that we have some test data, it wasn't showing up in the leaderboards tab; this fixes it to ensure (1) that the right ID is being passed to UpdateRow and (2) the map of leaderboard entries is being populated correctly.
2024-07-14 10:13:27 -04:00
Admiral H. Curtiss
a273dc2de2
Merge pull request #12924 from JosJuice/ra-unverified-ini-osd
RetroAchievements: Show OSD messages also for unverified INI files
2024-07-14 04:15:05 +02:00
Admiral H. Curtiss
f23460ab42
Merge pull request #12927 from OatmealDome/old-tools
Tools: Remove unused and broken scripts
2024-07-14 04:13:19 +02:00
Admiral H. Curtiss
f928fe97af
Merge pull request #12925 from LillyJadeKatrin/retroachievements-unlocked-progress
Achievements Progress Bar Tweaks
2024-07-14 04:11:02 +02:00
Admiral H. Curtiss
ca40eeecff
Merge pull request #12926 from OatmealDome/macos-system-libs
BuildMacOSUniversalBinary: Disable usage of most system-provided libraries
2024-07-12 16:49:03 +02:00
Admiral H. Curtiss
95933d5158
Merge pull request #12907 from GaryOderNichts/fix/init_ipc_running
IOS::HLE::EmulationKernel::InitIPC: Fix WiiIPC ack generation
2024-07-12 16:48:37 +02:00
LillyJadeKatrin
193c863f20 Disable Leaderboards Tab
Emergency PR to disable the leaderboards tab for launch if we are not satisfied with its testing yet.
2024-07-12 07:45:04 -04:00
OatmealDome
4550fc3ab5 Tools: Remove check-includes.py
Include sorting has been enforced by clang-format and lint since ~2015.
2024-07-11 15:01:15 -04:00
OatmealDome
8bd2cb40e5 Tools: Remove CleanFiles.py
This tool doesn't seem to work properly anymore, even after fixing the path in main().
2024-07-11 15:01:10 -04:00
OatmealDome
3db641ab4c Tools: Remove buildbot-try.sh
try support was removed from the buildbot master in dolphin-emu/sadm@336d0e6064.
2024-07-11 15:01:05 -04:00
OatmealDome
22aed354f5 Tools: Remove gameini-ratings-from-wiki.sh
We haven't been storing ratings in GameINIs since #6569.
2024-07-11 14:49:29 -04:00
GaryOderNichts
82b97ca904 IOS::HLE::EmulationKernel::InitIPC: Fix WiiIPC ack generation 2024-07-11 19:41:28 +02:00
LillyJadeKatrin
e035db9127 Update game progress bar to match achievement progress bar 2024-07-10 18:51:37 -04:00
OatmealDome
40f2b1a1c2 BuildMacOSUniversalBinary: Disable usage of most system-provided libraries 2024-07-10 17:33:38 -04:00
LillyJadeKatrin
073426ead7 Force progress bar to 100% on completed achievements 2024-07-10 08:51:13 -04:00
JosJuice
1bf12a50c2 RetroAchievements: Show OSD messages also for unverified INI files
Currently we're showing OSD messages for unknown patches in known INI
files, but not for unknown patches in unknown INI files. I don't think
this distinction makes much sense to the user. If there's a patch the
user can't use, they probably want to be aware of that fact.
2024-07-10 13:16:54 +02:00
Admiral H. Curtiss
321c4649a5
Merge pull request #12921 from VampireFlower/master
BreakpointWidget: Correct icon position
2024-07-10 03:25:49 +02:00
VampireFlower
afa6e26e5d BreakpointWidget: Correct icon position
Co-Authored-By: TryTwo <10532806+TryTwo@users.noreply.github.com>
2024-07-09 15:20:56 -07:00
Admiral H. Curtiss
bb03fc04cc
Merge pull request #12922 from JosJuice/android-approved-list-crash
RetroAchievements: Delay calling LoadApprovedList
2024-07-09 15:27:37 +02:00
JosJuice
e6b9091ffc RetroAchievements: Skip LoadApprovedList if there are no patches
There being no active patches is by far the most common case, so let's
optimize for this case.
2024-07-09 09:55:51 +02:00
JosJuice
f59678842b RetroAchievements: Delay calling LoadApprovedList
0c14b0c8a7 made Dolphin load a file from
the Sys folder the first time AchievementManager::GetInstance() is
called. Because Android calls AchievementManager::GetInstance() from
setBackgroundExecutionAllowedNative, this had two negative consequences
on Android:

1. The first time setBackgroundExecutionAllowedNative gets called is
   often before directory initialization is done. Getting the path of
   the Sys folder before directory initialization is done causes a crash.
2. setBackgroundExecutionAllowedNative is called from the GUI thread,
   and we don't want file I/O on the GUI thread for performance reasons.

This change makes us load the data from the Sys folder the first time
the data is needed instead. This also saves us from having to load the
data at all when hardcore mode is inactive.
2024-07-09 09:55:07 +02:00
Admiral H. Curtiss
01a2cf8db9
Merge pull request #12919 from JosJuice/set-background-execution-allowed-crash
Fix AchievementManager::SetBackgroundExecutionAllowed crash
2024-07-08 01:13:25 +02:00
JosJuice
95e2064099 Fix AchievementManager::SetBackgroundExecutionAllowed crash
We mustn't use m_system when it is nullptr. This was causing Dolphin to
crash on Android whenever an activity was recreated or resumed while
emulation is running, which is super common.
2024-07-07 23:56:10 +02:00
Admiral H. Curtiss
c4db83ce09
Merge pull request #12920 from TellowKrinkle/XXHashLink
Properly link against xxhash
2024-07-07 23:49:01 +02:00
Admiral H. Curtiss
b10d62cf66
Merge pull request #12913 from LillyJadeKatrin/retroachievements-allowlist-test
RetroAchievements - Patch Allowlist Unit Test
2024-07-07 23:48:09 +02:00
LillyJadeKatrin
ae87bf9af5
Add Unit Test for Patch Allowlist
This unit test compares ApprovedInis.json with the contents of the GameSettings folder to verify that every patch marked allowed for use with RetroAchievements has a hash in ApprovedInis.json. If not, that hash is reported in the test logs so that the hash may be updated more easily.
2024-07-07 21:29:03 +02:00
Admiral H. Curtiss
3ca50f7879
Implement File::GetExePath() for FreeBSD 2024-07-07 21:09:50 +02:00
LillyJadeKatrin
0c14b0c8a7 Add Approved Patch Allowlist for Achievements
Prototype of a system to whitelist known game patches that are allowed to be used while RetroAchievements Hardcore mode is active. ApprovedInis.txt contains known hashes for the ini files as they appear in the repo, and can be compared to the local versions of these files to ensure they have not been edited locally by the player. ApprovedInis.txt is hashed and verified similarly first, with its hash residing as a const string within AchievementManager.h, ensuring ApprovedInis and the hashes within cannot be modified without editing Dolphin's source code and recompiling completely.
2024-07-07 13:42:09 -04:00
TellowKrinkle
cab6e7c12e Properly link against xxhash
Things using dolphin_find_optional_system_library need to link against the name used there or they won't work with both the system and bundled cases
2024-07-06 16:56:44 -05:00
Admiral H. Curtiss
02e1b94149
Merge pull request #12905 from LillyJadeKatrin/retroachievements-hotkey
Add Open Achievements Hotkey
2024-07-06 14:23:47 +02:00
LillyJadeKatrin
8b427de28f Remove popups for challenges
The challenge popups have proven to be excessive and are no longer useful thanks to the achievements hotkey. Instead, those events will ask for an immediate RP-level update to the achievements dialog, which will among other things re-sort the dialog to show challenges on top faster.
2024-07-06 07:36:31 -04:00
LillyJadeKatrin
2372b6a386 Add Open Achievements Hotkey
Adds a hotkey to pause emulation and bring up the Achievements dialog.
2024-07-06 07:36:31 -04:00
Admiral H. Curtiss
6ddfdc1483
Merge pull request #12915 from AdmiralCurtiss/sha1-span
Common/Crypto/SHA1: Use span and string_view for Context::Update()
2024-07-05 21:15:00 +02:00
JMC47
2812e6116e
Merge pull request #12851 from iwubcode/texture_asset_from_to_json_sampler
VideoCommon: add way to serialize Texture Asset to json, update to deserialize values independently
2024-07-05 14:36:42 -04:00
Admiral H. Curtiss
5ea3d9fca0
Merge pull request #12856 from LillyJadeKatrin/retroachievements-pause-v2
Handle Pausing in AchievementManager
2024-07-04 22:53:04 +02:00
Admiral H. Curtiss
3a63633be3
Common/Crypto/SHA1: Use span and string_view for Context::Update() 2024-07-04 22:37:07 +02:00
Admiral H. Curtiss
1b1523d6e0
Merge pull request #12895 from LillyJadeKatrin/retroachievements-badge-cache
RetroAchievements Integration - Badge Cache
2024-07-04 22:36:48 +02:00
LillyJadeKatrin
bf97305a60
AchievementManager: Cache Badges on Disk
Badges are saved in /User/Cache/RetroAchievements on first download and reused from there instead of redownloaded.
2024-07-04 22:12:28 +02:00