Commit Graph

12533 Commits

Author SHA1 Message Date
LOuroboros
91b2e1bb50 More review changes and added lackings
-Removed unnecessary special handling of terrain-inducing overworld weather states from ChangeTypeBasedOnTerrain.
-Mimicry now activates normally for terrain-inducing overworld weather states.
-Weather abilities now activate normally when switchineffects is called, and at the beginning of a battle.
-Terrain abilities now activate normally at the beginning of a battle.
2023-01-09 07:55:55 -03:00
Eduardo Quezada
1b0ce96e12 Config for ball inheritence when breeding 2023-01-09 02:16:29 -03:00
ghoulslash
05e9bfeedf
Merge pull request #2531 from AsparagusEduardo/RHH/pr/feature/IncenseBaby
Refactored incense baby checks into table and added Gen 9 config.
2023-01-08 19:14:53 -05:00
LOuroboros
c32f584940 Applied review changes 2023-01-08 19:50:27 -03:00
Eduardo Quezada
612ef46d82 Forgot to add these suggestions 2023-01-08 19:26:34 -03:00
Eduardo Quezada
911541ba4f Merge branch 'RHH/upcoming' into RHH/pr/feature/IncenseBaby
# Conflicts:
#	include/config/pokemon.h
2023-01-08 18:48:01 -03:00
Eduardo Quezada
c5ea97ecc3 Review changes 2023-01-08 18:42:39 -03:00
Eduardo Quezada
9250f8c994 Standarized Pichu/Light Ball/Volt Tackle interaction into their own table, allowing for custom combinations 2023-01-08 18:35:47 -03:00
ghoulslash
da27df9f18
Merge pull request #2326 from AsparagusEduardo/RHH/pr/reworkScald
Rolled EFFECT_SCALD into EFFECT_BURN_HIT with a config for its Gen6+ change
2023-01-08 16:25:29 -05:00
Eduardo Quezada D'Ottone
335be4db5b
Merge pull request #2562 from rh-hideout/revert-2457-RHH/pr/cleanup/unown
Revert "Removed Unown hack"
2023-01-07 22:21:21 -03:00
GriffinR
c91b13a12b Merge branch 'master' of https://github.com/pret/pokeemerald into doc-windows 2023-01-07 13:30:11 -05:00
Eduardo Quezada D'Ottone
7622d84a4f
Revert "Removed Unown hack" 2023-01-07 11:39:56 -03:00
Eduardo Quezada
d72a3731d4 Merge branch 'RHH/upcoming' into RHH/pr/feature/reworkScald
# Conflicts:
#	include/constants/battle_move_effects.h
2023-01-06 15:25:49 -03:00
LOuroboros
f39f48fc51 Made MOVE_EFFECT_DIRE_CLAW a tiny bit prettier 2023-01-05 03:07:28 -03:00
LOuroboros
72566e6323 Turned Stone Axe's and Ceaseless Edge's effects into MOVE_EFFECTs 2023-01-05 03:02:56 -03:00
Eduardo Quezada D'Ottone
34d27eca0e
Merge pull request #2457 from AsparagusEduardo/RHH/pr/cleanup/unown
Removed Unown hack
2023-01-04 18:57:28 -03:00
Eduardo Quezada D'Ottone
11c3e9c7f8
Merge pull request #2318 from AsparagusEduardo/RHH/pr/palleteConversion2
Gen 1-5 Palette Conversion Redemption
2023-01-04 18:03:07 -03:00
Eduardo Quezada
74d8c587fe Merge branch 'RHH/upcoming' into RHH/pr/cleanup/unown
# Conflicts:
#	src/data/pokemon/species_info.h
#	src/data/pokemon_graphics/front_pic_anims.h
2023-01-04 17:58:54 -03:00
Eduardo Quezada
55be15f690 Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/palleteConversion2
# Conflicts:
#	include/config/pokemon.h
2023-01-04 16:19:57 -03:00
LOuroboros
7e398ce80e Corrected the AI conditionals 2023-01-04 12:45:49 -03:00
LOuroboros
2414283bb7 Removed BattleScript_EffectHit_Ret 2023-01-04 12:32:55 -03:00
LOuroboros
9a6bdfb74f Added AI conditionals for the new move effects in this batch 2023-01-04 12:13:34 -03:00
ghoulslash
1d2cb49bc6
Merge pull request #2542 from AsparagusEduardo/RHH/pr/config/multiTargetDmg
Config to restore Gen 3's damage reduction to multi target moves
2023-01-04 09:18:39 -05:00
ghoulslash
a425de77a6
Merge pull request #2446 from LOuroboros/primal
Updated AnimTask_PrimalReversion
2023-01-04 09:16:28 -05:00
ghoulslash
6ea9a34036
Merge pull request #2561 from AsparagusEduardo/RHH/pr/fix/repels
Fixed reusable repels/lures function forcefully using items while menu config is on
2023-01-04 09:15:30 -05:00
ghoulslash
a6269f8cc7
Merge pull request #2559 from AsparagusEduardo/RHH/pr/sync/pretmerge_20230103
For me, it was tuesday. (pret merge 2023/01/03)
2023-01-04 09:15:08 -05:00
Eduardo Quezada
ca46c22533 Removed SpeciesInfo array defines 2023-01-04 08:14:34 -03:00
GriffinR
6d6a876dbd
Merge pull request #1820 from GriffinRichards/doc-wnews
Document wonder news
2023-01-03 22:34:58 -05:00
GriffinR
36c89d345c
Merge branch 'master' into doc-wnews 2023-01-03 22:28:21 -05:00
Eduardo Quezada
ada47831aa Fixed reusable repels/lures function forcefully using items while menu config is on 2023-01-04 00:00:13 -03:00
Eduardo Quezada D'Ottone
41d846c74c
Merge pull request #2551 from ghoulslash/be/frontier_bp
Reshape sBattlePointAwards to be easier to read
2023-01-03 21:48:08 -03:00
ghoulslash
2ee26c6240 align cols 2023-01-03 19:36:19 -05:00
Eduardo Quezada
b897b7787e Applied bugfix from upstream 2023-01-03 15:41:03 -03:00
Eduardo Quezada
e0802f13a2 Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20230103
# Conflicts:
#	include/link_rfu.h
2023-01-03 15:40:33 -03:00
Eduardo Quezada D'Ottone
10bfc2a91f
Merge pull request #2557 from LOuroboros/patch-1
Updated HOLD_EFFECT_ZOOM_LENS check
2023-01-03 06:43:29 -03:00
LOuroboros
f1ca254c28 Updated the Mimicry reimplementation
Mimicry is now a proud member of ABILITYEFFECT_ON_TERRAIN.

Misc. changes:
-Ditched the dependency on and usage of gBattlerAttacker for the effects inside ABILITYEFFECT_ON_WEATHER and ABILITYEFFECT_ON_TERRAIN.
-Made Cmd_switchineffects activate ABILITYEFFECT_ON_TERRAIN to take into account overworld weather-induced field terrains.
-Updated the text strings printed by the battle scripts inside the aforementioned AbilityBattleEffects caseIDs.
-Removed constant label of unused VARIOUS_TRY_TO_APPLY_MIMICRY which I forgot about.
-Updated ChangeTypeBasedOnTerrain, partly as a result of the aforementioned changes but also for optimization purposes.
 -There was never a reason to establish an empty scope, or to use GET_MOVE_TYPE and the variables that complemented it.
-Removed case ABILITY_QUARK_DRIVE from AbilityBattleEffects' case ABILITYEFFECT_ON_SWITCHIN.
2023-01-03 02:27:41 -03:00
LOuroboros
bb218b1616
Updated HOLD_EFFECT_ZOOM_LENS check 2023-01-03 01:10:21 -03:00
LOuroboros
d0f5653f5e Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into mimicry 2023-01-02 19:00:41 -03:00
LOuroboros
0a00942a26 Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch1 2023-01-02 16:00:13 -03:00
ghoulslash
2944ebfe7b
Merge pull request #2543 from AsparagusEduardo/RHH/pr/fix/shinyChances
Reverting P_SHINY_BASE_CHANCE implementation as it wasn't accuerate to Gen6+
2023-01-02 13:55:36 -05:00
ghoulslash
8b28d4329b
Merge pull request #2525 from AsparagusEduardo/RHH/pr/fix/FixFrontierTutor2
Fixed right Frontier move tutor not loading their move list correctly.
2023-01-02 13:55:00 -05:00
ghoulslash
f5687de182
Merge pull request #2552 from LOuroboros/patch-1
Updated B_DOUBLE_WILD_CHANCE
2023-01-02 13:49:44 -05:00
LOuroboros
cdfec0fc05
Updated B_DOUBLE_WILD_CHANCE 2023-01-02 15:42:30 -03:00
ghoulslash
759ee8854a
Merge pull request #2470 from LOuroboros/dev_gen9_abilities
Implemented the majority of the Gen. 9 Abilities
2023-01-02 13:39:38 -05:00
ghoulslash
a06135b2f4
Merge pull request #2539 from AsparagusEduardo/RHH/pr/fix/FixEgg
Fixed Eggs sometimes reading garbage graphic data.
2023-01-02 13:27:28 -05:00
ghoulslash
82bf76588c move challengeNum index to end of sBattlePointAwards, explicitly call out frontier facilities, modes 2023-01-02 13:12:46 -05:00
LOuroboros
13d8c0d167 Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into dev_gen9_abilities 2023-01-02 14:34:24 -03:00
LOuroboros
ca32d43433 Streamlined ability-on-weather changes
Also renamed activateweatherabilities and activateterrainabilities.
2023-01-02 14:32:56 -03:00
Eduardo Quezada D'Ottone
682bcd4554
Merge pull request #2548 from LOuroboros/clearBody
Made Clear Body and similar abilities be normally affected by their own stat stage reductions
2023-01-01 11:37:11 -03:00
LOuroboros
d3443396e2 Made Clear Body and similar abilities be normally affected by their own stat stage reductions 2023-01-01 10:45:38 -03:00