Commit Graph

5956 Commits

Author SHA1 Message Date
PikalaxALT
cb69835536
Merge pull request #1210 from ExpoSeed/pull-request-template
More concise pull request template
2020-09-27 19:25:19 -04:00
ExpoSeed
933e180dd6 Remove breaking change line 2020-09-27 18:09:35 -05:00
ExpoSeed
70f7d4f256 More concise pull request template 2020-09-27 17:59:21 -05:00
PikalaxALT
46d748a219
Create pull_request_template.md 2020-09-27 17:40:30 -04:00
PikalaxALT
00b8208914
Merge pull request #1205 from GriffinRichards/constants-itemdigits
Use constants for item digits
2020-09-27 17:24:48 -04:00
GriffinR
f8ce2efb55
Merge pull request #1206 from ExpoSeed/script-command-comments
Comments for script command tables
2020-09-25 15:13:38 -04:00
ExpoSeed
032669e2ab Change script command table comment alignment from tabs to spaces 2020-09-25 14:05:17 -05:00
ExpoSeed
3860551777 Mark unused script commands 2020-09-25 13:41:17 -05:00
ExpoSeed
31d12383b1 Add byte comments to mystery event script command table 2020-09-25 13:27:15 -05:00
ExpoSeed
e7340ca0e1 Add byte comments to script command table 2020-09-25 13:25:36 -05:00
GriffinR
66bd1e6d3f Use constants for item digits 2020-09-25 11:18:52 -04:00
GriffinR
541eff3c73
Merge pull request #1204 from Kurausukun/rename-2
one more instrument
2020-09-23 23:39:12 -04:00
Kurausukun
04bf1d433a one more instrument
oops just found this one
2020-09-23 22:31:12 -04:00
GriffinR
47b5b75a1d
Merge pull request #1201 from tustin2121/tustin2121-patch-8
Documenting the trainer hill floor data
2020-09-20 15:20:24 -04:00
tustin2121
be9100fe52 Review changes 2020-09-20 13:04:20 -04:00
GriffinR
1d1035a01f
Merge pull request #1196 from Kurausukun/rename_instruments
rename instruments (again)
2020-09-20 12:30:57 -04:00
tustin2121
832be34898 More documenting trainer hill
- Renamed members and added comments in the TrHillDisplay struct.
- Formatted the trainer hill data to better match the metatile layout its representing.
- Documented the function which uses this data.
2020-09-20 01:50:54 -04:00
tustin2121
0d3646c0b9 Trainer hill location data
Changed the trainer hill data for trainer locations, directions, and ranges from vague unusable numbers into readable data via use of preprocessor macros.
2020-09-20 01:09:22 -04:00
GriffinR
0b592228c5
Merge pull request #1186 from kiliwily/DocSomeBugs
Document some bugs
2020-09-19 18:09:49 -04:00
kiliwily
f1366dfc69 Fix typos 2020-09-19 20:46:26 +02:00
kiliwily
56848fb891 Update battle_util.c 2020-09-19 20:44:16 +02:00
PikalaxALT
0088f59b1d
Merge pull request #1197 from MeatLoaf3/patch-1
Changed casts to volatile
2020-09-19 10:28:45 -04:00
PikalaxALT
b352d1be32
Merge pull request #1198 from PokeCodec/patch-1
Specify to install Libpng-dev, not libpng
2020-09-18 16:46:51 -04:00
Seija
f5457cd1fd
Libpng-devel
libpng dev library needs to be installed, not libpng
2020-09-18 16:25:46 -04:00
MeatLoaf3
0e74de0f9e
Changed casts to volatile
devkitArm wouldn't copy the bits properly in some instances. Casting as volatile solved the issue
2020-09-18 13:26:36 -04:00
Kurausukun
30e3437891 rename instruments (again) 2020-09-17 23:52:57 -04:00
GriffinR
a3a558acf4
Merge pull request #1195 from Kurausukun/audio-macro
Update Audio Macros
2020-09-17 20:10:57 -04:00
Kurausukun
f4a49dcd1d Make all arguments for audio macros required 2020-09-17 19:56:55 -04:00
Kurausukun
b9644e9583 Update Audio Macros
Information: Our current audio macros preclude the definition of root
key and pan (applicable when used in drumsets, aka "keysplit_all") for
GB channels. However, this functionality does exist in m4a--Pokemon
Emerald just happens not to use it. However, for the sake of people
working with custom music, I believe these values should be modifiable
by users.

Additionally, given the recent events that have occurred with this repo,
I would like to make something fully clear: I have indeed looked at the
GBA SDK before, which contains notes on how these sounds are defined;
therefore, I cannot blame you if you reject this PR on the grounds that
the information is "tainted." However, this information is readily
available and matches the same macros used for directsound--it's hardly
information that one would need the source to know.
2020-09-17 03:12:19 -04:00
GriffinR
62b79018dc
Merge pull request #1194 from ExpoSeed/typo-fix
Complete TMHM Learnset description
2020-09-16 14:21:21 -04:00
ExpoSeed
227d2dce32 Make description slightly more precise 2020-09-16 12:51:14 -05:00
ExpoSeed
778e6925de Complete TMHM Learnset description 2020-09-16 12:36:11 -05:00
GriffinR
b542eb1d5f
Merge pull request #1190 from AsparagusEduardo/fix-UltraRope
Fixed "Ultra Rope" name.
2020-09-13 10:41:34 -04:00
Eduardo Quezada
46ccb91155 Fixed "Ultra Rope" name. 2020-09-13 11:35:05 -03:00
kiliwily
a130c2dc4a Update bugs_and_glitches.md 2020-09-12 20:02:27 +02:00
kiliwily
9b4ded46c6 Update pokemon.c 2020-09-12 19:20:42 +02:00
kiliwily
f861b70fe7 Update bugs_and_glitches.md 2020-09-12 18:53:59 +02:00
kiliwily
50139aa00c Update bugs_and_glitches.md 2020-09-12 18:53:09 +02:00
kiliwily
f84702e50b Update bugs_and_glitches.md 2020-09-12 18:52:00 +02:00
kiliwily
4c4c2ea41b Update bugs_and_glitches.md 2020-09-12 18:49:55 +02:00
kiliwily
7377c2f192 Update bugs_and_glitches.md 2020-09-12 18:48:57 +02:00
kiliwily
84acc5c6db Update bugs_and_glitches.md 2020-09-12 18:47:10 +02:00
kiliwily
3e95f837a6 Update bugs_and_glitches.md 2020-09-12 18:44:39 +02:00
kiliwily
5c3669e0cd Bug documenting 2020-09-12 18:43:20 +02:00
GriffinR
58a2b62bae
Merge pull request #1184 from GriffinRichards/fix-typos
Fix Rusboro and Lavarige typos
2020-09-11 14:53:56 -04:00
GriffinR
921f389e4e Fix Rusboro and Lavarige typos 2020-09-11 14:47:47 -04:00
PikalaxALT
c0987169dd
Merge pull request #1183 from PokeCodec/PokemonLogicFix
Match Dewford
2020-09-10 19:36:21 -04:00
PokeCodec
c1286c2fe2 Change according to feedback 2020-09-10 18:07:46 -04:00
PokeCodec
87769756f8 spacing 2020-09-10 10:26:55 -04:00
PokeCodec
6967b234d4 adjustments and fakematch fix 2020-09-10 10:07:16 -04:00