Commit Graph

4310 Commits

Author SHA1 Message Date
Phlosioneer
e90e3458cb Document the regi* code more
Fixed some confusing naming, named some unknown symbols, and fixed the
names of some flags.
2019-02-15 18:24:55 -05:00
DizzyEggg
c0f47d67aa
Merge pull request #72 from PALPATlNE/battle_engine_work
Mud bomb and Shadow Sneak Animations
2019-02-15 22:50:07 +01:00
Phlosioneer
986d3d8b2f Finish and polish new_game.c
Only one function is left undocumented. I tried to go into the assembly
to at least name it, but it clears fields in the save block that aren't
even documented yet.
2019-02-15 03:40:57 -05:00
Phlosioneer
0a3912c95d Add comments explaining asm in pokedex.c
I added comments to each of the asm functions explaining why they won't
match with the C.
I also got one of the functions much closer to matching.
2019-02-15 01:28:28 -05:00
DizzyEggg
08892d19f2 Modify the stat changer, so it supports raise/lower by 12 2019-02-14 19:48:21 +01:00
Diegoisawesome
e95140270b
Merge pull request #556 from DizzyEggg/patch-2
Fix two battle scripting macros
2019-02-14 10:35:12 -06:00
DizzyEggg
94cd547e9a Change move effect to u16 2019-02-14 13:17:27 +01:00
DizzyEggg
cb57044531
Fix two battle scripting macros 2019-02-14 13:05:49 +01:00
DizzyEggg
dc39f76a95 Spectral Thief effect 2019-02-14 12:15:53 +01:00
Phlosioneer
9e8a841bfa Merge branch 'master' of github.com:pret/pokeemerald into main-menu-state-machine 2019-02-13 23:04:56 -05:00
Diegoisawesome
efc5494834
Merge pull request #555 from Diegoisawesome/master
scaninc: Fix C comment consumption logic
2019-02-13 22:00:32 -06:00
Diegoisawesome
05d02e804e Fix C comment consumption logic 2019-02-13 21:55:39 -06:00
Diegoisawesome
047c282763
Merge pull request #548 from Phlosioneer/intro-movie-state-machine
Document the intro movie state machine
2019-02-13 21:24:20 -06:00
Phlosioneer
e7d0268143 Fix spelling of Rayquaza 2019-02-13 21:41:28 -05:00
Diegoisawesome
aa5d5fa34a
Merge pull request #550 from Phlosioneer/name-palette-return-values
Name the possible return values of palette fading functions
2019-02-13 20:15:47 -06:00
Diegoisawesome
dfb896356c Merge branch 'master' of github.com:pret/pokeemerald 2019-02-12 00:40:42 -06:00
Diegoisawesome
449fb25f23 Clear up misnamed time-based flags and functions 2019-02-12 00:40:34 -06:00
Phlosioneer
d979ac3bf3 Document main_menu state machine, name window constants
The new names for the constants (and newly named functions) give a much
better understanding of what the window system is trying to do.
2019-02-11 00:34:50 -05:00
Diegoisawesome
16eff049a1
Merge pull request #552 from Phlosioneer/ignore-trigraph-warning
Ignore trigraph warning
2019-02-10 21:40:15 -06:00
Phlosioneer
05ad946b83 Ignore trigraph warning 2019-02-10 22:12:43 -05:00
PALPATlNE
6c717078c6 Fixed tab to 4 spaces in ground.c 2019-02-11 03:54:54 +01:00
Phlosioneer
327de0283d Adjust constants returned by FlipVerticalAndClearForced 2019-02-10 21:16:12 -05:00
Phlosioneer
e75f45dbcf Reverse engineered many of the multiplayer events
Some corrections to the way events are handled and identified.
2019-02-10 20:42:50 -05:00
PALPATlNE
136f767f1f Replaced tab spaces with 4 spaces 2019-02-10 19:30:00 +01:00
DizzyEggg
4c535a1b03
Merge pull request #71 from thechurchofcage/partingshot
Parting Shot
2019-02-10 18:18:49 +01:00
DizzyEggg
b5d0253890 Merge with master 2019-02-10 18:17:33 +01:00
Phlosioneer
f2f1b1978b Done documenting link code in overworld.c 2019-02-10 03:54:50 -05:00
Phlosioneer
3fd878483f Start renaming symbols
I finally figured out what the code is trying to do. I have a foothold;
the rest should follow.
2019-02-10 00:50:46 -05:00
Phlosioneer
d0cc8dfc17 Change negative constant into unsigned hex constant 2019-02-09 22:02:56 -05:00
Phlosioneer
37bea25b01 Name the possible return values of palette fading functions
Also replace implicit conversion from gPalette.active into a status with
if statements, to make the return value clear.

I've also added comments when the check is redundant.
2019-02-09 21:50:12 -05:00
Phlosioneer
45297797e6 Document the intro movie state machine
Need to study the water droplet animation more closely before they can
be renamed; otherwise, this names every major symbol in this file.
2019-02-09 21:07:07 -05:00
Papa Cancer
dd34272620
Parting Shot v3 2019-02-09 17:40:04 +00:00
Papa Cancer
a1be618c47
Parting Shot v2
With DizzyEgg's amendment
2019-02-09 16:05:59 +00:00
Marcus Huderle
6f1d2b870c Give proper names to dynamic map layouts 2019-02-09 09:57:30 -06:00
DizzyEggg
10536196f9 AI edge case with atk up 2019-02-09 16:45:02 +01:00
DizzyEggg
3d616dfffe Add Surge Abilities 2019-02-09 14:30:16 +01:00
DizzyEggg
872389b15c Fix Download raising the wrong stat 2019-02-09 13:30:45 +01:00
DizzyEggg
691544fa0b AI takes split into account, debug view ai move points 2019-02-09 13:21:32 +01:00
DizzyEggg
413cf4f0ae
Merge pull request #68 from Fontbane/patch-2
AI uses Swagger on allies with Own Tempo
2019-02-09 12:35:52 +01:00
Marcus Huderle
40dc6833c5 Fully document tileset animations 2019-02-08 15:07:42 -06:00
Marcus Huderle
abebd2b864 Cleanup externs in overworld.c 2019-02-08 11:48:51 -06:00
Marcus Huderle
6add3e1794 Document some battle dome stuff 2019-02-08 11:08:25 -06:00
Marcus Huderle
4570e3b6a5 Document battle arena 2019-02-08 09:41:36 -06:00
PALPATlNE
e7f8186ccc Mud bomb and Shadow Sneak Animations 2019-02-08 03:13:36 +01:00
Marcus Huderle
3a40f5203b Remove old rom_818CFC8.h header 2019-02-07 17:41:44 -06:00
Marcus Huderle
85040e26fd Document battle pike 2019-02-07 17:37:41 -06:00
DizzyEggg
6a186b5d5a Fix Sap Sipper 2019-02-07 21:33:03 +01:00
DizzyEggg
40e1dcb1d9 Fix Psycho Shift copying toxic counter 2019-02-07 21:26:42 +01:00
DizzyEggg
aa33a61e58 Merge branch 'master' into battle_engine_v2 2019-02-07 21:17:30 +01:00
Marcus Huderle
4785a07acd Document battle factory functions 2019-02-07 12:58:09 -06:00