Kurausukun
f4a49dcd1d
Make all arguments for audio macros required
2020-09-17 19:56:55 -04:00
Kaz
1404cf3330
field_player_avatar.c: Fix TryInterruptObjectEventSpecialAnim fakematch.
2020-09-17 18:24:11 -04:00
Kurausukun
b9644e9583
Update Audio Macros
...
Information: Our current audio macros preclude the definition of root
key and pan (applicable when used in drumsets, aka "keysplit_all") for
GB channels. However, this functionality does exist in m4a--Pokemon
Emerald just happens not to use it. However, for the sake of people
working with custom music, I believe these values should be modifiable
by users.
Additionally, given the recent events that have occurred with this repo,
I would like to make something fully clear: I have indeed looked at the
GBA SDK before, which contains notes on how these sounds are defined;
therefore, I cannot blame you if you reject this PR on the grounds that
the information is "tainted." However, this information is readily
available and matches the same macros used for directsound--it's hardly
information that one would need the source to know.
2020-09-17 03:12:19 -04:00
Kaz
c724f2b809
battle_ai_script_commands.c: -g fixes the fakematch.
2020-09-16 22:01:45 -04:00
Kaz
5a70f99e16
battle_script_commands.c: Eliminate the last nonmatching (swapped expressions).
2020-09-16 21:39:44 -04:00
Kaz
171154a097
Convert to -g; will be required for eliminating fakematches.
2020-09-16 19:36:30 -04:00
GriffinR
62b79018dc
Merge pull request #1194 from ExpoSeed/typo-fix
...
Complete TMHM Learnset description
2020-09-16 14:21:21 -04:00
ExpoSeed
227d2dce32
Make description slightly more precise
2020-09-16 12:51:14 -05:00
ExpoSeed
778e6925de
Complete TMHM Learnset description
2020-09-16 12:36:11 -05:00
GriffinR
b542eb1d5f
Merge pull request #1190 from AsparagusEduardo/fix-UltraRope
...
Fixed "Ultra Rope" name.
2020-09-13 10:41:34 -04:00
Eduardo Quezada
46ccb91155
Fixed "Ultra Rope" name.
2020-09-13 11:35:05 -03:00
aaaaaa123456789
7dc95a0103
Undo PokeCodec's PRs
...
This commit undoes most of PokeCodec's PRs after the debate in chat. Some
harmless or completely superseded PRs have been left alone, as there is not
much benefit in attempting to undo them.
Reverts #1104 , #1108 , #1115 , #1118 , #1119 , #1124 , #1126 , #1127 , #1132 , #1136 ,
#1137 , #1139 , #1140 , #1144 , #1148 , #1149 , #1150 , #1153 , #1155 , #1177 , #1179 ,
#1180 , #1181 , #1182 and #1183 .
2020-09-13 06:30:55 -03:00
Kaz
327dd877b5
use_pokeblock: fakematch fix.
...
I am beginning to suspect that we should be using the gflib DMA macros
everywhere wherever possible.
2020-09-13 03:47:12 -04:00
Kaz
f952144922
party_menu fakematch fix
2020-09-13 03:02:41 -04:00
Kaz
449df5860d
Begin documenting berry_crush
2020-09-13 00:26:01 -04:00
Kaz
d0fcb9168b
Match two minor functions in battle_tent and berry_crush
2020-09-12 21:51:16 -04:00
kiliwily
a130c2dc4a
Update bugs_and_glitches.md
2020-09-12 20:02:27 +02:00
kiliwily
9b4ded46c6
Update pokemon.c
2020-09-12 19:20:42 +02:00
kiliwily
f861b70fe7
Update bugs_and_glitches.md
2020-09-12 18:53:59 +02:00
kiliwily
50139aa00c
Update bugs_and_glitches.md
2020-09-12 18:53:09 +02:00
kiliwily
f84702e50b
Update bugs_and_glitches.md
2020-09-12 18:52:00 +02:00
kiliwily
4c4c2ea41b
Update bugs_and_glitches.md
2020-09-12 18:49:55 +02:00
kiliwily
7377c2f192
Update bugs_and_glitches.md
2020-09-12 18:48:57 +02:00
kiliwily
84acc5c6db
Update bugs_and_glitches.md
2020-09-12 18:47:10 +02:00
kiliwily
3e95f837a6
Update bugs_and_glitches.md
2020-09-12 18:44:39 +02:00
kiliwily
5c3669e0cd
Bug documenting
2020-09-12 18:43:20 +02:00
GriffinR
58a2b62bae
Merge pull request #1184 from GriffinRichards/fix-typos
...
Fix Rusboro and Lavarige typos
2020-09-11 14:53:56 -04:00
GriffinR
921f389e4e
Fix Rusboro and Lavarige typos
2020-09-11 14:47:47 -04:00
PikalaxALT
c0987169dd
Merge pull request #1183 from PokeCodec/PokemonLogicFix
...
Match Dewford
2020-09-10 19:36:21 -04:00
PokeCodec
c1286c2fe2
Change according to feedback
2020-09-10 18:07:46 -04:00
PokeCodec
87769756f8
spacing
2020-09-10 10:26:55 -04:00
PokeCodec
6967b234d4
adjustments and fakematch fix
2020-09-10 10:07:16 -04:00
PokeCodec
029db24adb
Make return
2020-09-10 09:32:36 -04:00
PokeCodec
eb25b951c3
InitPaintingMonOamData fix
2020-09-10 09:14:53 -04:00
PokeCodec
50a6b73edc
Fix sub_80C6104
2020-09-10 09:02:04 -04:00
PokeCodec
08696108e1
Match dewford
2020-09-09 17:02:52 -04:00
PokeCodec
f50ecf5c66
Match PrintMonWeight
2020-09-09 16:35:04 -04:00
PikalaxALT
d260943249
Merge pull request #1182 from PokeCodec/PokemonLogicFix
...
Fix more fakematches
2020-09-09 16:27:24 -04:00
PokeCodec
7f1827767c
Document size field of unknown struct
2020-09-09 16:09:31 -04:00
PokeCodec
a32f631fe6
Fix Pokemon Fakematch
2020-09-09 15:59:34 -04:00
PokeCodec
d541002ab6
Type adjust
2020-09-09 15:54:24 -04:00
PokeCodec
84a92279c9
Record mixing fakematch fixed!
2020-09-09 15:49:51 -04:00
PokeCodec
dc34cf1711
Mail Time
2020-09-09 15:09:40 -04:00
PokeCodec
56afdee7fc
Remove register variable mention
2020-09-09 14:43:41 -04:00
PokeCodec
aa45c05a3e
Match Battle Tower
2020-09-09 11:21:16 -04:00
PokeCodec
a3a8c23e00
Match battle_script commands
2020-09-09 11:18:04 -04:00
PokeCodec
3af118b0a7
Fix fakematch in pokemon animation
2020-09-09 11:12:12 -04:00
PokeCodec
779764b70d
Fix Battle_Script_commands fakematch
2020-09-09 10:35:40 -04:00
PikalaxALT
8f6d6b933e
Merge pull request #1181 from PokeCodec/trainer-hill
...
Remove fakematch in trainer_hill.c
2020-09-08 21:55:29 -04:00
PokeCodec
f980188b82
Fix battle transition fakematch
2020-09-08 20:54:41 -04:00
