Marcus Huderle
e9a3cc6d51
Merge remote-tracking branch 'upstream/master' into move-tutor
...
# Conflicts:
# include/pokenav.h
# src/battle_script_commands.c
2019-03-17 17:20:40 -05:00
Marcus Huderle
4ae8a52473
Finish decompiling contest_painting_effects.c
2019-03-17 16:25:18 -05:00
Phlosioneer
691392fd5d
Clean up intro_credits_graphics constants
2019-03-16 12:37:04 -05:00
Phlosioneer
a029254faa
Apply new macros to intro graphics struct
2019-03-16 12:37:04 -05:00
Phlosioneer
eeb329909c
Fix anonymous struct
2019-03-16 12:37:04 -05:00
Phlosioneer
9848f84b9e
Use constants for Oam .shape and .size fields
...
Also some general formatting fixes for constants.
2019-03-16 12:37:04 -05:00
Phlosioneer
291df27dcb
Use new MUS_NONE constant in sound.c
2019-03-16 12:31:29 -05:00
Phlosioneer
703554c4df
Ranges are magic
2019-03-16 12:25:02 -05:00
Phlosioneer
61344a4fee
Document the water droplet data.
2019-03-16 12:25:02 -05:00
garak
d0115db565
move pokemon graphics to mon-specific directories
2019-03-16 12:21:47 -05:00
garak
14211fb495
fix incbin paths
2019-03-16 12:21:47 -05:00
Phlosioneer
8e1537fb57
Document map name popup flag
2019-03-10 09:23:58 -05:00
huderlem
32f71b2976
Merge pull request #600 from Phlosioneer/summary-screen-macros
...
Summary screen macros
2019-03-08 13:37:12 -06:00
Phlosioneer
c3feb9871f
Use PIXEL_FILL macro
2019-03-08 04:02:05 -05:00
Phlosioneer
146c194b0c
Actually change the variable name this time
2019-03-08 03:12:08 -05:00
Phlosioneer
5886f82ef5
Merge branch 'master' into extern-cleanup
2019-03-08 02:45:26 -05:00
Phlosioneer
eaddf396b2
I was dumb and forgot to add merge fixes
2019-03-08 02:35:19 -05:00
Phlosioneer
b93d923826
Merge branch 'master' into move-tutor
2019-03-08 02:27:20 -05:00
Phlosioneer
eac70acab6
Change filename to something more descriptive
2019-03-08 02:17:01 -05:00
Phlosioneer
af182d6f16
Minor cleanup before pushing
2019-03-08 02:10:44 -05:00
Phlosioneer
69aec91577
Decompile move tutor stuff
...
2 nonmatching.
2019-03-08 01:56:38 -05:00
Marcus Huderle
bd157b301d
Scaninc: Don't insert missing headers into dependencies
2019-03-07 09:46:14 -06:00
Phlosioneer
105e1721d6
Overhaul scaninc to work recursively
...
This also fixes the bug where scaninc would ignore #include lines
in assembly files.
2019-03-07 08:46:55 -06:00
Phlosioneer
aa7657a82a
Move constants into C
...
Also figured out what one of the graphics files is for.
2019-03-06 22:58:05 -05:00
Phlosioneer
0da83abad2
Several nonmatching functions
...
Huge and difficult.
2019-03-06 22:27:30 -05:00
Phlosioneer
4345ba8e6c
More decompiled and cleanup
2019-03-05 22:32:28 -05:00
Phlosioneer
c3594f982d
Decompiling pokeblock ui stuff
2019-03-05 20:32:14 -05:00
DizzyEggg
e79b6f747b
Fix Controllers end command function names
2019-03-05 20:07:59 +01:00
Diegoisawesome
842e3c8b42
Merge pull request #605 from DizzyEggg/rename
...
Rename an erroneously named battlescript
2019-03-05 10:41:30 -06:00
DizzyEggg
596d85bcbd
What is love, baby dont hurt me
2019-03-05 17:07:37 +01:00
DizzyEggg
b150091436
Rename an erroneously named battlescript
2019-03-05 17:06:29 +01:00
DizzyEggg
b9c216638c
try flying
2019-03-05 16:52:40 +01:00
Phlosioneer
9bea9e1624
Start decompiling menu_unknown
2019-03-05 06:06:20 -05:00
DizzyEggg
3507ac3974
Start fixing flying.c
2019-03-05 09:02:05 +01:00
Phlosioneer
907492fd6e
Split rom asm file in half
...
The first half is ui/menu stuff, while the second half is link-related
stuff.
2019-03-04 23:26:51 -05:00
Phlosioneer
cae63cf1c7
Rename move tutor to move relearner
2019-03-04 20:56:39 -05:00
Phlosioneer
ac7a048380
Removed PREV and NEXT macros, changed summary name
2019-03-04 00:25:07 -05:00
Phlosioneer
05199f8fc7
Fix merge issue
2019-03-03 22:27:57 -05:00
garak
1758eb99df
match sub_810EE14 in flying.c
2019-03-03 22:08:58 -05:00
Phlosioneer
2879fe7fe0
Merge branch 'master' into summary-screen-macros
2019-03-03 16:58:54 -05:00
Phlosioneer
63e700af6c
Use macros for summary windows
...
Other minor changes and fixes are included
2019-03-03 16:50:51 -05:00
shinny456
1e7f4a80c7
port the rest of flying (leave 2 nonmatchings to egg)
2019-03-03 09:33:19 -06:00
Phlosioneer
4ea5e85bed
Fix typos
...
This is an updated version of #554 , since it hasn't been updated in two
weeks.
2019-03-03 09:31:47 -06:00
Phlosioneer
e03595a10d
Bugfixes from #591
2019-03-03 09:31:08 -06:00
Phlosioneer
4907ce6f7f
Fully document move_tutor (formerly learn_move)
2019-03-03 02:50:40 -05:00
Phlosioneer
9372731c3e
Merge branch 'master' into main-menu-state-machine
2019-03-02 17:35:44 -05:00
Phlosioneer
3716da5430
Rename macro with correct name for pixel values
2019-03-02 17:25:39 -05:00
Phlosioneer
80a4ee1145
Remove water.h and flying.h
2019-03-02 17:23:10 -05:00
DizzyEggg
043071ae12
Don't extern gMoveNames
2019-03-02 08:25:14 -06:00
huderlem
ee9694d9ba
Merge pull request #587 from Phlosioneer/document-all-event-vars
...
Document all event vars
2019-03-02 08:24:46 -06:00
Phlosioneer
25050b9944
Fix tabs, do suggested rename
2019-03-02 04:13:27 -05:00
Phlosioneer
49bef25856
Clean up the last extern functions
2019-03-02 03:18:08 -05:00
Phlosioneer
ee69426838
Eliminate more externs
2019-03-02 02:44:02 -05:00
Phlosioneer
0f6cc27e81
Fixed decomp issue around LoadPalette
...
In LoadLinkPartnerEventObjectSpritePalette, using paletteNum += 6 causes
GCC to "mark" paletteNum's register as a possible overflow, even though
it performs the overflow check. Then, when passing args to LoadPalette,
GCC fails to recognize that 0x100 + ((any u8) << 4) can never overflow
as a u16. It then does an overflow check before calling LoadPalette.
Assigning to a temp variable seems to avoid this "marking" behavior.
2019-03-02 00:36:59 -05:00
Phlosioneer
3ceb1667c9
Reduce externs
2019-03-01 22:32:50 -05:00
huderlem
3b04cfa437
Merge pull request #551 from Phlosioneer/multiplayer-stuff
...
Document overworld.c and link stuff in general
2019-03-01 08:43:55 -06:00
Phlosioneer
a7e5852f1d
More minor fixes
2019-03-01 01:49:11 -05:00
Phlosioneer
459fd93b59
Fix minor errors
2019-03-01 01:18:58 -05:00
Phlosioneer
da0687987d
Pick better names for constants
2019-02-28 22:21:16 -06:00
Phlosioneer
189d387f01
Add macros for metatile manipulation
2019-02-28 22:21:16 -06:00
hondew
53d7e21332
fix formatting in slot_machine.c
2019-02-28 21:21:56 -06:00
hondew
1dc0d346d9
fix spelling error
2019-02-28 21:21:56 -06:00
hondew
dd8ecabe26
fix mistakes and bad formatting
2019-02-28 21:21:56 -06:00
hondew
f965f1b13d
label luckyFlags
2019-02-28 21:21:56 -06:00
hondew
a6eb879267
minor reeltime changes
2019-02-28 21:21:56 -06:00
hondew
47a3477ab1
finish DecideReelTurns
2019-02-28 21:21:56 -06:00
hondew
f8f046c850
clean up slot machine more
2019-02-28 21:21:56 -06:00
hondew
67fe781ed2
clean up slot machine until AwardPayout
2019-02-28 21:21:56 -06:00
hondew
5c8cc5225f
document slot machine
2019-02-28 21:21:56 -06:00
DizzyEggg
baf95a8e7a
get rid of ugly cast
2019-02-28 17:26:09 -06:00
Phlosioneer
99bfd8c80f
VAR_0x3F20 is not a var
2019-02-28 00:10:44 -05:00
Phlosioneer
bf45b83c65
Finish documenting event vars
2019-02-27 23:54:51 -05:00
Phlosioneer
782979f1fc
Finish documenting trainer hill
...
Trainer hill isn't anywhere close to done, but I figured out enough
to name the VAR. That's all this PR should do.
2019-02-27 22:16:01 -05:00
Phlosioneer
66f0616a2d
I guess I'm documenting Trainer Hill now
2019-02-27 21:31:05 -05:00
Phlosioneer
e77e7844ea
Name several vars, document some related events
2019-02-27 20:25:09 -05:00
Phlosioneer
648fc3d4f3
Name more unknown vars
2019-02-27 15:18:56 -05:00
Phlosioneer
4137dd7b0b
Identify unused, never read, and never written vars
2019-02-27 14:42:32 -05:00
Marcus Huderle
4b9e93850c
Document easy chat screen types
2019-02-27 12:55:29 -06:00
Phlosioneer
c1348d22f3
Name most event scripts related to unusual weather
2019-02-27 04:27:54 -05:00
Phlosioneer
fe55580fe1
Reverse engineer unusual weather events
2019-02-27 03:42:04 -05:00
Phlosioneer
b2c92ee8c5
Missed some fill values
...
Must have forgotten to check FillWindowPixelRect.
2019-02-26 22:45:39 -05:00
Phlosioneer
72bb0daccb
Merge branch 'master' into main-menu-state-machine
2019-02-26 22:34:42 -05:00
Phlosioneer
6cb4c677cd
Fix backwards names
2019-02-26 22:30:40 -05:00
Phlosioneer
3a44b090d1
Merge branch 'master' into multiplayer-stuff
2019-02-26 22:07:29 -05:00
Phlosioneer
accea672f1
Incorporate feedback
2019-02-26 22:04:44 -05:00
Marcus Huderle
231355f84d
Decompile easy_chat data
2019-02-26 14:50:02 -06:00
Marcus Huderle
b60611c38e
Finish decompiling easy_chat.c code
2019-02-26 14:50:02 -06:00
DizzyEggg
7742e28dad
Easy chat nonmatchings fix
...
do {} while(0);
2019-02-26 09:15:20 -06:00
huderlem
153f134318
Merge pull request #583 from huderlem/easy_chat
...
Decompile more easy_chat.c
2019-02-25 14:12:18 -06:00
Marcus Huderle
7ea05431a5
Decompile more easy_chat.c
2019-02-25 14:11:31 -06:00
huderlem
d77ba3d413
Merge pull request #581 from arantonitis/pokemon_summary
...
Documented/polished pokemon_summary_screen.c
2019-02-25 08:09:14 -06:00
huderlem
b3a7a1278a
Merge pull request #577 from Phlosioneer/weather-15
...
Document the weather state functions
2019-02-25 08:03:22 -06:00
huderlem
84573f1774
Merge pull request #574 from Phlosioneer/event-vars
...
Event vars
2019-02-25 08:02:28 -06:00
Phlosioneer
a5cf2b8090
Use map script constants in map script functions
2019-02-25 08:01:22 -06:00
Phlosioneer
5f7a971313
Source file part of map script renaming
2019-02-25 08:01:22 -06:00
Phlosioneer
1cd5cb09cf
Merge branch 'master' into weather-15
2019-02-25 02:30:35 -05:00
Phlosioneer
e1b2460748
Adjust formatting, rename function
2019-02-25 02:28:41 -05:00
Phlosioneer
4e5fae0086
Merge branch 'master' into event-vars
2019-02-25 02:24:20 -05:00
Tustin2121
4a785e66ba
Changing descriptions to not be file names
2019-02-24 10:20:31 -06:00
tustin2121
8711bc5156
Document HEALTHBOX_GRX_* in battle_interface.c
...
Most of these are referenced via offsets, like the HP bar, which uses [0 pixels] + (number of pixels) to reference which chunk to draw. Each corresponds to a 16x16 pixel in the graphic named. Up to you guys if you want to rename the constants.
2019-02-24 10:20:31 -06:00