ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-12-27 04:04:17 +01:00
Code Issues Packages Projects Releases Wiki Activity
5,471 Commits 1 Branch 0 Tags 235 MiB
50d6e9ea34
Commit Graph

5471 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
GriffinR
18d57a3802 Document some overworld and field effects 2020-06-23 15:48:53 -04:00
GriffinR
fac6288156 Add local object event ids for referenced objects 2020-06-22 17:18:58 -04:00
Eduardo Quezada
7244b80fc6 Created constant for easier Ball Expansion. 2020-06-21 02:36:46 -04:00
GriffinR
8b462f3f6c Specify confetti util name 2020-06-18 18:14:30 -04:00
GriffinR
d2a760afdb Rename contest_link_80FC4F4, 80F57C4, and 81D9DE4 2020-06-18 18:01:32 -04:00
GriffinR
24569583e4 Document contest results 2020-06-18 17:50:13 -04:00
GriffinR
f600aff711 Rename rom_81520A8 2020-06-17 03:42:10 -04:00
GriffinR
76f6d05173 Document confetti 2020-06-17 03:39:03 -04:00
GriffinR
e507770425 Remove some unneeded link filler 2020-06-15 13:17:53 -04:00
GriffinR
4c8fd5af7c Move Pokemon cries to own directory 2020-06-15 13:00:24 -04:00
GriffinR
c2a07276ae
Merge branch 'master' into doc-link 2020-06-13 16:15:11 -04:00
Sierra A
46f4a4bbf7
Merge pull request #1074 from Sierraffinity/item-menu-cleanup 
Begin item_menu.c cleanup
 2020-06-10 17:17:35 -07:00
Sierra A
a05eea9312
Merge pull request #1075 from Sierraffinity/master 
Fix out of bounds array access in intro Groudon segment
 2020-06-10 17:16:04 -07:00
GriffinR
a9a427c6f2
Merge branch 'master' into doc-link 2020-06-10 17:36:43 -04:00
GriffinR
2859900ea9 Second pass on documenting union room 2020-06-10 17:30:59 -04:00
Sierraffinity
452f1e0047 Fix out of bounds array access in intro Groudon segment 2020-06-10 13:27:46 -07:00
Sierra A
a7815857ad
Merge pull request #1071 from PokeCF/patch-3 
Unnest if statements
 2020-06-10 13:23:57 -07:00
Sierraffinity
74edaed426 Begin item_menu.c cleanup 2020-06-10 13:07:42 -07:00
PikalaxALT
70c5f923ad
Merge pull request #1072 from nullableVoidPtr/master 
Match sub_80F0708
 2020-06-10 09:23:38 -04:00
nullableVoidPtr
8381828571 Match sub_80F0708 
Special thanks to @kazblox
 2020-06-10 21:13:58 +08:00
PokeCF
760baec098
Unnest if statements 
Overall, it is generally considered bad style to continually nest loops. However, if this is what the decompiler outputted, then why bother touching it?

However, this can be rewritten as returning early if the playtime is less than 60.

The reason for this is not because of the original code, but because it looks better, has the same output, and is easier to understand.
 2020-06-08 17:09:54 -04:00
GriffinR
35867f531b Some link rfu cleanup / link.c documentation 2020-06-08 15:24:25 -04:00
GriffinR
c98342c973 Document link_rfu_3.c 2020-06-08 00:28:21 -04:00
GriffinR
e6f5c4f264 Sync link_rfu_2.c 2020-06-07 12:54:50 -04:00
GriffinR
3f97763181 Document cable_club.c 2020-06-06 16:10:03 -04:00
huderlem
675f5ac03e Remove unnecessary comment 2020-06-03 19:55:15 -05:00
SBird
5d752bbe49 shop: document some constants s.t. object events don't break 2020-06-03 19:55:15 -05:00
GriffinR
aaf5d91c18 Document field_message_box.c 2020-06-03 19:47:45 -05:00
huderlem
83336585e2
Merge pull request #1067 from DizzyEggg/transitions 
Transitions
 2020-06-03 19:45:04 -05:00
GriffinR
9190af73b7 Label union room battle trainer 2020-06-03 15:28:29 -04:00
GriffinR
fd77eb1eb9 Document wireless_communication_status_screen.c 2020-06-03 14:07:40 -04:00
GriffinR
bc6bd36813 Document union_room_battle.c 2020-06-02 19:05:59 -04:00
GriffinR
18a00da820 Split wireless_communication_status_screen.c out 2020-06-02 18:51:26 -04:00
GriffinR
7632404ba5 Document union_room_chat.c 2020-06-02 18:35:00 -04:00
DizzyEggg
0690abd5a4 its time to ddddddduel 2020-06-02 17:28:47 +02:00
DizzyEggg
754266cb0f battle transitions 2020-06-02 13:32:30 +02:00
DizzyEggg
f608ae9f70 make battle transition OK ok Ok oK 2020-06-02 13:30:05 +02:00
PikalaxALT
8c54454923
Merge pull request #1066 from pret/revert-1065-transitions 
Revert "More transitions documentation"
 2020-06-01 18:26:07 -04:00
PikalaxALT
72b332d551
Revert "More transitions documentation" 2020-06-01 18:05:31 -04:00
Sierra A
d54053f9d7
Merge pull request #1065 from DizzyEggg/transitions 
More transitions documentation
 2020-06-01 10:57:07 -07:00
GriffinR
f53e2491bf Document union_room_player_avatar.c 2020-06-01 10:23:12 -04:00
DizzyEggg
ab3eb6065b More transitions documentation 2020-06-01 16:17:25 +02:00
Sierra A
ad61cccbd1
Merge pull request #1064 from DizzyEggg/patch-1 
Battle transition arrays easier to edit
 2020-05-31 11:31:31 -07:00
GriffinR
4fe507e453 Document union_room.c 2020-05-31 13:11:18 -04:00
DizzyEggg
b1ffe6efd7
Battle transition arrays easier to edit 2020-05-31 12:41:27 +02:00
PikalaxALT
24075e9e72
Merge pull request #1061 from GriffinRichards/fix-egg 
Clear up misleading egg step name
 2020-05-29 16:50:37 -04:00
PikalaxALT
e0ae696479
Merge pull request #1027 from PikalaxALT/gbagfx_tilemap 
Add tilemap rendering capability to gbagfx
 2020-05-29 16:49:46 -04:00
GriffinR
e27c3d2abd Clear up misleading egg step name 2020-05-27 16:41:23 -04:00
Sierraffinity
d528d75af7 Connect title screen BG palettes together 2020-05-27 07:58:48 -05:00
Sierraffinity
6963c00016 battle_anim_mons: Make cast not depend on size of struct 2020-05-27 07:58:48 -05:00