Commit Graph

6639 Commits

Author SHA1 Message Date
Sierraffinity
452f1e0047 Fix out of bounds array access in intro Groudon segment 2020-06-10 13:27:46 -07:00
Sierra A
a7815857ad
Merge pull request #1071 from PokeCF/patch-3
Unnest if statements
2020-06-10 13:23:57 -07:00
Sierraffinity
74edaed426 Begin item_menu.c cleanup 2020-06-10 13:07:42 -07:00
PikalaxALT
70c5f923ad
Merge pull request #1072 from nullableVoidPtr/master
Match sub_80F0708
2020-06-10 09:23:38 -04:00
nullableVoidPtr
8381828571 Match sub_80F0708
Special thanks to @kazblox
2020-06-10 21:13:58 +08:00
PokeCF
760baec098
Unnest if statements
Overall, it is generally considered bad style to continually nest loops. However, if this is what the decompiler outputted, then why bother touching it?

However, this can be rewritten as returning early if the playtime is less than 60.

The reason for this is not because of the original code, but because it looks better, has the same output, and is easier to understand.
2020-06-08 17:09:54 -04:00
GriffinR
35867f531b Some link rfu cleanup / link.c documentation 2020-06-08 15:24:25 -04:00
GriffinR
c98342c973 Document link_rfu_3.c 2020-06-08 00:28:21 -04:00
GriffinR
e6f5c4f264 Sync link_rfu_2.c 2020-06-07 12:54:50 -04:00
GriffinR
3f97763181 Document cable_club.c 2020-06-06 16:10:03 -04:00
huderlem
675f5ac03e Remove unnecessary comment 2020-06-03 19:55:15 -05:00
SBird
5d752bbe49 shop: document some constants s.t. object events don't break 2020-06-03 19:55:15 -05:00
GriffinR
aaf5d91c18 Document field_message_box.c 2020-06-03 19:47:45 -05:00
huderlem
83336585e2
Merge pull request #1067 from DizzyEggg/transitions
Transitions
2020-06-03 19:45:04 -05:00
GriffinR
9190af73b7 Label union room battle trainer 2020-06-03 15:28:29 -04:00
GriffinR
fd77eb1eb9 Document wireless_communication_status_screen.c 2020-06-03 14:07:40 -04:00
GriffinR
bc6bd36813 Document union_room_battle.c 2020-06-02 19:05:59 -04:00
GriffinR
18a00da820 Split wireless_communication_status_screen.c out 2020-06-02 18:51:26 -04:00
GriffinR
7632404ba5 Document union_room_chat.c 2020-06-02 18:35:00 -04:00
DizzyEggg
0690abd5a4 its time to ddddddduel 2020-06-02 17:28:47 +02:00
DizzyEggg
754266cb0f battle transitions 2020-06-02 13:32:30 +02:00
DizzyEggg
f608ae9f70 make battle transition OK ok Ok oK 2020-06-02 13:30:05 +02:00
PikalaxALT
8c54454923
Merge pull request #1066 from pret/revert-1065-transitions
Revert "More transitions documentation"
2020-06-01 18:26:07 -04:00
PikalaxALT
72b332d551
Revert "More transitions documentation" 2020-06-01 18:05:31 -04:00
Sierra A
d54053f9d7
Merge pull request #1065 from DizzyEggg/transitions
More transitions documentation
2020-06-01 10:57:07 -07:00
GriffinR
f53e2491bf Document union_room_player_avatar.c 2020-06-01 10:23:12 -04:00
DizzyEggg
ab3eb6065b More transitions documentation 2020-06-01 16:17:25 +02:00
Sierra A
ad61cccbd1
Merge pull request #1064 from DizzyEggg/patch-1
Battle transition arrays easier to edit
2020-05-31 11:31:31 -07:00
GriffinR
4fe507e453 Document union_room.c 2020-05-31 13:11:18 -04:00
AJ Fontaine
9311dfdbb3
Teatime and Eternabeam should be one word each 2020-05-31 10:00:21 -04:00
DizzyEggg
b1ffe6efd7
Battle transition arrays easier to edit 2020-05-31 12:41:27 +02:00
DizzyEggg
dd8879ca7c
Merge pull request #394 from ghoulslash/battle_engine
fix a bunch of anims
2020-05-31 11:26:01 +02:00
DizzyEggg
624f8fb28a
Merge pull request #396 from LOuroboros/regenerator
Fixed Regenerator
2020-05-30 10:54:53 +02:00
LOuroboros
c77bed7bfb Fixed Regenerator overhealing a Pokémon 2020-05-30 05:04:23 -03:00
PikalaxALT
24075e9e72
Merge pull request #1061 from GriffinRichards/fix-egg
Clear up misleading egg step name
2020-05-29 16:50:37 -04:00
PikalaxALT
e0ae696479
Merge pull request #1027 from PikalaxALT/gbagfx_tilemap
Add tilemap rendering capability to gbagfx
2020-05-29 16:49:46 -04:00
Evan
5d232c34fe fix a bunch of anims 2020-05-29 11:15:00 -06:00
DizzyEggg
19699bee23
Merge pull request #390 from ghoulslash/battle_engine
add animations for all moves
2020-05-29 12:53:17 +02:00
DizzyEggg
013f9b6a17 merge wiith masteer and summary screen change 2020-05-29 12:50:54 +02:00
Evan
fdc6e80e1e fix anim defines 2020-05-28 12:19:07 -06:00
Eduardo Alvaro Quezada D'Ottone
8d848997c9
Battle Configs: The Revenge (#363)
* Turns for Uproar

* Chances for the amount of hits with multi-hit moves.

* Electric type mon's immunity to paralysis

* (Hi) Jump Kick to always do 1/2 of maxHP when crashing

* Turns for Disable.

* Minimized mons can always be hit by moves like Stomp

* Grass types immune to powder and spore moves.

* Psywave's damage formula

* Fixed random usage.
2020-05-28 10:38:27 +02:00
GriffinR
e27c3d2abd Clear up misleading egg step name 2020-05-27 16:41:23 -04:00
Sierraffinity
d528d75af7 Connect title screen BG palettes together 2020-05-27 07:58:48 -05:00
Sierraffinity
6963c00016 battle_anim_mons: Make cast not depend on size of struct 2020-05-27 07:58:48 -05:00
Sierraffinity
ec92241d8f Fix REG_OFFSET_WININ/OUT mislabeling 2020-05-27 07:58:48 -05:00
Sierraffinity
42747663b5 Fix OAM region mislabeling 2020-05-27 07:58:48 -05:00
MandL27
c3d690a380 consistency with pokefirered 2020-05-27 07:58:04 -05:00
MandL27
6964d37db6 document UNKNOWN_A special char 2020-05-27 07:58:04 -05:00
DizzyEggg
5eeecb56c1 More touches to pokemon summary screen document 2020-05-27 07:57:15 -05:00
DizzyEggg
0f6b83f286 Entry hazards on 1 poke ai 2020-05-27 12:09:14 +02:00