Commit Graph

13288 Commits

Author SHA1 Message Date
SubzeroEclipse
5c98b9b427 Fixed Quagsire and Nuzleaf
Tweaked Quagsire female back and Nuzleaf to make their differences a bit more noticeable and faithful to the originals.
2023-07-03 18:12:39 +02:00
ghoulslash
cc3a6d4d94
make special case ABILITYEFFECT_xx ids their own caseId switch cases to fix potential overlap with ability IDs 0xFF etc (#3083)
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-07-03 10:03:50 +02:00
Eduardo Quezada D'Ottone
1fa9a05470
Convert move flags and bans into GCC bitfields (#2952)
* Slicing moves to new bitfield

* Wind moves to new bitfield

* Two-strike moves to new bitfield

* Forgot to add flagTwoStrikes to battle_moves.h

* Removed "flag" from field names

* FLAG_HIT_IN_SUBSTITUTE and FLAG_THAW_USER

* Airborne moves

* FLAG_POWDER, FLAG_TARGET_ABILITY_IGNORED and FLAG_DANCE

* FLAG_BALLISTIC and FLAG_PROTECTION_MOVE

* Fixed missing uses of MOVE_UNAVAILABLE in battle_ai_util.c

* FLAG_SOUND

* FLAG_DMG_UNDERGROUND and FLAG_DMG_UNDERWATER

* FLAG_DMG_MINIMIZE

* Cleanup

* FLAG_STAT_STAGES_IGNORED

* Updated Pollen Puff's ballistic flag

* FLAG_STRONG_JAW_BOOST and FLAG_MEGA_LAUNCHER_BOOST

* thaw

* FLAG_THREE_STRIKES

* FLAG_IRON_FIST_BOOST

* FLAG_RECKLESS_BOOST

* FLAG_HIGH_CRIT

* Removed empty flags

* Moves that fail when called by Me First + added missing Shell Trap

* Moves that fail when Gravity is active

* Better names for banned fields

* Moves that fail when called by Instruct

* Cleanup

* Contact Moves + Fixed Wandering Spirit skipping contact checks

* Inverted FLAG_PROTECT_AFFECTED so that there's a flag for moves that SKIP protect.

* Simplified B_MOVE_FLAGS configs

* FORBIDDEN_METRONOME

* Renamed hitsPastSubstitute to ignoresSubstitute

* FORBIDDEN_PARENTAL_BOND

* Struggle uncallable by Metronome

* FORBIDDEN_MIMIC

* FLAG_KINGS_ROCK_AFFECTED

* Made a single config for move flags

* Macro for checking move flags

* FLAG_MAGIC_COAT_AFFECTED

* Fixed HasMagicCoatAffectedMove

* FLAG_SNATCH_AFFECTED

* Removed unused EFFECT_FLINCH_MINIMIZE_HIT

* Fixed Stench/King's Rock interaction

* Removed sMovesNotAffectedByStench in favor of checking move effects

* Removed EFFECT_TWISTER, which was a repeat of EFFECT_FLINCH_HIT

* Changed Gen2 configs to less than Gen 3

* FORBIDDEN_SLEEP_TALK

* Cleanup

* Inverted FLAG_MIRROR_MOVE_AFFECTED

* FLAG_SHEER_FORCE_BOOST

* Ordered

* FORBIDDEN_ASSIST and FORBIDDEN_COPYCAT

* Removed TestMoveFlags and TestMoveFlagsInMoveset + flags field

* Fixed Triple Arrows test
2023-07-03 10:01:59 +02:00
hetoord
40a5995ead
Teatime tests and fixes (#3096) 2023-07-03 09:54:43 +02:00
gruxor
68ce97cd90
Fixed shadows in viewer (#3094)
* Fixed shadows in viewer + minor arg signature fix

* Unfixed castform functions, upcoming removal
2023-07-02 19:41:47 -04:00
SubzeroEclipse
49e7893ed2 Fixed Meganium shiny
There was a mismatch between the normal and the shiny that I didn't notice at first, so the regular palette was fixed. Thanks to CyanSixFour for pointing that out.
2023-07-02 07:28:08 +02:00
SubzeroEclipse
23d51df7c0 Added Hisuian Sneasel 2023-07-01 11:16:31 +02:00
SubzeroEclipse
d202bdd09c Added even more gender difference sprites, 2/2 2023-07-01 10:25:17 +02:00
Eduardo Quezada
2c4a9b754d Merge branch 'RHH/master' into RHH/upcoming 2023-06-30 16:14:57 -04:00
ghoulslash
a0ad8c817c
Change Mega evo sprites from 3per battler to 1 per battler (#3087) 2023-06-30 09:05:07 -04:00
ghoulslash
304fc4c5b5
Fix disobedience wrong move effect issue (#3089) 2023-06-30 09:03:18 -04:00
Eduardo Quezada D'Ottone
2100a760ad
A selection of animation frames (redone) (#3090)
* Applin Family

* Placeholder single frames to macro

* Stufful/Bewear

* Chewtle/Drednaw

* Rookidee/Corvisquire/Corviknight

* Rolycoly/Carkol/Coalossal

* Missing animations

* Grubbin/Charjabug/Vikavolt

* Turtonator and Wimpod/Golisopod

* Jangmo-O/Hakamo-O/Kommo-O

* Pyukumuku and Dewpider/Araquanid

* Fixed Charjabug/Vikavolt palettes

* Pincurchin and Sizzlipede/Centiscorch

* Alolan Exeggutor and Salandit/Salazzle

* Reverted PLACEHOLDER_ONE_FRAME_ANIMATION for a separate PR

* Forgot Pyukumuku's animation
2023-06-30 14:13:42 +02:00
SubzeroEclipse
0733e0908c Added even more gender difference sprites, 1/2 2023-06-30 10:40:46 +02:00
Eduardo Quezada D'Ottone
81e59ace25
Cleaned up remaining Castform hack stuff (#3063)
* Removed gCastformFrontSpriteCoords

* Removed sCastformElevations and IsCastformForm

* Removed sCastformBackSpriteYCoords and castformPalette in BattleStruct

* Scrubbed unused BS commands

* Removed B_ANIM_CASTFORM_CHANGE and BattleForm constants

* Removed redundant function in Pokémon Debug menu

* Removed handling in animation scripts

* Removed gBattleMonForms

* Reduced MAX_MON_PIC_FRAMES to 2

* Removed Castform/Cherrim makefile stuff

* Fixed weather form change tests not checking species.

* Fixed Castform palettes after Lunos' PR
2023-06-30 09:58:07 +02:00
DizzyEggg
1e2a613bd2
fix debug menu not removing task (#3088) 2023-06-29 14:11:02 -04:00
Alex
ea7e6265dd
Small Grassy Glide anim bug (#3092) 2023-06-29 14:07:46 -04:00
ghoulslash
e21fcda54c
Fix Light Of Ruin freeze and potentially other move anims (#3084) 2023-06-29 11:58:53 -04:00
GriffinR
8822264130
Merge pull request #1896 from PokemonSanFran/incrementgamestat_fix
Added bugfix for SaveBeforeLinkMultisChallenge to remove extra incrementgamestat
2023-06-29 11:45:13 -04:00
Eduardo Quezada D'Ottone
4c4365b0c1
Config for LGPE friendship stat boost (#2257)
* Config for LGPE friendship stat boost

* Separated Exp and Stat settings
2023-06-28 18:44:53 +02:00
Alex
20099274d8
Fix Clear Amulet visual bug + Tests (#3074)
* Fix Clear Amulet visual bug + Tests

TODO Tests, additional tests + Triple Kick pp bug

* Wonder Guard message, switch instead of if, misalignments
2023-06-28 12:26:03 -04:00
DizzyEggg
f9058a8544 Fix disobedience wrong move effect issue 2023-06-28 12:47:20 +02:00
DizzyEggg
a4a519b69f Change Mega evo sprites from 3per battler to 1 per battler 2023-06-28 10:38:38 +02:00
Eduardo Quezada D'Ottone
67b196cd86
Try fixing Clear Amulet palette issue (#3086) 2023-06-27 22:14:56 -04:00
Eclipse
fc52414383
Added many more gender differences sprites (#3082)
Added sprites for the remaining Gen1 mons and a couple of evolutions.
2023-06-27 21:11:01 -04:00
PSF
b2901c51b0 Added bugfix for SaveBeforeLinkMultisChallenge to remove extra incrementgamestat 2023-06-27 15:34:31 -07:00
DizzyEggg
09013ee2db Fix createsprite battle anim cmd not checking MAX_SPRITES 2023-06-27 22:39:43 +02:00
Eclipse
a44af6f06f
Gender differences sprites, part 1 (#3070)
* Added some gender difference sprites
Added sprites for:
- Pikachu/Raichu
- Doduo/Dodrio
- Goldeen/Seaking
- Xatu
- Politoed
- Meditite/Medicham
- Gible/Gabite/Garchomp

NOTE: I had to tweak Doduo's palette file because it wasn't matching the normal one and a result Doduo's beak looked weird.

* Swapped Pikachu sprites
Replaced them with the ones provided by CyanSixFour because they looked better than the ones that I had.

* Added Gloom and Vileplume

* Fixed Pikachu forms
Edited the macros so that only base Pikachu would show different forms based on gender. Big thanks to AsparagusEduardo for helping with this.

* Swapped a few more sprites
Replaced Goldeen (female back), Politoad (female back), Medicham (female all) sprites with those provided by CyanSixFour because they looked better. Also tweaked my male Meditite back
2023-06-26 19:04:19 -04:00
PacFire
4b3b9b5e0a
Added icon for Clear Amulet (#3078)
* Update graphics.h

* Update item_icon_table.h

* Update items.h

* Add files via upload

added icon for clear amulet, shards still missing.

* Add files via upload

added clear amulet's palette

* Update graphics.h
2023-06-26 18:19:33 -04:00
Eduardo Quezada
f9bf91a2f0 Merge branch 'RHH/master' into RHH/upcoming 2023-06-26 18:09:53 -04:00
Eduardo Quezada D'Ottone
f3be4e1ac5
Fixed 2 test runner issues (#3076)
* Fixed 2 test runner issues

Thanks to MGriffin for the help
- Fixed non-battle tests omitting errors when failing.
- Fixed non-battle tests showing false positive memory leak errors due to the test failing for a different cause.

* Update test/test_runner.c

Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
2023-06-26 19:26:42 +01:00
hetoord
4a6f791482
Tests for Air Balloon (#3071)
* Add tests for HOLD_EFFECT_AIR_BALLOON

* Apply suggestions from code review

---------

Co-authored-by: Bart <bart@DESKTOP-IKF42MG.localdomain>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-06-26 08:37:48 -04:00
ghoulslash
c7e8edf19b
Easy Chat always shows words in uppercase (#3050) 2023-06-24 13:28:13 -04:00
ghoulslash
5de84d9a2f
Killed the bKGD invalid index warnings and fixed the bit depth of the species sprites (#3051) 2023-06-24 13:27:40 -04:00
ghoulslash
5f147925a6
Fixed AI_WhoStrikesFirst considering status priority moves when it shouldn't (#3064) 2023-06-24 13:26:59 -04:00
Eduardo Quezada D'Ottone
f5aabcad70
Minor test changes (#3072) 2023-06-23 10:18:57 -04:00
Martin Griffin
8995296db4 Use ; instead of {} for empty PLAYER/OPPONENT 2023-06-23 15:09:41 +01:00
Martin Griffin
1987bda497 Regularize whitespace in tests 2023-06-23 15:09:41 +01:00
Martin Griffin
b90ff23b80 I_HEALTH_RECOVERY in item_effect_restore_hp.c 2023-06-23 15:09:41 +01:00
Martin Griffin
0d930946a7 Parametrize item_effect_restore_hp.c 2023-06-23 15:09:41 +01:00
Martin Griffin
b357d5b1b8 Inline uses of macros in tests 2023-06-23 15:09:41 +01:00
Martin Griffin
0b43f5ab0e Use 3-arg PASSES_RANDOMLY in Snow+Blizzard 2023-06-22 17:20:39 +01:00
Martin Griffin
72bb8b71b6 More conservative unlink error in Hydra 2023-06-22 17:17:43 +01:00
Martin Griffin
e8b2eea89d Sensible names for temporary ROMs in Hydra 2023-06-22 17:17:41 +01:00
Martin Griffin
20aea1f32f Print runner number in Hydra 2023-06-22 17:17:41 +01:00
Martin Griffin
c9a2c86d78 Simplify TO_DO_BATTLE_TEST 2023-06-22 15:19:35 +01:00
Martin Griffin
3e6f499517 TearDownBattle function 2023-06-22 15:08:15 +01:00
Eduardo Quezada
ca1d9f5393 Merge branch 'RHH/master' into RHH/upcoming
# Conflicts:
#	include/battle_util.h
2023-06-21 15:01:14 -04:00
ghoulslash
7371a9e401
Add many gen 8 move animations (#2861)
* port many gen8 and 9 move anims from cfru

* fix thunder cage, shell smash, shelter anims. update anim credits

---------

Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-06-21 13:19:54 -04:00
voloved
c911d4bf57
Made window's starting location track with ball; made window show if it's showing on startup (#3042) 2023-06-21 13:19:08 -04:00
Pawkkie
62ae3b1df1
Fix bug due to variable overflow when AI chooses new Pokemon to send out (#3068) 2023-06-21 12:59:30 -04:00