ninjdai/pokeemerald
1
0
Fork 0
mirror of https://github.com/Ninjdai1/pokeemerald.git synced 2024-11-18 04:27:38 +01:00
Code Issues Packages Projects Releases Wiki Activity
5,561 Commits 1 Branch 0 Tags 235 MiB
365e550f1d
Commit Graph

5561 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
PikalaxALT
70c5f923ad
Merge pull request #1072 from nullableVoidPtr/master 
Match sub_80F0708
 2020-06-10 09:23:38 -04:00
nullableVoidPtr
8381828571 Match sub_80F0708 
Special thanks to @kazblox
 2020-06-10 21:13:58 +08:00
PokeCF
760baec098
Unnest if statements 
Overall, it is generally considered bad style to continually nest loops. However, if this is what the decompiler outputted, then why bother touching it?

However, this can be rewritten as returning early if the playtime is less than 60.

The reason for this is not because of the original code, but because it looks better, has the same output, and is easier to understand.
 2020-06-08 17:09:54 -04:00
GriffinR
35867f531b Some link rfu cleanup / link.c documentation 2020-06-08 15:24:25 -04:00
DizzyEggg
dd30ae3481
Merge pull request #401 from Fontbane/cries 
Fix Alola Form back coordinates
 2020-06-08 10:05:36 +02:00
GriffinR
c98342c973 Document link_rfu_3.c 2020-06-08 00:28:21 -04:00
GriffinR
e6f5c4f264 Sync link_rfu_2.c 2020-06-07 12:54:50 -04:00
GriffinR
3f97763181 Document cable_club.c 2020-06-06 16:10:03 -04:00
huderlem
675f5ac03e Remove unnecessary comment 2020-06-03 19:55:15 -05:00
SBird
5d752bbe49 shop: document some constants s.t. object events don't break 2020-06-03 19:55:15 -05:00
GriffinR
aaf5d91c18 Document field_message_box.c 2020-06-03 19:47:45 -05:00
huderlem
83336585e2
Merge pull request #1067 from DizzyEggg/transitions 
Transitions
 2020-06-03 19:45:04 -05:00
GriffinR
9190af73b7 Label union room battle trainer 2020-06-03 15:28:29 -04:00
GriffinR
fd77eb1eb9 Document wireless_communication_status_screen.c 2020-06-03 14:07:40 -04:00
GriffinR
bc6bd36813 Document union_room_battle.c 2020-06-02 19:05:59 -04:00
GriffinR
18a00da820 Split wireless_communication_status_screen.c out 2020-06-02 18:51:26 -04:00
GriffinR
7632404ba5 Document union_room_chat.c 2020-06-02 18:35:00 -04:00
Fontbane
9365f4d758 Fix Alola Form back coordinates 
Meowth, Persian, Geodude, Golem, and Grimer were 1-2 pixels too high.
 2020-06-02 17:35:20 -04:00
DizzyEggg
0690abd5a4 its time to ddddddduel 2020-06-02 17:28:47 +02:00
DizzyEggg
754266cb0f battle transitions 2020-06-02 13:32:30 +02:00
DizzyEggg
f608ae9f70 make battle transition OK ok Ok oK 2020-06-02 13:30:05 +02:00
PikalaxALT
8c54454923
Merge pull request #1066 from pret/revert-1065-transitions 
Revert "More transitions documentation"
 2020-06-01 18:26:07 -04:00
PikalaxALT
72b332d551
Revert "More transitions documentation" 2020-06-01 18:05:31 -04:00
Sierra A
d54053f9d7
Merge pull request #1065 from DizzyEggg/transitions 
More transitions documentation
 2020-06-01 10:57:07 -07:00
GriffinR
f53e2491bf Document union_room_player_avatar.c 2020-06-01 10:23:12 -04:00
DizzyEggg
ab3eb6065b More transitions documentation 2020-06-01 16:17:25 +02:00
Sierra A
ad61cccbd1
Merge pull request #1064 from DizzyEggg/patch-1 
Battle transition arrays easier to edit
 2020-05-31 11:31:31 -07:00
GriffinR
4fe507e453 Document union_room.c 2020-05-31 13:11:18 -04:00
LOuroboros
6a3ab9d0df
Teatime and Eternabeam should be one word each 
Equivalent to #398 for the pokemon_expansion.
The moves are called Teatime and Eternabeam, so certainly, `MOVE_TEA_TIME` and `MOVE_ETERNA_BEAM` are incorrect labels.
 2020-05-31 13:47:41 -03:00
DizzyEggg
b1ffe6efd7
Battle transition arrays easier to edit 2020-05-31 12:41:27 +02:00
DizzyEggg
103783aec9
Merge pull request #397 from LOuroboros/patch-1 
Defined Gen. 8 Moves
 2020-05-31 11:25:51 +02:00
LOuroboros
bc2da33e0e
Defined Gen. 8 Moves 
Straight up copied from the battle_engine_v2 branch.
 2020-05-30 17:53:34 -03:00
PikalaxALT
24075e9e72
Merge pull request #1061 from GriffinRichards/fix-egg 
Clear up misleading egg step name
 2020-05-29 16:50:37 -04:00
PikalaxALT
e0ae696479
Merge pull request #1027 from PikalaxALT/gbagfx_tilemap 
Add tilemap rendering capability to gbagfx
 2020-05-29 16:49:46 -04:00
DizzyEggg
cca1dcc04a merge with master 2020-05-29 13:07:53 +02:00
GriffinR
e27c3d2abd Clear up misleading egg step name 2020-05-27 16:41:23 -04:00
Sierraffinity
d528d75af7 Connect title screen BG palettes together 2020-05-27 07:58:48 -05:00
Sierraffinity
6963c00016 battle_anim_mons: Make cast not depend on size of struct 2020-05-27 07:58:48 -05:00
Sierraffinity
ec92241d8f Fix REG_OFFSET_WININ/OUT mislabeling 2020-05-27 07:58:48 -05:00
Sierraffinity
42747663b5 Fix OAM region mislabeling 2020-05-27 07:58:48 -05:00
MandL27
c3d690a380 consistency with pokefirered 2020-05-27 07:58:04 -05:00
MandL27
6964d37db6 document UNKNOWN_A special char 2020-05-27 07:58:04 -05:00
DizzyEggg
5eeecb56c1 More touches to pokemon summary screen document 2020-05-27 07:57:15 -05:00
Marcus Huderle
79a1127122 Match sub_817F9F4 2020-05-24 17:22:56 -05:00
GriffinR
f9e6f7540f Use fixed point macros for math util 2020-05-24 08:28:02 -05:00
GriffinR
c6205b3df4 Document math_util.c 2020-05-24 08:28:02 -05:00
GriffinR
210862f7b6 Match InBoxInput_Normal, HandleInput_InParty, HandleInput_OnBox, and HandleInput_OnButtons 2020-05-24 08:26:38 -05:00
GriffinR
5019381911 Match sub_8024604 2020-05-24 08:26:38 -05:00
GriffinR
89350cb81a Clean up sub_8022C58 2020-05-24 08:26:38 -05:00
GriffinR
b29c7554ea Match sub_8022250 2020-05-24 08:26:38 -05:00