PokeCF
760baec098
Unnest if statements
...
Overall, it is generally considered bad style to continually nest loops. However, if this is what the decompiler outputted, then why bother touching it?
However, this can be rewritten as returning early if the playtime is less than 60.
The reason for this is not because of the original code, but because it looks better, has the same output, and is easier to understand.
2020-06-08 17:09:54 -04:00
huderlem
675f5ac03e
Remove unnecessary comment
2020-06-03 19:55:15 -05:00
SBird
5d752bbe49
shop: document some constants s.t. object events don't break
2020-06-03 19:55:15 -05:00
GriffinR
aaf5d91c18
Document field_message_box.c
2020-06-03 19:47:45 -05:00
huderlem
83336585e2
Merge pull request #1067 from DizzyEggg/transitions
...
Transitions
2020-06-03 19:45:04 -05:00
DizzyEggg
0690abd5a4
its time to ddddddduel
2020-06-02 17:28:47 +02:00
DizzyEggg
754266cb0f
battle transitions
2020-06-02 13:32:30 +02:00
DizzyEggg
f608ae9f70
make battle transition OK ok Ok oK
2020-06-02 13:30:05 +02:00
PikalaxALT
8c54454923
Merge pull request #1066 from pret/revert-1065-transitions
...
Revert "More transitions documentation"
2020-06-01 18:26:07 -04:00
PikalaxALT
72b332d551
Revert "More transitions documentation"
2020-06-01 18:05:31 -04:00
Sierra A
d54053f9d7
Merge pull request #1065 from DizzyEggg/transitions
...
More transitions documentation
2020-06-01 10:57:07 -07:00
DizzyEggg
ab3eb6065b
More transitions documentation
2020-06-01 16:17:25 +02:00
Sierra A
ad61cccbd1
Merge pull request #1064 from DizzyEggg/patch-1
...
Battle transition arrays easier to edit
2020-05-31 11:31:31 -07:00
DizzyEggg
b1ffe6efd7
Battle transition arrays easier to edit
2020-05-31 12:41:27 +02:00
PikalaxALT
24075e9e72
Merge pull request #1061 from GriffinRichards/fix-egg
...
Clear up misleading egg step name
2020-05-29 16:50:37 -04:00
PikalaxALT
e0ae696479
Merge pull request #1027 from PikalaxALT/gbagfx_tilemap
...
Add tilemap rendering capability to gbagfx
2020-05-29 16:49:46 -04:00
GriffinR
e27c3d2abd
Clear up misleading egg step name
2020-05-27 16:41:23 -04:00
Sierraffinity
d528d75af7
Connect title screen BG palettes together
2020-05-27 07:58:48 -05:00
Sierraffinity
6963c00016
battle_anim_mons: Make cast not depend on size of struct
2020-05-27 07:58:48 -05:00
Sierraffinity
ec92241d8f
Fix REG_OFFSET_WININ/OUT mislabeling
2020-05-27 07:58:48 -05:00
Sierraffinity
42747663b5
Fix OAM region mislabeling
2020-05-27 07:58:48 -05:00
MandL27
c3d690a380
consistency with pokefirered
2020-05-27 07:58:04 -05:00
MandL27
6964d37db6
document UNKNOWN_A special char
2020-05-27 07:58:04 -05:00
DizzyEggg
5eeecb56c1
More touches to pokemon summary screen document
2020-05-27 07:57:15 -05:00
Marcus Huderle
79a1127122
Match sub_817F9F4
2020-05-24 17:22:56 -05:00
GriffinR
f9e6f7540f
Use fixed point macros for math util
2020-05-24 08:28:02 -05:00
GriffinR
c6205b3df4
Document math_util.c
2020-05-24 08:28:02 -05:00
GriffinR
210862f7b6
Match InBoxInput_Normal, HandleInput_InParty, HandleInput_OnBox, and HandleInput_OnButtons
2020-05-24 08:26:38 -05:00
GriffinR
5019381911
Match sub_8024604
2020-05-24 08:26:38 -05:00
GriffinR
89350cb81a
Clean up sub_8022C58
2020-05-24 08:26:38 -05:00
GriffinR
b29c7554ea
Match sub_8022250
2020-05-24 08:26:38 -05:00
hondew
cfc47e642f
Clean up slot drawing
...
Fix typos
2020-05-24 08:24:20 -05:00
hondew
26a197847a
Rename tag offset functions
...
Fix typo
2020-05-24 08:24:20 -05:00
Sierra A
25f0dac1b5
Merge pull request #1055 from Sierraffinity/mystery_gift_fakematchfix
...
Fix mystery gift fakematchings
2020-05-20 21:08:31 -07:00
Sierra A
783ebfe163
Merge pull request #1052 from Missingmew/unused-decompress
...
Decompile unused decompress function, as seen in ruby
2020-05-20 21:06:47 -07:00
Sierraffinity
ac6bcecdf5
Fix mystery gift fakematchings
2020-05-20 21:00:21 -07:00
Sierra A
7b16d6b6f0
Merge pull request #1054 from Sierraffinity/battle_dome_fakematchfix
...
Fix HblankCb_TourneyTree fakematch
2020-05-20 20:40:24 -07:00
Sierraffinity
929e64ad33
Fix HblankCb_TourneyTree fakematch
2020-05-20 20:31:16 -07:00
Sierra A
02416dc79c
Merge pull request #1053 from Sierraffinity/text-drawdownarrow-fix
...
Fix TextPrinterDrawDownArrow fakematch
2020-05-20 19:50:52 -07:00
Sierraffinity
d301d438c1
Fix the fix
2020-05-20 19:33:40 -07:00
Sierraffinity
3617a064d2
Fix TextPrinterDrawDownArrow fakematch
2020-05-20 19:09:55 -07:00
Missingmew
9a13be4e7b
switch to pret short-types and tabs vs spaces
2020-05-21 00:25:30 +02:00
Missingmew
1beca515ed
Decompile unused function, as seen in ruby
2020-05-20 23:58:20 +02:00
Sierra A
476acc00d5
Merge pull request #1049 from GriffinRichards/typo
...
sPrizeListGigaSwap typo fix
2020-05-19 13:30:48 -07:00
GriffinR
2a1781b2ed
sPrizeListGigaSwap typo fix
2020-05-19 16:13:25 -04:00
PikalaxALT
7c248947f4
Merge pull request #1038 from ProjectRevoTPP/master
...
restore SeedRngWithRtc comment and declaration of GF oversight.
2020-05-19 13:31:41 -04:00
PikalaxALT
3c4b9dfacc
Merge pull request #1044 from DizzyEggg/sss
...
Document pokemon summary screen
2020-05-19 13:30:42 -04:00
Sierra A
eb4c880db8
Merge pull request #1046 from Kurausukun/patch-2
...
Fix compilation on gcc 10 (for real this time)
2020-05-18 20:49:00 -07:00
Kurausukun
65fb2e9957
Fix compilation on gcc 10 (for real this time)
2020-05-18 23:42:42 -04:00
Sierra A
da30244b6c
Merge pull request #1041 from AsparagusEduardo/UnownStats
...
Using ability constants for OLD_UNOWN stats
2020-05-18 16:33:23 -07:00
