DizzyEggg
dd3334aa82
Battle bond tests and small fix ( #3279 )
...
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-09-07 17:23:43 -03:00
kittenchilly
e20383b0a4
Merge branch 'upcoming' into overworldsnow
2023-09-07 14:29:30 -05:00
Eduardo Quezada
3333395ff7
Merge branch 'RHH/upcoming' into RHH/pr/upcoming/variousGone1
...
# Conflicts:
# include/constants/battle_script_commands.h
# src/battle_script_commands.c
2023-09-07 15:54:55 -03:00
Eduardo Quezada
820113d883
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# data/battle_anim_scripts.s
# data/battle_scripts_1.s
# include/battle_scripts.h
# include/battle_util.h
# src/battle_script_commands.c
# src/battle_util.c
2023-09-07 15:13:06 -03:00
DizzyEggg
cfd802423b
Fling fixes and tests ( #3191 )
...
* begin fling tests
* fling fixes and tests
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* Update test/move_effect_fling.c
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
* scripts names change
* fix fling's test file
---------
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-09-05 06:56:36 -03:00
ghoulslash
675aa5db41
fix GetBattleAnimMoveTargets logic ( #3278 )
...
* fix GetBattleAnimMoveTargets logic
* more efficient GetBattleAnimMoveTargets
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-09-05 09:21:14 +02:00
kittenchilly
1e10bbe007
Merge branch 'upcoming' into overworldsnow
2023-09-04 17:57:20 -05:00
kittenchilly
2fa4206bf1
Add new Substitute doll sprites ( #3263 )
2023-09-04 19:48:43 -03:00
DizzyEggg
d9677763e5
remove gActiveBattler replacement
2023-09-04 10:26:37 +02:00
DizzyEggg
7c2ad314d4
merge with upcoming
2023-09-04 09:40:48 +02:00
kittenchilly
0a781217ea
Merge branch 'upcoming' into overworldsnow
2023-09-02 15:17:23 -05:00
Eduardo Quezada
c4553c71aa
5 more callnatives
...
- jumpifshelltrap
- jumpifemergencyexited
- jumpifrodaffected
- jumpifabsorbaffected
- jumpifmotoraffected
2023-08-31 23:43:48 -04:00
Eduardo Quezada
4ac61ad15f
handleultraburst, handleprimalreversion, handlemegaevo
2023-08-31 22:34:57 -04:00
Eduardo Quezada
35d7201935
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# data/battle_scripts_1.s
# include/battle_scripts.h
2023-08-31 20:46:53 -04:00
Eduardo Quezada D'Ottone
c4e88760f5
Pret merge (2023/08/31) ( #3268 )
2023-08-31 14:52:18 -04:00
Eduardo Quezada
842b9dc6c0
Incorporated bugfixes from upstream
2023-08-31 14:30:13 -04:00
Eduardo Quezada
0d5b00aaf2
Merge remote-tracking branch 'pret/master' into RHH/pr/upcoming/pret_20230829
...
# Conflicts:
# README.md
# data/battle_ai_scripts.s
# data/battle_scripts_1.s
# data/maps/BattleFrontier_Lounge7/scripts.inc
# include/battle_anim.h
# include/battle_message.h
# include/constants/items.h
# src/battle_ai_script_commands.c
# src/battle_ai_switch_items.c
# src/battle_anim_throw.c
# src/battle_anim_utility_funcs.c
# src/battle_controller_link_opponent.c
# src/battle_controller_link_partner.c
# src/battle_controller_opponent.c
# src/battle_controller_player.c
# src/battle_controller_player_partner.c
# src/battle_controller_recorded_opponent.c
# src/battle_controller_recorded_player.c
# src/battle_controller_wally.c
# src/battle_gfx_sfx_util.c
# src/battle_message.c
# src/battle_script_commands.c
# src/battle_util.c
# src/data/party_menu.h
# src/data/pokemon/tmhm_learnsets.h
# src/daycare.c
# src/field_specials.c
# src/hall_of_fame.c
# src/party_menu.c
# src/pokemon.c
# src/tv.c
2023-08-31 14:28:01 -04:00
kittenchilly
9fcb1a8687
Merge remote-tracking branch 'upstream/upcoming' into overworldsnow
2023-08-31 11:56:12 -05:00
Eduardo Quezada D'Ottone
82c65d37e7
Fixed 2v1 handling when debug menu is enabled ( #3223 )
2023-08-31 09:00:59 +02:00
Alex
64ffc5a85d
Fixes Beat Up + Chloroblast ( #3264 )
2023-08-30 15:58:53 -04:00
DizzyEggg
aae4a0970c
merge with upcoming
2023-08-30 15:46:27 +02:00
DizzyEggg
493c330cbd
merge with upcoming
2023-08-30 13:23:55 +02:00
DizzyEggg
c29f8259f6
remove gActiveBattler entirely
2023-08-30 12:46:22 +02:00
DizzyEggg
a7615f9649
remove almost all usage of active battler
2023-08-30 11:21:10 +02:00
DizzyEggg
4683783a92
remove active battler from other files
2023-08-30 10:18:31 +02:00
DizzyEggg
77dd5150f5
remove gActiveBattler from battle_script_commands.c
2023-08-30 09:40:15 +02:00
kittenchilly
c8aac3407e
Merge branch 'upcoming' into overworldsnow
2023-08-29 21:02:33 -05:00
kittenchilly
c427d96f3f
Better Ultra Burst animation
2023-08-29 19:13:21 -05:00
kittenchilly
028536e2d3
Spaces
2023-08-29 17:12:09 -05:00
kittenchilly
d540eccbb1
Merge branch 'upcoming' into ultraburst
2023-08-29 16:17:35 -05:00
Eduardo Quezada
be152fbee8
Merge branch 'RHH/master' into RHH/pr/master/opponentName
2023-08-29 13:11:32 -04:00
DizzyEggg
0381ccdf32
remove more of gActiveBattler
2023-08-29 16:20:16 +02:00
DizzyEggg
156aa59f18
start removing gActiveBattler in controller emitters
2023-08-29 15:21:31 +02:00
DizzyEggg
00e1542cb8
Merge branch 'ai_switch_mon_fix' of https://github.com/DizzyEggg/pokeemerald into ai_switch_mon_fix
2023-08-29 10:42:07 +02:00
DizzyEggg
44acd287f1
solve conflicts
2023-08-29 10:41:05 +02:00
ghoulslash
326fb2605a
Some gActiveBattler Fixes ( #3259 )
...
* some gActiveBattler related fixes
* fix IsBattleSEPlaying gActiveBattler->battlerId
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-08-29 09:31:11 +02:00
ghoulslash
4490e9879a
Prevent certain status moves when item is known + Fake Out changes ( #3219 )
2023-08-28 17:12:29 -04:00
DizzyEggg
6ae1ba10da
fix conflicts
2023-08-28 13:55:45 +02:00
Pawkkie
906ea4a5b0
Add missing absorbing abilities to FindMonThatAbsorbsOpponentsMove ( #3218 )
...
* Add missing absorbing abilities to FindMonThatAbsorbsOpponentsMove
* Use array to match ability to absorbing type
Previous implementation involving piggybacking on a conditional in a bit of a messy fashion to check for each ability type, this should be more readable and more easily modified by a novice. This is almost exactly BuffelSaft's inclement emerald implementation.
* Minor syntax fixes
2023-08-28 13:39:27 +02:00
GriffinR
d67914e114
Merge pull request #1912 from GriffinRichards/moves-mask
...
Handful of fixes related to MAX_MON_MOVES
2023-08-27 19:40:59 -04:00
kittenchilly
37f6685949
Merge branch 'upcoming' into overworldsnow
2023-08-27 14:51:57 -05:00
kittenchilly
48d6fe2e64
Merge branch 'upcoming' into ultraburst
2023-08-26 14:43:31 -05:00
voloved
2784f701d8
Poké Ball shortcut tweaks ( #3254 )
2023-08-26 12:58:51 -04:00
voloved
2a2cd77cf4
Allow Cycling Through Balls in the Last Ball Used Menu ( #3039 )
2023-08-24 19:23:26 -04:00
Eduardo Quezada D'Ottone
9c937a945c
Pokemon sprite review pt.1 ( #3235 )
2023-08-23 22:43:42 -04:00
Philipp AUER
905fc6fd4d
Fixed Metronome Item damage multiplier ( #3246 )
...
Co-authored-by: sbird <sbird@no.tld>
2023-08-23 19:23:00 -04:00
CyanSMP64
fd37946c1d
resize golduck
2023-08-22 20:31:13 +12:00
LOuroboros
9d6953cc63
Removed the sTMHMMoves array and made TMs/HMs read moves from their secondaryId item field ( #3243 )
...
* Deleted sTMHMMoves array, TMs/HMs read moves from their secondaryId item field now
The unused "registrability" variable has been removed in order to preserve the size of the gItems array after turning the secondaryId variable into a u16.
* Made ItemIdToBattleMoveId return ITEM_NONE if an item that is not a TM/HM is passed through it
* Renamed IsMoveHm to IsMoveHM
2023-08-21 12:49:17 +01:00
DizzyEggg
9cf5376c96
use GetBattlerParty in LoadMonSprite
2023-08-21 09:43:01 +02:00
GriffinR
e70577d59b
Add missing sizeof in trainer_see
2023-08-20 17:22:29 -04:00
kittenchilly
a79898f1b1
Make fog cause misty terrain
2023-08-20 13:51:48 -05:00
GriffinR
4941e2602a
Merge pull request #1909 from GriffinRichards/stat-anim
...
Document stat change animation
2023-08-20 14:29:11 -04:00
kittenchilly
5e98891577
Snow doesn't cause shade anymore
2023-08-20 13:24:20 -05:00
CyanSMP64
4e5809a0d0
tweak graveler, pikachu
2023-08-20 22:08:54 +12:00
kittenchilly
0ad3919f22
Fix overworld snow weather
2023-08-19 01:40:31 -05:00
CyanSMP64
ec24754489
fix arcanine, change bg colour of green pokemon
2023-08-18 17:24:30 +12:00
Eduardo Quezada
d3333812dd
Merge branch 'RHH/upcoming' into RHH/pr/upcoming/cleanup/customTrainer
2023-08-17 17:52:28 -04:00
kittenchilly
4ca4b2dd76
Update battle_interface.c
2023-08-17 13:29:27 -05:00
kittenchilly
4e0e70ae81
Fix memory corruption when handling the ultra burst trigger sprite
2023-08-17 13:29:04 -05:00
kittenchilly
f95b4fdb4c
Merge branch 'upcoming' into ultraburst
2023-08-17 13:25:00 -05:00
Eduardo Quezada
a6dbb68bac
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# data/battle_scripts_1.s
# src/battle_util.c
# src/battle_z_move.c
2023-08-17 13:42:09 -04:00
Philipp AUER
cd90fdec5d
[Critical] fix memory corruption when handling trigger sprites ( #3238 )
...
Co-authored-by: sbird <sbird@no.tld>
2023-08-16 20:21:16 -04:00
GriffinR
bdc0ea1037
Add MOD to match mod with powers of 2
2023-08-16 16:44:45 -04:00
GriffinR
057928438a
Document ChooseMoveAndTargetInBattlePalace
2023-08-16 16:41:29 -04:00
GriffinR
aca7998b93
Add missing use of ALL_MOVES_MASK
2023-08-16 14:33:15 -04:00
CyanSMP64
74de0ef3ca
set background colour
2023-08-16 13:58:31 +12:00
GriffinR
10a10e914b
Merge pull request #1910 from GriffinRichards/misc-constants
...
Use miscellaneous missing constants
2023-08-15 17:53:41 -04:00
CyanSMP64
0c27db10d6
Review mon sprites 0001-0080
2023-08-15 20:24:07 +12:00
kittenchilly
dba28cf93f
Allow Z-Moves to be selected after Mega Evolution ( #3233 )
...
* Allow Z-Moves to be selected after Mega Evolution
* You cannot do Wish Mega Evolution at all if you hold a z crystal
* Rebase to master
2023-08-14 19:10:15 -04:00
LOuroboros
2d45b9b8fe
Corrected conditionals used for B_SPEED_BUFFING_RAPID_SPIN and I_GEM_BOOST_POWER ( #3232 )
2023-08-14 16:14:12 -04:00
LOuroboros
c414a0103c
Made Cmd_jumpifnopursuitswitchdmg and Cmd_pursuitdoubles use Pursuit's effect ID instead of its move ID ( #3231 )
...
* Made jumpifnopursuitswitchdmg use Pursuit's effect ID instead of its move ID
* Made Cmd_pursuitdoubles use Pursuit's effect ID too, even though it's unused
2023-08-14 08:45:37 -04:00
PCG
b8a22eb119
Remove soundMove from Steam Eruption and replace it with sheerForceBoost ( #3229 )
...
Co-authored-by: PCG06 <prajithgomes06@gmail.com>
2023-08-13 00:53:22 -04:00
GriffinR
4c2b12541b
Merge pull request #1908 from GriffinRichards/name-buffer
...
Automatically update nickname buffer sizes
2023-08-12 23:36:19 -04:00
GriffinR
344fe4dd65
Stop double-counting EOS in assert
2023-08-12 23:13:11 -04:00
kittenchilly
5e8caa8d45
Merge branch 'upcoming' into ultraburst
2023-08-12 12:36:11 -05:00
kittenchilly
2b27b0bf00
Constants
2023-08-12 12:30:36 -05:00
Eduardo Quezada
952bacd858
Merge branch 'RHH/master' into RHH/upcoming
...
# Conflicts:
# .github/ISSUE_TEMPLATE/01_battle_engine_bugs.yaml
# .github/ISSUE_TEMPLATE/02_battle_ai_issues.yaml
# .github/ISSUE_TEMPLATE/04_other_errors.yaml
2023-08-11 17:50:28 -04:00
Eduardo Quezada D'Ottone
ada29313de
Fix for wild double battles with an in-game partner ( #3210 )
...
Co-authored-by: DizzyEggg <jajkodizzy@wp.pl>
2023-08-11 17:29:10 -04:00
Philipp AUER
59da940283
Refactor damage formula to match Gen5+ ( #3196 )
...
* [battle, damage] refactor damage formula to match gen5+
* [test] use exact values for dry skin, swarm tests
* fixup: assume stats for dry-skin, swarm tests
---------
Co-authored-by: sbird <sbird@no.tld>
2023-08-11 16:28:38 -04:00
GriffinR
b248791f47
Merge pull request #1904 from GriffinRichards/temp-alias
...
Add temp flag and var aliases
2023-08-11 15:45:00 -04:00
kittenchilly
c3a8edae32
Sprites and fixes
2023-08-11 13:36:01 -05:00
Eduardo Quezada
f026b51b48
Merge branch 'RHH/upcoming' into RHH/pr/upcoming/cleanup/customTrainer
...
# Conflicts:
# src/battle_main.c
# src/battle_tower.c
# src/match_call.c
2023-08-11 11:41:44 -04:00
GriffinR
60a6c9d160
Merge pull request #1903 from GriffinRichards/frontier-gfx
...
Fix some frontier gfx, adjacent cleanup
2023-08-10 14:49:44 -04:00
Alex
bcb6f723d9
Use AI_DATA->holdEffects instead AI_GetHoldEffect
2023-08-10 16:24:29 +02:00
Alex
275e5ef5e6
Make more use of AI_GetHoldEffect + Fake Out changes
...
fix ShouldTryToFlinch
fix some mess up
fix of fix of mess up
2023-08-10 15:33:12 +02:00
GriffinR
d5d46bb438
More DISPLAY_WIDTH/HEIGHT constant usage
2023-08-10 01:42:38 -04:00
GriffinR
18319e8da3
Misc missing constant use
2023-08-10 01:42:18 -04:00
GriffinR
079f2da0f6
Fix some missing constant use in Apprentice
2023-08-10 00:38:23 -04:00
kittenchilly
c3e31af5f3
Ultra burst trigger
2023-08-09 22:12:26 -05:00
GriffinR
d1c2a30149
Merge pull request #1907 from GriffinRichards/fix-tv
...
Fix Bravo Trainer Tower member names
2023-08-09 15:25:45 -04:00
GriffinR
6eaaa50ad5
Correct berry fix graphics colors, more PLTT constant use ( #1892 )
2023-08-09 12:49:21 -04:00
Martin Griffin
912a80e27a
Reference TMs and HMs by move instead of number ( #1732 )
2023-08-09 10:51:01 -04:00
DizzyEggg
5f7819f697
no exp for ai mons
2023-08-09 16:03:02 +02:00
DizzyEggg
fec8f14fff
IsAiAiBattle function
2023-08-09 15:57:22 +02:00
DizzyEggg
d0fe75b06a
fixes
2023-08-09 09:57:42 +02:00
DizzyEggg
a0c34813f1
small fixes
2023-08-09 09:34:41 +02:00
DizzyEggg
8d5ba6c6d1
allow ai vs ai battles
2023-08-09 09:15:42 +02:00
GriffinR
6598cb30bc
Document stat change animation
2023-08-08 23:56:16 -04:00
GriffinR
65fee186f8
Automatically update nickname buffer sizes
2023-08-08 16:28:09 -04:00
GriffinR
087a2cecef
Fix Bravo Trainer Tower member names
2023-08-08 14:38:00 -04:00