DizzyEggg
bfe95bc4b9
Merge branch 'master' into battle_engine_v2
2019-03-01 13:29:50 +01:00
Phlosioneer
a7e5852f1d
More minor fixes
2019-03-01 01:49:11 -05:00
Phlosioneer
459fd93b59
Fix minor errors
2019-03-01 01:18:58 -05:00
Phlosioneer
da0687987d
Pick better names for constants
2019-02-28 22:21:16 -06:00
Phlosioneer
189d387f01
Add macros for metatile manipulation
2019-02-28 22:21:16 -06:00
hondew
53d7e21332
fix formatting in slot_machine.c
2019-02-28 21:21:56 -06:00
hondew
1dc0d346d9
fix spelling error
2019-02-28 21:21:56 -06:00
hondew
dd8ecabe26
fix mistakes and bad formatting
2019-02-28 21:21:56 -06:00
hondew
f965f1b13d
label luckyFlags
2019-02-28 21:21:56 -06:00
hondew
a6eb879267
minor reeltime changes
2019-02-28 21:21:56 -06:00
hondew
47a3477ab1
finish DecideReelTurns
2019-02-28 21:21:56 -06:00
hondew
f8f046c850
clean up slot machine more
2019-02-28 21:21:56 -06:00
hondew
67fe781ed2
clean up slot machine until AwardPayout
2019-02-28 21:21:56 -06:00
hondew
5c8cc5225f
document slot machine
2019-02-28 21:21:56 -06:00
LOuroboros
9564de6edb
Implemented the sprites for the Gen. 4 and 5 items.
2019-03-01 00:06:31 -03:00
DizzyEggg
baf95a8e7a
get rid of ugly cast
2019-02-28 17:26:09 -06:00
DizzyEggg
cebada80d0
Merge with master
2019-02-28 20:56:52 +01:00
Phlosioneer
99bfd8c80f
VAR_0x3F20 is not a var
2019-02-28 00:10:44 -05:00
Phlosioneer
bf45b83c65
Finish documenting event vars
2019-02-27 23:54:51 -05:00
Phlosioneer
782979f1fc
Finish documenting trainer hill
...
Trainer hill isn't anywhere close to done, but I figured out enough
to name the VAR. That's all this PR should do.
2019-02-27 22:16:01 -05:00
Phlosioneer
66f0616a2d
I guess I'm documenting Trainer Hill now
2019-02-27 21:31:05 -05:00
Phlosioneer
e77e7844ea
Name several vars, document some related events
2019-02-27 20:25:09 -05:00
Phlosioneer
648fc3d4f3
Name more unknown vars
2019-02-27 15:18:56 -05:00
Phlosioneer
4137dd7b0b
Identify unused, never read, and never written vars
2019-02-27 14:42:32 -05:00
Marcus Huderle
4b9e93850c
Document easy chat screen types
2019-02-27 12:55:29 -06:00
Phlosioneer
c1348d22f3
Name most event scripts related to unusual weather
2019-02-27 04:27:54 -05:00
Phlosioneer
fe55580fe1
Reverse engineer unusual weather events
2019-02-27 03:42:04 -05:00
Phlosioneer
b2c92ee8c5
Missed some fill values
...
Must have forgotten to check FillWindowPixelRect.
2019-02-26 22:45:39 -05:00
Phlosioneer
72bb0daccb
Merge branch 'master' into main-menu-state-machine
2019-02-26 22:34:42 -05:00
Phlosioneer
6cb4c677cd
Fix backwards names
2019-02-26 22:30:40 -05:00
Phlosioneer
3a44b090d1
Merge branch 'master' into multiplayer-stuff
2019-02-26 22:07:29 -05:00
Phlosioneer
accea672f1
Incorporate feedback
2019-02-26 22:04:44 -05:00
Marcus Huderle
231355f84d
Decompile easy_chat data
2019-02-26 14:50:02 -06:00
Marcus Huderle
b60611c38e
Finish decompiling easy_chat.c code
2019-02-26 14:50:02 -06:00
DizzyEggg
7742e28dad
Easy chat nonmatchings fix
...
do {} while(0);
2019-02-26 09:15:20 -06:00
huderlem
153f134318
Merge pull request #583 from huderlem/easy_chat
...
Decompile more easy_chat.c
2019-02-25 14:12:18 -06:00
Marcus Huderle
7ea05431a5
Decompile more easy_chat.c
2019-02-25 14:11:31 -06:00
DizzyEggg
df9e6a6889
Free up two status3 flags
2019-02-25 16:17:23 +01:00
huderlem
d77ba3d413
Merge pull request #581 from arantonitis/pokemon_summary
...
Documented/polished pokemon_summary_screen.c
2019-02-25 08:09:14 -06:00
huderlem
b3a7a1278a
Merge pull request #577 from Phlosioneer/weather-15
...
Document the weather state functions
2019-02-25 08:03:22 -06:00
huderlem
84573f1774
Merge pull request #574 from Phlosioneer/event-vars
...
Event vars
2019-02-25 08:02:28 -06:00
Phlosioneer
a5cf2b8090
Use map script constants in map script functions
2019-02-25 08:01:22 -06:00
Phlosioneer
5f7a971313
Source file part of map script renaming
2019-02-25 08:01:22 -06:00
Phlosioneer
1cd5cb09cf
Merge branch 'master' into weather-15
2019-02-25 02:30:35 -05:00
Phlosioneer
e1b2460748
Adjust formatting, rename function
2019-02-25 02:28:41 -05:00
Phlosioneer
4e5fae0086
Merge branch 'master' into event-vars
2019-02-25 02:24:20 -05:00
DizzyEggg
da33c38183
Merge pull request #78 from thechurchofcage/beta
...
Gravity fix
2019-02-24 19:38:42 +01:00
Tustin2121
4a785e66ba
Changing descriptions to not be file names
2019-02-24 10:20:31 -06:00
tustin2121
8711bc5156
Document HEALTHBOX_GRX_* in battle_interface.c
...
Most of these are referenced via offsets, like the HP bar, which uses [0 pixels] + (number of pixels) to reference which chunk to draw. Each corresponds to a 16x16 pixel in the graphic named. Up to you guys if you want to rename the constants.
2019-02-24 10:20:31 -06:00
Marcus Huderle
bb508ade64
Decompile more of easy_chat.c
2019-02-24 10:09:57 -06:00
Papa Cancer
d704b9cd5b
Gravity fix
...
Brings down Pokémon in the middle of a two-turn flying move (only Bounce and Fly at the moment); says the appropriate message for all mons brought to the ground via Gravity
2019-02-24 13:28:24 +00:00
DizzyEggg
47dce452e9
Fix missing moves mentioning typechart
2019-02-24 10:04:21 +01:00
DizzyEggg
a16a5f43a0
Fix Pursuit dbl damage on switch
2019-02-24 09:55:21 +01:00
DizzyEggg
b0f46c68b9
Fix PSS icons not disappearing when learning mvoe
2019-02-24 09:43:07 +01:00
Ariel Antonitis
0c47744a63
Moved ALIGNED(4) from extern to unknown struct.
2019-02-23 22:22:38 -05:00
Ariel Antonitis
d24cd4f0a8
Fixed broken encoding.
2019-02-23 22:04:21 -05:00
Ariel Antonitis
42bb5dc53d
Removed unused filler by aligning adjacent variables
2019-02-23 21:55:24 -05:00
Ariel Antonitis
74a3c06270
Documented/polished pokemon_summary_screen.c
...
Mostly variables mislabeled as global and some formerly unknown stuff.
2019-02-23 21:12:35 -05:00
Diegoisawesome
7995cf5b61
Merge pull request #578 from DizzyEggg/pokenav
...
pokenav
2019-02-23 16:04:59 -06:00
DizzyEggg
842e379a7b
Merge branch 'master' into battle_engine_v2
2019-02-23 22:50:46 +01:00
Marcus Huderle
f34903bc45
Decompile more easy_chat.c
2019-02-23 13:05:34 -06:00
DizzyEggg
788caa4fe2
pokenav
2019-02-23 13:34:01 +01:00
Phlosioneer
b2866fae21
Document the weather state functions
...
All weather types are now documented (including WEATHER_15)
2019-02-22 22:20:42 -05:00
Marcus Huderle
d3f66a98ff
Decompile more easy_chat
2019-02-22 11:46:05 -06:00
Phlosioneer
cea5696f23
Finish moving pokeruby vars
2019-02-22 04:18:43 -05:00
Phlosioneer
e12a7790cf
Start porting pokeruby vars to pokeemerald
2019-02-22 04:01:38 -05:00
Phlosioneer
44e92ce259
Give window drawing functions better names
2019-02-22 01:40:11 -05:00
Phlosioneer
199863f21f
Replace more instances of fill values
2019-02-21 23:56:22 -05:00
Phlosioneer
c96f8751cd
Improve window palette macros
2019-02-21 23:27:12 -05:00
Phlosioneer
399d646e3f
Merge branch 'master' into main-menu-state-machine
2019-02-21 22:24:25 -05:00
Phlosioneer
eca329f9c5
Merge branch 'master' into multiplayer-stuff
2019-02-21 21:22:10 -05:00
Marcus Huderle
b105d20d1e
Decompile chunk of easy_chat.c
2019-02-21 17:46:14 -06:00
Marcus Huderle
1c6502338e
Decompile contest_link_80F57C4.c
2019-02-20 18:11:27 -06:00
Marcus Huderle
4223bb65f0
Decompile several contest_link_80F57C4.c functions
2019-02-19 16:36:42 -06:00
Marcus Huderle
05f9368154
Decompile start of flying.c
2019-02-19 16:36:42 -06:00
Diegoisawesome
1b0079445d
Merge pull request #559 from Phlosioneer/finish-newgame-docs
...
Finish and polish new_game.c
2019-02-18 13:28:50 -06:00
Diegoisawesome
924cbe9ee4
Merge pull request #560 from Phlosioneer/regi-documentation
...
Document the regi* code more
2019-02-18 13:23:19 -06:00
Phlosioneer
486cf449b8
Make flag names more consistent
2019-02-18 14:17:02 -05:00
Phlosioneer
bfe67842ab
Fix spelling (again)
2019-02-18 14:14:07 -05:00
Phlosioneer
fcb541189d
Rename some flags, and use map ID macros
2019-02-18 02:02:20 -05:00
Diegoisawesome
047d8288cc
Merge pull request #557 from Phlosioneer/navgear-decompile
...
Navgear decompile
2019-02-18 00:34:01 -06:00
Phlosioneer
93e9b9fe5d
Fix some names
2019-02-18 01:33:41 -05:00
Phlosioneer
0a7b97ee06
Merge branch 'master' into multiplayer-stuff
2019-02-18 01:19:16 -05:00
Phlosioneer
5695617d64
Merge branch 'master' into multiplayer-stuff
2019-02-18 01:12:47 -05:00
Phlosioneer
40d4f7f8db
Minor fixes
2019-02-18 01:10:59 -05:00
Phlosioneer
08579edbcd
Clean up mistakes and bad formatting
2019-02-18 01:03:44 -05:00
Phlosioneer
7ad225a72f
Address formatting issues and use constants
2019-02-18 00:16:27 -05:00
Phlosioneer
f528552583
Rename pokenav file
2019-02-17 23:14:14 -05:00
Phlosioneer
762640664f
Fix formatting
2019-02-17 23:14:14 -05:00
Phlosioneer
bfeb7fb32a
Tabs converted to spaces.
...
Oops.
2019-02-17 23:14:14 -05:00
Phlosioneer
fbcfb69fe6
Remove guess code, fix pointer formatting
2019-02-17 23:14:14 -05:00
Phlosioneer
197ad274b4
Reformat braces
2019-02-17 23:14:14 -05:00
Phlosioneer
be08a662a8
More data moved into C code
2019-02-17 23:14:14 -05:00
Phlosioneer
a4aaf279ac
Move more data into pokenav, name some strings
2019-02-17 23:14:14 -05:00
Phlosioneer
bf4c1a73c0
Start moving pokenav data into C files
...
The types and usage of many of the globals are now known.
2019-02-17 23:14:14 -05:00
Phlosioneer
758b8c7f0e
Decompiled three more functions.
2019-02-17 23:14:14 -05:00
Phlosioneer
6d929c61c5
Decompiled 4 more functions
2019-02-17 23:14:14 -05:00
Phlosioneer
cb800e4708
Decompiled 5 functions
...
Was unable to decompile sub_81C79BC.
2019-02-17 23:14:14 -05:00
Phlosioneer
d41c597f90
Decompiled sub_81C7990
2019-02-17 23:14:14 -05:00
Phlosioneer
f95eebf47a
With help, sub_81C795C has been tamed.
...
Thanks to Garak on the discord server.
2019-02-17 23:14:14 -05:00
Phlosioneer
a8d920cc45
Decompiled 2 functions, unable to decompile 1.
...
sub_81C795C could not be decompiled due to register naming issues.
However, its structure was correctly matched, so I have left the C
code and a comment explaining the issue.
2019-02-17 23:14:14 -05:00
Phlosioneer
34b16e9e78
Decompiled 5 functions for unknown structs
2019-02-17 23:14:14 -05:00
Phlosioneer
3bb4057bad
Decompiled sub_81C7764
2019-02-17 23:14:14 -05:00
Phlosioneer
7c405e08d0
Decompiled three more small functions
2019-02-17 23:14:14 -05:00
Phlosioneer
5beb2baa97
Decompiled sub_81C76C4
2019-02-17 23:14:14 -05:00
Phlosioneer
b038556851
Decompiled several setters and getters
2019-02-17 23:14:14 -05:00
Phlosioneer
13a6765c88
Decompiled several trivial functions
2019-02-17 23:14:14 -05:00
Phlosioneer
112fc47017
Decompiled sub_81C756C
...
Also discovered a constant that may be useful for future decompiling.
Comments were added in the asm that references the constant.
2019-02-17 23:14:14 -05:00
Phlosioneer
3d73f7c48c
Decompiled sub_81C742C
2019-02-17 23:14:14 -05:00
Phlosioneer
cf721879dd
Decompiled sub_81C7418
2019-02-17 23:14:14 -05:00
Phlosioneer
323df8ed40
Decompiled sub_81C7400
2019-02-17 23:14:14 -05:00
Phlosioneer
729e7116f2
Decompiled AnyMonHasRibbon
2019-02-17 23:14:14 -05:00
Phlosioneer
5441d80ebc
Decompiled sub_81C7360
2019-02-17 23:14:14 -05:00
Phlosioneer
aa61e105e0
Decompiled sub_81C7334
2019-02-17 23:14:14 -05:00
Phlosioneer
d52cbe6bcb
Decompiled sub_81C72BC
2019-02-17 23:14:14 -05:00
Phlosioneer
9bda2297e3
Decompiled sub_81C72A4
2019-02-17 23:14:14 -05:00
Phlosioneer
cd84c92cfa
Decompiled CB2_PokeNav
2019-02-17 23:14:14 -05:00
Phlosioneer
69b014f7aa
Decompiled sub_81C71E4
2019-02-17 23:14:14 -05:00
Phlosioneer
fb705e6047
Decompiled sub_81C7170.
2019-02-17 23:14:14 -05:00
Phlosioneer
6466d0bea8
Decompiled sub_81C7124
2019-02-17 23:14:14 -05:00
Phlosioneer
052cd4da10
Decompiled sub_81C70D8
2019-02-17 23:14:14 -05:00
Phlosioneer
698c2879e4
Decompiled sub_81C7078
2019-02-17 23:14:14 -05:00
Diegoisawesome
367c7b5f89
Merge pull request #558 from Phlosioneer/check-pokedex-asm
...
Add comments explaining the remaining asm in pokedex.c
2019-02-17 12:59:52 -06:00
garak
22657c7087
use BG_SCREEN_ADDR macro for tilemap addresses
2019-02-17 00:35:26 -05:00
garak
35575b57a0
use BG_CHAR_ADDR define
2019-02-16 23:51:06 -05:00
DizzyEggg
9bc55246bc
AI handle Belch
2019-02-16 18:23:56 +01:00
DizzyEggg
a001faeced
New AI command for using priority moves in death situatiions
2019-02-16 14:54:17 +01:00
DizzyEggg
c1f9032989
Defiant and Competitive
2019-02-16 12:54:11 +01:00
Phlosioneer
e90e3458cb
Document the regi* code more
...
Fixed some confusing naming, named some unknown symbols, and fixed the
names of some flags.
2019-02-15 18:24:55 -05:00
DizzyEggg
c0f47d67aa
Merge pull request #72 from PALPATlNE/battle_engine_work
...
Mud bomb and Shadow Sneak Animations
2019-02-15 22:50:07 +01:00
Phlosioneer
986d3d8b2f
Finish and polish new_game.c
...
Only one function is left undocumented. I tried to go into the assembly
to at least name it, but it clears fields in the save block that aren't
even documented yet.
2019-02-15 03:40:57 -05:00
Phlosioneer
0a3912c95d
Add comments explaining asm in pokedex.c
...
I added comments to each of the asm functions explaining why they won't
match with the C.
I also got one of the functions much closer to matching.
2019-02-15 01:28:28 -05:00
DizzyEggg
08892d19f2
Modify the stat changer, so it supports raise/lower by 12
2019-02-14 19:48:21 +01:00
DizzyEggg
94cd547e9a
Change move effect to u16
2019-02-14 13:17:27 +01:00
DizzyEggg
dc39f76a95
Spectral Thief effect
2019-02-14 12:15:53 +01:00
Phlosioneer
9e8a841bfa
Merge branch 'master' of github.com:pret/pokeemerald into main-menu-state-machine
2019-02-13 23:04:56 -05:00
Diegoisawesome
047c282763
Merge pull request #548 from Phlosioneer/intro-movie-state-machine
...
Document the intro movie state machine
2019-02-13 21:24:20 -06:00
Phlosioneer
e7d0268143
Fix spelling of Rayquaza
2019-02-13 21:41:28 -05:00
Diegoisawesome
aa5d5fa34a
Merge pull request #550 from Phlosioneer/name-palette-return-values
...
Name the possible return values of palette fading functions
2019-02-13 20:15:47 -06:00
Diegoisawesome
dfb896356c
Merge branch 'master' of github.com:pret/pokeemerald
2019-02-12 00:40:42 -06:00
Diegoisawesome
449fb25f23
Clear up misnamed time-based flags and functions
2019-02-12 00:40:34 -06:00
Phlosioneer
d979ac3bf3
Document main_menu state machine, name window constants
...
The new names for the constants (and newly named functions) give a much
better understanding of what the window system is trying to do.
2019-02-11 00:34:50 -05:00
PALPATlNE
6c717078c6
Fixed tab to 4 spaces in ground.c
2019-02-11 03:54:54 +01:00
Phlosioneer
327de0283d
Adjust constants returned by FlipVerticalAndClearForced
2019-02-10 21:16:12 -05:00
Phlosioneer
e75f45dbcf
Reverse engineered many of the multiplayer events
...
Some corrections to the way events are handled and identified.
2019-02-10 20:42:50 -05:00
DizzyEggg
4c535a1b03
Merge pull request #71 from thechurchofcage/partingshot
...
Parting Shot
2019-02-10 18:18:49 +01:00
DizzyEggg
b5d0253890
Merge with master
2019-02-10 18:17:33 +01:00
Phlosioneer
f2f1b1978b
Done documenting link code in overworld.c
2019-02-10 03:54:50 -05:00
Phlosioneer
3fd878483f
Start renaming symbols
...
I finally figured out what the code is trying to do. I have a foothold;
the rest should follow.
2019-02-10 00:50:46 -05:00
Phlosioneer
37bea25b01
Name the possible return values of palette fading functions
...
Also replace implicit conversion from gPalette.active into a status with
if statements, to make the return value clear.
I've also added comments when the check is redundant.
2019-02-09 21:50:12 -05:00