Commit Graph

2805 Commits

Author SHA1 Message Date
tustin2121
8711bc5156 Document HEALTHBOX_GRX_* in battle_interface.c
Most of these are referenced via offsets, like the HP bar, which uses [0 pixels] + (number of pixels) to reference which chunk to draw. Each corresponds to a 16x16 pixel in the graphic named. Up to you guys if you want to rename the constants.
2019-02-24 10:20:31 -06:00
Marcus Huderle
bb508ade64 Decompile more of easy_chat.c 2019-02-24 10:09:57 -06:00
Phlosioneer
a25f4c75bc Decompiled a weird function 2019-02-24 04:33:58 -05:00
Phlosioneer
62589d7003 Decompiled more, ported asmdiff to powershell 2019-02-24 03:33:33 -05:00
Phlosioneer
a7d2d986b2 Decompiled two small functions, updated structs 2019-02-23 23:38:32 -05:00
Phlosioneer
fb8dddf0f1 Decompiled sub_81C81D4 2019-02-23 23:17:26 -05:00
Ariel Antonitis
0c47744a63 Moved ALIGNED(4) from extern to unknown struct. 2019-02-23 22:22:38 -05:00
Ariel Antonitis
d24cd4f0a8 Fixed broken encoding. 2019-02-23 22:04:21 -05:00
Ariel Antonitis
42bb5dc53d Removed unused filler by aligning adjacent variables 2019-02-23 21:55:24 -05:00
Ariel Antonitis
74a3c06270 Documented/polished pokemon_summary_screen.c
Mostly variables mislabeled as global and some formerly unknown stuff.
2019-02-23 21:12:35 -05:00
Diegoisawesome
7995cf5b61
Merge pull request #578 from DizzyEggg/pokenav
pokenav
2019-02-23 16:04:59 -06:00
Marcus Huderle
f34903bc45 Decompile more easy_chat.c 2019-02-23 13:05:34 -06:00
ultima-soul
eb48cc2f7e Decompile through sub_8167930. 2019-02-23 09:08:07 -08:00
DizzyEggg
788caa4fe2 pokenav 2019-02-23 13:34:01 +01:00
Phlosioneer
b2866fae21 Document the weather state functions
All weather types are now documented (including WEATHER_15)
2019-02-22 22:20:42 -05:00
Marcus Huderle
d3f66a98ff Decompile more easy_chat 2019-02-22 11:46:05 -06:00
Phlosioneer
cea5696f23 Finish moving pokeruby vars 2019-02-22 04:18:43 -05:00
Phlosioneer
e12a7790cf Start porting pokeruby vars to pokeemerald 2019-02-22 04:01:38 -05:00
Phlosioneer
44e92ce259 Give window drawing functions better names 2019-02-22 01:40:11 -05:00
Phlosioneer
199863f21f Replace more instances of fill values 2019-02-21 23:56:22 -05:00
Phlosioneer
c96f8751cd Improve window palette macros 2019-02-21 23:27:12 -05:00
Phlosioneer
399d646e3f Merge branch 'master' into main-menu-state-machine 2019-02-21 22:24:25 -05:00
Phlosioneer
eca329f9c5 Merge branch 'master' into multiplayer-stuff 2019-02-21 21:22:10 -05:00
Marcus Huderle
b105d20d1e Decompile chunk of easy_chat.c 2019-02-21 17:46:14 -06:00
Marcus Huderle
1c6502338e Decompile contest_link_80F57C4.c 2019-02-20 18:11:27 -06:00
Marcus Huderle
4223bb65f0 Decompile several contest_link_80F57C4.c functions 2019-02-19 16:36:42 -06:00
Marcus Huderle
05f9368154 Decompile start of flying.c 2019-02-19 16:36:42 -06:00
Diegoisawesome
1b0079445d
Merge pull request #559 from Phlosioneer/finish-newgame-docs
Finish and polish new_game.c
2019-02-18 13:28:50 -06:00
Diegoisawesome
924cbe9ee4
Merge pull request #560 from Phlosioneer/regi-documentation
Document the regi* code more
2019-02-18 13:23:19 -06:00
Phlosioneer
486cf449b8 Make flag names more consistent 2019-02-18 14:17:02 -05:00
Phlosioneer
bfe67842ab Fix spelling (again) 2019-02-18 14:14:07 -05:00
Phlosioneer
fcb541189d Rename some flags, and use map ID macros 2019-02-18 02:02:20 -05:00
Diegoisawesome
047d8288cc
Merge pull request #557 from Phlosioneer/navgear-decompile
Navgear decompile
2019-02-18 00:34:01 -06:00
Phlosioneer
93e9b9fe5d Fix some names 2019-02-18 01:33:41 -05:00
Phlosioneer
0a7b97ee06
Merge branch 'master' into multiplayer-stuff 2019-02-18 01:19:16 -05:00
Phlosioneer
5695617d64 Merge branch 'master' into multiplayer-stuff 2019-02-18 01:12:47 -05:00
Phlosioneer
40d4f7f8db Minor fixes 2019-02-18 01:10:59 -05:00
Phlosioneer
08579edbcd Clean up mistakes and bad formatting 2019-02-18 01:03:44 -05:00
Phlosioneer
7ad225a72f Address formatting issues and use constants 2019-02-18 00:16:27 -05:00
Phlosioneer
f528552583 Rename pokenav file 2019-02-17 23:14:14 -05:00
Phlosioneer
762640664f Fix formatting 2019-02-17 23:14:14 -05:00
Phlosioneer
bfeb7fb32a Tabs converted to spaces.
Oops.
2019-02-17 23:14:14 -05:00
Phlosioneer
fbcfb69fe6 Remove guess code, fix pointer formatting 2019-02-17 23:14:14 -05:00
Phlosioneer
197ad274b4 Reformat braces 2019-02-17 23:14:14 -05:00
Phlosioneer
be08a662a8 More data moved into C code 2019-02-17 23:14:14 -05:00
Phlosioneer
a4aaf279ac Move more data into pokenav, name some strings 2019-02-17 23:14:14 -05:00
Phlosioneer
bf4c1a73c0 Start moving pokenav data into C files
The types and usage of many of the globals are now known.
2019-02-17 23:14:14 -05:00
Phlosioneer
758b8c7f0e Decompiled three more functions. 2019-02-17 23:14:14 -05:00
Phlosioneer
6d929c61c5 Decompiled 4 more functions 2019-02-17 23:14:14 -05:00
Phlosioneer
cb800e4708 Decompiled 5 functions
Was unable to decompile sub_81C79BC.
2019-02-17 23:14:14 -05:00
Phlosioneer
d41c597f90 Decompiled sub_81C7990 2019-02-17 23:14:14 -05:00
Phlosioneer
f95eebf47a With help, sub_81C795C has been tamed.
Thanks to Garak on the discord server.
2019-02-17 23:14:14 -05:00
Phlosioneer
a8d920cc45 Decompiled 2 functions, unable to decompile 1.
sub_81C795C could not be decompiled due to register naming issues.
However, its structure was correctly matched, so I have left the C
code and a comment explaining the issue.
2019-02-17 23:14:14 -05:00
Phlosioneer
34b16e9e78 Decompiled 5 functions for unknown structs 2019-02-17 23:14:14 -05:00
Phlosioneer
3bb4057bad Decompiled sub_81C7764 2019-02-17 23:14:14 -05:00
Phlosioneer
7c405e08d0 Decompiled three more small functions 2019-02-17 23:14:14 -05:00
Phlosioneer
5beb2baa97 Decompiled sub_81C76C4 2019-02-17 23:14:14 -05:00
Phlosioneer
b038556851 Decompiled several setters and getters 2019-02-17 23:14:14 -05:00
Phlosioneer
13a6765c88 Decompiled several trivial functions 2019-02-17 23:14:14 -05:00
Phlosioneer
112fc47017 Decompiled sub_81C756C
Also discovered a constant that may be useful for future decompiling.
Comments were added in the asm that references the constant.
2019-02-17 23:14:14 -05:00
Phlosioneer
3d73f7c48c Decompiled sub_81C742C 2019-02-17 23:14:14 -05:00
Phlosioneer
cf721879dd Decompiled sub_81C7418 2019-02-17 23:14:14 -05:00
Phlosioneer
323df8ed40 Decompiled sub_81C7400 2019-02-17 23:14:14 -05:00
Phlosioneer
729e7116f2 Decompiled AnyMonHasRibbon 2019-02-17 23:14:14 -05:00
Phlosioneer
5441d80ebc Decompiled sub_81C7360 2019-02-17 23:14:14 -05:00
Phlosioneer
aa61e105e0 Decompiled sub_81C7334 2019-02-17 23:14:14 -05:00
Phlosioneer
d52cbe6bcb Decompiled sub_81C72BC 2019-02-17 23:14:14 -05:00
Phlosioneer
9bda2297e3 Decompiled sub_81C72A4 2019-02-17 23:14:14 -05:00
Phlosioneer
cd84c92cfa Decompiled CB2_PokeNav 2019-02-17 23:14:14 -05:00
Phlosioneer
69b014f7aa Decompiled sub_81C71E4 2019-02-17 23:14:14 -05:00
Phlosioneer
fb705e6047 Decompiled sub_81C7170. 2019-02-17 23:14:14 -05:00
Phlosioneer
6466d0bea8 Decompiled sub_81C7124 2019-02-17 23:14:14 -05:00
Phlosioneer
052cd4da10 Decompiled sub_81C70D8 2019-02-17 23:14:14 -05:00
Phlosioneer
698c2879e4 Decompiled sub_81C7078 2019-02-17 23:14:14 -05:00
Diegoisawesome
367c7b5f89
Merge pull request #558 from Phlosioneer/check-pokedex-asm
Add comments explaining the remaining asm in pokedex.c
2019-02-17 12:59:52 -06:00
garak
22657c7087 use BG_SCREEN_ADDR macro for tilemap addresses 2019-02-17 00:35:26 -05:00
garak
35575b57a0 use BG_CHAR_ADDR define 2019-02-16 23:51:06 -05:00
Phlosioneer
e90e3458cb Document the regi* code more
Fixed some confusing naming, named some unknown symbols, and fixed the
names of some flags.
2019-02-15 18:24:55 -05:00
Phlosioneer
986d3d8b2f Finish and polish new_game.c
Only one function is left undocumented. I tried to go into the assembly
to at least name it, but it clears fields in the save block that aren't
even documented yet.
2019-02-15 03:40:57 -05:00
Phlosioneer
0a3912c95d Add comments explaining asm in pokedex.c
I added comments to each of the asm functions explaining why they won't
match with the C.
I also got one of the functions much closer to matching.
2019-02-15 01:28:28 -05:00
Phlosioneer
9e8a841bfa Merge branch 'master' of github.com:pret/pokeemerald into main-menu-state-machine 2019-02-13 23:04:56 -05:00
Diegoisawesome
047c282763
Merge pull request #548 from Phlosioneer/intro-movie-state-machine
Document the intro movie state machine
2019-02-13 21:24:20 -06:00
Phlosioneer
e7d0268143 Fix spelling of Rayquaza 2019-02-13 21:41:28 -05:00
Diegoisawesome
aa5d5fa34a
Merge pull request #550 from Phlosioneer/name-palette-return-values
Name the possible return values of palette fading functions
2019-02-13 20:15:47 -06:00
Diegoisawesome
dfb896356c Merge branch 'master' of github.com:pret/pokeemerald 2019-02-12 00:40:42 -06:00
Diegoisawesome
449fb25f23 Clear up misnamed time-based flags and functions 2019-02-12 00:40:34 -06:00
Phlosioneer
d979ac3bf3 Document main_menu state machine, name window constants
The new names for the constants (and newly named functions) give a much
better understanding of what the window system is trying to do.
2019-02-11 00:34:50 -05:00
Phlosioneer
327de0283d Adjust constants returned by FlipVerticalAndClearForced 2019-02-10 21:16:12 -05:00
Phlosioneer
e75f45dbcf Reverse engineered many of the multiplayer events
Some corrections to the way events are handled and identified.
2019-02-10 20:42:50 -05:00
Phlosioneer
f2f1b1978b Done documenting link code in overworld.c 2019-02-10 03:54:50 -05:00
Phlosioneer
3fd878483f Start renaming symbols
I finally figured out what the code is trying to do. I have a foothold;
the rest should follow.
2019-02-10 00:50:46 -05:00
Phlosioneer
37bea25b01 Name the possible return values of palette fading functions
Also replace implicit conversion from gPalette.active into a status with
if statements, to make the return value clear.

I've also added comments when the check is redundant.
2019-02-09 21:50:12 -05:00
Phlosioneer
45297797e6 Document the intro movie state machine
Need to study the water droplet animation more closely before they can
be renamed; otherwise, this names every major symbol in this file.
2019-02-09 21:07:07 -05:00
Marcus Huderle
6f1d2b870c Give proper names to dynamic map layouts 2019-02-09 09:57:30 -06:00
Marcus Huderle
40dc6833c5 Fully document tileset animations 2019-02-08 15:07:42 -06:00
Marcus Huderle
abebd2b864 Cleanup externs in overworld.c 2019-02-08 11:48:51 -06:00
Marcus Huderle
6add3e1794 Document some battle dome stuff 2019-02-08 11:08:25 -06:00
Marcus Huderle
4570e3b6a5 Document battle arena 2019-02-08 09:41:36 -06:00
Marcus Huderle
3a40f5203b Remove old rom_818CFC8.h header 2019-02-07 17:41:44 -06:00
Marcus Huderle
85040e26fd Document battle pike 2019-02-07 17:37:41 -06:00
Marcus Huderle
4785a07acd Document battle factory functions 2019-02-07 12:58:09 -06:00
Marcus Huderle
b52871433a Fix typo 2019-02-07 11:54:51 -06:00
Marcus Huderle
3a88ab831d Document more battle pyramid 2019-02-07 11:51:03 -06:00
Marcus Huderle
a1ad1bad3a Document a bunch of battle pyramid 2019-02-06 21:14:28 -06:00
Marcus Huderle
1253cbf5f6 Document some battle anim things 2019-02-06 21:14:28 -06:00
huderlem
b0ee100975
Merge pull request #543 from pret/mapdata
Convert map data to JSON
2019-02-04 21:36:18 -06:00
Diegoisawesome
646533cfa3
Merge pull request #542 from Slawter666/pss
Label some summary screen functions
2019-02-04 09:46:39 -06:00
Slawter666
fa352cfda3 Some more labelling 2019-02-04 14:35:49 +00:00
Slawter666
3d79aeb9da More documentation 2019-02-04 12:44:09 +00:00
Slawter666
804e955c8d Label some more functions 2019-02-04 11:38:44 +00:00
Slawter666
031fd66393 Label some summary screen functions 2019-02-02 22:14:04 +00:00
Diegoisawesome
ff48e5ada0
Merge pull request #541 from Diegoisawesome/master
Misc documentation
2019-02-02 16:00:56 -06:00
Diegoisawesome
d64a905d65 Document trainer backsprites 2019-02-02 15:56:22 -06:00
Diegoisawesome
59807c0f2c
Merge pull request #536 from DizzyEggg/menu
Use Menu and List Menu input defines
2019-02-02 12:45:35 -06:00
DizzyEggg
ea79f1c8f6 tabs 2019-02-02 19:41:34 +01:00
Diegoisawesome
e8952c2374
Merge pull request #539 from DizzyEggg/ram_vars
Move ram vars in sym files to C
2019-02-02 11:17:50 -06:00
Diegoisawesome
47c105bef6
Merge pull request #538 from DizzyEggg/data
Dump last battle anim file
2019-02-02 11:12:29 -06:00
DizzyEggg
363fa9bed2 Clean up ram vars 2019-02-02 12:44:00 +01:00
DizzyEggg
a7f94bbeea Dump last battle anim file 2019-02-02 11:55:11 +01:00
DizzyEggg
a740bc7190 Name action 11 2019-02-02 11:32:00 +01:00
DizzyEggg
23b240ab65 Fix Menu and List Menu input defines 2019-02-02 11:04:38 +01:00
Diegoisawesome
46a3969f69 Add constants for flags and vars 2019-02-02 00:25:43 -06:00
Diegoisawesome
9d8a43a1fb
Merge pull request #534 from DizzyEggg/patch-1
Get rid of an unnecessary extern
2019-02-01 14:51:04 -06:00
DizzyEggg
b3d48c0ed6
Get rid of an unnecessary extern 2019-02-01 19:45:06 +01:00
DizzyEggg
d02a788d2e Match GetItemEffectType 2019-02-01 19:25:10 +01:00
Diegoisawesome
b26c24ffee
Merge pull request #532 from DizzyEggg/bored
Fix some fakematches
2019-02-01 10:04:42 -06:00
DizzyEggg
c0db311637 some more fakematch fix 2019-02-01 12:26:40 +01:00
DizzyEggg
e3bec4b480 fix nonmatch in mauville old man 2019-02-01 11:56:02 +01:00
DizzyEggg
7c8fb66acf Fix field player avatar fakmatch 2019-02-01 11:50:45 +01:00
DizzyEggg
5dfaf22fb3 Fix pokemon icon asm 2019-02-01 11:39:24 +01:00
DizzyEggg
b4055e4fc0 Merge m4a files into one, get rid of one asm 2019-02-01 10:37:13 +01:00
DizzyEggg
7750a8126d CgbSound is decompiled. 2019-02-01 00:25:31 +01:00
Marcus Huderle
29d6221935 Convert map data to JSON 2019-01-31 15:51:20 -06:00
Diegoisawesome
3f1a7330dd Document siirtc a bit more 2019-01-30 19:48:28 -06:00
DizzyEggg
d46e60765d Rename a palace battle field 2019-01-29 22:22:02 +01:00
Marcus Huderle
8f832434e5 Change drought colors table files to .bin 2019-01-29 14:36:02 -06:00
Marcus Huderle
36a1825bbe Document trainer approach funcs, and use movement type constants in scripts 2019-01-29 14:36:02 -06:00
Marcus Huderle
e81838dba3 Misc. documentation and move some data into .c files 2019-01-29 14:36:02 -06:00
DizzyEggg
73d919fa0f Define double single left right qutoation marks char 2019-01-28 19:02:34 +01:00
DizzyEggg
922726ff3d contest 2019-01-28 18:19:58 +01:00
DizzyEggg
ad59811154 Decompile whole contest 2019-01-28 18:13:07 +01:00
DizzyEggg
26a2a4f9e7 Match all of contest functions 2019-01-28 12:29:47 +01:00
Diegoisawesome
183b6857ff
Merge pull request #458 from ultima-soul/contest
Decompile more of contest
2019-01-27 23:08:24 -06:00
ultima-soul
72720204da Fix stuff 2019-01-27 20:54:21 -08:00
ultima-soul
d633ee6f58 Minor changes 2019-01-27 20:48:18 -08:00
ultima-soul
f828823bf0 Make changes 2019-01-27 20:21:30 -08:00
DizzyEggg
54ddbaaf0c Frontier pass clean-up 2019-01-26 22:09:24 +01:00
DizzyEggg
251d16b733 Make Frontier pass compile 2019-01-26 21:06:20 +01:00
DizzyEggg
01c3f3fc05 Document all of frontier pass 2019-01-26 20:56:06 +01:00
DizzyEggg
03549349f8 Decompile all frontier pass 2019-01-26 19:20:14 +01:00
DizzyEggg
0688725afb Document and decompile more of frontier pass. 2019-01-26 14:50:24 +01:00
DizzyEggg
08a3533682 Start frontier pass 2019-01-25 23:32:45 +01:00
DizzyEggg
ebfaf3f6be Merge branch 'master' into dump 2019-01-24 21:30:19 +01:00
DizzyEggg
b6e5b4ee1a trainer card diego pls 2019-01-22 21:56:57 +01:00
garak
261955b6ed trainer hill easy chat constants 2019-01-21 12:01:49 -05:00
DizzyEggg
75a1c022dd Make trainer card compile 2019-01-20 18:48:29 +01:00
DizzyEggg
4e396207d3 document more of trainer card 2019-01-20 18:24:35 +01:00
DizzyEggg
576d1b3474 Document and match somne trainer card 2019-01-19 23:04:33 +01:00
shinny456
f06c0749bc trainer_card up to sub_80C4998 2019-01-19 12:14:59 -05:00
shinny456
1b30da21d9 merge trainer hill changes 2019-01-19 10:44:58 -05:00
DizzyEggg
f84b22fca4 Dump trainer hill trainers 2019-01-19 12:57:18 +01:00
DizzyEggg
87763d133f bites to bits 2019-01-14 20:57:44 +01:00
DizzyEggg
353ad13f91 make trainer hill compile 2019-01-13 20:58:42 +01:00
DizzyEggg
4b420643dc Merge branch 'master' into trainer_hill 2019-01-13 20:51:05 +01:00
DizzyEggg
edddd847c5 Document and clean up trainer hill 2019-01-13 20:50:08 +01:00
DizzyEggg
c0bc01d301 Move some vars to C 2019-01-13 13:15:23 +01:00
DizzyEggg
11a49a7f02 Decompile trainer hill 2019-01-13 12:12:27 +01:00
shinny456
8a5fce7837 start decompiling trainer_card.s 2019-01-08 21:51:19 -05:00
Diegoisawesome
af2c39860d Rename non-mapsec constants 2019-01-08 13:40:11 -06:00
ultima-soul
b8ff71e65e Fix build conflicts. 2019-01-06 14:11:31 -08:00
ultima-soul
284751e761 Decompile through ClearContestWinnerPicsInContestHall, 10 NONMATCHINGs present. 2019-01-06 13:41:18 -08:00
ultima-soul
2ca482dc24 Committing progress so far. 2019-01-06 13:38:31 -08:00
ultima-soul
f966b65849 Through sub_80DC028, sub_80DC0F4 non-matching. 2019-01-06 13:32:48 -08:00
ultima-soul
76510d58bb Matched up to sub_80DBF68, sub_80DBF90 WIP. 2019-01-06 13:32:47 -08:00
Slawter666
aeaf390706 Update constants 2019-01-05 20:12:50 +00:00
Slawter666
f8c2fcb9b2 Merge branch 'master' of https://github.com/pret/pokeemerald into secret-base 2019-01-05 19:54:26 +00:00
DizzyEggg
50a26bffe4 tabs to spaces 2019-01-05 19:27:23 +01:00
DizzyEggg
b756996581 fakematch and nonmatch 2019-01-05 19:25:46 +01:00
Marcus Huderle
95db853a78 Decompile more of contest_link_80F57C4.c 2019-01-04 20:03:29 -06:00
Philipp AUER
55202eac24 rename coords to size in struct MonCoords 2019-01-04 19:59:55 -06:00
huderlem
cba2f81bf8
Merge pull request #507 from Tetrable/master
Finish off labeling flags
2019-01-03 20:37:25 -06:00
Marcus Huderle
fd201f8395 Start decompiling contest_link_80F57C4.c 2019-01-03 20:35:20 -06:00
Marcus Huderle
2857f7fff9 Decompile contest_link_81D9DE4.c 2019-01-03 20:35:20 -06:00
Marcus Huderle
bc43dbab13 Decompile contest_link_81D9DE4.c 2019-01-03 20:35:20 -06:00
Tetrable
30e7ac0dca Fix merge conflicts 2019-01-03 02:28:18 +00:00
Tetrable
50aa222aff Corrected typos 2019-01-03 01:54:55 +00:00
Marcus Huderle
b471bba55e Use better names for match call texts 2019-01-02 19:46:15 -06:00
Marcus Huderle
e1092028ec Decompile match_call.c 2019-01-02 19:46:15 -06:00
Diegoisawesome
f8c708a82a
Merge pull request #506 from Slawter666/menu
Minor labelling of menu.c
2019-01-02 17:29:27 -06:00
Diegoisawesome
0053e61535
Merge pull request #504 from Diegoisawesome/roulette
Port/decompile roulette
2019-01-02 17:00:33 -06:00
Diegoisawesome
a0188aac33 Cleanup and EWRAM 2019-01-02 16:55:50 -06:00
Diegoisawesome
6202ae1df0 Extract rodata from roulette 2019-01-02 16:40:40 -06:00
Tetrable
a3ebca4d81 Fix merge conflicts 2019-01-02 21:25:14 +00:00
Tetrable
1e3da62d24 Finish off labelling flags 2019-01-02 21:12:43 +00:00
Slawter666
99c37023c8 Minor labelling of menu.c 2019-01-02 01:11:02 +00:00
Slawter666
ee5a239534 Use constants in secret_base.c 2019-01-01 23:19:07 +00:00
Diegoisawesome
e7f8190ba3 Finish roulette port 2019-01-01 15:25:52 -06:00
Diegoisawesome
d28d8c850d Up to sub_81446DC 2018-12-31 19:39:41 -06:00
Diegoisawesome
af1e44befe Continue porting roulette 2018-12-31 18:07:29 -06:00
Marcus Huderle
a0ff38d0be Fix build 2018-12-31 16:53:38 -06:00
Marcus Huderle
05b1d2ea94 Document field_tasks.c 2018-12-31 16:53:38 -06:00
Marcus Huderle
b6ee970e7a Minor berry.c cleanup 2018-12-31 16:53:38 -06:00
Marcus Huderle
fb2d1591c1 Document more battle anim effects 2018-12-31 16:53:38 -06:00
Diegoisawesome
439fa13e94 Start porting/decompiling roulette 2018-12-31 16:09:45 -06:00
Diegoisawesome
17ac8e29ef
Merge pull request #497 from garakmon/rm_sec
index gRegionMapEntries by map section constants
2018-12-31 11:51:12 -06:00
Diegoisawesome
d004ce065c Merge branch 'master' of github.com:pret/pokeemerald into trade 2018-12-31 02:30:30 -06:00
Diegoisawesome
ec780bb209 Cleanup and documentation 2018-12-31 02:22:21 -06:00
Diegoisawesome
c5c6e437ec Document, cleanup, extract data from trade 2018-12-31 01:23:27 -06:00
Marcus Huderle
58f130d007 Document some battle anims and helpers 2018-12-30 11:04:17 -06:00
garak
ed25326140 fix formatting 2018-12-29 21:52:38 -05:00
garak
1baa17c632 index gRegionMapEntries by map section constants 2018-12-29 21:49:29 -05:00
Diegoisawesome
c22a12d8d6 trade source done 2018-12-29 13:50:24 -06:00
Diegoisawesome
2fb9f490fb Almost done with trade 2018-12-29 12:46:15 -06:00
DizzyEggg
b2a042f65c
Match and clean up battle anim 3 2018-12-29 19:31:04 +01:00
DizzyEggg
0d5a0b58fa Fakematch a function 2018-12-29 11:51:00 -06:00
DizzyEggg
75b4e9ac70 compile contest 2018-12-29 11:48:28 -06:00
DizzyEggg
55e44b0951 a bit more of contest painting effect 2018-12-29 11:48:28 -06:00
DizzyEggg
34243bbe1d Start contest painting effect 2018-12-29 11:48:28 -06:00
PALPATlNE
061b879561 Documentation for pokemon_summary_screens.c 2018-12-29 11:45:06 -06:00
Marcus Huderle
229177f7c6 Use anim weather constants 2018-12-29 11:40:12 -06:00
Marcus Huderle
8eea0925c5 Finish battle_anim_effects_3.c 2018-12-29 11:40:12 -06:00
Marcus Huderle
d0d870e193 Cleanup formatting 2018-12-29 11:36:54 -06:00
Marcus Huderle
6e7bdb3ca4 Document misc field_specials things 2018-12-29 11:36:54 -06:00
Marcus Huderle
67636b7c64 Document deoxys rock 2018-12-29 11:36:54 -06:00
Marcus Huderle
46d41d2fb9 Use EVENT_OBJ_ID_PLAYER in C code 2018-12-29 11:36:54 -06:00
Marcus Huderle
95dcff581b Document some fieldmap stuff 2018-12-29 11:36:54 -06:00
Diegoisawesome
146ad2bdd4 Next big honkin' function done 2018-12-28 13:42:34 -06:00
Diegoisawesome
9cad5e8197 Big switch mofo 2018-12-28 02:11:41 -06:00
Marcus Huderle
d59f5a8e56 Misc overworld documentation 2018-12-27 16:52:13 -06:00
Marcus Huderle
2c0f5f58e9 Use constants for warp into MAP_INSIDE_OF_TRUCK 2018-12-27 11:24:34 -06:00
Diegoisawesome
5691a67629 Up to sub_807B62C 2018-12-27 02:05:09 -06:00
DizzyEggg
b9ad5de8a0 fortmatting 2018-12-26 14:50:47 +01:00
DizzyEggg
6761a049da Fix Bldalpha args 2018-12-26 14:03:48 +01:00
DizzyEggg
7e4db39da5 Fix bldcnt gpu reg args 2018-12-26 13:43:07 +01:00
DizzyEggg
7f6f6c33ab Fix BgAttributes 2018-12-26 13:05:02 +01:00
Diegoisawesome
720007e457
Merge pull request #3 from DizzyEggg/patch-1
Match nonmatching except the loop one
2018-12-25 15:04:12 -06:00
Diegoisawesome
d8948a5cda Merge remote-tracking branch 'pret/master' into trade 2018-12-25 15:03:13 -06:00
melthelesbian
2dd706ca54 use max mon moves constant where able (#480)
* use max mon moves constant where able

* fix errors in script commands file

* fix more errors
2018-12-25 11:50:15 -06:00
Marcus Huderle
dcbc8db6a3 Document mirage_tower.c. (Combine fldeff_groundshake.c and fossil_specials.c) 2018-12-25 11:46:35 -06:00
DizzyEggg
1b28844b12
Match nonmatching except the loop one 2018-12-25 15:14:15 +01:00
Diegoisawesome
dea41e1a7e trade.c up to sub_807A7E0 2018-12-24 20:18:06 -06:00
DizzyEggg
8833004d41 space 2018-12-24 23:29:47 +01:00
DizzyEggg
44e5e82f67 clean up party menu 2018-12-24 23:27:20 +01:00
DizzyEggg
43c88440e0 make it compile for reals 2018-12-24 22:28:33 +01:00
DizzyEggg
49517aca9e make it compie hopefully 2018-12-24 22:19:40 +01:00
DizzyEggg
e230afd543 Merge branch 'master' into learn 2018-12-24 22:01:52 +01:00
DizzyEggg
442b1826a2 asm party and fldeff clean-up 2018-12-24 21:59:05 +01:00
Diegoisawesome
2bca45bcf5 More link stuff, stumped on sub_807A728 2018-12-24 14:39:05 -06:00
Melody
370b1093cd fix feebas check 2018-12-24 13:48:31 -06:00
Marcus Huderle
c2fdbb0ef7 Decompile psychic.c 2018-12-24 10:52:56 -06:00
Marcus Huderle
f1213ebb4b Decompile dark.c 2018-12-24 09:55:00 -06:00
Diegoisawesome
3f08e0c76c Some more trade nonsense 2018-12-24 03:03:02 -06:00
Diegoisawesome
980b055bf0
Merge pull request #471 from DizzyEggg/clean
Get rid of externs and add includes
2018-12-24 01:33:57 -06:00
DizzyEggg
72aa9eb5a9 clear headers more 2018-12-24 00:20:38 +01:00
DizzyEggg
9320fe8f85 Clear includes 2018-12-24 00:02:29 +01:00
Rangi
78bab9ca0c Fix OLD_UNOWN_BASE_STATS formatting: tabs->spaces, and comma outside the macro 2018-12-23 17:24:10 -05:00
Diegoisawesome
e874267edb
Merge pull request #469 from DizzyEggg/data
Move some data to C
2018-12-23 10:45:19 -06:00
Diegoisawesome
f1ee374e93
Merge pull request #468 from KDSKardabox/resolve_ice_electric_split
Move 2 incorrectly split functions of electric from ice
2018-12-23 10:42:01 -06:00
DizzyEggg
efa820469a move data to c 2018-12-23 14:52:47 +01:00
DizzyEggg
6d57a9dfc8 start data converting 2018-12-23 13:52:53 +01:00
KDSKardabox
436122ec93 Add new line at EOL 2018-12-23 13:07:00 +05:30
Diegoisawesome
a5c09bfec6 S'more trade 2018-12-23 01:26:38 -06:00
KDSKardabox
b394ad7781 Add space 2018-12-23 11:55:01 +05:30
DizzyEggg
adb4927504 Merge with master 2018-12-22 23:30:41 +01:00
Diegoisawesome
ebbe826133
Merge pull request #437 from DizzyEggg/storage
Pokemon Storage System
2018-12-22 16:12:27 -06:00
DizzyEggg
c805bab483 Storage - review changes 2018-12-22 23:00:22 +01:00
KDSKardabox
67beec5cbe Move 2 functions of electric from ice 2018-12-23 00:34:00 +05:30
DizzyEggg
6dffa6d17c Match and clean up fldeff misc 2018-12-22 19:33:45 +01:00
DizzyEggg
8fcb3f71c7 Match electric c 2018-12-22 18:52:05 +01:00
DizzyEggg
72532c9eee Match and clean up party_menu.c 2018-12-22 17:32:21 +01:00
Diegoisawesome
a39783a637 More trade.c 2018-12-22 01:26:53 -06:00
DizzyEggg
1374c11a1c Review pokemon storage system chaanges 2018-12-21 22:35:01 +01:00
Diegoisawesome
052d458f48 sub_80796B4 is a pain 2018-12-21 12:20:28 -06:00
Diegoisawesome
87fd6b8dc2
Merge pull request #463 from ShinyDragonHunter/old_unown_macro
Use a macro for OLD_UNOWN base stats
2018-12-21 12:15:34 -06:00
ShinyDragonHunter
c120a446ad Moved macro to the top of base_stats.h 2018-12-21 10:37:35 +00:00
golem galvanize
314b718471 finish porting ice 2018-12-21 01:37:59 -05:00
DizzyEggg
ecee02816d Merge with master 2018-12-20 22:53:08 +01:00
golem galvanize
64832ff67e start ice 2018-12-20 16:20:34 -05:00
DizzyEggg
7dcb614cca PSS is done 2018-12-20 22:14:36 +01:00
ShinyDragonHunter
c489bb88b7 Updated macro name to be less vague 2018-12-20 13:59:00 +00:00
ShinyDragonHunter
51e5be68de Use a macro for OLD_UNOWN base stats 2018-12-20 11:28:19 +00:00
Diegoisawesome
6ef9671718
Merge pull request #440 from garakmon/fldeff
Decompile / port fldeff_80F9BCC
2018-12-19 22:16:59 -06:00
Diegoisawesome
c74bfbe110
Merge pull request #462 from Deokishisu/Move-data-out-of-wild_encounter.c
Move data out of wild_encounter.c
2018-12-19 22:11:57 -06:00
Deokishisu
a3543c9a34 Move data out of wild_encounter.c
wild_encounter.c is cleaned up, and its data has been moved to src/data/wild_encounters.h.
2018-12-19 22:50:54 -05:00
garak
5eac3ce1a2 rename fldeff_misc 2018-12-19 22:19:54 -05:00
Marcus Huderle
b7ce383a96 Document a bunch of battle anims 2018-12-19 21:19:44 -06:00
garak
af208a6bbb Merge branch 'fldeff' of https://github.com/garakmon/pokeemerald into fldeff 2018-12-19 21:35:32 -05:00
Diegoisawesome
48d7c0a7a3
Merge pull request #454 from golemgalvanize/decompile_party_menu
Decompile party menu
2018-12-19 19:57:31 -06:00
garak
f801eed3a8
clean fldeff file 2018-12-19 20:52:41 -05:00
golem galvanize
d6589d1abc another fix 2018-12-19 20:50:36 -05:00
golem galvanize
44fae5a688 add TM constant use 2018-12-19 20:44:40 -05:00
golem galvanize
64d4eed63b hidden conversation fixes applied 2018-12-19 20:27:44 -05:00
Diegoisawesome
5b73fe138c
Merge pull request #457 from golemgalvanize/decompile_water
Decompile water
2018-12-19 19:16:40 -06:00
golem galvanize
038836d21d pretty sure it's fixed now 2018-12-19 20:08:01 -05:00
golem galvanize
085e793460 one line cleanup in summary_screen 2018-12-19 19:55:51 -05:00
golem galvanize
fabbbdd02a fix up party_menu 2018-12-19 19:53:52 -05:00
golem galvanize
6f0dd694ea removed weird comment 2018-12-19 19:48:28 -05:00
DizzyEggg
128239d65e Almost there 2018-12-19 22:47:27 +01:00
Melody
5e6ceeb631 update applymovement to remove magic numbers 2018-12-19 14:08:01 -05:00
golem galvanize
e771854eae removed commented out attempt 2018-12-19 10:51:55 -05:00
golem galvanize
0fa120ebcd get a nonmatching slightly more functional 2018-12-19 10:48:15 -05:00
golem galvanize
cd785011fe decompiled water 2018-12-19 10:31:37 -05:00
Diegoisawesome
bd7c251859 Fix compressed palette alignment 2018-12-18 20:15:59 -06:00
Diegoisawesome
2592803460 Merge branch 'master' of github.com:pret/pokeemerald into trade 2018-12-18 19:54:27 -06:00
Diegoisawesome
cd994f4935 Begin trade.c 2018-12-18 19:29:41 -06:00
golem galvanize
f7df299be8 Merge branch 'master' of https://github.com/pret/pokeemerald into decompile_water 2018-12-18 20:23:32 -05:00
golem galvanize
15a7b1bc08 begin water.s 2018-12-18 20:23:07 -05:00
Marcus Huderle
b2ac3b6d6f Decompile most of battle_anim_effects_3.c 2018-12-18 19:15:59 -06:00
Marcus Huderle
d2b5a0e83f Convert battle_anim_815A0D4 data to .c 2018-12-18 19:15:59 -06:00
Diegoisawesome
2c7948bae8
Merge pull request #452 from Meowsy/pokemon-adding-easer
Add macros to simplify defining front animations and still pics.
2018-12-18 14:27:01 -06:00
Meowsy
d6b31346c3 Additional SPECIES_* documentation. 2018-12-18 10:03:57 -05:00
Meowsy
9ca27f1332 Document return value. 2018-12-18 09:20:43 -05:00
golem galvanize
8781d969ff finish party_menu 2018-12-18 05:38:08 -05:00
golem galvanize
c259ee46d3 Merge branch 'master' of https://github.com/pret/pokeemerald into decompile_party_menu 2018-12-18 05:31:39 -05:00
Marcus Huderle
c74468fd11 Document a bunch of battle anim stuff 2018-12-17 22:16:17 -06:00
Marcus Huderle
c04ce0ee64 Decompile battle_anim_effects_2.c 2018-12-17 22:16:17 -06:00
DizzyEggg
9ffd0c7382 3.5 asm left 2018-12-17 23:00:08 +01:00
Meowsy
e92245ab06 Add macros to simplify defining front animations and still pics. 2018-12-17 12:29:35 -05:00
Meowsy
62c4379a21 Remove magic numbers. 2018-12-17 12:28:11 -05:00
golem galvanize
076d07f6fe Merge branch 'master' of https://github.com/pret/pokeemerald into decompile_party_menu 2018-12-17 02:40:30 -05:00
golem galvanize
71a7a8a075 decompiled up to sub_81B8A7C 2018-12-17 02:39:17 -05:00
shinny456
60484153a5 decompile electric.s 2018-12-16 22:23:05 -05:00
garak
e292d0ca83
Merge branch 'master' into fldeff 2018-12-16 20:05:31 -05:00
DizzyEggg
aae36b5653 6k left 2018-12-16 21:10:01 +01:00
Marcus Huderle
d1e6e705cc Decompile battle_anim_effects_1.c 2018-12-16 11:39:22 -06:00
Marcus Huderle
9c5fa4a787 Fix typo in UpdateContestPaintingMosaicEffect() 2018-12-16 08:28:09 -06:00
Marcus Huderle
fb9a365dc6
Merge pull request #448 from Meowsy/pokedex-documentation
Pokedex Documentation
2018-12-15 18:06:42 -06:00
Meowsy
1d09216e4b Simplify comparisons. 2018-12-15 18:39:48 -05:00
Meowsy
6ed8e4d6ed Rename temp_notNationalDex to temp_isHoennDex.
Don't use hexadecimal format for x and y args.
2018-12-15 18:34:06 -05:00
Meowsy
3d8cecb662 Use correct term. 2018-12-15 18:32:50 -05:00
DizzyEggg
f1421d94c3 Up to sub 0x80ce580 2018-12-15 23:58:47 +01:00
Meowsy
83c3f13655 Prettify line. 2018-12-15 15:26:07 -05:00
Meowsy
8f168add21 Remove incorrect comment. 2018-12-15 15:25:45 -05:00
Meowsy
bc11a4a9f4 Document various things relating to the Pokedex. 2018-12-15 15:12:28 -05:00
Marcus Huderle
1ca3656d74
Decompile contest_painting.c (#447) 2018-12-15 13:07:07 -06:00
Slawter666
2fa0555ed5 Document some of item_menu.c 2018-12-15 18:08:13 +00:00
garak
7e170a06cc label some sprite templates 2018-12-14 19:39:01 -05:00
Marcus Huderle
5e92481f51
Merge pull request #443 from Meowsy/misc-renamings
Misc renamings.
2018-12-13 21:35:36 -06:00
Marcus Huderle
2c6849bee8
Decompile battle_anim_8170478.c (#445) 2018-12-13 21:33:54 -06:00
golem galvanize
6748ef72fb Merge branch 'master' of https://github.com/pret/pokeemerald into decompile_party_menu 2018-12-13 00:31:06 -05:00
Marcus Huderle
170b6ef449
Decompile battle_intro.c (#444) 2018-12-12 23:18:25 -06:00
golem galvanize
2265d49ac2 decompiled up to sub_81B5A8C 2018-12-12 22:55:39 -05:00
DizzyEggg
59a69eb627 Storage up to icon palettes 2018-12-12 23:19:50 +01:00
DizzyEggg
74746603ad More pokemon storage 2018-12-11 23:09:12 +01:00
DizzyEggg
c5b5f4bd77 More storage 2018-12-10 23:42:44 +01:00
Meowsy
d3e32ab287 Rename Mauville Man text. 2018-12-10 15:50:10 -05:00
Meowsy
68017b531a Rename UnknownPokemonStruct to BattleTowerPokemon. 2018-12-10 15:49:33 -05:00
DizzyEggg
c2d8876174 Document PSS functions 2018-12-10 21:36:52 +01:00
Diegoisawesome
58ca87accc
Merge pull request #441 from Meowsy/document-pockets
Document bag pocket magic numbers.
2018-12-10 11:23:41 -06:00
Diegoisawesome
bfdfe367e8
Merge pull request #422 from garakmon/frontier_data_1
Battle tower data
2018-12-10 11:22:16 -06:00