GriffinR
ec89e519f9
Merge pull request #1858 from AsparagusEduardo/pret/doc/fateful
...
Rename eventLegal to modernFatefulEncounter
2023-02-28 11:48:34 -05:00
DizzyEggg
12db276a71
fix endif
2023-02-28 10:36:11 +01:00
DizzyEggg
1fb2560f7b
newline
2023-02-28 10:14:16 +01:00
DizzyEggg
9d1e31ab39
accidentally removed ifs
2023-02-28 10:12:50 +01:00
DizzyEggg
cc2778b8bb
some touches
2023-02-28 10:08:31 +01:00
ghoulslash
b399d1e8c5
fix ABILITYEFFECT_ON_TERRAIN battler Id settings
2023-02-27 22:29:23 -05:00
ghoulslash
5a740c7461
dont overwrite gbattlerAttacker in TryChangeBattleTerrain, update BattleScript_ActivateTerrainAbilities loop iterator
2023-02-27 22:18:42 -05:00
Eduardo Quezada
90021f3be6
Removed zMovePower field in gBattleMoves in favor of a function.
2023-02-27 23:49:43 -03:00
DizzyEggg
3159508603
fix dex size inaccuraccies
2023-02-27 23:08:54 +01:00
GriffinR
adf28c2f63
Merge pull request #1855 from GriffinRichards/doc-chat
...
Add/correct some union room chat documentation
2023-02-27 13:25:05 -05:00
GriffinR
8d88a38561
Merge pull request #1854 from GriffinRichards/constants-num-frames
...
Add MAX_MON_PIC_FRAMES, and trainer pic size constants
2023-02-27 13:16:49 -05:00
Alex
21ca6defa7
forgot torment
2023-02-27 18:39:17 +01:00
Alex
1a2504d5ee
forgot disable
2023-02-27 18:29:29 +01:00
Alex
930a88b0e2
z status moves did not work properly
2023-02-27 18:00:32 +01:00
DizzyEggg
5a745020ee
add tests for stockpile swallow spit up
2023-02-27 16:27:58 +01:00
DizzyEggg
3338a6b786
add messages for stockpile effects wear off
2023-02-27 12:31:29 +01:00
LOuroboros
8a036e6007
Made this build again
2023-02-27 07:51:36 -03:00
LOuroboros
a54a8d9b2a
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into trainerSlideMsgUpdate
2023-02-27 07:43:19 -03:00
DizzyEggg
468625ed1d
fit long z-moves names on battle textbox
2023-02-27 10:32:45 +01:00
AgustinGDLV
e537be76ea
Z-moves bypass protection ( #2730 )
2023-02-27 09:17:07 +01:00
DizzyEggg
919fb184fe
AI knows how to handle Illusion ( #2726 )
...
* AI knows how to handle Illusion
2023-02-27 09:12:52 +01:00
DizzyEggg
44d2cc7232
Fix bugs related to Trainer Slide messages ( #2699 )
...
* start working on trainer slides
* use cmd->nextInstr
2023-02-27 09:11:25 +01:00
LOuroboros
fe09f3e0d3
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into trainerSlideMsgUpdate
2023-02-26 23:42:01 -03:00
Eduardo Quezada
41bf9ea63c
Removed trailing whitespaces
2023-02-26 18:43:15 -03:00
DizzyEggg
4bdca43dbd
refactor mega evolution indicator sprite
2023-02-26 12:51:35 +01:00
BuffelSaft
deb3109c81
Use proper symbol name styles for Jangmo-o family ( #2739 )
2023-02-26 13:15:53 +13:00
Eduardo Quezada D'Ottone
abc0e20aaf
Consider Nature Power in AI_CalcDamage ( #2776 )
2023-02-25 12:30:53 -03:00
Alex
f249b58c01
fix style
2023-02-25 15:24:31 +01:00
Alex
7ea82820ec
Consider nature power in AI_CalcDamage
2023-02-25 15:07:45 +01:00
Eduardo Quezada
31ab56bceb
Fixed footprint symbol names.
2023-02-25 09:23:34 -03:00
Alex
df47312e32
Fix move to battle_util.c
2023-02-25 12:38:57 +01:00
Alex
fc5c93fd83
exclude status move type check
2023-02-25 12:15:40 +01:00
Eduardo Quezada
ca81d7a0f9
Forgot about Jangmo-o
2023-02-24 21:58:09 -03:00
Alex
1e1686b69a
Fixes #2414
2023-02-24 23:38:23 +01:00
Eduardo Quezada
bbefee6bd4
Use proper symbol styles for Hakamo-O and Kommo-O
2023-02-24 15:22:58 -03:00
Eduardo Quezada
079ca8ab29
Renamed MON_DATA_SPECIES2 to MON_DATA_SPECIES_OR_EGG for clarification
2023-02-24 07:53:02 -03:00
Alex
48391d8eff
Basculegion female form
2023-02-24 08:46:34 +01:00
Eduardo Quezada
d330ca051a
Document music usage to make it easier to search for a specific track
2023-02-23 11:44:23 -03:00
Eduardo Quezada
f5aa3b8272
Document the 2 different sText_GotchaPkmnCaught
2023-02-23 11:43:40 -03:00
ghoulslash
827bf11307
Merge pull request #2660 from DizzyEggg/ace_voltswitch
...
Fix Volt Switch / Roar with ace pokemon
2023-02-23 09:20:18 -05:00
Alex
a870ec3c22
enamorus_t cry, basculegionf sprite, new typhlosion back sprite
2023-02-23 15:20:12 +01:00
DizzyEggg
3ff8c95c4e
add meltan melmetal teachable moves
2023-02-23 10:53:55 +01:00
DizzyEggg
23272074bf
fix uninitialized ai modifier variable in ai calc damage
2023-02-23 10:25:53 +01:00
Alex
1c832768bb
fix trainer party
2023-02-22 20:44:03 +01:00
Alex
1f694ae7ed
missing pla sprites
2023-02-22 20:41:01 +01:00
DizzyEggg
877e3fd6af
merge with upcoming
2023-02-22 19:27:42 +01:00
DizzyEggg
e0b76e98ff
Add MOVE_SHELL_TRAP Effect ( #2716 )
...
* implemented Shell Trap
Co-authored-by: AgustinGDLV <agustingomezdelavega@gmail.com>
2023-02-22 13:55:34 +00:00
Jaizu
403a6f4544
Merge pull request #2712 from DizzyEggg/fix_abilities_empty_field
...
Fix switch-in abilities activating on an empty field
2023-02-22 09:49:13 +01:00
DizzyEggg
31138455de
remove unneeded VARIOUS_JUMP_IF_NO_VALID_TARGETS
2023-02-22 09:28:12 +01:00
DizzyEggg
bca47a0891
Update src/battle_script_commands.c
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2023-02-22 09:17:23 +01:00
DizzyEggg
d73ab0246f
Fix Explosion + Galvanize + Volt Absorb and Mind Blown ( #2688 )
...
* Fix Explosion and Mind Blown
* Use battler ability in jumpifabilitypresent
2023-02-21 22:50:29 +00:00
Eduardo Quezada
5ca9213d07
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_script_commands.c
2023-02-21 17:47:02 -03:00
DizzyEggg
61064ab07e
Merge branch 'upcoming' into fix_abilities_empty_field
2023-02-21 16:22:26 +01:00
Martin Griffin
29c64c82f3
Test Red Card
...
Dragon Tail activates Red Card if the target does not switch.
2023-02-21 10:44:58 +00:00
Martin Griffin
afe09e9653
Test Dragon Tail
...
Remove the "But it failed!" message if the foe cannot be switched.
2023-02-21 10:43:57 +00:00
Martin Griffin
666e59b37f
Test Roar
...
The original implementation of forcerandomswitch was biased towards
certain party members.
2023-02-21 10:43:57 +00:00
LOuroboros
24581426a1
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into trainerSlideMsgUpdate
2023-02-21 04:46:28 -03:00
LOuroboros
3a91a5c930
Added new trainer slide-in msg conditions
...
Now they can say something:
-When their last Pokémon's HP is between 25% and 50%.
-When a critical hit is dealt to their first Pokémon for the first time.
-When a super effective hit is dealt to their first Pokémon for the first time.
-When a STAB move is used against (but doesn't faint) the opponent's Pokémon.
-When the Player's Pokémon's move doesn't affect the opponent's Pokémon.
-When they're about to trigger a Mega Evolution.
-When they're about to trigger a Z-Move.
Misc. changes:
-Split GetEnemyMonCount for readability's sake.
-Optimized the size allocated to trainerSlideLowHpMsgDone.
2023-02-21 04:40:02 -03:00
ghoulslash
6f23ada6e2
Merge pull request #2705 from DizzyEggg/pickup
...
correct Cmd_pickup
2023-02-20 12:15:20 -05:00
DizzyEggg
a8c0e1ebeb
fix intimidate
2023-02-20 13:15:08 +01:00
DizzyEggg
03915524c5
Fix switch-in abilities activating on empty field
2023-02-20 12:42:06 +01:00
DizzyEggg
53180ebf87
Update Healing wish to gen5 / gen8 mechanics ( #2708 )
...
* Updated Healing Wish and added config
* Fixed Lunar Dance message
Co-authored-by: AgustinGDLV <agustingomezdelavega@gmail.com>
Co-authored-by: AgustinGDLV <103095241+AgustinGDLV@users.noreply.github.com>
Co-authored-by: Martin Griffin <martinrgriffin@gmail.com>
2023-02-20 11:25:43 +00:00
GriffinR
f888021c8f
Merge pull request #1857 from GriffinRichards/sync-mapjson
...
Sync mapjson
2023-02-19 20:48:13 -05:00
LOuroboros
c33cc834bc
Updated Psyshield Bash's accuracy
2023-02-19 19:04:36 -03:00
DizzyEggg
380af442c3
Fix buggy pokemon anims with Illusion ( #2639 )
...
* try illusion fix
* fix
2023-02-19 12:05:56 +01:00
DizzyEggg
c82f35d6bf
correct Cmd_pickup
2023-02-19 12:01:13 +01:00
ghoulslash
4b64433816
Add Battle Anim cmds for dynamic Task, Sprite creation + Misc. Anim Fixes ( #2649 )
...
* add createvisualtaskontargets, createspriteontargets to fix electroweb, fiery wrath anims
* add missing semicolon
* add Cmd_createspriteontargets_onpos for heal block, fix heal block targeting
* remove duplicate func
* improve origin pulse anim
* fix IsDoubleBattle call
* venom drench acid uses average battler positions
* add GetSubpriorityForMoveAnim
* add GetBattleAnimMoveTargets for CreateSpriteOnTargets and Cmd_createvisualtaskontargets
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-02-19 11:48:12 +01:00
Eduardo Quezada D'Ottone
ec343cef02
Config to have Shuckle make Berry Juice from Oran Berries ( #2331 )
...
* Removed unused ifdefs and made actually check for Z Power Ring
* Config to have Shuckle make Berry Juice from Oran Berries
* Ordered species-specific configs
2023-02-19 10:45:59 +01:00
Eduardo Quezada D'Ottone
fcf13aab2b
Fixed evolutions that use held items to evolve not working when using Rare Candies. ( #2565 )
2023-02-19 10:40:55 +01:00
ghoulslash
79ea2e8074
add howl AI check for new effect ( #2703 )
...
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-02-18 11:37:29 +01:00
LOuroboros
4be4ec3081
metatitleBehavior -> metatileBehavior
2023-02-17 16:43:22 -03:00
GriffinR
bc3805f9d3
Fix two binary palettes
2023-02-17 13:27:39 -05:00
LOuroboros
6e134bb7dc
Removed pointless IsBattlerHpLow function
2023-02-17 12:52:43 -03:00
DizzyEggg
66d2f253a1
merge with master
2023-02-17 15:43:15 +01:00
Jaizu
31316dbfd2
Merge pull request #2529 from mrgriffin/rhh-battlescript-cmd-args
...
Readable BattleScript command arguments
2023-02-17 15:35:03 +01:00
DizzyEggg
0c523f9518
Fix Magic bounce powder moves against grass types ( #2633 )
...
* Fix Magic bounce powder moves against grass types
2023-02-17 13:55:51 +00:00
DizzyEggg
56c9564e7a
8th gen Howl's effect ( #2700 )
...
* Howl gen8 effect
2023-02-17 10:28:46 +00:00
Martin Griffin
0573aa455a
Introduce macros to parse battle script arguments
...
CMD_ARGS for regular commands, VARIOUS_ARGS for various commands, and
NATIVE_ARGS for callnative commands.
2023-02-17 10:05:57 +00:00
Eduardo Quezada D'Ottone
625a7622e2
Merge pull request #2697 from AsparagusEduardo/RHH/sync/pret_20230214
...
It's ya boi, pret merge! (pret merge 2023/02/16)
2023-02-16 21:57:41 -03:00
Eduardo Quezada
a60b179bcb
Incorporated fixes from upstream
2023-02-16 18:20:54 -03:00
DizzyEggg
d637ee3b13
Fix After You for gen8 ( #2646 )
...
Fix After You
2023-02-16 20:59:36 +00:00
DizzyEggg
6cdca24c31
use forced switch battler bit
2023-02-16 21:58:00 +01:00
Eduardo Quezada
f4f8ab6ee9
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
2023-02-16 17:06:49 -03:00
DizzyEggg
d7f68a3893
IsAceMon - not isAceMon
2023-02-16 15:57:15 +01:00
ghoulslash
f4ef67d897
Merge pull request #2689 from DizzyEggg/grenja
...
Fix Battle Bond activating multiple times in battle
2023-02-16 09:36:02 -05:00
ghoulslash
6b0b427d93
Merge pull request #2680 from DizzyEggg/mirror_armor
...
Fix Mirror Armor against Clear Body
2023-02-16 09:29:04 -05:00
ghoulslash
05bef50a1f
Merge pull request #2658 from DizzyEggg/one_vs_two_egg
...
Fix 1 vs 2 battles with eggs
2023-02-16 09:20:18 -05:00
ghoulslash
60a3da5811
Merge pull request #2691 from DizzyEggg/clang_scales
...
Fix Clanging Scales target and effect
2023-02-16 09:13:33 -05:00
ghoulslash
8c81cf1e66
Merge pull request #2692 from DizzyEggg/shields_down
...
Fix Shield Down Ability pop-up
2023-02-16 09:11:24 -05:00
sbird
fea54c9277
[intro] add fading, refactor abort, align intro gfx
2023-02-16 10:43:50 +01:00
DizzyEggg
97f9c0a4d9
oof
2023-02-15 23:45:53 +01:00
DizzyEggg
f6a0c882d1
Fix Shield Down Ability pop-up
2023-02-15 23:44:00 +01:00
DizzyEggg
94651e77a5
Fix Clang Scales target and effect
2023-02-15 22:18:18 +01:00
Eduardo Quezada
7ddebb6671
Merge remote-tracking branch 'pret/master' into RHH/sync/pret_20230214
...
# Conflicts:
# data/battle_ai_scripts.s
# src/menu_specialized.c
# src/mystery_gift_menu.c
2023-02-15 14:18:00 -03:00
Eduardo Quezada
b62e5aa72e
Merge remote-tracking branch 'pret/master' into RHH/sync/pret_20230214
...
# Conflicts:
# src/battle_main.c
# src/field_specials.c
# src/trade.c
2023-02-15 14:11:03 -03:00
Eduardo Quezada
bd54990333
Review changes
2023-02-15 13:56:11 -03:00
GriffinR
69fdf0faa4
Merge pull request #1853 from GriffinRichards/doc-contest-bar
...
Clarify AI_CV_AttackDown_UnknownTypeList
2023-02-15 11:29:57 -05:00
GriffinR
671c9c5353
Merge branch 'master' into doc-chat
2023-02-15 10:57:05 -05:00
Alex
e4045a7a5f
z move pp color ( #2690 )
2023-02-15 16:19:09 +01:00
GriffinR
a322379feb
Merge branch 'master' into doc-windows
2023-02-15 10:04:48 -05:00
GriffinR
9c1c598160
GROUPTYPE_NONE to unsigned
2023-02-15 09:49:33 -05:00
DizzyEggg
3f0f7c6b7f
Fix Battle Bond activating multiple times in battle
2023-02-15 15:30:29 +01:00
LOuroboros
7885941d3c
Tweaked Task_HandleExpansionIntro to fix the water drops glitch
...
Thanks to Tustin2121.
2023-02-14 14:03:18 -03:00
ghoulslash
908b509401
Fix Round's Base Power calc, Add Turn order effects ( #2602 )
...
* fix round base power calc, add turn order change
* remove unused callnative cmd
* fix round turn order update
* fix moveTarget getting set incorrectly in HandleAction_UseMove. also redirection doesn't affect MOVE_TARGET_ALL_BATTLERS
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-02-14 16:49:50 +01:00
ghoulslash
094554b3a3
Merge pull request #2681 from DizzyEggg/jaw_lock
...
Fix Jaw Lock locking player pokemon
2023-02-13 10:40:47 -05:00
DizzyEggg
2b4d2a7695
Fix Jaw Lock locking player pokemon
2023-02-13 16:27:21 +01:00
ghoulslash
d1ef53f93a
Merge pull request #2678 from AlexOn1ine/z_indicator_in_doubles
...
Z-Move Indicator was wrongly displayed in double battles
2023-02-13 08:52:06 -05:00
DizzyEggg
0577d8d04d
Fix Mirror Armor against Clear Body
2023-02-13 14:44:34 +01:00
ghoulslash
c399391891
Merge pull request #2677 from AlexOn1ine/z_moves_switch_order
...
Fix switching Z-Moves when pressing SELECT in battle
2023-02-13 08:41:58 -05:00
ghoulslash
39b8c8e9e7
fix sText_BeingHitChargedPkmnWithPower battler
2023-02-13 08:39:04 -05:00
ghoulslash
d508f12ac9
merge with upcoming
2023-02-13 08:38:32 -05:00
DizzyEggg
5d958e245a
Merge pull request #2669 from Jaizu/giga_impact_contests
...
Fix Giga Impact on contests.
2023-02-13 09:22:24 +01:00
Alex
2b32bfcdc1
add battlerId arg to ShowZMoveTriggerSprite
2023-02-12 19:39:14 +01:00
Eduardo Quezada
d699d55ba3
Reformatted gNatureStatTable
2023-02-12 01:19:03 -03:00
Eduardo Quezada
a937b3221a
Documented Ribbons
2023-02-11 23:16:24 -03:00
Eduardo Quezada
96865f66af
Updated term to modernFatefulEncounter
2023-02-11 22:36:42 -03:00
Eduardo Quezada
6da5e0a280
Rename eventLegal to fatefulEncounter
2023-02-11 17:13:53 -03:00
Alex
d363ed8152
z indicator in double battles
2023-02-11 19:55:08 +01:00
Alex
ce416be297
z_move switch move bug
2023-02-11 18:32:07 +01:00
sbird
4bcbb7c9e1
[intro] refactor expansion intro
2023-02-09 23:12:29 +01:00
ghoulslash
deb23fc7c6
Merge pull request #2648 from AlexOn1ine/pollen_puff
...
Fixes Pollen Puff issue #2611
2023-02-09 08:21:33 -05:00
ghoulslash
27933836b5
Merge pull request #2662 from AlexOn1ine/heal_pulse_v2
...
Add Logic for Heal Pulse effects in double battles
2023-02-09 08:18:00 -05:00
Jaizu
9f7267e48d
Fix Giga Impact on contests.
2023-02-09 11:29:29 +01:00
GriffinR
c32fbf594a
Merge pull request #1851 from GriffinRichards/doc-fldspc
...
Document remaining field_specials task data
2023-02-08 22:34:57 -05:00
GriffinR
de56e400ff
Sync clone object macro
2023-02-08 13:11:10 -05:00
Eduardo Quezada D'Ottone
8381b14c51
Implemented Xhyzi's RHH copyright intro (with config) ( #2415 )
...
* Rhh & Pret Copyright Screen
* Porygon recovered his voice
* Expansion text
---------
Co-authored-by: Xhyzi <xhyzdot@gmail.com>
Co-authored-by: Jaizu <jaizu85@gmail.com>
2023-02-08 15:54:12 +01:00
Alex
41d64ea41e
heal pulse effect in double battles
2023-02-08 13:02:41 +01:00
DizzyEggg
84d7024add
cleanup
2023-02-08 12:48:48 +01:00
DizzyEggg
896b575c07
Fix volt switch breaking ace pokemon
2023-02-08 12:42:38 +01:00
DizzyEggg
8c257bde99
Fix 1 vs 2 battles with eggs
2023-02-08 10:24:19 +01:00
Eduardo Quezada
6c30c5490c
Test PR
2023-02-08 00:51:59 -03:00
DizzyEggg
ff088752e7
Insomnia ability pop-up ( #2643 )
...
* Insomnia ability pop-up
* remove B_MSG_STAYED_AWAKE_USING constant
2023-02-07 18:47:23 +01:00
Alex
5bf607049e
Fix Pollen Puff score
2023-02-07 16:41:30 +01:00
ghoulslash
7e9d40d401
Merge pull request #2645 from DizzyEggg/damp_aftermath
...
Damp shows ability pop-up when reacting with Aftermath
2023-02-07 10:18:23 -05:00
DizzyEggg
0d6b640876
Merge pull request #2439 from AsparagusEduardo/RHH/pr/cleanup/DragonTailEffect
...
Cleaned up move effect checks for Dragon Tail/Circle Throw
2023-02-07 16:17:12 +01:00
DizzyEggg
f762ed728d
remove pointless timers from disable struct
2023-02-07 15:10:20 +01:00
DizzyEggg
0dc5e1e685
aftermath damp pop-ups and string
2023-02-07 13:01:56 +01:00
ghoulslash
0c4c3fbbb7
Fix Poison Gas Anim for MOVE_TARGET_BOTH ( #2608 )
...
* poison gas anim handles MOVE_TARGET_BOTH
* fix sprite position fields
* fix it again
---------
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
2023-02-07 12:14:36 +01:00
GriffinR
bbf0cf0103
Stop hard-coding number of preset names
2023-02-04 00:00:38 -05:00
GriffinR
5496f0e6b0
Merge pull request #1850 from GriffinRichards/sync-trade
...
Sync trade
2023-02-03 19:05:00 -05:00
GriffinR
c1cfd3ac66
Add fix for commented bug
2023-02-03 16:01:13 -05:00
Jaizu
717ba22ea1
Make contest opponents an enum
...
I'm sure that at least 2 people eventually might consider editing them, this makes it easier.
2023-02-03 15:49:22 +01:00
ghoulslash
f060d0185f
fix wind power, electromorphosis stomping on gbattlerattacker
2023-02-02 21:59:40 -05:00
Eduardo Quezada
101ea6522d
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_util.c
2023-02-02 17:56:13 -03:00
GriffinR
5793a1a5e7
Correct some union room chat documentation
2023-02-02 11:41:02 -05:00
LOuroboros
4b5a6e2328
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch1
2023-02-01 20:18:56 -03:00
Philipp AUER
8983739267
Merge pull request #2564 from mrgriffin/rhh-battle-tests
...
Battle Tests
2023-02-01 22:18:17 +01:00
GriffinR
3b15fd34cc
Merge branch 'master' of https://github.com/pret/pokeemerald into constants-num-frames
2023-02-01 16:09:01 -05:00
GriffinR
28ada9c93b
Merge branch 'master' of https://github.com/pret/pokeemerald into doc-contest-bar
2023-02-01 15:52:19 -05:00
GriffinR
020266463c
Add fix for described UB
2023-02-01 15:44:48 -05:00
GriffinR
07e00b2e41
Additional window id constant usage
2023-02-01 15:24:15 -05:00
GriffinR
4328ed8b19
Merge branch 'master' of https://github.com/pret/pokeemerald into doc-windows
2023-02-01 14:59:45 -05:00
GriffinR
30f893f255
Fix comment mistake
2023-02-01 11:52:32 -05:00
GriffinR
9003966fcc
Misc field_specials cleanup
2023-02-01 11:48:55 -05:00
GriffinR
43af7d46ca
Label data for elevator effects
2023-02-01 10:43:10 -05:00
GriffinR
27a5e05f75
Label data for screen effect tasks
2023-02-01 10:20:23 -05:00
GriffinR
603d870ea0
Fix debug printing negative values
2023-02-01 09:36:18 -05:00
GriffinR
65d476d575
Remove some incorrect color constant usage
2023-02-01 09:32:41 -05:00
Martin Griffin
f1b9872bf0
Test moves, items, and abilities in battle
...
Thank you to SBird for providing mgba-rom-test binaries and Spikes/Toxic
Spikes tests!
Co-authored-by: sbird <sbird@no.tld>
2023-02-01 13:53:57 +00:00
Martin Griffin
c11774acb8
Decap gStatNamesTable, Spikes, Sturdy, and Torment
2023-02-01 13:53:57 +00:00
Eduardo Quezada D'Ottone
fcccffce45
Apply suggestions from code review
...
* Jaizu ran away *
2023-01-31 09:07:45 -03:00
Jaizu
074e601c1f
Fix transform on players side too
2023-01-31 13:02:24 +01:00
Jaizu
4eb7b7048e
Make transform not break
2023-01-31 12:41:07 +01:00
Jaizu
767008427f
Don't pass down daycare like AlterEggSpeciesWithIncenseItem
2023-01-31 09:47:02 +01:00
Jaizu
68ee9e5739
Restore bugfix
...
Ooopsie!
2023-01-30 13:57:59 +01:00
Jaizu
267cf1e6f0
Update comment
2023-01-29 19:45:43 +01:00
Jaizu
8b1f4ac3ac
Implement Destiny Knot
2023-01-29 19:35:46 +01:00
Jaizu
761878f1fe
Fix ball resetting when hatching an Egg
2023-01-28 21:35:04 +01:00
ghoulslash
feb4bfee42
fix toxic debris side status check
2023-01-28 13:56:09 -05:00
Martin Griffin
bdb04da9a5
Refactor battle animations
2023-01-28 00:16:25 +00:00
Martin Griffin
cba4b78df6
Move-based mega evolution message for NPCs/recorded battles
2023-01-28 00:16:24 +00:00
Eduardo Quezada D'Ottone
f1d97bfad7
Merge pull request #2607 from mrgriffin/rhh-battlescript-fixes
...
Fix uses of gBattlescriptCurrInstr
2023-01-27 19:25:06 -03:00
Eduardo Quezada D'Ottone
53e41a2b3d
Merge pull request #2605 from mrgriffin/rhh-battle-tests-fixes
...
Rhh battle tests fixes
2023-01-27 19:24:13 -03:00
Martin Griffin
4e19d1aaec
Fix uses of gBattlescriptCurrInstr
...
- VARIOUS_SWAP_STATS and moveend could branch inside their own arguments.
- VARIOUS_JUMP_IF_LAST_USED_ITEM_BERRY was implemented in reverse.
2023-01-27 21:27:57 +00:00
ghoulslash
2b58593e33
Merge pull request #2595 from AsparagusEduardo/RHH/pr/data/Gen9Items
...
Added some Gen9 item data and fixed Punching Glove's effect
2023-01-27 16:13:50 -05:00
Martin Griffin
4ad4d8e25c
Encore fails if target has not moved
2023-01-27 18:55:50 +00:00
Eduardo Quezada D'Ottone
4c4fa6a2b6
Merge pull request #2603 from TeamAquasHideout/upcoming
...
Fix Wood Hammer To Have 1/3rd Recoil
2023-01-27 10:47:32 -03:00
Team Aqua's Hideout
e87e8d0898
Fix Wood Hammer To Have 1/3rd Recoil
...
Wood Hammer was set to 1/4th recoil before
2023-01-27 08:16:37 -05:00
Martin Griffin
6a403ab45c
Pastel Veil grants immunity to poison
2023-01-27 00:57:24 +00:00
Martin Griffin
3647825a30
Fix Poison Point
...
It incorrectly activated only if the Pokémon with Poison Point could be
poisoned by the attacker.
2023-01-27 00:57:24 +00:00
Martin Griffin
a13ffdbfba
U-turn does not switch the user out if Emergency Exit activates
2023-01-27 00:57:22 +00:00
ghoulslash
92341e6d6a
fix flame burst hitting semi-invulnerable partner
2023-01-26 13:04:01 -05:00
Jaizu
d074daedbe
Allow exiting the Battle Debug menu pressing B
2023-01-26 16:36:33 +01:00
Eduardo Quezada
7774c9727d
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pret_20230125
...
# Conflicts:
# tools/mapjson/mapjson.cpp
2023-01-25 20:28:55 -03:00
Eduardo Quezada
3288309c43
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_script_commands.c
2023-01-25 19:57:19 -03:00
walkingeyerobot
f9bb0bfb29
better handle throwing balls in a double wild battle ( #2587 )
...
* Handle throwing balls in a double wild battle where the player has only a single Pokémon.
2023-01-25 20:15:58 +00:00
GriffinR
f4cb6d229f
Add some missing sizeof usage for SpriteSheets
2023-01-24 17:04:48 -05:00
Eduardo Quezada
a044774896
Added Gen9 item data and fixed Punching Glove's effect
2023-01-24 16:47:54 -03:00
GriffinR
10230799d3
Simplify some max value macros
2023-01-23 16:01:46 -05:00
Eduardo Quezada D'Ottone
1202f0366c
Merge pull request #2586 from Jaizu/ability_popup_fixes
...
Ability popup updates
2023-01-23 17:34:18 -03:00
GriffinR
7681340966
Merge branch 'master' of https://github.com/pret/pokeemerald into sync-trade
2023-01-23 14:45:51 -05:00
ghoulslash
321634ed3b
Silk Trap Effect ( #2512 )
...
* add silk trap effect, analog of obstruct
Co-authored-by: ghoulslash <pokevoyager0@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2023-01-23 16:42:47 -03:00
Eduardo Quezada D'Ottone
fbcad9d3ec
Merge pull request #2572 from rh-hideout/AsparagusEduardo-patch-1
...
Fixed Exp Candy S using the XS description
2023-01-23 15:00:25 -03:00
Eduardo Quezada D'Ottone
1bfc922c72
Merge pull request #2471 from ghoulslash/be/gen9items
...
Start Gen9 Hold Effects
2023-01-23 14:58:08 -03:00
ghoulslash
8cc923ebcc
parentheses around random & 1
2023-01-23 09:42:04 -05:00
Eduardo Quezada D'Ottone
2b22bdf1e7
Merge pull request #2579 from LOuroboros/allahu
...
Fixed Explosion & Intimidate's 'interaction'
2023-01-23 11:37:06 -03:00
ghoulslash
e93d22c0f1
optimize IsMoveMakingContact
2023-01-23 09:37:05 -05:00
ghoulslash
125e73dd07
loaded dice fix
2023-01-23 09:36:17 -05:00
ghoulslash
f97ec1975a
merge w upcoming
2023-01-23 09:24:03 -05:00
TeamAquasHideout
af07c451d0
Fix Psycho Shift printfromtable Error
2023-01-23 05:01:55 -05:00
Jaizu
a7ce3974ad
Apply feedback
2023-01-21 19:25:02 +01:00
Jaizu
c6811fb692
Ability popup fixes
2023-01-21 18:12:12 +01:00
ghoulslash
428ea97028
IsBattlerAlive instead of hp check
2023-01-21 12:11:12 -05:00
ghoulslash
a044084182
Remove redundant IsBattlerAlive checks from ITEMEFFECT_ORBS
2023-01-21 11:11:50 -05:00
ghoulslash
9e6c5725d0
add hp check to ITEMEFFECT_ORBS
2023-01-21 08:55:20 -05:00
GriffinR
29c1af50ca
Fix Best Streak stat name
2023-01-20 11:25:04 -05:00
Eduardo Quezada
4a9515e8db
Restored improvements from upstream
2023-01-20 12:34:15 -03:00
Eduardo Quezada
749225ace1
Matching merge from upstream pret
...
# Conflicts:
# graphics/interface/menu_info.png
# include/pokemon.h
# src/battle_ai_switch_items.c
# src/battle_anim_mons.c
# src/battle_anim_water.c
# src/battle_controller_opponent.c
# src/battle_gfx_sfx_util.c
# src/battle_main.c
# src/battle_pike.c
# src/battle_script_commands.c
# src/data/pokemon/species_info.h
# src/pokemon.c
# src/pokemon_summary_screen.c
2023-01-20 12:31:54 -03:00
GriffinR
b7d92e8537
Revert incorrect constant usage, add new correct ones
2023-01-18 12:11:09 -05:00
GriffinR
0cc10a1ada
Merge branch 'master' of https://github.com/pret/pokeemerald into ui-standardize
2023-01-18 11:07:12 -05:00
GriffinR
4a9c4951ab
Merge pull request #1815 from tustin2121/patch-5
...
Adding FindObjectEventPaletteIndexByTag bugfix
2023-01-18 10:40:07 -05:00
GriffinR
a203c03eac
Add bugfix to LoadObjectEventPalette
2023-01-18 10:33:39 -05:00
GriffinR
d68e81c2be
Clarify MB_SEMI_DEEP_WATER name
2023-01-17 21:32:55 -05:00
LOuroboros
773e7f0de2
Fixed Explosion & Intimidate's 'interaction'
2023-01-17 22:16:42 -03:00
GriffinR
d5a4bfcd6f
Merge pull request #1843 from GriffinRichards/colorize
...
Colorize more grayscaled/incorrectly colored pngs
2023-01-15 12:48:42 -05:00
Jaizu
a3ae182fc2
Add constants when using GetMonsStateToDoubles_2
2023-01-15 09:50:31 +01:00
GriffinR
c0e68f33f7
Colorize pokemon storage tiles
2023-01-15 00:39:51 -05:00
GriffinR
18384894e0
Merge pull request #1822 from AsparagusEduardo/pret/doc/typesEggGroups
...
Made Types and Egg Groups into arrays
2023-01-15 00:27:20 -05:00
Eduardo Quezada
70d59d6aa9
Improve Easy Chat documentation
2023-01-15 02:15:11 -03:00
GriffinR
387ea563fc
Move FRLG trainer card gfx to own folder, fix tiles
2023-01-13 13:40:13 -05:00
GriffinR
1707f82992
Combine/colorize status graphics
2023-01-13 12:53:08 -05:00
Eduardo Quezada D'Ottone
6e1981369b
Fixed Exp Candy S using the XS description
2023-01-13 13:22:27 -03:00
Eduardo Quezada
ac4825ad28
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_util.c
2023-01-13 11:50:47 -03:00
ghoulslash
c72274ee98
Merge pull request #2566 from AsparagusEduardo/RHH/pr/feature/breedBalls
...
Config for ball inheritence when breeding
2023-01-13 09:35:15 -05:00
GriffinR
ee3f5033b3
Colorize contest/interface.png
2023-01-13 00:26:40 -05:00
Eduardo Quezada
77cc407386
Review change
2023-01-12 23:44:34 -03:00
GriffinR
12cbb0b30f
Colorize and combine birch_bag/birch_grass
2023-01-12 15:22:23 -05:00
GriffinR
5b3596108d
Add some missing PARTY_SIZE usage
2023-01-12 10:51:20 -05:00
Bassoonian
3b4cba9b51
Apply suggestions from code review
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2023-01-11 14:11:47 +01:00
Bassoonian
333917941b
Add PLA+ obedience mechanics (with config)
2023-01-11 08:15:57 +01:00
GriffinR
b873d69679
Sync trade anim
2023-01-09 15:32:04 -05:00
LOuroboros
bdcc84f019
Updated the implementation
2023-01-09 15:18:22 -03:00
LOuroboros
dccceb9689
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2023-01-09 14:59:41 -03:00
ghoulslash
cc7c546011
Merge pull request #2473 from LOuroboros/mimicry
...
Reimplemented Mimicry
2023-01-09 12:54:44 -05:00
LOuroboros
ba21ffb3f2
Oopsie. Protosynthesis is NOT a terrain ability
2023-01-09 14:37:18 -03:00
LOuroboros
620a6a5e90
Extra review changes
...
-Foolproofed the ability checks in ABILITYEFFECT_ON_WEATHER and ABILITYEFFECT_ON_TERRAIN
-Made BattleScript_OverworldWeatherStarts and BattleScript_OverworldTerrain call the battle scripts that handle weather form changes, weather abilities, terrain seeds and terrain abilities.
-Consequentially, I removed the activation for weather and terrain abilities that I added to TryDoEventsBeforeFirstTurn, and the activation of Protosynthesis in ABILITYEFFECT_ON_SWITCHIN.
-Added a weatherAbilityDone to prevent abilities that lack self-checks like Protosynthesis from getting stuck in a loop.
-Removed now pointless ABILITYEFFECT_WEATHER_FORM. I think Duke/Sneed69 added it to fix Castform's form change, but it no longer serves a purpose.
2023-01-09 14:22:14 -03:00
LOuroboros
91b2e1bb50
More review changes and added lackings
...
-Removed unnecessary special handling of terrain-inducing overworld weather states from ChangeTypeBasedOnTerrain.
-Mimicry now activates normally for terrain-inducing overworld weather states.
-Weather abilities now activate normally when switchineffects is called, and at the beginning of a battle.
-Terrain abilities now activate normally at the beginning of a battle.
2023-01-09 07:55:55 -03:00
Eduardo Quezada
1b0ce96e12
Config for ball inheritence when breeding
2023-01-09 02:16:29 -03:00
LOuroboros
c32f584940
Applied review changes
2023-01-08 19:50:27 -03:00
Eduardo Quezada
612ef46d82
Forgot to add these suggestions
2023-01-08 19:26:34 -03:00
Eduardo Quezada
911541ba4f
Merge branch 'RHH/upcoming' into RHH/pr/feature/IncenseBaby
...
# Conflicts:
# include/config/pokemon.h
2023-01-08 18:48:01 -03:00
Eduardo Quezada
c5ea97ecc3
Review changes
2023-01-08 18:42:39 -03:00
Eduardo Quezada
9250f8c994
Standarized Pichu/Light Ball/Volt Tackle interaction into their own table, allowing for custom combinations
2023-01-08 18:35:47 -03:00
ghoulslash
da27df9f18
Merge pull request #2326 from AsparagusEduardo/RHH/pr/reworkScald
...
Rolled EFFECT_SCALD into EFFECT_BURN_HIT with a config for its Gen6+ change
2023-01-08 16:25:29 -05:00
GriffinR
c91b13a12b
Merge branch 'master' of https://github.com/pret/pokeemerald into doc-windows
2023-01-07 13:30:11 -05:00
Eduardo Quezada D'Ottone
7622d84a4f
Revert "Removed Unown hack"
2023-01-07 11:39:56 -03:00
Eduardo Quezada
d72a3731d4
Merge branch 'RHH/upcoming' into RHH/pr/feature/reworkScald
...
# Conflicts:
# include/constants/battle_move_effects.h
2023-01-06 15:25:49 -03:00
LOuroboros
f39f48fc51
Made MOVE_EFFECT_DIRE_CLAW a tiny bit prettier
2023-01-05 03:07:28 -03:00
LOuroboros
72566e6323
Turned Stone Axe's and Ceaseless Edge's effects into MOVE_EFFECTs
2023-01-05 03:02:56 -03:00
Eduardo Quezada D'Ottone
34d27eca0e
Merge pull request #2457 from AsparagusEduardo/RHH/pr/cleanup/unown
...
Removed Unown hack
2023-01-04 18:57:28 -03:00
Eduardo Quezada
74d8c587fe
Merge branch 'RHH/upcoming' into RHH/pr/cleanup/unown
...
# Conflicts:
# src/data/pokemon/species_info.h
# src/data/pokemon_graphics/front_pic_anims.h
2023-01-04 17:58:54 -03:00
Eduardo Quezada
55be15f690
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/palleteConversion2
...
# Conflicts:
# include/config/pokemon.h
2023-01-04 16:19:57 -03:00
LOuroboros
7e398ce80e
Corrected the AI conditionals
2023-01-04 12:45:49 -03:00
LOuroboros
9a6bdfb74f
Added AI conditionals for the new move effects in this batch
2023-01-04 12:13:34 -03:00
ghoulslash
1d2cb49bc6
Merge pull request #2542 from AsparagusEduardo/RHH/pr/config/multiTargetDmg
...
Config to restore Gen 3's damage reduction to multi target moves
2023-01-04 09:18:39 -05:00
ghoulslash
a425de77a6
Merge pull request #2446 from LOuroboros/primal
...
Updated AnimTask_PrimalReversion
2023-01-04 09:16:28 -05:00
ghoulslash
a6269f8cc7
Merge pull request #2559 from AsparagusEduardo/RHH/pr/sync/pretmerge_20230103
...
For me, it was tuesday. (pret merge 2023/01/03)
2023-01-04 09:15:08 -05:00
GriffinR
36c89d345c
Merge branch 'master' into doc-wnews
2023-01-03 22:28:21 -05:00
Eduardo Quezada D'Ottone
41d846c74c
Merge pull request #2551 from ghoulslash/be/frontier_bp
...
Reshape sBattlePointAwards to be easier to read
2023-01-03 21:48:08 -03:00
ghoulslash
2ee26c6240
align cols
2023-01-03 19:36:19 -05:00
Eduardo Quezada
b897b7787e
Applied bugfix from upstream
2023-01-03 15:41:03 -03:00
Eduardo Quezada
e0802f13a2
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20230103
...
# Conflicts:
# include/link_rfu.h
2023-01-03 15:40:33 -03:00
LOuroboros
f1ca254c28
Updated the Mimicry reimplementation
...
Mimicry is now a proud member of ABILITYEFFECT_ON_TERRAIN.
Misc. changes:
-Ditched the dependency on and usage of gBattlerAttacker for the effects inside ABILITYEFFECT_ON_WEATHER and ABILITYEFFECT_ON_TERRAIN.
-Made Cmd_switchineffects activate ABILITYEFFECT_ON_TERRAIN to take into account overworld weather-induced field terrains.
-Updated the text strings printed by the battle scripts inside the aforementioned AbilityBattleEffects caseIDs.
-Removed constant label of unused VARIOUS_TRY_TO_APPLY_MIMICRY which I forgot about.
-Updated ChangeTypeBasedOnTerrain, partly as a result of the aforementioned changes but also for optimization purposes.
-There was never a reason to establish an empty scope, or to use GET_MOVE_TYPE and the variables that complemented it.
-Removed case ABILITY_QUARK_DRIVE from AbilityBattleEffects' case ABILITYEFFECT_ON_SWITCHIN.
2023-01-03 02:27:41 -03:00
LOuroboros
bb218b1616
Updated HOLD_EFFECT_ZOOM_LENS check
2023-01-03 01:10:21 -03:00
LOuroboros
d0f5653f5e
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into mimicry
2023-01-02 19:00:41 -03:00
Eduardo Quezada
a23501a4a3
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# src/battle_script_commands.c
2023-01-02 18:54:57 -03:00
LOuroboros
0a00942a26
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into gen_9_move_effects_batch1
2023-01-02 16:00:13 -03:00
ghoulslash
2944ebfe7b
Merge pull request #2543 from AsparagusEduardo/RHH/pr/fix/shinyChances
...
Reverting P_SHINY_BASE_CHANCE implementation as it wasn't accuerate to Gen6+
2023-01-02 13:55:36 -05:00
ghoulslash
759ee8854a
Merge pull request #2470 from LOuroboros/dev_gen9_abilities
...
Implemented the majority of the Gen. 9 Abilities
2023-01-02 13:39:38 -05:00
ghoulslash
a06135b2f4
Merge pull request #2539 from AsparagusEduardo/RHH/pr/fix/FixEgg
...
Fixed Eggs sometimes reading garbage graphic data.
2023-01-02 13:27:28 -05:00
ghoulslash
82bf76588c
move challengeNum index to end of sBattlePointAwards, explicitly call out frontier facilities, modes
2023-01-02 13:12:46 -05:00
LOuroboros
13d8c0d167
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into dev_gen9_abilities
2023-01-02 14:34:24 -03:00
LOuroboros
ca32d43433
Streamlined ability-on-weather changes
...
Also renamed activateweatherabilities and activateterrainabilities.
2023-01-02 14:32:56 -03:00
Eduardo Quezada
16e8a5dd7f
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# include/battle_util.h
2023-01-01 16:02:40 -03:00
LOuroboros
d3443396e2
Made Clear Body and similar abilities be normally affected by their own stat stage reductions
2023-01-01 10:45:38 -03:00
LOuroboros
f2e63a2e41
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2022-12-31 03:33:42 -03:00
Bassoonian
453aa2ffe7
Fix faulty gBaseStats reference
2022-12-31 02:01:56 +01:00
Eduardo Quezada D'Ottone
0e1836d42b
Merge pull request #2106 from Sneed69/PartyBattlerShouldAvoidHazards
...
PartyBattlerShouldAvoidHazards rewrite
2022-12-30 17:55:53 -03:00
Eduardo Quezada D'Ottone
2d222ad0a9
Merge pull request #2544 from LOuroboros/miscs
...
Applied minor tweaks
2022-12-30 17:51:55 -03:00
Eduardo Quezada D'Ottone
4dc72dcfc1
Merge pull request #1956 from SonikkuA-DatH/SonikkuA-DatH-Teatime2
...
Implementing Teatime effect
2022-12-30 17:49:54 -03:00
LOuroboros
e8dfb66c30
Adding ability effect triggers for terrains and weather
...
A new, probably better way to handle the announcement trigger that abilities such as Protosynthesis and Quark Drive have, when the battle weather or the field terrain change.
Misc. changes:
-EFFECT_DAMAGE_SET_TERRAIN -> EFFECT_HIT_SET_REMOVE_TERRAIN
-It's more appropriate as the effect can be used to force set a terrain or simply to remove an active terrain, after all.
-The main reason for the rename was the inconsistency with the battle script's label.
-Reverted accidentally committed change to B_DOUBLE_WILD_CHANCE, performed back in c8abf00c
.
2022-12-30 03:25:16 -03:00
Jaizu
c40c7e7e65
Fix breaking modern, correct labels.
2022-12-29 16:11:17 +01:00
Jaizu
e2d47a07f5
Fix ANIM_SPRITE on regular builds with BUGFIX.
...
Dicussion about this being a BUGFIX define instead limiting it only to modern.
Credit SBird.
2022-12-29 12:28:44 +01:00
LOuroboros
0ef148dfbb
Applied more corrections
...
-Removed BattleScript_WindRiderActivatesEnd2
-Tweaked the condition of Wind Power in AbilityBattleEffects
-Renamed ApplySupremeOverlordModifier to GetSupremeOverlordModifier
2022-12-28 08:50:15 -03:00
LOuroboros
9bad91b167
Applied minor tweaks
...
-Made setbeakblast affect a specified battler instead of the gBattlerAttacker to justify the macro's layout.
-Added Shell Trap to the list of moves unaffected by Encore.
-Renamed CheckFocusPunch_ClearVarsBeforeTurnStarts into CheckChosenMoveForEffectsBeforeTurnStarts because that function doesn't just check for Focus Punch anymore, and it doesn't clear any variables either.
2022-12-28 08:33:31 -03:00
LOuroboros
f5c165ff0c
Updated Dire Claw's effect again
...
Thanks to MGriffin for providing a much nicer code for it.
2022-12-28 08:30:22 -03:00
LOuroboros
0159065dea
Removed Shell Trap
...
It's time to let it go for my own mental sanity.
Besides, it's a Gen. 7 move. I shouldn't have added it here.
2022-12-28 07:51:11 -03:00
GriffinR
d02d518917
Merge pull request #1829 from AsparagusEduardo/pret/doc/SaveBlockPadding
...
Documenting padding in structs used by Saveblocks
2022-12-27 20:50:37 -05:00
Eduardo Quezada
1fc86e52b5
Reverting P_SHINY_BASE_CHANCE implementation as it wasn't accuerate to Gen6+
2022-12-27 21:18:20 -03:00
Eduardo Quezada
95f39c8c81
Config to restore Gen 3's damage reduction to multi target moves
2022-12-27 15:24:43 -03:00
SphericalIce
200b71be02
Fix Beat Up's battle script to avoid an out-of-bounds array access
2022-12-27 10:49:57 +00:00
Eduardo Quezada
b0127428c6
Review suggestions.
2022-12-27 00:04:46 -03:00
Eduardo Quezada
701179eb1f
Documented missing use of SPRITE_ARR_ID_MOVE_SELECTOR1
2022-12-26 21:05:18 -03:00
Eduardo Quezada D'Ottone
263ed33755
Fixed Eggs sometimes reading garbage graphic data.
2022-12-26 11:56:27 -03:00
Eduardo Quezada D'Ottone
034ba7d5d2
Fixed usage of gBattleStruct->changedSpecies so its only used by player's party
2022-12-26 08:59:37 -03:00
SphericalIce
09d20bd634
Rename ball_display_unused_extra
2022-12-26 11:30:12 +00:00
Eduardo Quezada
d103025527
Merge branch 'RHH/upcoming' into RHH/pr/feature/palleteConversion2
...
# Conflicts:
# include/config/pokemon.h
2022-12-22 10:30:01 -03:00
LOuroboros
9972cce0ec
Updated MOVE_EFFECT_DIRE_CLAW
2022-12-21 20:05:10 -03:00
SonikkuA-DatH
c4db74460a
Update battle_util.c
...
Noted Protection Bypassing
2022-12-21 14:50:06 -08:00
LOuroboros
4bb86c5d96
Implemented Barb Barrage's effect
2022-12-21 19:48:50 -03:00
LOuroboros
1229fa752a
Fixed Triple Axe's target, added its effect and fixed Ceaseless Edge's
2022-12-21 19:48:49 -03:00
LOuroboros
2cb9400ef0
Implemented Dire Claw's effect
2022-12-21 19:48:48 -03:00
LOuroboros
3ce4869766
Implemented Shell Trap's effect
2022-12-21 19:48:10 -03:00
LOuroboros
ae482ed1f4
Implemented Ceaseless Edge's effect
2022-12-21 19:47:00 -03:00
LOuroboros
c40e15f8c5
Added Sheer Force check to Anger Shell
2022-12-21 19:43:41 -03:00
Eduardo Quezada D'Ottone
da535fc8f1
Merge pull request #2530 from mrgriffin/rhh-setroost-cleanup
...
Minor Roost fixes/cleanup
2022-12-21 17:04:14 -03:00
Eduardo Quezada
339d794324
Fixed compile and made table into struct
2022-12-21 16:46:32 -03:00
ghoulslash
dba1aa4f0b
fix ai helping hand
2022-12-21 12:05:38 -05:00
Eduardo Quezada
c0d4e14a61
Merge branch 'RHH/upcoming' into RHH/pr/feature/reworkScald
...
# Conflicts:
# include/config/battle.h
# include/constants/battle_move_effects.h
2022-12-21 12:46:09 -03:00
Eduardo Quezada
8840d0bbf6
Refactored incense baby checks into table and added Gen 9 config.
2022-12-21 12:31:59 -03:00
Eduardo Quezada D'Ottone
42d2bee519
Merge pull request #2527 from mrgriffin/rhh-cleanup-handle-terrain-move
...
Cleanup HandleTerrainMove
2022-12-21 12:21:46 -03:00
Martin Griffin
632ec92475
Minor Roost changes
...
- Fix 'mon with Flying in type3 but not type1 or type2 is set to
uninitialized roostTypes.
- Remove unread third roostTypes element.
- Option for Gen IV pure-Flying behavior.
2022-12-21 14:52:01 +00:00
LOuroboros
d943f891c5
Applied Wind Power and Wind Rider correction
...
-Renamed TryActivateWindRiderLoop to BattleScript_TryTailwindAbilitiesLoop
-Modified how it handles the check for Wind Rider by using a various and incorporated Wind Power into the mix because that ability is affected by Tailwind as well.
2022-12-21 10:08:16 -03:00
SonikkuA-DatH
405a42b246
Update battle_anim_effects_1.c
...
spacing
2022-12-20 18:17:49 -08:00
SonikkuA-DatH
8d28d23e74
Update src/battle_util.c
...
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2022-12-20 18:09:15 -08:00
Philipp AUER
766c0140ee
Refactor sInverseTypeEffectivenessTable to implicit lookup ( #2528 )
...
* [refactor, battle_util] replace sInverseTypeEffectivenessTable LUT by implicit lookup
* [review, style, squashme] update switch/case codestyle
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
* [review, squashme] merge code branches
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
Co-authored-by: sbird <sbird@no.tld>
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
Co-authored-by: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2022-12-20 22:48:41 -03:00
Martin Griffin
682c59869b
Cleanup HandleTerrainMove
2022-12-20 21:28:54 +00:00
LOuroboros
6153b8e904
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into dev_gen9_abilities
2022-12-20 07:11:36 -03:00
LOuroboros
c8abf00cac
Applied corrections
...
Anger Shell:
-Made it print a string from the gStatDownStringIds table while lowering Def and Sp. Def
-Made it use the shiny new modifybattlerstatstage macro.
-Made it activate multiple times per battle, as it should.
Well-Baked Body:
-Turned it into an absorbing ability.
Wind Rider:
-Turned it into an absorbing ability.
-For its Tailwind interaction, I made it activate only when Tailwind kicks in successfully, instead of whenever it's active at the end of a turn.
Guard Dog:
-Updated its check inside BattleScript_EffectHitEscape.
-Moved it from Cmd_forcerandomswitch to BattleScript_EffectRoar.
Wind Power:
-Split off its move end effect from Electromorphosis'.
Electromorphosis:
-Split off its move end effect from Wind Power's.
Hadron Engine:
-Merged its Switch In effect with Electric Surge's.
Protosynthesis:
-Fixed its stat boost.
Quark Drive:
-Fixed its stat boost.
Cud Chew:
-Updated its ENDTURN effect's berry check.
Supreme Overlord:
-Tweaked the looping i variable's data type, the order of the variables and the checks inside ApplySupremeOverlordModifier.
Earth Eater:
-Turned it into an absorbing ability.
Misc changes:
-Added a variable to set the amount of stat stages raised inside AbilityMoveEffects' case ABILITYEFFECT_ABSORBING.
-Added a preproc config to update the text string that they print.
-Limited the scope of atkHighestStat and defHighestStat in CalcMoveBasePowerAfterModifiers to Protosynthesis's and Quark Drive's effects.
2022-12-20 07:08:29 -03:00
SonikkuA-DatH
07a91b9e9b
Update src/battle_script_commands.c
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-19 17:18:43 -08:00
SonikkuA-DatH
459631eb96
Update src/battle_script_commands.c
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-19 17:18:23 -08:00
SonikkuA-DatH
6215d4b1b4
Update src/battle_script_commands.c
...
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-19 17:18:05 -08:00
SonikkuA-DatH
f6fab92ac8
Merge branch 'upcoming' into SonikkuA-DatH-Teatime2
2022-12-19 15:52:20 -08:00
Eduardo Quezada
1580f892a5
Merge branch 'RHH/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# include/constants/pokemon.h
# src/battle_script_commands.c
2022-12-19 18:53:26 -03:00
ghoulslash
79fa2c79e2
Merge pull request #2517 from LOuroboros/speed_swap
...
Fixed Speed Swap's effect
2022-12-19 08:56:36 -05:00
SonikkuA-DatH
bf1a205661
Update src/battle_script_commands.c
...
Bracket fixing
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-18 22:27:12 -08:00
SonikkuA-DatH
c81b702a86
Update src/battle_script_commands.c
...
Spacing refix
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-18 22:26:51 -08:00
SonikkuA-DatH
03b5d36249
Update src/battle_script_commands.c
...
removes various description
Co-authored-by: LOuroboros <lunosouroboros@gmail.com>
2022-12-18 22:26:06 -08:00
SonikkuA-DatH
6a2a026c70
Update battle_anim.h
...
Added required tags
2022-12-18 22:23:51 -08:00
SonikkuA-DatH
5682247ace
Add files via upload
...
Base upload. Need to apply Teatime changes...
2022-12-18 19:14:54 -08:00
SonikkuA-DatH
b97a68656c
Delete battle_anim.h
...
Need to replace with current...
2022-12-18 19:14:01 -08:00
SonikkuA-DatH
f0aee1f8d3
Merge branch 'upcoming' into SonikkuA-DatH-Teatime2
2022-12-18 17:50:39 -08:00
SonikkuA-DatH
44b522fd1c
Update battle_script_commands.c
...
Spacing
2022-12-18 15:53:07 -08:00
SphericalIce
17052d4547
Use the ITEM_NONE constant for the registeredItem save block field
2022-12-18 21:05:37 +00:00
Eduardo Quezada
bd7d949f5f
Fixed B_DOUBLE_WILD_CHANCE becoming 1% less than what's set
2022-12-18 13:49:02 -03:00
LOuroboros
089104cd9c
Update battle_script_commands.c
2022-12-18 10:35:58 -03:00
Eduardo Quezada
66d1c9bc65
Documenting padding in structs used by Saveblocks
2022-12-17 22:55:43 -03:00
LOuroboros
4f951b7887
Updated ENDTURN_PLASMA_FISTS
2022-12-17 03:44:19 -03:00
Eduardo Quezada
c03f354dca
Finished cleaning up the animations to the new standard
2022-12-16 20:58:41 -03:00
Eduardo Quezada
6a57dcdc4c
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pret_20221216
...
# Conflicts:
# src/data.c
# src/data/pokemon_graphics/front_pic_anims.h
2022-12-16 19:19:23 -03:00
Eduardo Quezada D'Ottone
0dca5a5230
Merge pull request #2516 from LOuroboros/patch-1
...
Updated SetMoveEffect
2022-12-15 18:10:08 -03:00
LOuroboros
852f06deea
Updated SIDE constant usages
2022-12-15 17:44:56 -03:00
GriffinR
347a02ace1
Sync trade
2022-12-15 15:40:59 -05:00
LOuroboros
7c447a1f62
Small corrections
2022-12-14 12:09:16 -03:00
LOuroboros
4c9446ed0a
Fixed Speed Swap's effect
2022-12-14 12:00:45 -03:00
LOuroboros
af6ea91e72
Applied Eduardo's suggestion
2022-12-14 10:48:12 -03:00
LOuroboros
37151e4a2d
Updated SetMoveEffect
2022-12-14 10:46:11 -03:00
LOuroboros
a3e58b05c1
Implemented Guard Dog's effect
2022-12-12 20:33:37 -03:00
LOuroboros
a56cfd1aa7
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into dev_gen9_abilities
2022-12-12 19:55:48 -03:00
ghoulslash
340278c83b
Merge pull request #2452 from LOuroboros/intimidate
...
Optimized Intimidate's code
2022-12-11 22:04:16 -05:00
Bassoonian
07a8af5975
Set FLAG_SYS_POKEMON_GET when debug gifting yourself a Pokémon
2022-12-11 22:09:23 +01:00
ghoulslash
e3e0d60222
Merge pull request #2467 from Bassoonian/gen9moves
...
Generation IX Moves
2022-12-11 14:47:47 -05:00
Eduardo Quezada
2f96344cd9
Removed ANIM_CMD macro from unused_anims.h
2022-12-10 11:46:41 -03:00
LOuroboros
0d1f9d9613
Reimplemented Mimicry
2022-12-09 20:46:18 -03:00
ghoulslash
04e9c181ad
add covert cloak check for stats
2022-12-06 12:42:01 -05:00
ghoulslash
2391150274
Revert "CreateAbilityPopup always records ability"
...
This reverts commit c8661a1bc1
.
2022-12-06 11:25:27 -05:00
ghoulslash
c8661a1bc1
CreateAbilityPopup always records ability
2022-12-06 11:24:04 -05:00
ghoulslash
c327655ef5
small fixes
2022-12-06 11:12:20 -05:00
ghoulslash
5a26a69ccd
add some RecordItemEffect and RecordAbilityBattle situations, ai checks
2022-12-06 11:00:57 -05:00
ghoulslash
bdb480765c
add ability shield check to mummy, wandering spirit
2022-12-06 10:50:33 -05:00
ghoulslash
b6258adc6d
fix ShouldLowerStat clear amulet check
2022-12-06 10:43:01 -05:00
ghoulslash
6d28882e44
start gen9 hold effects
2022-12-06 09:48:36 -05:00
LOuroboros
c287f4f016
Updated sAbilitiesAffectedByMoldBreaker
2022-12-06 06:22:02 -03:00
LOuroboros
107ace784b
Implemented Mycelium Might's effect
2022-12-06 06:18:18 -03:00
LOuroboros
d6b9f07681
Implemented Earth Eater's effect
2022-12-06 05:30:21 -03:00
LOuroboros
fa78e3b2c4
Implemented Armor Tail's effect
2022-12-06 05:26:30 -03:00
LOuroboros
a961980e0f
Implemented Toxic Debris' effect
2022-12-06 05:23:30 -03:00
LOuroboros
aa051dab02
Implemented Costar's effect
2022-12-06 05:23:30 -03:00
LOuroboros
7a52404fd3
Implemented Supreme Overlord's effect
2022-12-06 05:23:30 -03:00
LOuroboros
3c30e6bdc3
Implemented Sharpness' effect
2022-12-06 05:23:30 -03:00
LOuroboros
f96137eb5e
Implemented Cud Chew's effect
2022-12-06 05:23:30 -03:00
LOuroboros
18c30be838
Implemented Hadron Engine's effect
2022-12-06 05:23:30 -03:00
LOuroboros
dd90ab1911
Implemented Orichalcum Pulse's effect
2022-12-06 05:23:29 -03:00
LOuroboros
24465858a7
Implemented the 4 Ruin Abilities
2022-12-06 05:23:29 -03:00
LOuroboros
de05c4dd56
Implemented Good as Gold's effect
2022-12-06 05:23:29 -03:00
LOuroboros
e25f843db3
Implemented Quark Drive's effect
...
Also tweaked STRINGID_SUNLIGHTACTIVATEDABILITY and STRINGID_STATWASHEIGHTENED.
2022-12-06 05:23:29 -03:00
LOuroboros
a328088122
Implemented Protosynthesis' effect
...
Also turned GetHighestStatId into a global function since Protosynthesis' effect uses it.
2022-12-06 05:23:29 -03:00
LOuroboros
34cafa746c
Implemented Electromorphosis' effect
...
Also added a battle preproc config to check if the STATUS3_CHARGED_UP was already applied.
Pokémon Scarlet and Violet don't check if this status flag was already applied on the target of abilities like Electromorphosis (and Wind Power until proven otherwise.)
As a result, the game will trigger the ability multiple times if they're hit by a multihit move.
This directive makes the code end the ability effect preemptively if the target does have the status flag applied.
2022-12-06 05:23:29 -03:00
LOuroboros
88cae380d0
Implemented Wind Power's effect
2022-12-06 05:23:29 -03:00
LOuroboros
c1e232cbf6
Implemented Rocky Payload's effect
2022-12-06 05:23:29 -03:00
LOuroboros
4dc44150c5
Implemented Wind Rider's effect
2022-12-06 05:23:29 -03:00
LOuroboros
ca656b63b9
Added Well Baked Body's effect and misc. changes
...
-Added a modifybattlerstatstage macro to handle stat stages in battle.
-Rewrote the checks inside the case ABILITYEFFECT_MOVES_BLOCK of AbilityBattleEffects.
2022-12-06 05:21:24 -03:00
Eduardo Quezada D'Ottone
3718f58a0a
Merge pull request #2469 from LOuroboros/patch-1
...
Updated TryChangeBattleTerrain
2022-12-05 23:40:52 -03:00
LOuroboros
f9458117ee
Updated TryChangeBattleTerrain
2022-12-05 23:31:41 -03:00
Eduardo Quezada
2d694a84e3
Trying to fix remote reference
2022-12-05 21:57:28 -03:00
Bassoonian
8c77ae59d6
Use official Double Shock message
2022-12-04 21:57:02 +01:00
Bassoonian
06ab4fc842
Update move flags
2022-12-04 21:56:40 +01:00
Bassoonian
b0ead44ee8
Update battle_tv.c
2022-12-04 21:23:45 +01:00
Bassoonian
5bcb6b8afd
Update B_METRONOME_MOVES
2022-12-04 18:16:15 +01:00
Bassoonian
dc97a31c31
Change battle_debug.c to MOVES_COUNT
2022-12-04 18:15:35 +01:00
Bassoonian
c14fa82f43
Fix Headlong Rush description
2022-12-04 18:14:27 +01:00
Bassoonian
051ad7bf69
Update src/data/text/move_descriptions.h
...
Co-Authored-By: Eduardo Quezada D'Ottone <eduardo602002@gmail.com>
2022-12-04 00:26:05 +01:00
GriffinR
f55443656f
Add NUM_TILES_PER_METATILE
2022-12-03 17:29:02 -05:00
LOuroboros
eb082cd1a2
Implemented Purifying Salt's effect
2022-12-03 01:51:11 -03:00
LOuroboros
acb9c31bd4
Implemented Anger Shell's effect
2022-12-03 01:19:24 -03:00
LOuroboros
be71c4ca99
Implemented Thermal Exchange's effect
2022-12-03 01:15:31 -03:00
LOuroboros
b0027cb78b
Implemented Seed Sower's effect
2022-12-02 23:31:41 -03:00
LOuroboros
8dd3fd025f
Implemented Lingering Aroma's effect
...
And took the chance to tweak Mummy's.
2022-12-02 23:31:38 -03:00
LOuroboros
653364fd71
Added the basic data for the Gen. 9 Abilities
2022-12-02 23:01:22 -03:00
ghoulslash
6140cacbef
set BS_SCRIPING before BattleScript_TrainerSlideMsgRet
2022-11-29 18:28:33 -05:00
Eduardo Quezada
9d1149c423
Merge branch 'RHH/upcoming' into RHH/pr/sync/pretmerge_20221124
...
# Conflicts:
# src/pokemon.c
2022-11-29 17:40:09 -03:00
ghoulslash
4b799f2571
optimize BS_GetBattlerSide
2022-11-28 15:10:42 -05:00
ghoulslash
cd7abea6fe
fix BS_TrySymbiosis
2022-11-28 14:47:56 -05:00
ghoulslash
34ba9b4e0d
convert a few various to callnatives
2022-11-28 14:36:19 -05:00
ghoulslash
b869b836cc
add callnative bs func, convert metal burst dmg calc
2022-11-28 10:34:27 -05:00
ghoulslash
1037613b0e
Merge pull request #2418 from LOuroboros/zPP
...
Made Z-Moves unusable without PP
2022-11-28 09:52:28 -05:00
ghoulslash
ac30ebd5a4
Merge pull request #2453 from AsparagusEduardo/RHH/pr/cleanup/configShiny
...
Refactored Shiny configs + cleanup
2022-11-28 09:51:39 -05:00
tustin2121
cf6f343726
Use multi-include incbins for stormy_water
...
- Removes a special case rule from the make files.
2022-11-26 23:38:39 -05:00
LOuroboros
add75d84c0
Applied a couple of tweaks
...
-Made it so only Rare Candies can evolve Lv100 'mons. Game Freak dumb. The Exp. Candies SHOULD work too.
-Made sure to remove the candy that was used from the bag.
2022-11-25 18:12:51 -03:00
LOuroboros
53110a0ff6
Allow Lv100 'mons to access level based evos
2022-11-25 17:34:11 -03:00
Eduardo Quezada
4bac880042
Removed Unown hack
2022-11-25 16:55:53 -03:00
Eduardo Quezada
e858b4e709
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20221124
...
# Conflicts:
# include/battle.h
# src/battle_ai_script_commands.c
# src/battle_ai_switch_items.c
# src/battle_dome.c
# src/battle_main.c
# src/battle_pike.c
# src/battle_script_commands.c
# src/battle_tower.c
# src/data/pokemon/species_info.h
# src/pokemon.c
2022-11-24 15:36:00 -03:00
GriffinR
004ce32da0
Sync text ctrl codes with pokefirered
2022-11-23 21:13:00 -05:00
Eduardo Quezada
7999220361
Fixed modern compile
2022-11-22 18:37:38 -03:00
Eduardo Quezada
7327be6f9e
Made Types and Egg Groups into arrays
2022-11-22 17:05:25 -03:00
GriffinR
483c3d5c13
Document wonder news
2022-11-22 02:17:03 -05:00
Bassoonian
4ac1e4fc61
Power Shift is now a clone of Power Trick
2022-11-19 13:41:56 +01:00
GriffinR
4736b4b14d
Merge pull request #1810 from AsparagusEduardo/pret/pr/baseStatsRename
...
Renamed gBaseStats to gSpeciesInfo
2022-11-18 17:45:23 -05:00
GriffinR
5fa364256d
Merge pull request #1808 from AsparagusEduardo/pret/PR/numSides
...
Introduce NUM_BATTLE_SIDES
2022-11-18 17:39:00 -05:00
Bassoonian
4da9ecbcea
Prepare FLAG_SLICING_MOVE for merger with abilities branch
2022-11-18 22:37:31 +01:00
Bassoonian
4034f18c0e
Update PLA descriptions
2022-11-18 22:30:40 +01:00
Bassoonian
739680e425
Victory Dance effect
2022-11-18 22:23:34 +01:00
Bassoonian
29ae22183b
Mystical Power effect
2022-11-18 22:17:08 +01:00
Bassoonian
9512b3a57a
Implement Double Shock functionality with temporary string
2022-11-18 22:12:26 +01:00
Bassoonian
a250341e6c
Forgot to reset Wicked Torque effect rate
2022-11-18 22:00:46 +01:00
Bassoonian
3ac3cb249e
Wicked Torque effect
2022-11-18 22:00:21 +01:00
Bassoonian
d4c92a0a19
Fix Bitter Malice's effect
2022-11-18 21:54:46 +01:00
Bassoonian
ed33f2b9ce
Change PLA moves to SV effects
2022-11-18 20:56:25 +01:00
Bassoonian
e279185152
Update move data to GEN9 (with config)
2022-11-18 12:22:15 +01:00
Bassoonian
f7d1a12d2d
Data entry for gen9 moves
2022-11-18 12:15:44 +01:00
GriffinR
df470b75dd
Merge pull request #1817 from GriffinRichards/sync-wireless
...
Add cursor kind constants, sync wireless improvements
2022-11-17 15:18:20 -05:00
Eduardo Quezada
791c547b2c
Renamed missing overworld debug configs
2022-11-14 14:07:32 -03:00
Eduardo Quezada
540f4679bb
Implemented uses of Shiny config
2022-11-14 11:56:02 -03:00
Eduardo Quezada
011ec16f1e
Organized conffig files into their own folder and cleaned up
2022-11-14 11:03:49 -03:00
LOuroboros
11c99cac61
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2022-11-13 23:17:59 -03:00
LOuroboros
31a602f3b6
Optimized Intimidate's code
2022-11-12 18:03:46 -03:00
eatthepear
bd4b660983
Fix Berries that were broken after Bug Bite fix
...
Issue #2448
Haven't tested extensively, but regular Berries work and Bug Bite w/ Berries also works.
I believe this line was missing by accident (you can look at the merged Bug Bite PR #2433 to see that this line was deleted and never replaced).
2022-11-11 21:28:44 -05:00
LOuroboros
7260478c54
Uncommented level up moves
2022-11-11 01:31:22 -03:00
GriffinR
601bb0b578
Index gBattleFrontierHeldItems
2022-11-10 16:14:06 -05:00
GriffinR
3b1c8dfb17
Update list menu graphics
2022-11-09 19:44:58 -05:00
Eduardo Quezada
f2d0e547ac
Merge branch 'RHH/upcoming' into RHH/pr/sync/pretmerge_20221030
...
# Conflicts:
# src/rom_header_gf.c
2022-11-09 19:54:44 -03:00
Eduardo Quezada
bd63ef18af
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20221030
...
# Conflicts:
# src/pokemon_storage_system.c
2022-11-09 19:33:26 -03:00
GriffinR
e434b0047f
More missing constant usage
2022-11-09 15:53:47 -05:00
GriffinR
431a7ef8dd
Add missing cursorKind field usage
2022-11-09 15:37:47 -05:00
GriffinR
1d1c2d41bb
Add list menu cursor constants
2022-11-09 15:16:46 -05:00
GriffinR
b3e75138da
Sync wireless improvements
2022-11-09 15:14:18 -05:00
LOuroboros
a35986fd9c
Fixed indentation in ScrCmd_faceplayer
2022-11-08 21:01:50 -03:00
LOuroboros
999a53028a
Updated AnimTask_PrimalReversion
2022-11-08 09:38:27 -03:00
Eduardo Quezada D'Ottone
e6ae0bd01e
Merge pull request #2434 from LOuroboros/badDreams
...
Optimized Bad Dreams' code
2022-11-08 08:16:07 -03:00
tustin2121
33f3a7c11a
Adding FindObjectEventPaletteIndexByTag bugfix
...
The code in event_object_movement.c indicates that OBJ_EVENT_PAL_TAG_NONE was meant to be a sentinel for the bottom of each of the tables involving palettes in there. sObjectEventSpritePalettes is the exception, but the functions that access it look for OBJ_EVENT_PAL_TAG_NONE even though it's not in the table. If the palette tag isn't in the table, the functions which scan it fall off the bottom of the table into an infinite loop of scanning 256 "entries" of the table (because it uses a u8 index), and the game locks up. In vanilla, the search simply never falls off the bottom of the table. It seems the developers intended for that last entry to be {NULL, OBJ_EVENT_PAL_TAG_NONE}.
2022-11-07 06:09:21 -05:00
Eduardo Quezada
237877e21b
Doc missing uses of ST_OAM_OBJ_X in Pokémon Storage System
2022-11-07 00:00:23 -03:00
Eduardo Quezada
2ef2134be1
Moved Hunger Switch to form change table.
2022-11-06 17:12:34 -03:00
Eduardo Quezada
62912f8caf
Battle indicator now depends on species instead of held item
...
- This is to avoid a situation where a user would plop a Primal Groudon and its indicator would become Alpha if it doesn't have a Red Orb.
2022-11-06 16:01:07 -03:00
Eduardo Quezada
0eccbdf980
Primal Reversion at the beginning of a battle now happens in the switchin ability loop, making it happen by speed order.
2022-11-06 00:36:25 -03:00
Eduardo Quezada
712d41c752
Cleaned up move effect checks for Dragon Tail/Circle Throw
2022-11-05 23:51:59 -03:00
Eduardo Quezada
57bdb683ec
DoBurmyFormChange handled by FORM_CHANGE_END_BATTLE_TERRAIN
2022-11-05 23:27:40 -03:00
Eduardo Quezada
99536089cf
Renamed form change defines to be consistant with which function calls which
2022-11-05 22:02:25 -03:00
Eduardo Quezada
8f289714b2
Moved form change defines and descriptions to their own header
2022-11-05 21:36:45 -03:00
Eduardo Quezada
ceb5c8a00a
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/formBattleChange
...
# Conflicts:
# include/battle_util.h
# src/battle_util.c
2022-11-05 20:11:33 -03:00
Eduardo Quezada
42f8e8c114
Multiple refactors
...
- Added a general GetBattleFormChangeTargetSpecies instead of getting specific ones for Mega Evolution and Primal Reversion.
- Added FORM_CHANGE_BATTLE_HP_PERCENT, to replace ShouldChangeFormHpBased.
- Cleaned ifdefs for hold effects.
- Finally removed UndoMegaEvolution.
- FORM_CHANGE_FAINT and FORM_CHANGE_BATTLE_END restore to the first form before a battle form change if species isn't specified.
- When changing from a form with more HP to one with less, now current HP is kept to fix Zygarde edge case. (Will likely need to be reworked for Dynamax, as it behaves differently)
- Uses DoesSpeciesUseHoldItemToChangeForm in CanBattlerGetOrLoseItem.
2022-11-05 20:00:12 -03:00
BuffelSaft
1da4eb3b14
Merge pull request #2428 from AsparagusEduardo/RHH/pr/feature/DarkVoid
...
Config for Dark Void being only usable by Darkrai
2022-11-05 22:42:51 +13:00
BuffelSaft
bbd7b205fd
Merge pull request #2433 from ghoulslash/be/bug_bite
...
Redo Bug Bite
2022-11-05 22:08:47 +13:00
LOuroboros
f56df74576
Optimized Bad Dreams' code
...
Misc:
-Made the ability pop up stick around until the ability's effect ends just like in ORAS.
-Updated sText_BadDreamsDmg accordingly while I was at it.
2022-11-04 14:58:58 -03:00
Eduardo Quezada D'Ottone
fa8bf80905
Merge pull request #2420 from LOuroboros/teleport
...
Updated CanTeleport
2022-11-04 12:40:25 -03:00
Eduardo Quezada D'Ottone
2b5aff2764
Merge pull request #2426 from tustin2121-2/patch-linker
...
GF Header and Modern Builds
2022-11-04 12:27:13 -03:00
Eduardo Quezada
44bf4a15e3
Merge branch 'RHH/upcoming' into RHH/pr/feature/reworkScald
...
# Conflicts:
# include/constants/battle_config.h
# include/constants/battle_move_effects.h
2022-11-04 12:19:40 -03:00
BuffelSaft
d05c74b9e9
Merge pull request #2430 from AsparagusEduardo/RHH/pr/fix/BadDreams
...
Fixed Bad Dream's ability popup message
2022-11-05 03:42:44 +13:00
ghoulslash
7a0e541413
workaround for GetBattlerHoldEffectParam to handle bug bite different battler id
2022-11-04 10:29:05 -04:00
Eduardo Quezada
5b1552514e
Review changes
2022-11-04 11:10:06 -03:00
ghoulslash
1e6903840a
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into be/bugbite
2022-11-04 09:29:45 -04:00
ghoulslash
d13431b4ab
merge w rhh master
2022-11-04 09:29:39 -04:00
Eduardo Quezada
8c66b318eb
Fixed Bad Dream's ability popup message
2022-11-04 00:46:07 -03:00
Eduardo Quezada
d23b5c95c9
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/monAnimations
...
# Conflicts:
# src/data/pokemon_graphics/front_pic_anims.h
# src/pokemon.c
2022-11-03 23:31:20 -03:00
Eduardo Quezada
edf4e45c4d
Config for Dark Void being only usable by Darkrai
2022-11-03 21:36:12 -03:00
BuffelSaft
c169a9523e
Merge branch 'upcoming' into fix-stat-boost-on-hit
2022-11-03 22:01:30 +13:00
BuffelSaft
736ca893b6
Fix abilities that raise target's stat after hit
...
Fix Justified, Berserk, Rattled, Stamina and Water Compaction printing the wrong message when they activate. Steam Engine was also updated to follow the gen 5+ ability activation method style.
2022-11-03 21:54:56 +13:00
tustin2121
b32413d11e
Restoring the GFHeader
...
- Also adding comment about what the header does and how to maintain it.
2022-11-02 12:45:36 -04:00
tustin2121
fd87c97ef8
Adding documentation about GFHeader
2022-11-02 12:42:58 -04:00
Eduardo Quezada
271bff5675
Gen 5+ stat recalculate in the same party loop at the end of battle that changes forms.
2022-11-02 10:06:02 -03:00
Eduardo Quezada
8b0a848424
Zen Mode triggers at the beginning of a battle
2022-11-01 23:53:04 -03:00
Eduardo Quezada
15c12af2cf
Using TryBattleFormChange in place of certain TryFormChange
2022-11-01 23:50:26 -03:00
LOuroboros
86e322dcea
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into iceFaceRedux
2022-11-01 22:41:31 -03:00
Eduardo Quezada D'Ottone
b8371500d3
Merge pull request #1676 from BuffelSaft/multistrike
...
Multi-hit refactor and Parental Bond
2022-11-01 21:16:04 -03:00
ghoulslash
53061c7d62
Merge pull request #2391 from AsparagusEduardo/RHH/pr/sugardoodoodoodoodoodooaahhoneyhoney
...
Implemented Honey's Sweet Scent functionality
2022-11-01 20:09:30 -04:00
ghoulslash
c6cb54b54e
Merge pull request #2319 from AsparagusEduardo/RHH/pr/Lures
...
Implemented Lures and Repel/Lure "use another" menu
2022-11-01 20:05:15 -04:00
Eduardo Quezada
797c5514d3
Mega Evolution in form change tables
2022-11-01 18:37:23 -03:00
Eduardo Quezada
fa8b1b9c05
Updated descriptions of form change constants
2022-11-01 15:02:45 -03:00
Eduardo Quezada
f5b900e2ef
Defaults Primal Reversion indicator to Alpha when item not Red Orb.
2022-11-01 15:02:22 -03:00
Eduardo Quezada
a57f6d184b
Fainting by poison in the overworld reverts forms
2022-11-01 12:24:04 -03:00
Eduardo Quezada D'Ottone
ebc9fc31d2
Merge pull request #2416 from DizzyEggg/fix_palace
...
Fix battle palace bug
2022-11-01 12:16:55 -03:00
DizzyEggg
51d8b57dcc
restore deleted line
2022-10-31 13:19:10 +01:00
DizzyEggg
ea43b7732c
Fix battle tent again
2022-10-31 13:16:48 +01:00
Eduardo Quezada D'Ottone
9d64c838cf
Merge pull request #2424 from LOuroboros/getItemId
...
Actually removed ItemId_GetId
2022-10-31 07:15:25 -03:00
LOuroboros
52dda5fc0f
Actually removed ItemId_GetId
2022-10-30 22:52:22 -03:00
LOuroboros
5ebc996c51
Removed worthless DEBUG_FLAG_PC_FROM_DEBUG_MENU config
2022-10-30 22:03:14 -03:00
Eduardo Quezada
14e85249d1
Review changes
2022-10-30 17:12:13 -03:00
Eduardo Quezada
d02fc43703
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20221030
2022-10-30 13:38:25 -03:00
GriffinR
d90132842a
Update gitignore/spacing for new region map data
2022-10-30 12:22:41 -04:00
Eduardo Quezada
e4a439aa46
Merge remote-tracking branch 'pret/master' into RHH/pr/sync/pretmerge_20221030
...
# Conflicts:
# src/data/bard_music/moves.h
# src/data/bard_music/pokemon.h
2022-10-30 12:30:38 -03:00
Eduardo Quezada
3172273c73
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/Lures
...
# Conflicts:
# src/pokemon.c
2022-10-30 12:16:09 -03:00
GriffinR
c76beed989
Merge pull request #1807 from pret/porymap-5
...
Update for Porymap 5.0.0
2022-10-30 11:01:37 -04:00
LOuroboros
a74a8fa134
Updated CanTeleport
2022-10-29 16:13:40 -03:00
LOuroboros
bdd082f869
Made Z-Moves unusable without PP
2022-10-29 12:07:59 -03:00
DizzyEggg
215604f5f7
fix battle palace bug
2022-10-27 20:44:43 +02:00
Eduardo Quezada
85c0d2dac8
Review changes
2022-10-27 11:26:09 -03:00
BuffelSaft
224ca256ce
Requested clean up
...
Rename constants, remove white space, improve B_BEAT_UP description.
* Rename B_BEAT_UP_DMG to B_BEAT_UP
* Shorten B_PARENTAL_BOND_DAMAGE to B_PARENTAL_BOND_DMG
* Remove trailing whitespace
* Replace boolean 1 with TRUE in MOVEEND_MULTIHIT_MOVE
2022-10-27 22:25:33 +13:00
Eduardo Quezada D'Ottone
93dd8786ee
Merge pull request #2413 from kaisermg5/fix_tmhm_lock
...
Fix lock when teaching a TM/HM after learning a move by level up.
2022-10-26 22:27:19 -03:00
kaisermg5
2cd0a0f862
Fix lock when teaching a TM/HM after learning a move by level up.
2022-10-25 18:48:06 -03:00
Eduardo Quezada
85ce30b1d6
Created macros for Bard Sounds
2022-10-25 14:33:02 -03:00
Eduardo Quezada
3ed485632f
Renamed gBaseStats to gSpeciesInfo
2022-10-24 17:01:48 -03:00
BuffelSaft
d9cc98a4fe
Suggested changes
...
- Various style fixes
- Add BATTLE_ALIVE_EXCEPT_ATTACKER case to CountAliveMonsInBattle
2022-10-24 22:19:35 +13:00
BuffelSaft
7bca475d77
Add Misty Explosion to Parental Bond ban list
...
Probably not needed, but just in case!
2022-10-23 21:48:20 +13:00
BuffelSaft
9b076a9dcf
Fix spread moves, tidy up CANCELLER_MULTIHIT_MOVES
...
- Parental Bond spread moves should now strike twice whenever there is a single target, even if the target is the user's ally.
- Random chance to hit 2-5 times is now set in SetRandomMultiHitCounter().
2022-10-23 21:40:04 +13:00
BuffelSaft
1b056f9044
Fix various Parental Bond issues
...
- Dragon Tail and Circle Throw strike twice and then switch the target
- Z moves are unaffected by Parental Bond
- Renamed parentalBondOn to parentalBondState
- Added constants for possible values of parentalBondState
- Fixed broken stat change animations and removed unused MOVE_EFFECT_SKY_DROP
2022-10-23 17:37:23 +13:00
LOuroboros
c267c615c1
Fixed CanFling
2022-10-22 10:38:39 -03:00
BuffelSaft
6035c5a280
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald into multistrike
2022-10-22 14:31:13 +13:00
Eduardo Quezada
0a79390ec0
Primal Reversion in Form Change tables
2022-10-21 02:08:37 -03:00
Eduardo Quezada
861590f747
Form change when fainting. Goodbye UndoFormChange!
2022-10-20 18:53:12 -03:00
Eduardo Quezada
d8cc7f7abe
Form change when switching out
2022-10-20 17:56:56 -03:00
Eduardo Quezada
b74f0777da
Renamed form change constants
2022-10-20 17:22:58 -03:00
Eduardo Quezada
ff494edb85
Refactored ItemUseOutOfBattle_FormChange to not use secondaryId
2022-10-20 16:57:34 -03:00
Eduardo Quezada
620e69945d
Form change for starting and ending battles. Adjusted PP for Iron Head/Behemoth moves
2022-10-20 16:40:24 -03:00
GriffinR
e752c8a2f9
Merge pull request #1805 from tustin2121/tustin2121-patch-runimmedeately
...
Document seldom-used trigger functionality
2022-10-20 11:45:35 -04:00
Eduardo Quezada D'Ottone
18e7fc5efc
Introduce NUM_BATTLE_SIDES
2022-10-20 08:41:18 -03:00
GriffinR
3e8baa5b04
Merge branch 'master' into porymap-5
2022-10-18 22:54:25 -04:00
GriffinR
a418f8d976
Merge pull request #1755 from GriffinRichards/map-dynamic
...
Rename special map constants, treat warp ids as strings
2022-10-18 22:45:56 -04:00
tustin2121
4730870646
VAR_RUN_TRIGGER_IMMEDIATELY -> TRIGGER_RUN_IMMEDIATELY
...
Getting rid of the VAR_ prefix, to avoid the porymap problem.
2022-10-18 21:12:31 -04:00
GriffinR
e33581ff9c
Merge pull request #1671 from sphericalice/heal-location-none
...
Add the HEAL_LOCATION_NONE constant
2022-10-18 18:41:04 -04:00
Abaresk
7f09894045
Merge branch 'master' into thunder
2022-10-18 04:37:56 +00:00
Marcus Huderle
0d0a9bd31d
Update src/overworld.c
...
Co-authored-by: GriffinR <griffin.g.richards@gmail.com>
2022-10-17 17:41:27 -07:00
Marcus Huderle
48ab684b48
Fix weather color map documentation
2022-10-17 17:41:27 -07:00
GriffinR
716025395c
Merge pull request #1802 from abaresk/wild-encounters
...
Document new metatile wild encounter odds
2022-10-17 18:56:58 -04:00
Eduardo Quezada D'Ottone
c57ab9e529
Merge pull request #2392 from gruxor/wait-fix
...
Replaced busy-wait loops
2022-10-17 15:34:22 -03:00
gruxor
610a8efb7d
Replaced busy-wait loops
2022-10-17 11:21:06 -04:00
tustin2121
327c648e87
Document seldom-used trigger functionality
...
Added a define for use in overworld triggers where the goal is to run the provided script in the immediate script context instead of the global one like normal. This is used in triggers in the desert, on faraway island, and a couple other places to do weather effects quickly and on the same frame. Suggestions for a better define name are welcome.
2022-10-16 20:46:50 -04:00
Eduardo Quezada D'Ottone
1607291982
Implemented Honey's Sweet Scent functionality
2022-10-16 20:20:13 -03:00
ghoulslash
ede6162724
Merge pull request #2388 from AsparagusEduardo/RHH/pr/running
...
Config for running indoors
2022-10-16 09:28:32 -04:00
Eduardo Quezada D'Ottone
dd2d6107bd
Fixed Z-Move not being cleared if Pokémon faints
2022-10-16 09:57:21 -03:00
Abaresk
e67d55bfc4
Fix names
2022-10-15 13:37:24 +00:00
Abaresk
b538239f18
Add more documentation to thunder weather
2022-10-15 04:25:35 +00:00
Eduardo Quezada D'Ottone
4cbc6d4de1
Config for running indoors
2022-10-14 22:31:45 -03:00
LOuroboros
8a1a561b80
Uncommented evo moves for each species
2022-10-14 11:28:15 -03:00
ghoulslash
d64e18d0b4
Merge pull request #2385 from LOuroboros/trainerClassBasedBalls
...
Added class-based Poké Balls for trainers
2022-10-14 10:19:20 -04:00
LOuroboros
90f79999bb
Added class-based Poké Balls for trainers
...
Thanks to Ghoulslash for helping me optimizing things.
2022-10-14 11:14:30 -03:00
GriffinR
2e128e3282
Merge pull request #1799 from AsparagusEduardo/pret/pr/recordedInvalid
...
Moved ILLEGAL_BATTLE_TYPES to include\constants\battle.h and renamed it to BATTLE_TYPE_RECORDED_INVALID
2022-10-13 14:30:18 -04:00
GriffinR
722e501b7c
Merge pull request #1800 from AsparagusEduardo/pret/pr/gSoftResetDisabled
...
Documented missing gSoftResetDisabled uses
2022-10-13 14:29:43 -04:00
Eduardo Quezada D'Ottone
71dad6aec9
Merge pull request #2384 from May8th1995/confuseAI
...
Fix AI issue giving decrementing score to confuse hit instead of confuse
2022-10-13 12:16:00 -03:00
tennis
db013aab0b
Fix AI issue giving decrementing score to confuse hit instead of confuse
2022-10-13 15:58:57 +01:00
tennis
f79205af08
Fix bug where badge boost flag is inverted
2022-10-13 15:32:08 +01:00
Abaresk
af081b08ee
Make related func names more concise
2022-10-12 04:35:23 +00:00
Abaresk
11e3f03bd8
Document new metatile wild encounter odds
2022-10-12 04:03:02 +00:00
GriffinR
60e1ad20e4
Add NUM_MON_PIC_FRAMES, and trainer pic size constants
2022-10-10 23:16:08 -04:00
Kurausukun
dc97eca92d
combine "unused" field into tile buffer
2022-10-10 21:00:31 -04:00
GriffinR
bd023b1c6c
Merge pull request #1796 from GriffinRichards/tilesets-c
...
Convert tilesets.s to C
2022-10-10 12:47:47 -04:00
GriffinR
65d3944a93
Give tileset palettes proper type, name compressed secret base tiles
2022-10-08 02:02:12 -04:00
Eduardo Quezada D'Ottone
2ce340e8e1
Merge pull request #2262 from LOuroboros/becomingAHero
...
Fixed Mega Evolved Pokémon being able to get Friendship effects in battle
2022-10-07 18:27:29 -03:00
LOuroboros
589c969e89
Removed unused access to struct MegaEvolutionData in GetBattlerFriendshipScore
2022-10-07 18:20:00 -03:00
ghoulslash
06bddbac23
Merge pull request #2379 from AsparagusEduardo/RHH/pr/pretmerge_20221007
...
One for the go! (pret merge 2022/10/07)
2022-10-07 17:14:00 -04:00
ghoulslash
9164f03f96
Merge pull request #2141 from Sneed69/Triple-Kick-Fix
...
Triple kick power calc rework
2022-10-07 16:31:50 -04:00
Eduardo Quezada
044898fe95
Documented missing gSoftResetDisabled uses
2022-10-07 15:56:00 -03:00
Eduardo Quezada
453da8aa8c
Moved ILLEGAL_BATTLE_TYPES to include\constants\battle.h and renamed it to BATTLE_TYPE_RECORDED_INVALID
2022-10-07 15:49:00 -03:00
Eduardo Quezada
77f24d42e4
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/reworkScald
...
# Conflicts:
# include/constants/battle_config.h
2022-10-07 15:39:02 -03:00
Eduardo Quezada
44754f8ca7
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/feature/palleteConversion2
...
# Conflicts:
# include/constants/pokemon_config.h
# src/data/pokemon_graphics/back_pic_table.h
# src/data/pokemon_graphics/palette_table.h
# src/data/pokemon_graphics/shiny_palette_table.h
# src/pokemon_icon.c
2022-10-07 15:27:16 -03:00
Eduardo Quezada
2a8048b677
Removed ItemId_GetId like in upstream
2022-10-07 14:53:58 -03:00
Eduardo Quezada
68b474c0f0
Merge remote-tracking branch 'pret/master' into RHH/pr/pretmerge_20221007
...
# Conflicts:
# include/constants/items.h
# src/battle_interface.c
2022-10-07 14:52:32 -03:00
Eduardo Quezada
9b977486fe
Merge remote-tracking branch 'RHH_origin/upcoming' into RHH/pr/pokemonConfig
...
# Conflicts:
# src/data/pokemon/base_stats.h
2022-10-07 14:05:45 -03:00
LOuroboros
50ca188cb2
Replaced didMegaEvo with a shiny new species flag
2022-10-07 12:32:36 -03:00
LOuroboros
02c6bc64b2
Merge branch 'upcoming' of https://github.com/rh-hideout/pokeemerald-expansion into becomingAHero
2022-10-07 12:20:52 -03:00
ghoulslash
441586f23f
Merge pull request #2293 from AsparagusEduardo/RHH/pr/pokemonFlags
...
4 new species flags
2022-10-07 10:55:43 -04:00
ghoulslash
d7f7fa7d07
Merge pull request #2376 from AsparagusEduardo/RHH/pr/feature/ballsMulti
...
Changed ballMultiplier to account for future Hisuian ball multipliers
2022-10-07 10:48:02 -04:00
ghoulslash
1e04c80dfa
Merge pull request #2367 from AsparagusEduardo/RHH/pr/feature/MewTeach
...
Special handling for Mew's Teachable moveset
2022-10-07 10:39:56 -04:00
ghoulslash
7c7eb8ac7f
Merge pull request #2365 from AsparagusEduardo/RHH/pr/BattleArenaBide
...
Added missing Bide exception to Battle Arena Mind Points
2022-10-07 10:32:47 -04:00
ghoulslash
923046c993
Merge pull request #2359 from AsparagusEduardo/RHH/pr/pretmerge_20220925
...
I don't have any Sunday memes (pret merge 2022-09-25)
2022-10-07 10:25:59 -04:00
GriffinR
bb2e64b3fc
Merge pull request #1786 from tustin2121/patch-spritestuff
...
Subsprite Tables Documentation
2022-10-06 22:17:32 -04:00
tustin2121
ea168d1a6b
Fix typo 2: revelations
2022-10-06 20:34:46 -04:00
tustin2121
f3bddd1ea6
Fix typo
2022-10-06 19:36:01 -04:00
GriffinR
e293986fbb
Merge pull request #1793 from GriffinRichards/clean-shop
...
Clean up shop.c
2022-10-06 17:24:53 -04:00
GriffinR
c6e4c29ea3
Merge pull request #1792 from GriffinRichards/display-tiles
...
Add DISPLAY_TILE_* constants
2022-10-05 20:44:28 -04:00
Eduardo Quezada
a20334f79a
Removed unused functions in item header
2022-10-04 22:06:07 -03:00
Eduardo Quezada
e8ed0bd9f2
Changed ballMultiplier to account for future Hisuian ball multipliers
2022-10-04 20:39:45 -03:00
Eduardo Quezada D'Ottone
d0895a7c32
Merge pull request #2370 from StephenLynx/master
...
Fixed berserk not activating if mon falls to exactly half HP.
2022-10-01 21:30:44 -03:00
Sérgio Augusto Vianna
764bed6580
Fixed berserk not activating if mon falls to exactly half HP.
2022-10-01 20:50:55 -03:00
Eduardo Quezada D'Ottone
af171eb4d4
Merge remote-tracking branch 'pret/master' into RHH/pr/pretmerge_20220925
...
# Conflicts:
# src/pokemon_summary_screen.c
2022-10-01 17:32:32 -03:00
GriffinR
e989879f71
Use window constants in battle_dome
2022-09-29 22:17:44 -04:00
GriffinR
7587963d24
Use window constants in berry_fix_program
2022-09-29 19:09:50 -04:00
GriffinR
7449525428
Use window constants in wallclock
2022-09-29 18:56:34 -04:00
GriffinR
77c3163cf0
Use window constants in reset_rtc_screen
2022-09-29 18:29:20 -04:00
GriffinR
7d4fddd56b
Use window constants in mystery_event_menu
2022-09-29 15:55:26 -04:00
GriffinR
fb87616e9d
Use window constants in mystery_gift_menu
2022-09-29 15:48:19 -04:00
GriffinR
79a34411ce
Add additional DISPLAY_TILE_WIDTH usage
2022-09-29 15:22:21 -04:00
GriffinR
5af7355fbd
Clarify window ID usage in contest_util
2022-09-29 15:10:32 -04:00
GriffinR
6bc1955c99
Use window constants in easy_chat
2022-09-29 15:03:44 -04:00
GriffinR
c719d5d9b1
Use window constants in link
2022-09-29 14:50:51 -04:00
GriffinR
9ae918bb35
Use window constants in field_region_map
2022-09-29 13:37:32 -04:00
GriffinR
2cd07d80b8
Use window constants in wireless_communication_status_screen
2022-09-29 13:31:01 -04:00
GriffinR
81defb5986
Use window constants in union_room_chat
2022-09-29 13:20:35 -04:00
GriffinR
4af1044439
Use window constants in region_map
2022-09-29 13:11:38 -04:00
GriffinR
1f225286d5
Use window constants in party_menu
2022-09-29 12:55:31 -04:00
GriffinR
9f5704b05a
Use window constants in trainer_card
2022-09-29 12:30:10 -04:00
GriffinR
dd5daa3208
Use window constants in berry_blender
2022-09-29 12:15:17 -04:00
GriffinR
16be1e8447
Use window constants for move relearner
2022-09-29 12:10:10 -04:00
sbird
8dad7cc649
[doc] clean up casts in decompress.c
2022-09-29 17:33:39 +02:00
GriffinR
f254df9a1a
Use window constants in berry_tag_screen
2022-09-29 11:28:27 -04:00
Eduardo Quezada
90ad11278d
Sorry Mewtwo ^^;
2022-09-28 09:17:10 -03:00
Eduardo Quezada
d24899369f
Special handling for Mew's Teachable moveset
2022-09-28 09:04:31 -03:00
GriffinR
6db489e2d5
Use constants for overworld object palette slots
2022-09-27 20:16:48 -04:00
GriffinR
4f407a1066
Convert tilesets.s to C
2022-09-27 17:23:26 -04:00
Eduardo Quezada
ecad6ff0db
Merge remote-tracking branch 'RHH_origin/breaking' into RHH/pr/breaking/palleteConversion2
2022-09-27 10:46:49 -03:00
Eduardo Quezada
fb9105f8ac
Added Mega Evolution flag
2022-09-27 10:21:26 -03:00
Eduardo Quezada
3d214f8204
Merge remote-tracking branch 'RHH_origin/dev' into RHH/pr/pokemonFlags
...
# Conflicts:
# src/pokemon.c
2022-09-27 10:13:32 -03:00
Eduardo Quezada
5ca1b927e6
Added missing Bide exception to Battle Arena Mind Points
2022-09-27 08:13:32 -03:00
ghoulslash
253234378c
trace records target ability
2022-09-26 23:46:41 -04:00
ghoulslash
6e276b5f4d
Merge pull request #2339 from AsparagusEduardo/RHH/pr/MindRatings
...
Extrapolated Battle Arena's move Mind ratings
2022-09-26 21:04:16 -04:00
Eduardo Quezada
ae21e1626e
Reworked Mind Points
2022-09-26 21:20:08 -03:00
GriffinR
e515e52abb
Add DISPLAY_TILE_* constants
2022-09-26 19:52:17 -04:00
ghoulslash
ff42806e04
Merge pull request #2335 from AsparagusEduardo/RHH/pr/MultiBattleFix
...
Multi battle interface fix
2022-09-26 09:12:40 -04:00
ghoulslash
8ecdf68491
Merge pull request #2360 from TheXaman/rhh_pokemon_debug_fix
...
Fixes: Pokémon Debug isn't loading female icon palettes correctly
2022-09-26 09:09:14 -04:00
Eduardo Quezada
dfdfb72365
Separate config for updated move types
2022-09-26 07:50:43 -03:00
TheXaman
886a487bf1
Added LoadMonIconPalettePersonality to load gender specific pokemon icon palettes
2022-09-26 12:40:30 +02:00
GriffinR
f0744641d1
Merge pull request #1651 from garakmon/entry_json
...
use json for region map sections
2022-09-25 21:56:09 -04:00
GriffinR
171367d66c
Merge pull request #1643 from cbt6/object-event-graphics-info
...
Format object event graphics info
2022-09-25 21:55:22 -04:00
GriffinR
45e6b48170
Merge pull request #1636 from GriffinRichards/rme-update
...
Updates to region map for Porymap
2022-09-25 21:54:26 -04:00
Eduardo Quezada
5054cf3586
Documented unk40EF in Summary Screen
2022-09-25 21:33:20 -03:00
GriffinR
56c28fb2dd
Move region map gitignore to existing data gitignore
2022-09-25 18:15:16 -04:00
GriffinR
e473aaf783
Merge branch 'master' of https://github.com/pret/pokeemerald into entry_json
2022-09-25 18:10:04 -04:00
Eduardo Quezada
057f76bfe6
Cleaned up missing JOY macros
2022-09-25 13:05:18 -03:00
GriffinR
7223dbd62f
Merge branch 'master' into rme-update
2022-09-25 11:56:57 -04:00
Eduardo Quezada
f969effd36
Merge remote-tracking branch 'pret/master' into RHH/pr/pretmerge_20220925
2022-09-25 12:51:39 -03:00
Eduardo Quezada D'Ottone
3b983aae14
Apply suggestions from code review
2022-09-25 08:31:24 -03:00
LOuroboros
a9ab3286ef
Fixed IsPlayerInFrontOfPC
2022-09-25 05:51:08 -03:00
Eduardo Quezada
0f35f080ec
Gender icon in naming screen based on Pokémon name length
2022-09-24 23:48:24 -03:00
LOuroboros
8e9bfda120
Update field_specials.c
2022-09-24 22:22:18 -03:00
Eduardo Quezada D'Ottone
13573b6e53
Merge pull request #2356 from LOuroboros/PeeC
...
Modified the debug menu's PC access
2022-09-24 22:18:21 -03:00
LOuroboros
00eb67608a
Small tweak to the new check in PCTurnOffEffect
2022-09-24 22:10:46 -03:00
LOuroboros
5500e64a71
Reworked the debug menu's PC access
2022-09-24 17:26:41 -03:00
Eduardo Quezada D'Ottone
17c8842ad4
Merge branch 'dev' into teleport
2022-09-24 14:39:21 -03:00
Eduardo Quezada D'Ottone
38df216ebd
Merge pull request #2355 from ghoulslash/be/aiparty
...
Add overwrittenAbilities field
2022-09-24 14:33:02 -03:00
Eduardo Quezada D'Ottone
0fa8e20d08
Style changes from upstream
2022-09-24 14:20:07 -03:00
ghoulslash
c22671d2a2
add overwrittenAbilities field
2022-09-24 12:12:31 -04:00
Eduardo Quezada D'Ottone
a483899043
Merge branch 'dev' into symbiosis
2022-09-24 11:58:35 -03:00
Eduardo Quezada D'Ottone
d59d8b92af
Merge branch 'dev' into AI
2022-09-24 11:07:09 -03:00
Eduardo Quezada D'Ottone
bb564d805f
Merge pull request #2353 from LOuroboros/siTypes
...
Fixed Z-Moves showing the wrong type in battle
2022-09-24 10:36:38 -03:00
LOuroboros
696d90880e
Made Z-Moves always show the right type
2022-09-24 09:33:31 -03:00
LOuroboros
64405250ae
Updated IsViableZMove
2022-09-24 08:50:48 -03:00
GriffinR
9b6b164aad
Merge pull request #1768 from SBird1337/feature/mgba-print
...
[debug] add support for mgba printf
2022-09-23 13:49:48 -04:00
sbird
343d7f7d26
[debug] do not use heap allocation for MgbaPrintf
2022-09-23 04:12:57 +02:00
Eduardo Quezada
7e112b0f0d
Added missing uses of JOY_xx macros
2022-09-22 21:43:33 -03:00
GriffinR
1107ff954d
Clean up shop.c
2022-09-22 15:08:17 -04:00
GriffinR
b8341558c3
Merge pull request #1779 from GriffinRichards/sync-fld-weather
...
Add misc constant usage to field_weather_effect
2022-09-22 12:13:07 -04:00
GriffinR
9bcc36fe08
Merge pull request #1767 from GriffinRichards/trainer-pals
...
Generate trainer pic palettes from image
2022-09-22 11:34:03 -04:00
StubbornOne
cad8922d7b
Replace battle-type flags in GetAiLogicData with BATTLE_TYPE_HAS_AI
2022-09-21 23:42:40 +08:00
LOuroboros
d04a852e91
Update debug.c
2022-09-20 02:31:20 -03:00
Eduardo Quezada D'Ottone
24aebf0624
Merge pull request #2337 from LOuroboros/patch-2
...
Renamed some misclassified labels in src/debug.c
2022-09-19 14:33:51 -03:00
Eduardo Quezada D'Ottone
6868d8aa2a
Merge pull request #2338 from LOuroboros/BoxMonMon
...
Fixed typo in BoxMonKnowsMove
2022-09-19 14:33:12 -03:00
Eduardo Quezada
192312d7ee
Extrapolated Battle Arena's move Mind ratings
2022-09-19 14:29:22 -03:00
LOuroboros
5f67335212
Fixed typo in BoxMonKnowsMove
2022-09-19 05:21:54 -03:00
LOuroboros
c137b01dd8
Update debug.c
2022-09-19 04:19:19 -03:00
ghoulslash
add3625589
fix natural cure, shed skin, early bird check in ShouldSwitchIfGameStatePrompt
2022-09-18 22:47:30 -04:00
Eduardo Quezada
adb4e54e95
Fixed multi battle battler coordinates and party menu when only one Pokémon is chosen
2022-09-18 22:34:06 -03:00
Eduardo Quezada D'Ottone
681ad8c7a9
Merge remote-tracking branch 'RHH_origin/dev_1.x' into RHH/pr/pokemonConfig
...
# Conflicts:
# src/data/pokemon/form_change_table_pointers.h
# src/data/pokemon/form_change_tables.h
# src/data/pokemon/form_species_table_pointers.h
# src/data/pokemon_graphics/back_pic_coordinates.h
# src/data/pokemon_graphics/front_pic_coordinates.h
2022-09-18 18:25:05 -03:00
Eduardo Quezada D'Ottone
41ae8ecdb7
Update src/battle_controller_opponent.c
2022-09-18 00:51:34 -03:00
Eduardo Quezada D'Ottone
293a880238
Apply suggestions from code review
2022-09-18 00:50:21 -03:00
Ct11217
5f74781a7d
Remove ACE_POKEMON_FUNCTIONALITY
2022-09-17 17:44:50 -06:00
tustin2121
5c55e44173
More diagrams
...
- Diagramed all subsprite tables in the code base. There's a LOT in the slot machine code.
2022-09-17 14:34:20 -04:00
tustin2121
c371a44a83
Formatting
2022-09-17 13:34:54 -04:00
tustin2121
13877f71dc
Minor documentation
...
Some things I figured out while working on my hack.
- The Subsprite tables do not use `DISPLAY_WIDTH`, but rather use -16, since they are signed bytes. The negative numbers better illustrate what the tables are doing.
- Figured out the as-of-yet undocumented data in SpriteCB_FlygonSilhouette
2022-09-17 13:33:10 -04:00
Eduardo Quezada
8a68596b64
Removed free macro
2022-09-16 20:36:44 -03:00
Eduardo Quezada
e412ec30a0
Removed calloc macro
2022-09-16 20:34:22 -03:00
Eduardo Quezada
63156b4398
Removed malloc macro
2022-09-16 20:24:26 -03:00
Eduardo Quezada
b2b308fe9e
Fixed Old Rod Lure swap
2022-09-16 15:16:51 -03:00
Eduardo Quezada
b0bd5f9879
Cleaned up trailing spaces and spaces instead of tabs
2022-09-16 14:42:11 -03:00
Eduardo Quezada
720cb249d6
Merge remote-tracking branch 'RHH_origin/dev' into RHH/pr/reworkScald
...
# Conflicts:
# include/constants/battle_config.h
2022-09-16 12:06:06 -03:00
ghoulslash
8bbe1b9037
Merge pull request #2327 from AsparagusEduardo/RHH/pr/Metronome
...
Config to limit the moves called by Metronome (by generation)
2022-09-16 11:03:33 -04:00
Eduardo Quezada
6b79c7772c
Merge branch 'RHH/dev' into RHH/pr/pretmerge_20220909
...
# Conflicts:
# src/battle_interface.c
2022-09-16 11:56:50 -03:00
Eduardo Quezada
672f572ff8
Config to limit the moves called by Metronome (by generation)
2022-09-16 11:04:30 -03:00
Eduardo Quezada
77696ca686
Rolled EFFECT_SCALD into EFFECT_BURN_HIT with a config for its Gen6+ change
2022-09-16 10:31:02 -03:00
Ct11217
cc4a9b9f4b
Recommit to Dev branch
2022-09-15 22:57:29 -06:00
ghoulslash
ed81ec41bc
Merge pull request #2324 from ghoulslash/be/aiswitch
...
fix ai switch semi invulnerable
2022-09-15 23:15:02 -04:00
ghoulslash
95a3ead254
styling fix
2022-09-15 22:10:39 -04:00
Eduardo Quezada D'Ottone
7825153bb2
Merge pull request #2282 from AsparagusEduardo/RHH/pr/tutorFix
...
Exp Candy Fixes
2022-09-15 22:46:59 -03:00
ghoulslash
20190ac85a
fix ai switch semi invulnerable
2022-09-15 18:34:15 -04:00
ghoulslash
133aa9e28d
Merge pull request #2306 from AsparagusEduardo/RHH/pr/autogenNames
...
Generating music names for the debug menu based on their labels
2022-09-15 18:02:27 -04:00
ghoulslash
6616c89451
Merge pull request #2303 from Blackforest92/RHH-PR-Branch
...
Tidying graphics - Trio Weather
2022-09-15 18:01:43 -04:00
ghoulslash
6cfacb396e
Merge pull request #2307 from AsparagusEduardo/RHH/pr/debugMapCount
...
Automated creation of MAP_GROUP_COUNT for the debug menu
2022-09-15 18:01:05 -04:00
ghoulslash
5bdd292dc3
Merge pull request #2310 from AsparagusEduardo/RHH/pr/FairyUses
...
Added missing uses of Fairy type for Union Room and Battle Factory
2022-09-15 18:00:38 -04:00
ghoulslash
354a8256e4
Merge pull request #2226 from Porygon23/AI-Logic-Updates
...
Added corner case logic for AI Switching.
2022-09-15 17:56:35 -04:00
Eduardo Quezada
492380bd24
gReservedSpritePaletteCount using MAX_BATTLERS_COUNT for battles
2022-09-14 12:20:59 -03:00
Eduardo Quezada
41d11b0708
Restored filename format for gendered species
2022-09-14 11:13:42 -03:00
TheXaman
ef4e64c2f7
-added a submenu to set the weather
...
-lowest flag is 1
2022-09-14 15:19:23 +02:00
TheXaman
1e03b4747f
debug menu: object events now frozen while open
2022-09-14 13:43:26 +02:00
TheXaman
2c20514035
improved debug menu function declaration consistency
2022-09-14 13:39:35 +02:00
Eduardo Quezada
dc423ef7ff
Handling repel/lure menu
2022-09-14 00:18:01 -03:00
Eduardo Quezada
ee628de82f
Config to turn off Hippopotas' and Hippowdon's female icons
2022-09-13 21:42:53 -03:00
Eduardo Quezada
0caf79f702
Merge remote-tracking branch 'blackforest/pokemon_expansion' into RHH/pr/palleteConversion2
...
# Conflicts:
# graphics/pokemon/cherrim/anim_front.png
# graphics/pokemon/scyther/anim_front.png
# graphics/pokemon/scyther/front.png
# graphics/pokemon/shinx/anim_front.png
# src/data/pokemon_graphics/back_pic_table.h
# src/data/pokemon_graphics/front_pic_table.h
# src/data/pokemon_graphics/palette_table.h
# src/data/pokemon_graphics/shiny_palette_table.h
# src/pokemon_icon.c
2022-09-13 20:44:49 -03:00
Eduardo Quezada
c68ca72fb0
Merge remote-tracking branch 'pret/master' into RHH/pr/pretmerge_20220909
2022-09-13 16:26:59 -03:00
Eduardo Quezada
de32940fdf
Further removed trailing whitespaces
2022-09-13 16:26:36 -03:00
Eduardo Quezada
1d7e8bd730
Merge remote-tracking branch 'pret/master' into RHH/pr/pretmerge_20220909
...
# Conflicts:
# asm/macros/battle_ai_script.inc
# asm/macros/battle_script.inc
# data/battle_ai_scripts.s
# include/link_rfu.h
# src/pokemon.c
# src/pokemon_summary_screen.c
# src/sound.c
2022-09-13 16:22:42 -03:00
GriffinR
c1dfd3c9ec
Merge pull request #1763 from GriffinRichards/rm-global
...
Drop usage of global directive
2022-09-13 15:08:37 -04:00
LOuroboros
2d841a25f9
Removed unused extern declaration of old gUnknown func
2022-09-13 15:45:01 -03:00
GriffinR
91c040b081
Merge pull request #1777 from AsparagusEduardo/pret/pr/trailingWhitespace
...
Cleaned trailing whitespace
2022-09-13 14:00:11 -04:00